Sean Harvey
fda6ab0afb
MINOR Unnecessary check of trim() twice on TextareaField->Field()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64557 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:54:04 +00:00
Sean Harvey
62a28cab64
ENHANCEMENT Clearer indication of setting disabled attribute in DropdownField->Field() since the disabled attribute shouldn't be set if the field isn't to be disabled
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64556 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:52:47 +00:00
Sean Harvey
719bc5dff4
MINOR whitespace removal
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64555 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:32:14 +00:00
Sean Harvey
a16f55b068
ENHANCEMENT Clearer indication of setting disabled attribute in CheckboxField->Field() since the disabled attribute shouldn't be set if the field isn't to be disabled
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64553 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:22:01 +00:00
Sean Harvey
2fd43fccfa
ENHANCEMENT If TextField->disabled has been set to true, then add the "disabled" attribute to the input type text attribute list
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:18:25 +00:00
Sean Harvey
f5a39b5c2c
ENHANCEMENT Made use of FormField->createTag() functionality for creating a textarea field in TextareaField->Field()
...
MINOR Documentation tweaks in TextareaField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:05:05 +00:00
Sean Harvey
1611deb019
MINOR Convert::raw2att() isn't required because FormField->createTag() already does this
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64550 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:03:20 +00:00
Normann Lou
249c7a7d12
APICHANGE: delete GenericDataAdmin, RelatedDataEditor, DropdownField_WithAdd and their related code (js, css, etc) from cms, sapphire, "GenericDataAdmin" name space has also been deleted from lang files. They are all added in the new module "genericdataadmin"
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64528 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 00:20:00 +00:00
Sean Harvey
a6e6a4387d
BUGFIX Renamed "Save & Publish" to "Save and Publish" since this value is used in the value attribute of input elements, properly parsed, this would produce & instead of &
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64506 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-19 01:28:30 +00:00
Sean Harvey
8e1f647252
MINOR Added to @deprecated note for TypeDropdown about why this class shouldn't be used
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64505 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-19 00:41:16 +00:00
Sean Harvey
7048077184
API CHANGE Removed HtmlOneLineField. This field has been deprecated for some time now, and it does not work.
...
API CHANGE Changed HTMLVarchar->scaffoldFormField() to use HtmlEditorField instead of HtmlOneLineField, which does not work.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64504 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-19 00:18:55 +00:00
Sean Harvey
ee5b0e2447
MINOR ErrorPage removal of ShowInMenus explicitly being set - this is done using static $defaults on the class itself.
...
MINOR ErrorPage phpDoc updates - removal of non-existant token @usedby, replaced with @see
MINOR Code formatting changes to be more consistent
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64502 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-18 22:31:04 +00:00
Ingo Schommer
9025c57e4b
MINOR Moved CollectionController_Results template into genericviews module
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64498 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-17 22:05:20 +00:00
Ingo Schommer
12f2457677
BUGFIX Fixed distribution of textcollector files to modules (was collecting all entities into all modules before) - added unit tests
...
ENHANCEMENT Using ksort() in textcollector to get alphabetized language master files (=easier to compare and debug)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64494 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-17 17:44:14 +00:00
Ingo Schommer
c4cdc9ce87
ENHANCEMENT Made _t() global function in Core.php an alias for the new i18n::_t() method
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64493 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-17 15:40:59 +00:00
Ingo Schommer
874aaf1d27
ENHANCEMENT Refactored i18nTextCollector and added unit tests
...
FEATURE Support for i18n entity namespaces in templates
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64492 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-17 15:21:33 +00:00
Ingo Schommer
9f41917fb1
BUGFIX Fixed wrongly formatted _t() call in Security class
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64491 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-17 15:20:31 +00:00
Ingo Schommer
2cf70326ae
BUGFIX Fixed $module parameter for i18nTextCollectorTask
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64490 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-17 15:19:10 +00:00
Ingo Schommer
23aa23fb60
ENHANCEMENT Added ClassInfo::classes_for_file()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64489 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-17 15:18:26 +00:00
Sam Minnee
c47257568c
FEATURE: Added support for 'sake dev/tests/all --showslow' to list slow tests
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64480 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-17 02:28:55 +00:00
Sam Minnee
c6f6f82f24
FEATURE: Added ?debug_memory=1 flag
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64473 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-17 00:52:58 +00:00
Sam Minnee
6fe79bc1c6
BUGFIX: Fix issue with language files not being included
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64471 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 23:39:19 +00:00
Sam Minnee
c45ef338d2
Removed junk text from CSSContentParserTest
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64470 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 23:39:02 +00:00
Ingo Schommer
795fdb2169
BUGFIX Removed duplicate setValue() method on Time (was supposed to be deleted instead of renamed from setVal() to setValue())
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64467 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 23:19:39 +00:00
Sam Minnee
f49e2c1ca6
BUGFIX: posix_isatty sometimes returns a benign error
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64466 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 23:17:43 +00:00
Andrew O'Neil
d3f6b8ec9e
BUGFIX: Don't run migration code for permissions if the old field doesn't exist.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64462 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 22:46:48 +00:00
Sam Minnee
509f14d6ae
FEATURE: Show max memory usage on dev/tests/all
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64461 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 22:26:16 +00:00
Normann Lou
e30b5e3f22
MINOR: documenting my new method, correct a coding convention about whitespace
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64460 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 22:22:32 +00:00
Ingo Schommer
5f70af6d38
ENHANCEMENT Moving i18n->textcollector() and related methods to new class i18nTextCollector and i18nTextCollectorTask - enabling running textcollector through CLI, refactored to instance methods for better testability
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64447 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 20:42:41 +00:00
Ingo Schommer
5b91ea9d0a
ENHANCEMENT Improved TaskRunner and BuildTask metadata and styling
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64446 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 20:40:24 +00:00
Sam Minnee
f1f76b22b7
FEATURE: Flush template cache before running tests
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64444 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 19:48:12 +00:00
Ingo Schommer
68dba3e8af
BUGFIX Fixed RestfulServerTest fixture path
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64443 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 18:22:37 +00:00
Ingo Schommer
593e0f1799
MINOR moved RestfulServerTest from cms to sapphire module, same as the actual RestfulServer class
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64441 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 17:37:31 +00:00
Ingo Schommer
3c55ea4f01
BUGFIX Fixed combined Content-Type and encoding header parsing in RestfulServer for DataFormatter::get_by_mimetype()
...
BUGFIX Returning 409 Conflict HTTP Header when trying to create a resource on an existing URL through RestfulServer
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64439 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 17:35:27 +00:00
Ingo Schommer
00eaa1b5b7
BUGFIX Removed $headingLevel reference from LabelField (was supposed to go into HeaderField)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64438 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 14:03:10 +00:00
Ingo Schommer
06671277a7
BUGFIX Second constructor argument $title for HeaderField should be optional for legacy reasons
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64437 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:54:21 +00:00
Ingo Schommer
cb5d772111
MINOR deprecation notes
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64429 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:44:20 +00:00
Ingo Schommer
794ae40f8f
API CHANGE Moved CheckboxFieldDisabled class to more common CheckboxField_Disabled notation
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64428 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:44:05 +00:00
Ingo Schommer
692bd4c835
BUGFIX Using PasswordField instead of deprecated EncryptField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64427 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:43:31 +00:00
Ingo Schommer
80b5bfd4d2
API CHANGE Removed NoScriptField, please use LiteralField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64426 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:31:57 +00:00
Ingo Schommer
82e1ad8d8a
API CHANGE Removed EncryptField, use PasswordField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64425 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:31:34 +00:00
Ingo Schommer
768fc5a588
BUGFIX Adjusted HeaderField and LabelField implementation to new constructor arguments (see r64421)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64422 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:26:50 +00:00
Ingo Schommer
e95c5657ff
API CHANGE Changed constructor parameters for LabelField and Header: First parameter is now $name, not $title. Necessary change to consistently support labelled fields which can be identified and modified within a FieldSet, and in the DOM structure. Both HeaderField and LabelField still acceppt old notation through checking the parameter signature with func_get_args().
...
API CHANGE Moved setAllowHTML() to DataLessField
ENHANCEMENT Using createTag() to create HeaderField and LabelField, which adds support for HTML id attributes and extra css classes through addExtraClass()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64421 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:26:25 +00:00
Ingo Schommer
ab891c67ec
API CHANGE Removed LabelledLiteralField, use LiteralField
...
API CHANGE Removed NamedLabelField, use LabelField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64420 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:22:36 +00:00
Ingo Schommer
461354bb47
MINOR Misc deprecation notes
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64419 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:00:30 +00:00
Ingo Schommer
bc28a64e18
MINOR Changed visibility of SiteTree->getClassDropdown()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64418 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:00:02 +00:00
Ingo Schommer
edd087f80b
API CHANGE Removed SiteTree->makelinksunique() and SiteTree->makelinksuniquequick() - use new SiteTreeMaintenanceTask
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64416 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 12:18:16 +00:00
Ingo Schommer
d80a6899e1
MINOR documentation
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64415 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 12:05:08 +00:00
Ingo Schommer
639dee8926
MINOR Removed unused DatabaseAdmin->makeURL()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64414 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 12:02:57 +00:00
Ingo Schommer
b46250b9dc
MINOR documentation
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64413 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 12:02:41 +00:00