Commit Graph

21890 Commits

Author SHA1 Message Date
Loz Calver
e08bf1cdd9
Merge pull request #9461 from creative-commoners/pulls/4/remove-db-config-glob
Cache results of _configure_database.php glob
2020-04-20 08:45:48 +01:00
Serge Latyntcev
cb36aab80c Merge branch '4.5' into 4 2020-04-15 14:49:19 +12:00
Serge Latyntcev
a9c05f3287 Merge branch '4.4' into 4.5 2020-04-15 14:48:59 +12:00
Serge Latyntcev
cf898a2672 Merge branch '4.3' into 4.4 2020-04-15 14:47:59 +12:00
Serge Latyntsev
d253d87b74
Merge pull request #9469 from open-sausages/pulls/4/fix-broken-merge
DOC Fix broken merge request in change logs
2020-04-15 12:56:48 +12:00
Maxime Rainville
9766302869 DOC Fix broken merge request in change logs 2020-04-15 12:53:44 +12:00
Maxime Rainville
7da77be5ce Merge branch '4.5' into 4 2020-04-15 08:22:27 +12:00
Daniel Hensby
03239f9dcc
Merge pull request #9454 from open-sausages/pulls/4/myisam
NEW Allow InnoDB for FULLTEXT indexes
2020-04-14 11:50:45 +01:00
Daniel Hensby
cd1bd2a5a7
Merge pull request #9464 from mattclegg/1586149337
DOCS: Minor changes
2020-04-14 11:42:56 +01:00
mattclegg
60e670176a
DOCS: Correct spelling 2020-04-14 15:00:08 +05:45
mattclegg
5585f6633f
DOCS: Update typos 2020-04-14 15:00:08 +05:45
mattclegg
e968f5cb86
DOCS: Remove outdated TODO 2020-04-14 15:00:08 +05:45
Maxime Rainville
14bbaac1cb Merge tag '4.5.3' into 4.5
Release 4.5.3
2020-04-14 14:23:57 +12:00
Maxime Rainville
de8fd82c55 Merge branch '4.4' into 4.5 2020-04-14 14:18:18 +12:00
Maxime Rainville
1fe6255f9b Merge tag '4.4.6' into 4.4
Release 4.4.6
2020-04-14 14:13:59 +12:00
Steve Boyd
0f7fd35926
Merge pull request #9458 from creative-commoners/pulls/4/doc-versioned-file-migration
DOC CMS 3.x file migration section about versioned files
2020-04-14 11:31:43 +12:00
Maxime Rainville
10c32aaa28 Added 4.5.2 changelog 2020-04-14 11:02:06 +12:00
Maxime Rainville
092acc7112 Added 4.4.6 changelog 2020-04-14 10:59:19 +12:00
Serge Latyntcev
eaa69530be DOC CMS 3.x file migration section about versioned files 2020-04-14 10:53:21 +12:00
Aaron Carlino
2e40d31800
DOCS: upgrade project duplicated in index (#9466) 2020-04-14 10:18:09 +12:00
Steve Boyd
956f312a37
Merge pull request #9465 from mattclegg/1586758562
DOCS: Update to show default functionality of VersionedGridfieldDetailForm
2020-04-14 09:48:11 +12:00
mattclegg
6a640f1498
DOCS: Example should show how to disable VersionedGridfieldDetailForm as it's enabled by default 2020-04-13 17:34:55 +05:45
Serge Latyntcev
9779e42963 BUG Register new sub tasks to fix files affected by CVE-2020-9280 and CVE-2019-12245 2020-04-13 19:43:53 +12:00
Maxime Rainville
052ce6916c DOC Explain how to use the new file migation sub tasks in the 4.4.6/4.5.2 changelogs 2020-04-13 19:39:24 +12:00
Serge Latyntcev
b269d87490 BUG Register new sub tasks to fix files affected by CVE-2020-9280 and CVE-2019-12245 2020-04-13 17:16:57 +12:00
Maxime Rainville
4b0345bee7 DOC Explain how to use the new file migation sub tasks in the 4.4.6/4.5.2 changelogs 2020-04-13 17:16:29 +12:00
Steve Boyd
75d31c2cd3 Cache glob results for _configure_database.php 2020-04-10 23:15:12 +12:00
Loz Calver
3ad4b93daa
Merge pull request #9456 from open-sausages/pulls/4/avoid-tempdatabase-infinite-loop
BUG Infinite loops in TempDatabase (fixes #8902)
2020-04-09 09:28:57 +01:00
Ingo Schommer
a50e15e5ee FIX Avoid VACUUM on test dbs in Postgres
The Postgres implementation was always faulty,
but the database exception was swallowed until
See https://github.com/silverstripe/silverstripe-framework/pull/9456.

Now that the the exception is only swallowed the first time,
the second recurrence will cause failing test execution.

This is a bit of an awkward fix, but the indirection "through" DataObject doesn't allow for anything else without changing public API surface.
The logic goes from TempDatabase to DBSchemaManager, then through the closure into DataObject->requireTable(),
then back into DBSchemaManager->requireTable(). And updateschema() is subclassed in SQLite3, making it difficult to add more arguments.

VACUUM is described as:

> VACUUM reclaims storage occupied by dead tuples. In normal PostgreSQL operation, tuples that are deleted or obsoleted by an update are not physically removed from their table; they remain present until a VACUUM is done. Therefore it's necessary to do VACUUM periodically, especially on frequently-updated tables.

https://www.postgresql.org/docs/9.1/sql-vacuum.html

Since test databases are short-lived, there's no reason to delete dead tuples, they'll be garbage collected when either the transaction is rolled back, or the database is destroyed after the test run.
2020-04-09 14:43:16 +12:00
Ingo Schommer
2c5deceeb4 FIX Filter out all FULLTEXT BOOLEAN chars
The query might still work depending on where these chars are placed,
but it seems weird to only remove *some* of the valid chars here.
See https://dev.mysql.com/doc/refman/5.6/en/fulltext-boolean.html

Note that the query runs both the actual boolean query with chars,
and then a separate relevance search without them.
2020-04-09 10:32:45 +12:00
Ingo Schommer
0215fdd262 DOC Clarify sanitisation in searchEngine() under boolean mode
This came up in https://github.com/silverstripe/silverstripe-cms/issues/1452, and wasn't fully addressed.
Either we allow boolean mode and all the constraints this brings around special character usage,
or we filter out those special characters, which makes boolean mode pointless.
You can't just pass arbitrary user input in a power-user function like this.
See https://dev.mysql.com/doc/refman/5.6/en/fulltext-boolean.html

Context: This used to work for some examples like "foo>*" under MyISAM,
presumably because it had a more lenient parser. InnoDB rightfully complains about this now.
2020-04-09 10:32:45 +12:00
Ingo Schommer
c6b698cb02 NEW Allow InnoDB for FULLTEXT indexes
MyISAM used to be the only one to support it, now InnoDB has caught up.
Unless an engine is set specifically in create_table_options,
this will auto-convert existing MyISAM tables to InnoDb.

Fixes #9242
2020-04-09 10:32:45 +12:00
Loz Calver
f1c74c3570
Merge pull request #9415 from botzkobg/4
Form validation should throw ValidationException
2020-04-08 09:33:20 +01:00
Ingo Schommer
052c5cbc38 BUG Infinite loops in TempDatabase (fixes #8902)
Ugly, but so is the original implementation that this works around (swallowing an exception to trigger functionality)
2020-04-08 13:58:02 +12:00
tdenev
1d85981537 Refactoring the form validation in the action to be more readable and in the SS standards based on the code review 2020-04-07 22:46:32 +01:00
Loz Calver
bcab982aa7
Merge pull request #9452 from botzkobg/GridFieldDocsUpdate
Fix issue with the GridField documenation
2020-04-06 09:38:44 +01:00
tdenev
d6fc7fe804 Fix issue with the GridField documenation - many_many_extraFields code example 2020-04-05 18:53:21 +01:00
Robbie Averill
f77f725355
Merge pull request #9447 from mattclegg/docs__GridFieldDetailForm_ItemRequest-httpError
[DOCS] Better debug text for errors generated by GridFieldDetailForm_ItemRequest
2020-04-02 13:05:49 -07:00
Robbie Averill
d3b19069b3
Apply suggestions from code review
Add double quotes around object title
2020-04-02 12:51:13 -07:00
Dan Hensby
d1075f29b8
Remove empty parameter as per feedback 2020-04-02 12:11:35 +01:00
Dan Hensby
9e0ed0a50a
Fix spaces around concatenation operator 2020-04-02 12:09:22 +01:00
Dan Hensby
bb03d314ff
Include phpcs as a dev dependency 2020-04-02 12:06:40 +01:00
Dan Hensby
5bf2ac83ee
Merge branch '4.5' into 4 2020-04-01 19:23:47 +01:00
Loz Calver
39fab1974a
Merge pull request #9435 from unclecheese/pulls/4.5/wha-diff
BUGFIX: Ensure diff arrays are one-dimensional
2020-04-01 09:16:20 +01:00
Robbie Averill
dcd54ecec0
Merge pull request #9448 from mattclegg/patch-5
[DOCS] Member::logInAs is not a valid example
2020-03-31 11:12:49 -07:00
Matt Clegg
e80f1b2b83
[DOCS] Member::logInAs is not a valid example
Member::logInAs doesn't exist as a static function.

Additionally, `logInAs` does exist as a function in SapphireTest.php, so, should this be updated to also use `Member::actAs` for consistency?
2020-03-31 18:20:21 +05:45
mattclegg
24bc80ed35
[DOCS] Better debug text for errors generated by GridFieldDetailForm_ItemRequest 2020-03-31 12:09:16 +05:45
Loz Calver
5952a7ce71
Merge pull request #9444 from mattclegg/docs-13_i18n
[DOCS] Example should be valid YAML
2020-03-27 16:34:40 +00:00
mattclegg
ba3deb9b72
[DOCS] Example should be valid YAML 2020-03-27 20:31:25 +05:45
Daniel Hensby
1fb574a5bd
NEW: Variadic URL parameter matches for url_handlers (#9438)
* Add wildcard URL parameter matches for url_handlers

* Extra tests for wildcard parameters

* Add a PHP warning if more params appear after wildcard param
2020-03-25 09:16:13 +13:00