Robbie Averill
42dd02ef78
Merge pull request #9122 from aNickzz/4
...
Add onBeforeRenderHolder extension point for FormField
2019-09-06 11:53:10 -07:00
Maxime Rainville
dd40d53e6b
Merge branch '4.4' into 4
2019-09-04 09:46:33 +12:00
Robbie Averill
ef49dcf726
Merge pull request #9164 from sminnee/fix-9162
...
FIX: Write relations when saving in grid-field item edit form
2019-09-01 20:44:13 -07:00
Maxime Rainville
a2a202c016
Merge pull request #9200 from open-sausages/pulls/4.4.3/consistent-actions
...
FIX make the grid field actions consistent to what they look like on pages
2019-09-02 14:07:22 +12:00
bergice
2f8d847a10
FIX make the grid field actions consistent to what they look like on pages
...
Resolves https://github.com/silverstripe/silverstripe-admin/issues/904
2019-09-02 12:22:32 +12:00
Will Rossiter
d2a07b1047
FIX Remove error when exporting a column that is not displayed in a GridField
2019-08-27 11:54:31 +12:00
Robbie Averill
45f86658ca
Merge branch '4.4' into 4
2019-08-14 09:31:05 +12:00
Robbie Averill
4b44272367
Merge branch '4.3' into 4.4
2019-08-14 09:30:53 +12:00
Nicholas Sorokin
4a32b3418a
Add onBeforeRenderHolder extension point for FormField
2019-08-09 14:43:14 +09:30
Guy Marriott
3d989a6eae
FIX Use content generated by DataColumns component for print and csv export
2019-08-09 15:04:38 +12:00
Aaron Carlino
b3093b7a1a
BUGFIX: Allow state to be shared across nested GridFields
2019-08-07 23:09:51 +12:00
Sam Minnee
6ec02da577
FIX: Allow multi-line content in grid field cells
...
It’s amazing that this but has been present for 7 years, but there you
go!
2019-08-02 17:46:56 +12:00
Sam Minnee
d088354f46
FIX: Write relations when saving in grid-field item edit form
...
Fixes https://github.com/silverstripe/silverstripe-framework/issues/9162
2019-08-02 16:17:42 +12:00
Saophalkun Ponlu
6a8c6703d1
Remove use_gzip
from HTMLEditorField since it's been removed by TinyMCE codebase ( #7261 )
...
* Remove `use_gzip` from HTMLEditorField
* DOCS Mention remove use_gzip in changelog
2019-06-21 09:27:48 +12:00
Aaron Carlino
e2da7b0dc4
Merge branch '4.4' into 4
2019-06-10 16:37:16 +12:00
Sam Minnée
654156d46d
FIX: Fix bug when confirmed password is changed but not the password. ( #9012 )
...
In this case the confirmed password field is not reflected. It’s
unclear how often this situation would arise outside of test scenarios,
but may come up if $form->loadDataFrom() is called more than once.
Fixes #2496 (it’s a minor issue but I think this is why Dan flagged it
as a regression). Originally introduced as part of Dan’s initial fix
at 2a6f1f1949
.
2019-06-10 15:48:29 +12:00
Robbie Averill
179a982f45
Merge pull request #9019 from rafaeldsousa/pull/include-cancreate-check-gridfield-rightgroupfield
...
Including canCreate in if statement so that button gets removed if us…
2019-06-10 09:59:45 +12:00
Robbie Averill
00fd74a0a1
Merge branch '4.4' into 4
...
# Conflicts:
# src/Dev/Tasks/MigrateFileTask.php
2019-05-30 09:36:42 +12:00
Robbie Averill
14673ffd0a
Merge branch '4.3' into 4.4
2019-05-30 09:35:26 +12:00
Robbie Averill
188698dcee
Merge branch '4.2' into 4.3
2019-05-30 09:35:17 +12:00
Robbie Averill
7f69cc8f94
Merge branch '4.1' into 4.2
2019-05-30 09:35:06 +12:00
Robbie Averill
02864aba3f
Merge branch '4.0' into 4.1
2019-05-30 09:34:55 +12:00
Robbie Averill
a1f0d7a3bf
Merge pull request #9016 from sminnee/partial-fix-4622
...
FIX: Better message when form action handler not found.
2019-05-30 09:22:54 +12:00
Rafael Marins de Sousa
f7c1be7ac1
Including canCreate in if statement so that button gets removed if user isn't to be able to create new records
2019-05-28 12:28:00 +12:00
Sam Minnee
7407096e99
FIX: List default items in the readonly view of ListboxField
...
Adds tests for non-readonly default items too.
Fixes #4142
2019-05-27 17:47:09 +12:00
Sam Minnee
983d36b7ee
FIX: Better message when form action handler not found.
...
Fixes #4622 to some extent, although this fix will be most useful when
https://github.com/silverstripe/silverstripe-errorpage/issues/30 is
addressed also.
2019-05-27 15:00:10 +12:00
Dylan Wagstaff
25aa3af032
FIX HeaderField requires the optional Title field
...
FormField marks the Title constructor argument as optional, and DatalessField does not override the __construct method. HeaderField on the other hand goes against the grain of FormFields as a whole and requires the Title field, seemingly for no good reason (at least, not that the commit message for a68ba38478
indicates) - this seems like an accidental ommision. This commit looks to reinstate the optionality of this constructor argument for consistency's sake.
Plus it broke a module I was investigating.
2019-05-24 13:44:01 +12:00
shoosah
4da8be3bf5
Add extend function in getSchemaValidation function
...
This allows to create extensions which add validation list
2019-05-14 09:47:14 +12:00
aNickzz
28be2b2263
Swap argument order for implode
...
I noticed this squiggly red line while perusing the code.
The PHP doc says
`implode ( string $glue , array $pieces ) : string`
> implode() can, for historical reasons, accept its parameters in either order. For consistency with explode(), however, it may be less confusing to use the documented order of arguments.
2019-05-11 00:32:23 +09:30
Guy Marriott
856e841955
FIX Ensuring pagination buttons have a consistent state to work off of ( #8957 )
2019-05-06 14:42:25 +12:00
Robbie Averill
5337e6d048
API Replace FormActions with anchors to enable panel-based loading in GridField navigation buttons ( #8953 )
...
* FIX Add accessibility labels and titles to previous, next, and add new buttons in GridFields
* API Replace FormActions with anchors to enable panel-based loading in GridField navigation buttons
* FIX Previous and Next links are now correctly disabled when end of lists are reached
* Add English translations
2019-05-03 15:03:59 +12:00
Guy Marriott
ecfe039e72
FIX Don't add "better buttons" previous and next without a paginator
2019-05-01 15:48:03 +12:00
Sam Minnée
6a2762662b
MINOR: Change “Choose Page” to “Search or choose Page” ( #8766 )
...
* MINOR: Change “Choose Page” to “Search or choose Page”
Based on discussions with James Ford, it wasn’t clear that you could
search.
* Use new translation key
2019-04-16 16:06:37 +12:00
Guy Marriott
b1339f0d72
NEW Update FieldList::replaceField API to match removeByName ( #8876 )
...
* API Update FieldList::replaceField API to match removeByName
This specifically adds the parameter that `removeByName` has but `replaceField` does not. This parameter is set to `true` by default rather than inheriting the same default as `removeByField`. This is because the existing funtionality of `replaceField` was the same as if this parameter was set to `true`. This should be updated in SS5 to match the `removeByField` API.
* Add dataFieldOnly to CompositeField
2019-04-15 16:22:54 +12:00
Robbie Averill
f4a6115ee6
Merge branch '4.0' into 4.1
2019-04-11 11:36:40 +12:00
Robbie Averill
8a06682e31
Merge branch '4.3' into 4
...
# Conflicts:
# src/ORM/Connect/DBSchemaManager.php
2019-04-11 11:24:17 +12:00
Robbie Averill
55cbacca86
Merge branch '4.2' into 4.3
...
# Conflicts:
# src/Forms/GridField/GridFieldLevelup.php
# src/includes/constants.php
2019-04-11 11:21:42 +12:00
Sam Minnee
f12fa62ad6
FIX: Better error message when GridFieldLevelup passed bad record details
...
Fixes https://github.com/silverstripe/silverstripe-framework/issues/3519
2019-04-08 18:09:51 +12:00
Robbie Averill
8b4b54f264
PHPCS linting error on indentation
2019-04-05 16:29:24 +13:00
Aaron Carlino
fc6213c293
Merge branch '4.3' into 4
2019-03-27 13:25:57 +13:00
Damian Mooyman
6dc41e50a0
MINOR Linting fixes
2019-03-26 17:35:58 +13:00
Kong Jin Jie
1d406c64b9
Fix: Allow editing of relation if item is created.
2019-03-20 12:51:49 +08:00
Aaron Carlino
f6a7bddd8d
Linting
2019-03-20 15:50:54 +13:00
Robbie Averill
3e90fdf42f
Merge branch '4.3' into 4
2019-02-19 08:41:05 +07:00
Robbie Averill
ed74549c4f
Merge branch '4.2' into 4.3
2019-02-19 08:39:59 +07:00
Robbie Averill
79e44b42fa
Merge branch '4.1' into 4.2
2019-02-19 08:37:07 +07:00
Robbie Averill
cb7f15a681
Merge branch '4.0' into 4.1
2019-02-19 08:36:41 +07:00
Robbie Averill
dc9d1b9cc0
FIX GridFieldPrintButton no longer assumes that children of GridField would implement their own print template
2019-01-28 11:45:55 +02:00
Maxime Rainville
db466fb013
MINOR Always cast formfield display value as a string to avoid 0 being blank
2019-01-25 13:34:36 +13:00
Robbie Averill
394dd4765c
NEW Scaffolded field labels now only have an uppercased first word
2019-01-07 17:52:28 +01:00
Kong Jin Jie
1667af8f5e
Add $disabledItems to check for disabled items instead of checking against $defaultItems
...
Fixes #8688
2018-12-31 17:25:11 +08:00
Russell Michell
0397c54b5a
FIX: Fixes #8459
...
- Missing conditionals for optional constructor args
- Missing calls to FieldList::setForm()
- Missing guards around naive calls to Form::Fields()->foo()
2018-12-19 13:28:19 +13:00
Robbie Averill
5d7c5ffb07
Merge branch '4.3' into 4
2018-12-06 09:40:40 +00:00
Robbie Averill
08866f89d9
Merge branch '4.2' into 4.3
2018-12-06 09:40:05 +00:00
Robbie Averill
96bd17d469
Merge branch '4.1' into 4.2
2018-12-06 09:38:45 +00:00
Robbie Averill
3f532466d1
Merge branch '4.0' into 4.1
2018-12-06 09:37:52 +00:00
Guy Marriott
c7b5b1efd2
FIX Switching to use Controller::curr as it was using previously
2018-11-30 15:40:45 +13:00
Guy Marriott
32d096d9e5
DOCS Moving interface subscription to the abstract and adding a changelog entry
2018-11-30 15:40:45 +13:00
Guy Marriott
ddaa22986f
Updating StateStore interface not to define a constructor & fixing GridFieldFilterHeader to add required attributes
2018-11-30 15:40:45 +13:00
Guy Marriott
b4c8f699eb
FIX Provide alternatives to session for storing GridField_FormAction state
2018-11-30 15:40:45 +13:00
Loz Calver
441d079647
Merge pull request #8637 from creative-commoners/pulls/4.4/falsy-detail-component
...
FIX getComponentByType can return null - prevent null pointer errors
2018-11-26 18:28:26 +01:00
Robbie Averill
f22a4b980b
FIX getComponentByType can return null - prevent null pointer errors
2018-11-26 16:01:46 +01:00
Robbie Averill
efa427fc45
FIX Remove redundant "rightGroup" logic and increase getRightGroupField to protected
2018-11-26 12:42:47 +01:00
Robbie Averill
1f1c344272
Merge branch '4.3' into 4
...
# Conflicts:
# tests/php/Forms/ConfirmedPasswordFieldTest.php
2018-11-26 12:15:17 +01:00
Andre Kiste
1d9e40ba26
Use new plus icon ( #8619 )
...
* Use new plus icon and refactor
* MINOR: Add ability to customise the visibility of the `Previous`, `Next` and `Add` buttons at a `GridField` level
* - Merge `showPrevious` and `showNext` to `showPagination` for grid fields
- Update documentation
- Improve performance for next/previous buttons by not fetching all list records
- Refactoring
* Refactor to fail gracefully on GridFieldPaginator
* Fix merge
2018-11-23 12:40:18 +13:00
Serge Latyntcev
9ce6d91b76
FIX / TreeMultiselectField::objectForKey handles list of IDs correctly
2018-11-22 12:11:18 +13:00
Maxime Rainville
d74af1c17e
FIX Explicity mark nodes when searching nodes in TreeDropdownField #8621
2018-11-21 11:43:21 +13:00
Andre Kiste
cc712892a9
NEW Port betterbuttons to framework ( #8569 )
...
* MINOR: Add `Previous`, `Next` and `Create New` actions in edit form
If the form is opened via a grid field, the filters will be retained so the previous/next record opened will be correct
* MINOR: Add ability to customise the visibility of the `Previous`, `Next` and `Add` buttons at a `GridField` level
* Fix invalid action when pressing the `New` button in an edit form unless `betterbuttons` module was installed
* - Merge `showPrevious` and `showNext` to `showPagination` for grid fields
- Update documentation
- Improve performance for next/previous buttons by not fetching all list records
- Refactoring
* Refactor to fail gracefully on GridFieldPaginator
2018-11-19 11:06:47 +13:00
Serge Latyntcev
15aaf9db9f
Fix a code style typo
2018-11-13 10:20:49 +13:00
Guy Marriott
b2dd22fb50
Merge pull request #8506 from creative-commoners/pulls/4.3/all-the-unit-tests
...
NEW Adding a stack more unit tests for logging and some form fields
2018-11-11 10:31:24 +13:00
Loz Calver
bbb208e1dd
Merge pull request #8499 from sminnee/fix-1489
...
FIX: CheckboxSetField can now save into DBMultiEnum
2018-11-09 10:40:55 +01:00
Robbie Averill
24d6527845
Merge branch '4.3' into 4
2018-11-09 11:39:27 +02:00
Serge Latyntcev
4b4fbabed5
FIX TreeMultiselectField passes value 'unchanged' as null to ORM for 'ID' column key
2018-11-08 15:41:46 +13:00
Robbie Averill
358cef0cdf
Merge pull request #8514 from wilr/pulls/lookup-injector
...
FIX use Injector for FormField::castedCopy
2018-11-07 19:20:36 +02:00
Robbie Averill
64c2938c96
Merge branch '4.3' into 4
2018-11-06 11:05:22 +01:00
Aaron Carlino
0ba275cb40
Merge branch '4.2' into 4.3
2018-11-06 15:09:01 +13:00
Sam Minnee
76255c9fb5
FIX: CheckboxSetField can now save into DBMultiEnum
...
Fixes https://github.com/silverstripe/silverstripe-framework/issues/1489
2018-11-05 17:40:28 +13:00
Luke Edwards
97180c2612
Fix readonly grid state always being truthy ( #8562 )
2018-11-02 14:28:47 +13:00
Luke Edwards
8866e7674a
BUG: Fix duplicate plugins on HTML editor fields ( #8559 )
...
* BUG: Fix duplicate plugins on HTML editor fields
* Add new test
2018-11-02 12:26:53 +13:00
Luke Edwards
c7b8b80e8b
Persist GridField readonly state, add view button ( #8535 )
...
* Persist GridField readonly state, add view button
* Minor clarity fixes
2018-11-01 11:12:52 +13:00
Andre Kiste
511c368e8c
Merge pull request #8521 from open-sausages/pulls/4.3/searching-for-legacy
...
Add config to force legacy filter header globally
2018-10-29 14:57:21 +13:00
Robbie Averill
b02a6fa02d
FIX Replace usage of Convert JSON methods with json_encode
2018-10-28 21:15:29 +00:00
Luke Edwards
3284bf48d6
Fix search filtering relations and clear filters ( #8477 )
2018-10-26 14:43:56 +13:00
Luke Edwards
d879148bff
Add config to force legacy filter header globally
2018-10-26 14:28:15 +13:00
Will Rossiter
66a404ad1a
FIX use Injector for FormField::castedCopy
...
Allows LookupField to be replaced with user specificed classes.
2018-10-24 12:13:14 +13:00
Maxime Rainville
af46381dca
MINOR Correct implementation of single lookup field when valueToLabel returns null
2018-10-23 11:54:26 +13:00
Robbie Averill
bea4101e21
Add tests for DisabledTransformation, PrintableTransformation and PrintableTransformation_TabSet
2018-10-20 20:06:02 +02:00
Robbie Averill
449b2cf291
Add tests for DefaultFormFactory
2018-10-20 19:47:11 +02:00
Robbie Averill
97209bc919
Add edge case unit tests for DateField
2018-10-20 18:15:42 +02:00
Robbie Averill
c06cf4820e
BUG Readonly and disabled CurrencyFields no longer always returns dollar currency sign, now respect config
2018-10-20 17:47:16 +02:00
Robbie Averill
d56bad7568
Add tests for edge cases in CurrencyField
2018-10-20 17:33:59 +02:00
Robbie Averill
8929b8204f
More validation tests for ConfirmedPasswordField
2018-10-20 17:21:25 +02:00
Robbie Averill
c418ee2915
NEW Add getters and setters for public properties in ConfirmPasswordField, add tests
...
Some of the validation parts of ConfirmPasswordField are previously untested, this adds tests
2018-10-20 16:43:49 +02:00
Robbie Averill
60b375d995
Add more tests for CheckboxField_Readonly and CompositeField, improve PHPDocs
2018-10-20 15:44:23 +02:00
bergice
a6a1743997
BUG: Fix ENTER
not triggering form save button as GridField
s used submit
type buttons
2018-10-18 12:37:24 +13:00
Aaron Carlino
57756f38cb
Revert bd6c4fd
2018-10-17 14:54:03 +13:00
Robbie Averill
7215637673
Merge pull request #8460 from open-sausages/pulls/4/lazy-loadable-gidfield
...
API Add a new GridFieldLazyLoader component
2018-10-11 13:43:10 +02:00
Loz Calver
dca2d47127
Merge pull request #8357 from creative-commoners/pulls/4.3/fix-i18n
...
FIX Text collector translations now compile without errors
2018-10-11 13:16:23 +02:00
Maxime Rainville
250d925810
MINOR Update CompositeField::__construct to call setChildren #8460
2018-10-11 15:25:34 +13:00
Maxime Rainville
98afbfe9b4
Implement Peer review feedback #8460
2018-10-11 14:56:06 +13:00