Commit Graph

7087 Commits

Author SHA1 Message Date
Ingo Schommer
cc32957414 API CHANGE Don't allow specifying $form as constructor argument in various form fields, use setForm() instead (to achieve a cleaner API with less confusing parameter order) 2012-01-02 17:50:34 +01:00
Ingo Schommer
3c5c04cd75 API CHANGE Removed $maxlength constructor argument from PasswordField, use setMaxlength() instead 2012-01-02 17:45:47 +01:00
Ingo Schommer
27ec98cfce API CHANGE Removed $rightTitle and $folderName constructor arguments for FileField and SimpleImageField, use setRightTitle() and setFolderName() instead 2012-01-02 17:44:28 +01:00
Ingo Schommer
1a10e8bcf5 API CHANGE Removed $rows and $cols constructor arguments on TextareaField and HtmlEditorField, use setRows() and setCols() instead 2012-01-02 17:44:23 +01:00
Ingo Schommer
d678c12ac8 API CHANGE Removed FormAction->extraData() and $extraData constructor argument, use setAttribute() instead 2012-01-02 16:58:46 +01:00
Ingo Schommer
eb5716f471 MINOR Using instanceof rather than is_a in CheckboxSetField 2012-01-02 16:49:33 +01:00
Ingo Schommer
e31851b182 BUGFIX Correctly mark DatetimeField, MoneyField and PhoneNumberField composites as disabled or readonly 2012-01-02 16:49:33 +01:00
Ingo Schommer
4056b94f75 BUGFIX Improved ClassInfo::ancestry() performance through in-memory caching and removal of unnecessary is_object() check - get_class() will complain if its not passed an object already) 2012-01-02 16:49:33 +01:00
Ingo Schommer
72694d8349 ENHANCEMENT Custom form attributes through Form->setAttribute() 2012-01-02 16:49:33 +01:00
Ingo Schommer
0dab75c3a0 MINOR Making SecurityAdminTest more resilient against markup order changes 2012-01-02 16:48:36 +01:00
Ingo Schommer
1eaf45a118 MINOR Documentation for FormField->setTemplate() and FormField->setAttribute() 2012-01-02 16:48:36 +01:00
Ingo Schommer
b4d7e51da3 API CHANGE Deprecated ImageFormAction, use FormAction with setAttribute('src', 'myimage.png') 2012-01-02 16:48:14 +01:00
Ingo Schommer
d535847f27 MINOR Making $title optional in TreeMultiselectField to comply with parent implementation 2012-01-02 16:48:14 +01:00
Ingo Schommer
b5421d9598 ENHANCEMENT Allowing custom attributes in (most) FormField implementations, which allows for HTML5 data attributes 2012-01-02 16:48:14 +01:00
Ingo Schommer
c77f4e8421 MINOR Allowing usage of FormField->Type() on base implementation 2012-01-02 16:48:14 +01:00
Ingo Schommer
639caea949 MINOR Using FieldList instead of FieldSet on SelectionGroup to comply with parent implementation 2012-01-02 16:48:14 +01:00
Ingo Schommer
475f3764c3 BUGFIX Using separate template for readonly version of Textarea (mainly to avoid SSViewer bugs, but also for more granular customisation) 2012-01-02 16:48:14 +01:00
Ingo Schommer
a6148c33da MERGE Using FormField->template in most fields 2012-01-02 16:48:14 +01:00
Ingo Schommer
b36ad3b876 MINOR Testing nested if blocks in SSViewerTest 2012-01-02 16:48:13 +01:00
Sean Harvey
19e9b19a1a BUGFIX Ensure TextareaField template is encoding characters correctly 2012-01-02 16:48:13 +01:00
Sean Harvey
9e548f501e API CHANGE FormField::Field() and FormField::FieldHolder() now render into templates on each FormField instead of creating HTML from PHP 2012-01-02 16:48:13 +01:00
Ingo Schommer
b3c08dba12 API CHANGE Deprecated FieldSet-specific methods from Form, namely dateFieldByName(), unsetDataFieldByName(), unsetFieldFromTab(), resetField() 2012-01-02 16:47:59 +01:00
Ingo Schommer
7d46e7e751 MINOR Added CMS architecture documentation 2012-01-01 18:24:09 +01:00
wolfv
2ccda564ca ENHANCEMENT: #6579 Show page status in page tree (pull request #142 from wolfv/sapphire) 2011-12-29 10:35:44 +01:00
Wolf Vollprecht
2a429c9850 MINOR: Added Member Profile Popup Styling
MINOR: Better button styles
MINOR: Now compass for button sprites
2011-12-29 09:48:22 +01:00
Ingo Schommer
749d908e95 Merge pull request #147 from ajshort/pull-1
Minor Form Changes
2011-12-28 23:49:58 -08:00
ajshort
d692c22ee4 MINOR: Fixed FileField->Value() erroring when files value not set. 2011-12-26 19:08:08 +11:00
ajshort
3478e4f9e6 ENHANCEMENT: Made the form enctype configurable via a method Form->setEncType().
API CHANGE: Deprecated Form->FormEncType() in favour of Form->getEncType().
MINOR: Added enctypes as constants to the Form class.
2011-12-26 18:36:24 +11:00
ajshort
6aa90e6288 MINOR: Replaced is_a with instanceof to fix bugs with the changed is_a behaviour in PHP 5.3.7. 2011-12-26 18:31:32 +11:00
Ingo Schommer
565e2ab318 Merge pull request #143 from Innovatif/sapphire
---

BUGFIX Having <header tag in HTML causes requirements to double. See http://www.silverstripe.org/general-questions/show/17524
2011-12-23 16:36:01 +01:00
Ingo Schommer
7d245c3803 MINOR Reduced unnecessary autoloading 2011-12-23 10:31:35 +01:00
Ingo Schommer
255c110fb5 Merge pull request #144 from simonwelsh/sapphire
---

..._FILES so it handles nested keys properly.
2011-12-23 09:33:13 +01:00
Simon Welsh
dd546a9888 BUGFIX Merge request arrays recursively 2011-12-23 17:48:49 +13:00
Ingo Schommer
1f3b0d2684 MINOR Fixed link form prepopulation of selected text in CMS 2011-12-21 14:50:42 +01:00
Ingo Schommer
53506f37f2 MINOR Don't remove checkboxes from page tree after batch actions, as it causes an inconsistent UI ('multi-select' view is still enabled) (fixes #6758) 2011-12-21 10:48:53 +01:00
Ingo Schommer
0d26776e09 MINOR Deselecting tree items after swtiching back from multi-select (fixes #6810, thanks wolfv) 2011-12-21 10:19:42 +01:00
Anselm Christophersen
cdedbb8d37 MINOR ModelAdmin styling 2011-12-20 18:00:56 +01:00
Ingo Schommer
30377f277e MINOR Update CMS menu state on form submission (as well as history state change) 2011-12-20 17:46:44 +01:00
Ingo Schommer
225776389a MINOR Allow overwriting of 'X-Controller' and 'X-Title' HTTP headers in CMS 2011-12-20 17:46:44 +01:00
Ingo Schommer
c70e70b5c4 MINOR Removing compass asset_cache_buster functionality, as it wrongly changes the hashes even if files haven't changed, causing merging hassles - leave cache control to the webserver 2011-12-20 17:46:43 +01:00
Ingo Schommer
2211fc11ca MINOR Added reuseable .cms-panel-padded style 2011-12-20 17:46:43 +01:00
Ingo Schommer
47f53dfa39 MINOR Reverted special styling of preview button in CMS, too hard to keep consistent alignment 2011-12-20 17:46:43 +01:00
Ingo Schommer
ac963755dd ENHANCEMENT Support for fake "redirects" in ajax responses via History.replaceState() (used e.g. for an add form loading the record for editing afterwards, under its own URL) 2011-12-20 17:46:38 +01:00
Ingo Schommer
068fcb209f MINOR Added temporary, hardcoded "add page" menu links 2011-12-20 14:10:08 +01:00
Ingo Schommer
11b3b43c84 MINOR Only load preview panel if its visible, to avoid unnecessary asset loads and processing. Only refresh edit form view from preview events when its visible. 2011-12-19 15:06:04 +01:00
Ingo Schommer
f1f8dcd24d MINOR Improved CMS UI context by showing breadcrumbs in form record title, using current record instead of form field to determine values 2011-12-19 14:57:11 +01:00
Ingo Schommer
058719571c ENHANCEMENT Allowing to inject <style> tags via ajax responses in LeftAndMain.js (used for the CMS page tree icons) 2011-12-19 13:33:07 +01:00
Ingo Schommer
05d19d9a82 Revert "MINOR Use json_decode() instead of the Services_JSON class if the function exists." - it breaks assumptions around Convert::json2array() only converting the *first* level of an object structure into an array, which in turn fails CMSMainTest and LeftAndMainTest (as well as some UI functionality relying on it). In order to introduce this change we have to fix these issues in a backwards compatible manner.
This reverts commit 3a006b77ae.
2011-12-18 20:17:41 +01:00
Ingo Schommer
68a394427d MINOR Fixed usage of FieldSet->insertFirst() in ModelAdmin, no longer present in FieldList 2011-12-18 18:19:28 +01:00
Ingo Schommer
0bfc0bc645 MINOR Cleaning $Content property explicitly for SecurityAdmin->groupimport() iframe 2011-12-18 18:18:44 +01:00