Jeremy Shipman
c4eac5310e
FIX: Instead of CsvBulkLoader->findExistingRecord out right failing (i.e. no duplicate found) when the duplicate check field is empty, it will now continue on to check other duplicateCheck fields.
...
Added extra testing data to CSVBulkLoaderTest so that it fails.
2013-04-19 16:52:39 +12:00
Che Van Lawrence
d07fb4355d
Merge pull request #1770 from kinglozzer/config-dir-detection-fix
...
FIX: _config/ directories are now correctly detected as modules (fixes #1762 )
2013-04-18 14:48:55 -07:00
Sean Harvey
6e0fa5db45
Merge pull request #1768 from tractorcow/3.1-http-mail-fixes
...
BUG HTTP incorrectly converts mailto links to absolute urls
2013-04-18 14:46:10 -07:00
Ingo Schommer
6e3a150424
3.1.0-beta3 changelog
2013-04-18 19:28:13 +02:00
Ingo Schommer
d877c1063d
Updated changelog, moved "statics in Page.php" to top
...
Its going to be a fatal error on every upgrade unless tended to,
so we need to ensure people don't overlook it in the guide.
2013-04-18 18:28:09 +02:00
Ingo Schommer
7f6671628d
"UploadFieldFileButtons" casting (regression from casting changes)
...
Caused the UploadField rows to show "[Object object]" because
it tried to pass through a PHP object to JS without string casting
(the return used to be a string).
2013-04-18 17:09:56 +02:00
Loz Calver
0384369acb
FIX: _config/ directories are now correctly detected as modules ( fixes #1762 )
...
DO NOT MERGE: to be reviewed. Only i18n & Deprecation classes use
->getModules() as far as I can see. Given that the method still simply
returns an array of modulename => modulepath, I don't think it's really
an API change
2013-04-18 14:08:03 +01:00
Damian Mooyman
b6fc1d314e
BUG HTTP will now correctly pass over mailto: links when converting relative links to absolute (e.g. in Emails)
2013-04-18 14:25:51 +12:00
Simon Welsh
93a8e6f16e
Merge pull request #1773 from silverstripe-rebelalliance/fix/htmlvalue_attr_escaping
...
FIX We still need XML escaping on href attributes in HTML4Value
2013-04-17 15:05:33 -07:00
Hamish Friedlander
8d26bdbd2e
FIX We still need XML escaping on href attributes in HTML4Value
2013-04-18 09:13:24 +12:00
uniun
4d70daa9e2
BUG: HiddenFields and VisibleFields should always return extraFields
...
HiddenFields() and VisibleFields() should always return extraFields, e.g. HiddenFields doesn't return SecurityID if it is called before Fields().
2013-04-17 20:31:17 +02:00
Ingo Schommer
2523dfbe95
Enforcing extension-less file validation ( fixes #1767 )
...
By default, File.allowed_extensions contains '' (no extension),
but if you specifically remove it, the validation should pick it up.
2013-04-17 10:21:59 +02:00
Ingo Schommer
a7574f0450
Merge pull request #1769 from wilr/doubleduplication
...
Remove duplicate functionality between float and double
2013-04-17 01:15:30 -07:00
Will Rossiter
e366fabd55
Remove duplicate functionality between float and double
2013-04-17 17:35:59 +12:00
Ingo Schommer
67ce9e08cc
Extended docs for shortcode handling and doctypes ( fixes #1700 )
2013-04-16 14:01:04 +02:00
Nicolaas
08bf2aa91e
removing potentially invalid html in email
...
The generic email template encapsulates the "body" content in a paragraph mark. This is undesirable as it can lead to invalid HTML. Rather than using a paragraph, it is better to have a div encapsulating the content.
The underlying reason for this is that $Body is usually HTML and this can included block elements (div, p, etc...) that are not allowed within paragraphs (p).
It is important that the HTML is valid, because it will reduce the likelihood for it being marked as spam, because it is less likely to show up strange formatting and for use of tools like emogrifier.
2013-04-16 10:38:08 +02:00
Ingo Schommer
85202876a9
Merge pull request #1726 from s-m/1487-fix-template-comments
...
BUG: Fix invalid code with source-file-comments, fixes #1487
2013-04-16 00:59:15 -07:00
s-m
acf2ff8ce6
BUG: Fix for #1487
...
The parser could sometimes generate invalid code if the
source-file-comments were enabled, this moves the comments outside the
html-tag to circumvent these problems, update test as well.
2013-04-15 19:54:41 +02:00
Hamish Friedlander
c02d7e4c2e
Merge pull request #1750 from s-m/1660-elseif-parsing
...
BUG: Allow empty else- and else_if-blocks
2013-04-14 14:56:45 -07:00
Sean Harvey
2a65f17542
Merge pull request #1757 from tractorcow/3.1-phone-field-fix
...
BUG Fixed incorrect variable usage in generation of PhoneNumberField form fields
2013-04-14 14:01:09 -07:00
Ingo Schommer
566ae87c36
Merge pull request #1755 from kinglozzer/leftandmain_state_fix
...
Fix broken CMSSettings saving
2013-04-14 13:40:39 -07:00
Ingo Schommer
fadf77e63d
Merge pull request #1758 from chiujl/patch-1
...
DatetimeField returns wrong year
2013-04-14 13:31:09 -07:00
Marvin Dickhaus
ea558828c9
Group description in CMSFields
2013-04-14 22:11:19 +02:00
chiujl
cb463449e8
DatetimeField returns wrong year
...
This is related to how Zend_Date returns year for YYYY & yyyy format. Detailed explanation is here http://framework.zend.com/issues/browse/ZF-5297
Sample code (adapted the Datetimefield setValue() method) to highlight the problem:
include 'framework/thirdparty/Zend/Date.php';
$userValueObj = new Zend_Date(null, null, 'en_US');
$userValueObj->setTimezone('GMT');
$userValueObj->setDate('2012-01-01', 'YYYY-MM-dd');
$userValueObj->setTime('00:00:00', 'HH:mm:ss');
echo $userValueObj->get('YYYY-MM-dd HH:mm:ss', 'en_US'), "\n"; // returns 2011-01-01 00:00:00
echo $userValueObj->get('yyyy-MM-dd HH:mm:ss', 'en_US'), "\n"; // returns 2012-01-01 00:00:00
2013-04-13 06:26:52 +08:00
Damian Mooyman
0dfc6d5eab
BUG Fixed incorrect variable usage in generation of PhoneNumberField form fields
2013-04-12 15:13:58 +12:00
Ingo Schommer
59dc0085d8
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
docs/en/reference/urlvariabletools.md
tests/forms/CheckboxFieldTest.php
2013-04-12 01:13:32 +02:00
Ingo Schommer
933fbf8ea4
l10n key to make "yes" and "no" translatable (see #1749 )
2013-04-12 01:11:24 +02:00
Loz Calver
c53b61c347
Fix broken CMSSettings saving
...
Regression from da7e515d13
2013-04-11 17:25:15 +01:00
Ingo Schommer
1f7796c83e
Merge pull request #1753 from g4b0/1752-image-manipulation-parameter
...
API: used reflection in order to have an arbitrary number of parameter
2013-04-11 08:53:25 -07:00
g4b0
c8e8b5147d
API: used call_user_func_array in order to have an arbitrary number of parameter for getFormattedImage ( fixes #1752 )
2013-04-11 16:51:36 +02:00
Ingo Schommer
ae09301c8c
Revert deprecation of Object::add_extension() usage
...
This reverts commit 14b997eea3
.
Its just not practical to use the Config API as it stands,
the add_extension() wrapper does more than just a Config->update().
Most use cases can be covered via YML, but any conditional
additions (e.g. in unit tests) can still benefit from the
add_extensions() shorthand.
2013-04-11 11:40:53 +02:00
Ingo Schommer
16c7235942
DateField.js event selector regression ( fixes #1528 )
...
See 19a8545076
2013-04-11 10:19:00 +02:00
s-m
29e6bd513c
BUG: Allow empty else- and else_if-blocks
...
This fix allows empty else and else-if blocks to be processed, fixes #1660
2013-04-10 16:17:44 +02:00
Will Rossiter
ba67d4c5cd
Merge pull request #1746 from tractorcow/3.1-errorpage-icons-fix
...
BUG Fixed broken ErrorPage icons in CMS view
2013-04-10 00:25:24 -07:00
Damian Mooyman
9da57b083a
BUG Fixed broken ErrorPage icons in CMS view
2013-04-10 17:15:42 +12:00
Sean Harvey
97b1f8616f
Merge pull request #1739 from kinglozzer/leftandmain-uninitialized-tabs
...
FIX: Edge case attempting to destroy uninitialized tabs
2013-04-09 14:08:12 -07:00
Ingo Schommer
a68fb1f096
Fixed /admin/pages/publishall link in docs
2013-04-09 23:00:27 +02:00
Ingo Schommer
659a793cc8
Merge pull request #1744 from ryanwachtl/patch-1
...
Update configuration.md
2013-04-09 08:13:26 -07:00
Ryan Wachtl
46831f56fb
Update configuration.md
...
Link to ssbits.com config cheatsheet no longer relevant.
2013-04-09 10:09:25 -05:00
Ingo Schommer
5fbf2e9303
Merge pull request #1741 from kinglozzer/1696_handlerequest_fix
...
Fix: RequestHandler not managing 404/403 errors correctly (fixes #1696 )
2013-04-09 07:52:20 -07:00
Loz Calver
58de19e01f
Fix: RequestHandler not managing 404/403 errors correctly ( fixes #1696 )
2013-04-09 15:43:50 +01:00
Ingo Schommer
14b997eea3
API Deprecated Object::add_extension() usage (as of 3.2)
2013-04-09 15:00:34 +02:00
Ingo Schommer
1cfc159f1a
Un-deprecated Object::add_extension() non-LSB usage ( fixes #1710 )
...
Its usage is too common to force-remove it just for a shortcut.
We still recommend adding extensions through YAML of course.
2013-04-09 14:56:26 +02:00
Ingo Schommer
9456b8043c
Fixed "insert media" styling (regression from 27b0cda0
)
2013-04-09 14:47:10 +02:00
Ingo Schommer
9856fcef21
Merge remote-tracking branch 'origin/3.0' into 3.1
...
Conflicts:
javascript/DateField.js
model/DataQuery.php
model/Versioned.php
tests/forms/RequirementsTest.php
tests/model/DataObjectLazyLoadingTest.php
view/Requirements.php
2013-04-09 14:45:35 +02:00
Ingo Schommer
310bc8d09c
Better default icon for ModelAdmin
...
Cogwheels doesn't really communicate its meaning well...
New icon is from http://thenounproject.com/noun/database/#icon-No6001 ,
doesn't require permanent attribution (CC0)
2013-04-09 13:43:32 +02:00
Ingo Schommer
baca12bf37
3.1 changelog summaries
2013-04-09 13:36:39 +02:00
Loz Calver
975c6992df
FIX: Edge case attempting to destroy uninitialized tabs
...
Another edge case very similar to
https://github.com/silverstripe/sapphire/commit/07fb7563273fa82bd93eb255
70571c0a298198e5
2013-04-09 11:21:54 +01:00
Ingo Schommer
17362f9474
Showing "Help" menu item below "Settings"
2013-04-09 12:20:20 +02:00
Ingo Schommer
7d600f57d5
CMSMenu sort order ( fixes #1716 )
...
Regression caused by b645703eb9
2013-04-09 12:19:33 +02:00