Commit Graph

51 Commits

Author SHA1 Message Date
Sam Minnee
c347278dda API CHANGE: Added Debug::$friendly_error_header and Debug::$friendly_error_detail for customising the friendly error message. (from r69855)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88632 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-12 03:20:24 +00:00
Ingo Schommer
e7add7a943 MINOR Dont trim strings in Debug::message(), they are useful for indentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86222 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-09-14 05:41:28 +00:00
Sean Harvey
3386e8223a MINOR Removed unnecessary $bt variable in Debug::errorHandler()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86176 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-09-13 23:23:02 +00:00
Sean Harvey
c9af2765b2 MINOR Fixed tabbing in errorHandler()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84838 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-08-19 22:58:03 +00:00
Sean Harvey
2cca0b0a7b API CHANGE Added SSLogFileWriter to replace Debug::log_errors_to() and Debug::log_error_if_necessary() - the existing formatting for the Debug deprecation functions is now wrapped into SSLogErrorFileFormatter
MINOR Moved SSErrorLogTest to SSLogTest
MINOR Documentation updates for SSLog and other bits and pieces



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84828 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-08-19 21:55:03 +00:00
Sean Harvey
12e54a4a6e MINOR Fixed tabbing in Debug
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84818 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-08-19 06:05:01 +00:00
Sean Harvey
1494169201 ENHANCEMENT Debug and DebugView now supports showing E_NOTICE and E_USER_NOTICE level errors, whereas before they were not handled
ENHANCEMENT Updated SSLogErrorEmailFormatter to support NOTICE priority level logging
MINOR Updated SSBacktrace to ignore Debug::noticeHandler() in the backtrace



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84816 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-08-19 06:03:57 +00:00
Sean Harvey
2c703c8a84 MINOR Added NOTICE level priority to SSLog
MINOR Added @deprecated php tag to deprecated functions in the Debug class
MINOR Class documentation for SSLog and Debug



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84811 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-08-19 05:41:58 +00:00
Sean Harvey
a682ab9c0e API CHANGE Moved Debug::backtrace() to SSBacktrace::backtrace()
API CHANGE Moved Debug::get_rendered_backtrace() to SSBacktrace::get_rendered_backtrace()
ENHANCEMENT Added SSLog, SSLogEmailWriter and SSLogErrorEmailFormatter for silverstripe message reporting
API CHANGE Debug::send_errors_to() and Debug::send_warnings_to() are deprecated in favour of SSLog. See class documentation for SSLog on configuration of error email notifications
MINOR Added SSLogTest for basic testing of the SSLog and SSLogEmailWriter classes



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84774 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-08-19 03:55:23 +00:00
Tom Rix
7115d327d4 MINOR made $prefix to Debug::header() optional
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82789 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-27 21:56:27 +00:00
Tom Rix
0609a8e9cd MINOR added Debug::header() for fun debugging.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82759 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-27 03:52:40 +00:00
Ingo Schommer
cca0d327e7 BUGFIX Don't try to fetch contents from non-existent debug.log files in Debug::log() (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82059 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:48:41 +00:00
Sean Harvey
6c754d29e9 Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79438 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-17 11:36:49 +00:00
Sean Harvey
2b3889b640 API CHANGE Removed @deprecated 2.3 function Debug::sendLiveErrorsTo(): Please use Debug::send_errors_to() instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@77392 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-20 07:19:14 +00:00
Sean Harvey
a1b1e337f9 Merged r77259 from sapphire/branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@77260 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-19 22:11:33 +00:00
Ingo Schommer
e78d6022fe BUGFIX Fixing assets filepath in Debug::friendlyError()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@75914 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-05-04 02:17:56 +00:00
Sean Harvey
a5e82ddff1 Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@75590 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-04-29 01:20:24 +00:00
Sam Minnee
a970382924 BUGFIX #3579 bgribaudo: Error in error text rendering
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73490 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-22 08:38:14 +00:00
Ingo Schommer
7ad7f8dcf2 ENHANCEMENT Adjusted SearchForm, Debug, ErrorPage, SiteTree to using locales instead of lang codes
API CHANGE Changed Translatable datamodel to use locales ("en_US") instead of lang values ("en).
API CHANGE Changed Translatable::$default_lang to $default_locale, Translatable::$reading_lang to $reading_locale
API CHANGE Using "locale" instead of "lang" in Translatable::choose_site_lang() to auto-detect language from cookies or GET parameters
API CHANGE Deprecated Translatable::is_default_lang(), set_default_lang(), get_default_lang(), current_lang(), set_reading_lang(), get_reading_lang(), get_by_lang(), get_one_by_lang()
API CHANGE Removed Translatable::get_original() - with the new "translation groups" concept there no longer is an original for a translation
BUGFIX Updated MigrateTranslatableTask to new Locale based datamodel

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73468 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-20 08:47:06 +00:00
Andrew O'Neil
c86971c93f #2328 - Show backtrace for uncaught exceptions (ajshort)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@70444 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-20 21:30:12 +00:00
Ingo Schommer
7057b56b2c ENHANCEMENT Making ErrorPage static HTML files translatable (#2233)
ENHANCEMENT Added ErrorPage::$static_filepath to flexibly set location of static error pages (defaults to /assets)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@70326 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-19 01:25:23 +00:00
Ingo Schommer
d26f08b481 MINOR merged branches/2.3 into trunk
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@67465 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-12-04 22:38:32 +00:00
Sam Minnee
96c5be8252 Updating queries to be more DB agnostic
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@66507 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-24 09:31:14 +00:00
Sam Minnee
486ae69f09 #2135 - Disallow XSS bug in development RestfulService use
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65287 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-05 05:04:32 +00:00
Ingo Schommer
404aba0bb8 API CHANGE Removed Debug::mailBuffer()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64381 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 08:43:03 +00:00
Sam Minnee
25a812c12f MINOR: Reformatting
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63937 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 01:45:12 +00:00
Ingo Schommer
5d3e815967 API CHANGE Changed parameters for Debug::friendlyError()
ENHANCEMENT Using DebugView class in Debug::friendlyError()
ENHANCEMENT Using Debug::friendlyError() in HTTPResponse class if status code signifies error (only on live environments in non-ajax requests)
ENHANCEMENT Showing contact information in Debug::friendlyError() from Email::getAdminEmail()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63465 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 14:43:43 +00:00
Ingo Schommer
9371f4688b ENHANCEMENT Introduced constants for system paths like /sapphire in preparation for a more flexible directory reorganisation. Instead of hardcoding your path, please use the following constants: BASE_PATH, BASE_URL, SAPPHIRE_DIR, SAPPHIRE_PATH, CMS_DIR, CMS_PATH, THIRDPARTY_DIR, THIRDPARTY_PATH, ASSETS_DIR, ASSETS_PATH, THEMES_DIR, THEMES_PATH
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63154 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-27 16:02:38 +00:00
Ingo Schommer
306ea3761f ENHANCEMENT Added Debug::send_warnings_to()
API CHANGE Deprecated Debug::mailBuffer()
API CHANGE Removed Debug::warning()
MINOR Documentation and formatting for Debug class

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62843 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-22 16:03:19 +00:00
Ingo Schommer
0739b0520e ENHANCEMENT In Debug::showError(), if error is displayed through ajax with CliDebugView, use plaintext output
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62468 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-16 18:15:26 +00:00
Ingo Schommer
c57ce5f1a4 FEATURE Formatting MySQL error messages with newlines through new SQLFormatter class (used in MySQLDatabase)
ENHANCEMENT Using CliDebugView to report errors on ajax requests (with plaintext output)
ENHANCEMENT Removed "ERROR:" prefix hack for ajax error responses - clientside evaluation should inspect HTTP status codes instead

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62467 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-16 18:12:07 +00:00
Sam Minnee
5cd5440473 FEATURE: Update error handler to show useful information in the 500's status text
FEATURE: Allow customisation of HTTPResponse status text, as well as status code 


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62286 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-12 01:47:39 +00:00
Ingo Schommer
67e427cdf6 BUGFIX Reinstated error_handling(E_ALL) for dev environments in main.php after clarifying with sam - we want to force developers to recard notice-level errors unless they expicitly opt-out in their _config.php
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60643 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 21:49:52 +00:00
Sam Minnee
7f72a0120b Correct line numbers in error source fragment view
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:54:50 +00:00
Sam Minnee
1a73ef447e Added Debug::get_rendered_backtrace() for rendering backtraces from other contexts (such as exceptions)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60601 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:40:06 +00:00
Sam Minnee
0bdc8fad81 Improve CLI use of Debugging tools and test execution.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 01:47:05 +00:00
Hayden Smith
b512e4bd3b Changed Debug::loadErrorHandlers to use value returned by error_reporting() rather than E_ALL. This way, the user can adjust the error handler screens with the error_reporting function.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60555 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 23:50:28 +00:00
Sam Minnee
028cb281ce Improved Debug::backtrace() output
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60390 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-11 05:16:51 +00:00
Sam Minnee
db1e79c3b1 FEATURE: Improved debugging view on CLI interface, by having a separate DebugView subclass that takes care of error output for this situation.
API CHANGE: Added Debug::log_errors_to(), to log errors to a file.


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60368 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-11 04:02:32 +00:00
Ingo Schommer
46bbde18e7 (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60261 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-10 23:03:35 +00:00
Ingo Schommer
7b26120582 (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60259 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-10 22:52:52 +00:00
Ingo Schommer
75f2cf2654 (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60232 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-09 06:40:50 +00:00
Ingo Schommer
4ec93162a0 (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60231 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-09 06:29:50 +00:00
Ingo Schommer
0362276b67 (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60230 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-09 06:24:30 +00:00
Ingo Schommer
e033d105f6 (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60229 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-09 06:21:41 +00:00
Ingo Schommer
0a8f2a67f6 (merged from branches/roa. use "svn log -c <changeset> -g <module-svn-path>" for detailed commit message)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60228 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-09 06:18:32 +00:00
Mark Rickerby
b9cb101182 do I still have write access?
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@57832 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-07-11 06:22:50 +00:00
Ingo Schommer
60860cc1b9 MINOR Unified @package PHPdoc (added where missing, removed duplicates)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@56212 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-06-15 13:33:53 +00:00
Mark Rickerby
a0f664bf25 replacing reference to new DebugView in error reporting method
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@55819 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-06-06 05:13:18 +00:00
Mark Rickerby
4619d7d466 removed redundant reporter class
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@55814 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-06-06 05:06:53 +00:00