Commit Graph

630 Commits

Author SHA1 Message Date
Julian Seidenberg
ed666b71b7 ENHANCEMENT: DataObject and SiteTree duplicate now duplicate relations (except for has_many relations, as the object at the other end of such a relation has an existing relation to the original object and that should not be modified by the duplication)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@110845 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-09-16 03:40:34 +00:00
Andreas Piening
983fb1fc09 BUGFIX #5157 strftime() %F format parameter does not work on Windows - use %Y-%m-%d instead (from r100795)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@108762 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-08-02 01:00:44 +00:00
Ingo Schommer
c81a788ba7 ENHANCEMENT Added 'updateImageForm', 'updateFlashForm', 'updateLinkForm' hooks to HtmlEditorField (the imageform hook was necessary to make the 'pixlr' module work) (see #3938) (from r100753)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105642 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:56:02 +00:00
Ingo Schommer
e4dfc243b4 BUGFIX Fixed SapphireTest->loginWithPermission() and MemberAuthenticatorTest to use existing Members based on their unique_identifier_field (if existing) to accommodate recent Member->onBeforeWrite() changes (see r100705) (from r100723)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105628 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:24:53 +00:00
Ingo Schommer
79b912f7b1 BUG FIX: column names quoted properly (from r100693)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105625 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:23:44 +00:00
Ingo Schommer
b717d19457 BUG FIX: column names quoted properly (from r100692)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105623 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:23:18 +00:00
Ingo Schommer
656eccc7a4 MINOR Removed Requirements:: static call and replace with instance (from r100533)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105598 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:16:33 +00:00
Ingo Schommer
9a438d26b0 ENHANCEMENT #3387 Requirements now has a new static function called Requirements::set_combined_files_folder() for setting where the combined files should belong (from r100528)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105596 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:15:43 +00:00
Ingo Schommer
a030d33f33 MINOR Removed whitespace (from r100517)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105592 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:14:18 +00:00
Ingo Schommer
7d8ac7662b MINOR Removed end php tag for Requirements and RequirementsTest (from r100514)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105591 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:14:00 +00:00
Ingo Schommer
9c03cc7fe1 API CHANGE Refactored Requirements to use Requirements_Backend at all times - this makes testing far easier. Thanks tobych!
MINOR Updated RequirementsTest to test Requirements_Backend instead of global statics (from r100513)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105590 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:13:45 +00:00
Ingo Schommer
7e8a2c10c9 MINOR Changed places of Object::extInstance() to Object::getExtensionInstance() and added a notice if extInstance is used in future (from r100487)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105575 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:55:30 +00:00
Ingo Schommer
d5e48d55dc ENHANCEMENT #4599 DataObjectSet now uses more array functions instead of performing equivalent tasks - thanks simon_w! (from r100453)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105570 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:53:43 +00:00
Ingo Schommer
30b2a950fe ENHANCEMENT Convert JSON functions now use the Services_JSON library where appropriate instead of custom code, and if json_decode() or json_encode() are available these are used
MINOR Added unit tests for Convert JSON functions (from r100423)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105567 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:52:38 +00:00
Ingo Schommer
252be427f7 ENHANCEMENT #5072 RSSFeed_Entry::rssField() now respects custom getters on the data class (from r100400)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105559 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:49:55 +00:00
Ingo Schommer
75b98970e4 API CHANGE #5107 Upload now uses Upload_Validator to separate the validation rules from the File loading done in the Upload class (from r100057)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105549 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:42:52 +00:00
Ingo Schommer
f86c05ba08 MINOR Reinstated UploadTest (from r99862)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105540 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:18:49 +00:00
Ingo Schommer
b632c8ff88 BUGFIX: Fix #5097, Translatable uses augmentValidURLSegment to check that URLSegment is valid (from r99850)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105539 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:18:25 +00:00
Ingo Schommer
5986bd859d MINOR: More tests for array data (from r99750)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105525 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 02:58:06 +00:00
Ingo Schommer
0f0f29c35e MINOR Fixed typo
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@103668 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-28 07:16:21 +00:00
Ingo Schommer
4703aa6e81 MINOR Fixed SapphireTest->logInWithPermission() spelling (from r99491)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102866 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:41:30 +00:00
Ingo Schommer
6227478f82 FEATURE New DatetimeField class (form field wrapper composed of DateField andTimeField)
FEATURE New DateField and TimeField form classes with more consistent API and easier localization
API CHANGE Date/time parsing in DateField, TimeField and DatetimeField defaults to i18n::get_locale() ('en_US') instead of using en_NZ/en_GB specific parsing. Use i18n::set_locale('en_NZ') in mysite/_config.php to revert to old behaviour.
API CHANGE  constructor parameter in TimeField needs to be in ISO date notation (not PHP's date())
API CHANGE TimeField, DateField and related subclasses use Zend_Date for date parsing, meaning they're stricer than the previously used strtotime()
API CHANGE Removed DMYCalendarDateField and CalendarDateField, use DateField with setConfig('showcalendar')
API CHANGE Removed CompositeDateField, DMYDateField, use DateField with setConfig('dmyfields')
API CHANGE Removed DropdownTimeField, use TimeField with setConfig('showdropdown')
API CHANGE Removed PopupDateTimeField, use DatetimeField
API CHANGE Changed 'date', 'month' and 'year' HTML field names to lowercase in DMYDateField
API CHANGE Removed support for ambiguous date formats in DateField, e.g. '06/03/03'. Use DateField->setConfig('dateformat', '<format>') to revert to this behaviour.
API CHANGE Removed  flag from DateField, CalendarDateField etc., use DateField->setConfig('min') and DateField->setConfig('max')
ENHANCEMENT Using Zend_Date for DateField and TimeField, with more robust date handling, starting localization support. Set globally via i18n::set_locale(), or for a field instance through setLocale(). Note: Javascript validation is not localized yet. (from r99360)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102859 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:38:40 +00:00
Ingo Schommer
76d57b648d MINOR Temporarily disabled nested url specific cases inTranslatableTest->testAlternateGetByLink(), unclear functionality requirements (from r99350)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102856 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:12:46 +00:00
Ingo Schommer
ffd0774839 BUGFIX: Fixed SiteTree_versions version numbers for published virtual pages. (from r98675) (from r99065)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102833 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:58:16 +00:00
Ingo Schommer
000d892256 MINOR refactored setting/getting strict hierarchy setting. (from r98654) (from r99064)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102832 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:57:45 +00:00
Ingo Schommer
a5c2a3e564 MINOR more unit tests around loose hierarchy (from r98509) (from r99062)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102830 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:56:51 +00:00
Ingo Schommer
658e24ea45 MINOR added enforce_strict_hierarchy option, and tests around not cascading deletions (from r98498) (from r99059)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102829 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:56:22 +00:00
Ingo Schommer
9c5303285a BUGFIX: Generate SiteTree_version records for VirtualPages more reliably. (from r98309) (from r99052)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102828 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:54:36 +00:00
Ingo Schommer
d5f21946d2 BUGFIX: the ID should be that of untranslated child (it's the middle segment that's from translated version, not the last one) (from r98946)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102816 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:49:23 +00:00
Ingo Schommer
394cddb4e6 MINOR: Renamed manifest test temp dir as there was some kind of conflict (from r98519)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102761 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:17:09 +00:00
Ingo Schommer
6e284c2914 MINOR: Speed up cache test (1s is as good a test expiry as 8s) (from r98433)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102657 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:24:37 +00:00
Ingo Schommer
56fc2d579f MINOR Fixed SiteTreeBacklinksTest on Windows (from r98427)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102655 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:24:08 +00:00
Ingo Schommer
2d01b35bf5 MINOR Fixed HTTPTest->testSetGetVar() (from r98409)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102654 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:23:56 +00:00
Ingo Schommer
67305d2787 MINOR Fixed HTTPTest->testSetGetVar() (from r98407)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102653 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:23:36 +00:00
Ingo Schommer
dc21cb9ae0 BUGFIX Fixed Hierarchy->loadDescendantIdList() to call setOwner() on the extension instance. This was necessary due to underlying Object/Extension changes in 2.4.
MINOR Fixed HierarchyTest assertions around including grand children counts (from r98403)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102651 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:23:06 +00:00
Ingo Schommer
804c588215 MINOR Fixed HTTPTest when invoked through dev/tests/all or with GET parameters (see r98373) (from r98383)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102650 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:22:43 +00:00
Ingo Schommer
dad685e2e2 MINOR Testing of grand-children items in HierarchyTest::testLoadDescendantIDListIntoArray() and HierarchyTest::testNumChildren() (from r98376)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102648 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:21:58 +00:00
Ingo Schommer
6f411a359a API CHANGE HTTP::setGetVar() always returns absolute URLs. Use Director::makeRelative() to make them relative again.
API CHANGE HTTP::setGetVar() combines any GET parameters in PHP array notation (e.g. "foo[bar]=val") instead of replacing the whole array
BUGFIX HTTP::setGetVar() uses parse_url() and http_build_query() to add query parameters to an existing URL, instead of doing its own regex-based parsing. This means existing GET parameters are correctly url encoded. (from r98373)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102647 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:21:33 +00:00
Ingo Schommer
4f84761ab4 MINOR Fixed test case name in Hierarchy (from r98370)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102645 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:20:46 +00:00
Ingo Schommer
761f607615 MINOR Added test case for Hierarchy::getDescendantIDList() which also tests Hierarchy::loadDescendantIDListInto() (from r98369)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102644 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:20:33 +00:00
Ingo Schommer
f34bdada7b MINOR Use 'b' mode for fopen() where possible for better portability (from r98321)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102641 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:19:41 +00:00
Ingo Schommer
0a4d5ca990 BUGFIX: Updated SiteConfig-based theme selection to remove inappropriate coupling from SSViewer (from r98263)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102636 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:18:10 +00:00
Ingo Schommer
b73d75f907 MINOR Adding SiteConfig as Translatable dependency in SiteTreeTest and TranslatableTest (from r98228)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102634 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:17:14 +00:00
Ingo Schommer
d7f2925dc8 APICHANGE: Refactor Versioned so a single state is kept for stage, archived date, or any module specific reading modes (from r98161) (from r98224)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102633 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:16:57 +00:00
Ingo Schommer
29a778fa45 MINOR: Fixed PermissionTest assertion (from r96642) (from r98142)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102614 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:18:14 +00:00
Ingo Schommer
1e78fbc34c MINOR: Fixed TableListField test to suit changed behaviour. (from r96639) (from r98141)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102613 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:17:51 +00:00
Ingo Schommer
9b650a4e6c MINOR remove sort direction when running canSortBy. Also added test coverage for this. (from r96428) (from r98138)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102610 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:16:50 +00:00
Ingo Schommer
ac5bb2b527 MINOR Cleanup test folder after SiteConfigTest::testAvailableThemes() is run (from r98127)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102601 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:14:47 +00:00
Ingo Schommer
c045198333 MINOR: added descriptive text to test assert. (from r98115)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102600 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:14:35 +00:00
Ingo Schommer
b8ab017597 BUGFIX: fixed test that was trying to do a assertContains between a DataObjectSet and a Member object. Changed it to an assertEquals between Member and the First item in the Set. Also added an inverse test to check that Set doesn't contain the wrong Member. (from r98114)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102599 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:14:23 +00:00