Robbie Averill
46c50577a4
Expect BEM class names in tests, fix PSR-2 line lengths, add ArrayList import
2018-10-11 12:04:23 +02:00
Loz Calver
ee21c42011
FIX: Re-instate missing SS_DATABASE_SUFFIX functionality ( fixes #7966 )
2018-10-11 10:50:56 +01:00
Robbie Averill
648988bc18
Merge pull request #8468 from creative-commoners/pulls/4.3/tinymce-and-behat-help-me
...
FIX Persist TinyMCE updates when writing with Behat
2018-10-11 11:42:53 +02:00
Sam Minnee
4740346ed8
FIX: Make ArrayList::limit() consistent with DataList::limit()
...
This makes it easier to swap one fo the other without code breaking.
Since it’s strictly a removed API, I’ve opted to throw a deprecation
note in SS4 rather than throwing an InvalidArgumentException.
Fixes #2949
2018-10-11 21:05:20 +13:00
Maxime Rainville
250d925810
MINOR Update CompositeField::__construct to call setChildren #8460
2018-10-11 15:25:34 +13:00
Maxime Rainville
98afbfe9b4
Implement Peer review feedback #8460
2018-10-11 14:56:06 +13:00
Guy Marriott
0db2f84ade
FIX Persist TinyMCE updates when writing with Behat
2018-10-11 14:34:18 +13:00
Maxime Rainville
ef439f9306
MINOR Correct GridField_DataManipulator PHPDOC to not assume DataList
...
Tweak GridField_DataManipulator to not assume only DataList will be
provided. Use the SS_List Interface instead. (#8460 )
2018-10-11 12:06:21 +13:00
Maxime Rainville
2e2ca5a4a7
Make sure LazyLoader still woks after a readonly transofrmation ( #8460 )
2018-10-11 11:56:39 +13:00
Robbie Averill
eb0ef1c268
Merge pull request #8465 from creative-commoners/pulls/4.3/extensible-bug
...
NEW Add method to flush extra_methods static cache data and implement into test state
2018-10-11 00:02:27 +02:00
Robbie Averill
3642e7aeae
Remove extensionsToRemove and extensionsToReapply, now obsolete
2018-10-10 22:19:15 +02:00
Robbie Averill
bd6c4fdda0
Merge pull request #8440 from creative-commoners/pulls/4.3/its-indestruc-tab-le
...
NEW TabSet react component is no longer structural
2018-10-09 22:05:53 +02:00
Robbie Averill
56d5621934
FIX Flush extra_methods statics between test runs
2018-10-09 13:22:54 +02:00
Robbie Averill
55e79ffdfd
Add failing test to show that overloaded extensions are broken in Extensible
2018-10-09 12:35:32 +02:00
Robbie Averill
d1281a571a
FIX Escape HTML in PHPDoc to fix API docs from rendering incorrectly
2018-10-09 10:46:45 +02:00
Maxime Rainville
0b5a654d73
Add changelog entry for the GridFieldLazyLoader.
2018-10-09 17:33:23 +13:00
Maxime Rainville
fdb53311ba
Fix linting issue.
2018-10-09 17:32:42 +13:00
Maxime Rainville
a13a2cdd40
Add unit test for FieldList::getContainerField()
2018-10-09 17:32:42 +13:00
Maxime Rainville
51ba787ffb
Finish writting unit test for GridFieldLazyLoader.
2018-10-09 17:32:42 +13:00
Maxime Rainville
bfb6518176
Tweak the logic to empty lazy list.
2018-10-09 17:32:42 +13:00
Maxime Rainville
d2a51471e9
Don't lazy load tab that are not in a TabSet.
2018-10-09 17:32:42 +13:00
Maxime Rainville
5276b6cbb1
API Add FieldList::getContainerField
2018-10-09 17:32:42 +13:00
Maxime Rainville
bdb53979aa
API Create a new GridFieldLazyLoader GridField component
2018-10-09 17:32:42 +13:00
Robbie Averill
1d1cf6882d
Merge pull request #8461 from creative-commoners/pulls/4.3/unbelabelable-dom-skills
...
NEW Adding a helper to find a form field by label content (Behat)
2018-10-08 23:22:03 +02:00
Loz Calver
5426f34b4a
Merge pull request #8463 from creative-commoners/pulls/4.3/rm-cachedata
...
FIX Remove unused cacheData prop from #8451
2018-10-08 15:12:14 +02:00
Loz Calver
e829ad78b1
Merge pull request #8429 from sminnee/fix-2950
...
FIX: Throw deprecation on limit=0
2018-10-08 15:11:52 +02:00
Robbie Averill
c4788803ee
FIX Remove unused cacheData prop from #8451
2018-10-08 12:05:29 +02:00
Guy Marriott
2775895d03
NEW Adding a helper to find a form field by label content
2018-10-08 14:28:16 +13:00
Maxime Rainville
36b1066413
Merge pull request #8451 from creative-commoners/pulls/4.3/memory-cache-findtemplate
...
NEW Add memory cache to ThemeResourceLoader::findTemplate()
2018-10-08 10:38:07 +13:00
Robbie Averill
7668162be9
Merge pull request #8458 from sminnee/fix-4849
...
FIX: Don’t break validation on selects without a source.
2018-10-06 17:38:10 +02:00
Sam Minnee
8c7459a708
FIX: Fix CompositeField test that relied on a DropdownField bug
...
A DropdownField without a source no longer returns a validation
error.
2018-10-06 19:14:34 +13:00
Sam Minnee
e5d3b28a4d
FIX: Don’t break validation on selects without a source.
...
Fixes cases where there are no valid values or an empty-string
value is manually added rather than using setEmptyString()
Fixes #4849
Fixes #7159
2018-10-06 11:53:17 +13:00
Sam Minnée
7915fe0c0f
Merge pull request #8303 from hchokshi/pulls/4.2/viewable-data-customised-isset
...
Implement __isset for ViewableData_Customised
2018-10-06 09:37:19 +13:00
Sam Minnée
28c12bfec9
Merge pull request #8457 from kinglozzer/ext-json
...
Add ext-json to composer platform requirements
2018-10-06 09:31:40 +13:00
Loz Calver
7f6652996c
Re-order composer requirements
2018-10-05 15:52:47 +01:00
Loz Calver
df73188bc6
Add ext-json to composer platform requirements
2018-10-05 15:52:12 +01:00
Robbie Averill
98568262f2
Fixed phpcs violations
2018-10-05 16:07:33 +02:00
Robbie Averill
024762f03b
Move default themes lookup before cache check
2018-10-05 15:00:32 +02:00
Robbie Averill
da9301f241
Use SilverStripe cache API instead of memory cache, add tests and fix cache config indentation
2018-10-05 14:58:48 +02:00
Robbie Averill
172d8915b7
Clear cache between ThemeResourceLoader tests
2018-10-05 14:12:26 +02:00
Robbie Averill
9ea7b58a8f
NEW Add memory cache to ThemeResourceLoader::findTemplate()
...
For large sites, this reduces the number of file_exists, Path::join, getThemePaths etc
calls and can contribute to 26% reduction in TTFB load time
2018-10-05 14:12:26 +02:00
Maxime Rainville
d68f02ad25
Merge pull request #8393 from sachajudd/pulls/4/document-help-menu
...
DOCS Add docs for CMS help menu links
2018-10-05 14:02:14 +13:00
Robbie Averill
4c25894a59
Merge pull request #8446 from sminnee/fix-8121
...
FIX: Drop seconds from DBDatetime::Nice() to restore SS3 behaviour.
2018-10-04 08:38:42 +00:00
Robbie Averill
79812d10c2
Merge pull request #8441 from open-sausages/pull/4.3/refernce-new-search-in-changelog
...
Document new Search component in change logs.
2018-10-04 08:25:24 +00:00
Robbie Averill
9c68f0e4ac
Merge pull request #8447 from pstaender/patch-3
...
fixing name of constant ASSETS_PATH
2018-10-04 08:07:49 +00:00
Philipp Staender
fafd9dad6d
fixing name of constant ASSETS_PATH
2018-10-04 04:34:16 +02:00
Sam Minnee
0fc06e51e5
FIX: Drop seconds from DBDatetime::Nice() to restore SS3 behaviour.
...
Note that the medium date format depends on locale, with en_NZ being
resolutely numeric. I’ve updated the test to verify a couple of locales
to make this more obvious.
Fixes #8121
2018-10-04 14:51:24 +13:00
Maxime Rainville
14a8707bf2
Address PR feedback for Search changelog
2018-10-04 13:35:48 +13:00
Maxime Rainville
191d93697d
Document new Search component in change logs.
2018-10-04 13:29:48 +13:00
Sacha Judd
f5b6ce01cf
DOCS Add docs for CMS help menu links
...
[ci skip]
2018-10-04 10:50:57 +13:00