Commit Graph

1745 Commits

Author SHA1 Message Date
Sean Harvey
c5ed0c3c2e MINOR removed < and > characters from @author phpdoc token
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63492 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-02 00:38:53 +00:00
Sean Harvey
2c773d0d69 MINOR phpdoc tweaks
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63490 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-02 00:34:16 +00:00
Sean Harvey
673ce66e90 MINOR Filled in Ingo's email for phpdoc since he failed to do it himself
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63489 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-02 00:34:04 +00:00
Ingo Schommer
b33aaf81ae ENHANCEMENT Setting SimpleImageField->allowedExtensions to sensible defaults
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63470 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 18:33:30 +00:00
Ingo Schommer
17aad01848 MINOR Formatting in Member
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63469 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 18:32:55 +00:00
Ingo Schommer
b548ee6360 API CHANGE Deprecated Form->resetData() - use Form->resetField()
ENHANCEMENT Added Form->resetField()
MINOR Documentation for Form

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63468 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 18:32:10 +00:00
Ingo Schommer
5927bf2399 BUGFIX Fixed Upload->isValidExtension() - was checking array keys instead of array values ....
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63467 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 18:31:08 +00:00
Ingo Schommer
2a02c8f08a MINOR Documentation in ErrorPage
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63466 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 14:57:06 +00:00
Ingo Schommer
5d3e815967 API CHANGE Changed parameters for Debug::friendlyError()
ENHANCEMENT Using DebugView class in Debug::friendlyError()
ENHANCEMENT Using Debug::friendlyError() in HTTPResponse class if status code signifies error (only on live environments in non-ajax requests)
ENHANCEMENT Showing contact information in Debug::friendlyError() from Email::getAdminEmail()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63465 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 14:43:43 +00:00
Ingo Schommer
fd175cdbd3 BUGFIX Fixed hardcoded HTTP protocol information in BasicAuth
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63464 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 14:41:15 +00:00
Ingo Schommer
655395a8e7 ENHANCEMENT Added Director::get_environment_type()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63463 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 14:40:29 +00:00
Ingo Schommer
40fd160743 FEATURE Added Email::obfuscate()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63462 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 14:40:01 +00:00
Sean Harvey
497d760bcd MINOR Fix undefined variable error in ManifestBuilder::get_manifest_info()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63449 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 04:27:48 +00:00
Sam Minnee
ca884b809d BUGFIX #2753: Couldn't have fields named the same as methods
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63432 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 00:55:25 +00:00
Sam Minnee
ba85bc7614 Fixed bug in cli-script argument parsing
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63431 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 00:55:18 +00:00
Sean Harvey
c08f6e4dbb MINOR Code formatting changes for readability and consistency in DropdownField->Field()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63420 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 20:08:17 +00:00
Sean Harvey
b675fbe1ec MINOR Ticket #2869 Fixed PHP notice in Director::forceWWW()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63390 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 03:31:29 +00:00
Sean Harvey
1754e6cf81 Reverted r63388
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63389 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 03:28:50 +00:00
Sean Harvey
813679cc9b ENHANCEMENT Director::forceWWW() now does a 301 redirect for SEO (to be consistent with Director::forceSSL())
MINOR Fix PHP notice in checking $_SERVER['HTTPS']

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63388 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 03:27:49 +00:00
Sean Harvey
fb1b0b4381 MINOR Fixed PHP notices in ListboxField->Field() by defining the variables first
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63385 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 03:21:28 +00:00
Ingo Schommer
8502f4064d MINOR documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63370 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 02:06:46 +00:00
Ingo Schommer
0c4681eb81 MINOR todos for DataObjectTest
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63339 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 00:27:22 +00:00
Ingo Schommer
bf896a2cfd API CHANGE Deprecated DataObject->fieldExists() - please use hasField(), hasDatabaseField(), hasOwnTableDatabaseField()
ENHANCEMENT Added DataObject->hasOwnTableDatabaseField(), replaced legacy usage of fieldExists()
ENHANCEMENT Renamed cached static "fieldExists" to "_cache_hasOwnTableDatabaseField"
ENHANCEMENT Added DataObjectTest test cases for checking various field existence levels
API CHANGE Deprecated DataObject->listOfFields() - use custom code instead

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63337 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 00:20:30 +00:00
Sam Minnee
2af039785c ENHANCEMENT: Updated cli-script handling to be more in line with web calls, and improved Director::setBaseURL() calls.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63321 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 23:41:50 +00:00
Ingo Schommer
150d41b4c7 API CHANGE Removed SiteTree->canView_page() - originally created under the false assumption that SiteTree->can('view_page') is still valid. Every canView() can be instance specific. Original patch by simon_w in r53183 and #2198
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63310 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 21:41:20 +00:00
Sam Minnee
85e52eb568 BUGFIX #2529: Fixed HTTP/1.0 support
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63304 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 20:23:47 +00:00
Ingo Schommer
2c11afb2df BUGFIX wrong jsparty PATH references
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63296 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 18:49:55 +00:00
Ingo Schommer
6afad36c39 BUGFIX Don't try to use HTTP_HOST environment variable if its not set in Director::protocolAndHost(). Throw a warning, then return false - before if script execution was not set to stop on WARNING, you'll get a NOTICE as well.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63291 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 12:52:23 +00:00
Ingo Schommer
21944a2e06 BUGFIX Moved *_PATH and PR_*constants from main.php/cli-script.php back to Core.php - was causing problems with installer (directly includes Core.php, but doesn't run through main.php) - see ticket #2867 for improvement suggestions in bootstrapping code to avoid these bugs
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63290 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 12:33:07 +00:00
Sean Harvey
11e09aa0d6 ENHANCEMENT Tidied up DropdownField->Field() by making use of FormField->createTag() as other FormField subclasses such as TextField do
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63289 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 10:31:06 +00:00
Sean Harvey
57ad2dd372 Reverted en_US.php changes from r63249
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63251 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 03:20:22 +00:00
Sean Harvey
ba509c5336 ENHANCEMENT Moved UserDefinedForm and related code, templates, CSS and javascript out of cms and sapphire classes into userforms/trunk
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63249 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 03:18:23 +00:00
Ingo Schommer
a30532becb BUGFIX Moved TEMP_FOLDER define back from main.php/cli-script.php to Core.php, as it was causing problems with the installer
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63204 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 23:03:28 +00:00
Ingo Schommer
d7a4ae6a8f ENHANCEMENT Added ManifestBuilder::$cache_expiry_mins
API CHANGE Deprecated URL parameter ?buildmanifest=1 (please use ?flush=1)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63182 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 19:52:06 +00:00
Ingo Schommer
97263cd09c ENHANCEMENT Using HTTP Status 301 for RedirectorPage class, to be nice to search engines and improve SEO (with 200 page rank gets split between pages, with 301 its all transferred to the target page)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63181 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 19:50:53 +00:00
Ingo Schommer
86e37a8225 MINOR Added externals for thirdparty JSON library
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63180 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 13:37:48 +00:00
Ingo Schommer
98656631d6 MINOR Moved JSON library to thirdparty externals
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63179 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 13:33:42 +00:00
Ingo Schommer
8c8cde6e75 MINOR Reverted accidental commit to main.php from r63177
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63178 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 13:16:39 +00:00
Ingo Schommer
3f3346fd93 API CHANGE Removed Text->Att(), use Text->ATT_val() instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63177 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 13:14:03 +00:00
Ingo Schommer
e7f3e3487d API CHANGE Deprecated Varchar->Attr(), use Varchar->ATT_val() instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63176 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 13:13:16 +00:00
Ingo Schommer
fabf01d076 ENHANCEMENT Introduced constants for system paths like /sapphire in preparation for a more flexible directory reorganisation. Instead of hardcoding your path, please use the following constants: BASE_PATH, BASE_URL, SAPPHIRE_DIR, SAPPHIRE_PATH, CMS_DIR, CMS_PATH, THIRDPARTY_DIR, THIRDPARTY_PATH, ASSETS_DIR, ASSETS_PATH, THEMES_DIR, THEMES_PATH
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63175 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 13:12:20 +00:00
Ingo Schommer
e2b626434a MINOR Documentation for image uploads
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63174 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 13:08:56 +00:00
Ingo Schommer
0da97be4f9 BUGFIX Reverted Director class using BASE_PATH instead of dirname(dirname(['SCRIPT_FILENAME'])), originally committed in r63154
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63157 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-27 17:02:46 +00:00
Ingo Schommer
c4a47f1def MINOR Reverted accidental disabling of ManifestBuilderTest cleanup code
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63156 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-27 16:55:42 +00:00
Ingo Schommer
b8846a9ab3 MINOR Temporarily disabled RSSFeedTest as its overriding environment variables that should be handled by Director class with Director::setBaseURL() (which is currently not fully working). Added stub-tests for Director.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63155 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-27 16:04:01 +00:00
Ingo Schommer
9371f4688b ENHANCEMENT Introduced constants for system paths like /sapphire in preparation for a more flexible directory reorganisation. Instead of hardcoding your path, please use the following constants: BASE_PATH, BASE_URL, SAPPHIRE_DIR, SAPPHIRE_PATH, CMS_DIR, CMS_PATH, THIRDPARTY_DIR, THIRDPARTY_PATH, ASSETS_DIR, ASSETS_PATH, THEMES_DIR, THEMES_PATH
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63154 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-27 16:02:38 +00:00
Ingo Schommer
12a73455ac ENHANCEMENT Moved procedural bootstrapping code hiding away between function definitions in Core.php to main.php and cli-script.php (TEMP_FOLDER and PR_* constants)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63153 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-27 13:17:58 +00:00
Sean Harvey
ce1f2e2b3a MINOR: Fix phpdoc parsing error
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63127 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-26 04:35:29 +00:00
Sean Harvey
bd6a645857 MINOR: Fix phpdoc parsing error
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63125 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-26 04:26:06 +00:00
Sean Harvey
525e5b14c6 MINOR: Fix phpdoc parsing error
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63122 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-26 04:19:45 +00:00