Commit Graph

1134 Commits

Author SHA1 Message Date
Sam Minnee
1694546870 API CHANGE: Allow fieldList arguments to Form::loadDataFrom() and Form::saveInto(), for situations where the data passed only applies to a segment of the form. (from r90872)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@90963 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:31 +13:00
Sam Minnee
ef5ffe52a1 API CHANGE: Inserting $HiddenFields into a form template will show the input tags of all the hidden fields. (from r90871)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@90962 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:31 +13:00
Sean Harvey
60f237092a BUGFIX #6299 TableListField::Link() includes $action value twice (thanks ajshort!) (from r115379)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@115380 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-01-10 03:46:28 +00:00
Will Rossiter
2ed7c9c1b0 BUGFIX: fixed accessing private variable from Geoip. ENHANCEMENT: added Geoip::get_default_country_code(). Fixes #6315
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@115364 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-01-09 05:55:17 +00:00
Ingo Schommer
e4c586f78e BUGFIX Checking for existence of FormAction in Form->httpSubmission() to avoid bypassing $allowed_actions definitions in controllers containing this form
BUGFIX Checking for $allowed_actions in Form class, through Form->httpSubmission()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@115182 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-20 00:00:38 +00:00
Ingo Schommer
05eca28c96 MINOR Using Convert::raw2xml() in LabelField->Field() (fixes #6267, thanks odraska)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@115125 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-16 08:12:21 +00:00
Will Rossiter
815e9efd94 APICHANGE: removed page comments from core. Please see the github.com account for page comments functionality
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114821 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-11 05:43:08 +00:00
Sean Harvey
ec661a9886 ENHANCEMENT #6228 FieldSet::addFieldsToTab() now allows inserting before a field name for consistency with addFieldToTab()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114817 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-11 02:31:49 +00:00
Will Rossiter
1ca5ea6fb4 FEATURE: added ability to define a default configuration set for date field. PATCH via gigtech. Fixes (#6131).
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114816 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-11 02:26:59 +00:00
Sam Minnee
c24ed58d2d BUGFIX Better checking of file validity (#6093) Thanks Pigeon (from r113419)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114533 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:34:42 +00:00
Sam Minnee
854e0e30b4 ENHANCEMENT Added Form->enableSecurityToken() as a counterpart to the existing disableSecurityToken() (from r113284)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114531 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:30:32 +00:00
Sam Minnee
38601b96f8 BUGFIX Fixed ComplexTableField and TableListField GET actions against CSRF attacks (with Form_SecurityToken->checkRequest()) (from r113276)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114529 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:26:03 +00:00
Sam Minnee
5c0b2182ae API CHANGE Added security token to TableListField->Link() in order to include it in all URL actions automatically. This ensures that field actions bypassing Form->httpSubmission() still get CSRF protection (from r113275)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114528 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:24:58 +00:00
Sam Minnee
9ec31acacb ENHANCEMENT Added SecurityToken to wrap CSRF protection via "SecurityID" request parameter (from r113272)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114525 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:22:57 +00:00
Sam Minnee
662f581b24 BUGFIX Fixed month conversion in DateField_View_JQuery::convert_iso_to_jquery_format() (fixes #6124, thanks mbren and natmchugh) (from r113247)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114523 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:20:13 +00:00
Sam Minnee
75c6c4941c BUGFIX: Use correct language code for jquery-ui date picker for en_US (from r113107)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114520 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:17:16 +00:00
Ingo Schommer
8b220b923a ENHANCEMENT Using RandomGenerator in Form->getExtraFields() "SecurityID" token creation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114498 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 00:18:48 +00:00
Ingo Schommer
eeed9ce189 BUGFIX Don't call LinkTracking/ImageTracking relationships in HTMLEditorField->saveInto() unless we have internal links/files to save. This helps to improve CMS saving times on records with many HTMLEditorField instances
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114139 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:51 +00:00
Ingo Schommer
3ffa3bfe42 ENHANCEMENT: user-friendly error now present for unwanted upload file types
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114132 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:47 +00:00
Ingo Schommer
7700b223a3 MINOR Documentation for MoneyField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113691 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-13 02:05:34 +00:00
Carlos Barberis
bf8afd6cac MINOR: call jquery-ui from thirdparty folder instead google api (see ticket 5915)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113656 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-11 04:45:31 +00:00
Sam Minnee
b40544e694 BUGFIX #6066 Form::__construct() should respect hasMethod on passed in Controller instance if it's available (thanks paradigmincarnate!) (from r111890)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112940 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:04:58 +00:00
Sam Minnee
89c3349a1c BUGFIX More common defaults for en_US.xml used by Zend_DateFormat (and DateField/DatetimeField), with less error prone numerical format replacing the Zend default of shortened month names (fixes #6071, thanks dalesaurus)
BUGFIX Correct locale mapping in DateField_View_JQuery for "en_US" and "en_NZ"
MINOR Fixed form validation message in DateField to include actual date format, rather than a hardcoded value (from r111843)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112928 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:01:18 +00:00
Sam Minnee
9bed2ca4f3 BUGFIX RFC 2822 compliant validation of email adresses in EmailField->jsValidation() and EmailField->validate() (fixes #6067, thanks paradigmincarnate) (from r111841)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112925 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:57:52 +00:00
Sam Minnee
3388642d6b MINOR Fixed documentation in CheckboxSetField (fixes #6068, thanks paradigmincarnate) (from r111788)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112922 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:53:24 +00:00
Sam Minnee
29515b2e01 BUGFIX Removing overloaded TableField->sourceItems() method, which enables features of the underlying TableListField implementation, such as pagination and source item caching (fixed #5965, thanks martijn) (from r111492)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112907 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:56:23 +00:00
Sam Minnee
cdb04f79de BUGFIX Fixed quoting and GROUP BY statement in ManyManyComplexTableField->getQuery() for Postgres compatibility (from r111202)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112900 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:48:57 +00:00
Sam Minnee
31d442f5da BUGFIX Respecting field specific locale settings in DatetimeField and DateField when validating and saving values (fixes #5931, thanks Tjofras) (from r110889)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112864 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:01:03 +00:00
Sam Minnee
2d82ae6217 BUGFIX Enforcing canEdit() checks in ComplexTableField_Popup - making form readonly if the current user can't edit (from r110857)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112863 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:00:45 +00:00
Sam Minnee
2c60a67e09 BUGFIX Case insensitive DateField value navigation (fixes #5990, thanks gw0( (from r110838)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112851 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:40:21 +00:00
Sam Minnee
3c6512ab1a MINOR Check in TableListField->HighlightClasses() (fixes #5993, thanks lx) (from r110837)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112850 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:36:39 +00:00
Sam Minnee
9d4d7301a2 BUGFIX Passing $name in MoneyField->FieldCurrency() (fixes #5982, thanks andersw) (from r110835)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112848 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:34:31 +00:00
Sam Minnee
61bb2fe4a4 BUGFIX Removing "typography" class from HTMLEditorField container (should just apply to the contained <iframe>) (fixes #5949) (from r110809)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112847 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:33:28 +00:00
Sam Minnee
1b95077fed BUGFIX Allowing $extraClass on CheckboxField FieldHolder (fixes #5939, thanks mobiusnz) (from r110808)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112846 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:33:08 +00:00
Sam Minnee
6fa348a2cb BUGFIX Fixed boundary PHP notice case in RequiredFields::php() where a field name may not be defined in the $data array when a Form is submitted (from r110463)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112842 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:31:30 +00:00
Sam Minnee
12dd5b08e8 BUGFIX Fixed missing "Save" action input label on ComplexTableField popup form (from r110165)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112833 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:27:35 +00:00
Sam Minnee
e92a2da304 BUGFIX: $val is now cast as an int to prevent strings always returning true (YES) (from r109168)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112820 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:21:45 +00:00
Sam Minnee
a7d0b685ec BUGFIX: Validator::requiredField() should check the required field submitted value is an array before check strlen(). Some fields submitted as an array, e.g. MoneyField (from r109155)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112816 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:20:38 +00:00
Sam Minnee
b8ee6f6af5 BUGFIX Added specific border case for array form data in RequiredFields::php() (from r108811)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112767 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:51:18 +00:00
Sam Minnee
8ced8772aa BUGFIX: Fixed validation to accept arrays (FileField case) (from r108792)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112766 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:50:59 +00:00
Sam Minnee
4b1f71d67b BUGFIX NumericField javascript does not accept negatives, make use of isNaN built-in javascript function instead of custom regex (from r108633)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112760 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:47:43 +00:00
Sam Minnee
c0e2017cfc BUGFIX Validator/RequiredFields should not regard "0" as an empty value (from r108512)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112756 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:43:38 +00:00
Sam Minnee
43c0e432ed BUGFIX CurrencyField doesn't accept negative value (#5769, thanks simon_w) (from r108422)
BUGFIX: Take note of output format when building Location header for RestfulServer (from r108427)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112744 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:32:18 +00:00
Sam Minnee
ce06d13fd6 MINOR Cross-referencing some documentation (from r108375)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112721 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:50:48 +00:00
Sam Minnee
b90e3a680c BUGFIX: the autoselection on linking sidebar for downloads did not work properly: the item would not be selected when the user clicked a link in the editor. Only numeric IDs were permitted, but the TreeDropdownField now supports other columns as IDs too, so enabled that for autoselection.
BUGFIX: asset search would fail - typo in request var and the sql query had unnecessarily escaped quotes (from r108351)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112720 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:50:30 +00:00
Sam Minnee
ea50868156 BUGFIX Added a clearing div after the date and time fields, not the best way of doing it but the only way as the overflow css trick for clearing fields doesn't work with the time dropdown (from r107811)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112698 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:26:13 +00:00
Sam Minnee
30efd55852 ENHANCEMENT Added class to time icon in TimeField so it can be styled (from r107810)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112697 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:25:59 +00:00
Sam Minnee
c5f4926d4d BUGFIX Fixed DateField->validate() with keyed, but empty array values
MINOR Fixed DateField/TimeField validation message translation (wrong sprintf() nesting) (from r107789)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112696 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:25:41 +00:00
Sam Minnee
61012967cf MINOR Fixed TimeField validation _t() entity name (from r107787)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112695 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:25:17 +00:00
Sam Minnee
171fdd6050 BUGFIX Using actual date format settings in DateField/TimeField->validate() messages (from r107786)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112694 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:23:40 +00:00
Sam Minnee
40bc9ced5d BUGFIX Limit 'showcalendar' javascript option to DateField instances (rather than applying to all available) (from r107785)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112693 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:22:56 +00:00
Ingo Schommer
a0dd4ff8f0 MINOR Moved class-specific documentation from doc.silverstripe.org back into class-level PHPDoc (from r107725)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:55:22 +00:00
Ingo Schommer
e07d56096d BUGFIX Allowing DatetimeField->saveInto() to save a partial array notation with missing 'time' value (from r107441)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112599 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:51:21 +00:00
Ingo Schommer
52bd0cc4bb API CHANGE Using FieldHolder() instead of Field() for subfields in DatetimeField->FieldHolder(), in order to get configuraton settings for javascript DateField (from r107439)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112598 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:49:06 +00:00
Ingo Schommer
d67c43ad7d ENHANCEMENT Using jQuery UI datepicker in DateField and DatetimeField instead of outdated DHTML calendar.js (fixes #5397)
ENHANCEMENT Abstracted optional DateField->setConfig('showcalendar') logic to DateField_View_JQuery (from r107438)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112597 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:48:39 +00:00
Ingo Schommer
80eab2a24c BUGFIX: Reverted 107414, wrong patch (from r107417)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112589 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:43:47 +00:00
Ingo Schommer
3b500bb137 BUGFIX: TableListField headings i18n translation (ticket #5742) (from r107414)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112576 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:26:45 +00:00
Ingo Schommer
6351b16ab9 BUGFIX Added Locale hidden field to HTMLEditorField->LinkForm() in order to show correct context in "page on the site" dropdown (fixes #5743) (from r107390)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112573 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:25:51 +00:00
Ingo Schommer
47762cdf5b ENHANCEMENT #5352 Decouple date display from i18n locales, users now have access to change their date and time formats in Member::getCMSFields() using Member_DatetimeOptionsetField field (from r107326)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:23:02 +00:00
Ingo Schommer
efebfe5993 ENHANCEMENT: added setDisabled() to set DropdownField::$disabled (from r107086)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112546 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:08:09 +00:00
Ingo Schommer
a848a182a7 API CHANGE Deprecated AutocompleteTextField, use third-party solutions (from r107054)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112545 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:07:54 +00:00
Ingo Schommer
a1f9efc414 BUGFIX Stricter checking that a relation exists on ComplexTableField::saveComplexTableField() (from r106755)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112536 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:03:54 +00:00
Ingo Schommer
ceb27c4a41 BUGFIX Fixed ImageField->EditFileForm() to list subclasses of Image in tree dropdown (fixes #5708, thanks keeny) (from r106671)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112533 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:02:17 +00:00
Ingo Schommer
4d665ce268 BUGFIX Prevent DateField->performReadonlyTransformation() from segfaulting on PHP 5.2 due to broken __toString() casting (fixes #5713, thanks charden) (from r106666)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112532 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:01:58 +00:00
Ingo Schommer
48cea784f6 MINOR: Provide a default message for FIELDISREQUIRED (from r106568)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112531 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:01:42 +00:00
Ingo Schommer
2d2ca13e45 ENHANCEMENT: added setRows() and setColumns() to customize the size of the textarea field outside of the controller (from r106118)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112518 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:56:36 +00:00
Ingo Schommer
db460ed57f MINOR Better error handling in Form::__construct() (fixes #5649) (from r105912)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112511 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:54:02 +00:00
Ingo Schommer
ca02b91673 BUGFIX: TableListField_Item::SelectOptionClasses() can not use it parent protected variable. (from r105876)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112506 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:52:05 +00:00
Ingo Schommer
8a2576ee3e BUGFIX: rollback r105858 which introducesa bug (from r105875)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112505 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:51:48 +00:00
Ingo Schommer
91700a3dac BUGFIX: updated select options classes to work with the dataobjectset returned by selectoptions rather than the array previously (from r105872)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112504 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:51:33 +00:00
Ingo Schommer
092a3c1c26 BUGFIX: TableListField_Item::SelectOptionClasses() can use it parent protected variable. (from r105858)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112503 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:51:04 +00:00
Ingo Schommer
4c2ff4bd0a APICHANGE: refactored methods in session to use coding conventions (from r105756)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112502 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:50:43 +00:00
Ingo Schommer
12fa850986 ENHANCEMENT: Preserve sort options in pagination links in TableListField (from r105275)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112475 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:29:44 +00:00
Ingo Schommer
68fcd8c94f MINOR Reverted r105264, breaks CompositeFieldTest, FieldSetTest, TranslatableTest (from r105274)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112474 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:28:12 +00:00
Ingo Schommer
bcbe9c254d ENHANCEMENT Allowing batch checkbox selection of TableListField rows with TableListField->Markable and TableListField->addSelectOptions() (from r105266)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112473 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:27:59 +00:00
Ingo Schommer
de0bf3f7cd BUGFIX: addFieldToTab segfaulting under PHP 5.2 (from r105264)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112445 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:29:18 +00:00
Ingo Schommer
93cd3ae55d BUGFIX: force dateformat to en_NZ if showcalendar is enabled as calendar is compatibile with en_NZ only (from r105225)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112444 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:29:02 +00:00
Ingo Schommer
a191019e7a MINOR Documentation (from r104404)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112345 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 00:04:14 +00:00
Ingo Schommer
c969e04731 MINOR Removed unnecessary $timeformat parameter from TimeField::__construct, and getting the default from Zend_Locale_Format in the same way that DateField behaves (unreleased API, so no api change).
MINOR Automatically choosing $locale in TimeField::__construct, to be consistent with DateField (from r103975)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112328 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-14 23:53:13 +00:00
Ingo Schommer
d2c096119c BUGFIX Fixed double pragma after referer redirection on forms with Form->httpSubmission() (fixes #5509, thanks ktauber) (from r103936)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112325 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-14 23:51:55 +00:00
Sam Minnee
077a119cfb MINOR Database quoting in TreeDropdownField (fixes #5484) (from r103515)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112146 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 03:56:48 +00:00
Sam Minnee
da671c628d BUGFIX Fixed CurrencyField->jsValidation() regex escaping (fixes #5462, thanks mobiusnz) (from r103451)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112143 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 03:53:52 +00:00
Sam Minnee
a2f6487fa3 BUGFIX DateField with setConfig('dmyfields') now validates TRUE for empty values (fixes #5458) (from r103450)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112140 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 03:52:36 +00:00
Sam Minnee
961d4ce298 BUGFIX: added optional separator for http_build_query in HTTP:setGetVar(). this fixes sorting columns in ModelAdmin (ticket #5325). (from r103012)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112071 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:48:24 +00:00
Sam Minnee
19f4c1ef89 BUGFIX #5320 ManyManyComplexTableField::getQuery() now uses T-SQL compatible syntax CASE WHEN instead of IF THEN which works in multiple databases as well (from r102436)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112066 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:42:01 +00:00
Sam Minnee
3ac1580aae BUGFIX: Explicitly specify the many_many's join table name in the join's ON match statement in ManyManyComplexTableField (from r101608)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112008 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 00:51:33 +00:00
Sam Minnee
e09cc66e94 BUGFIX: Fixed issues with broekn link tracking (from r101138)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111960 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:42:25 +00:00
Sam Minnee
a96cb319d3 BUGFIX Fixed TableListField->print() - was unsetting $cachedSourceItems instead of null'ing it, which breaks later access to the property (from r101080)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111583 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:44:58 +00:00
Sam Minnee
5b6fa898d5 BUGFIX: column and table names now quoted properly (from r100998)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111564 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:30:39 +00:00
Sam Minnee
c54cce8673 BUGFIX Disable javascript date validation via DateField->jsValidation() if locale is not 'en_NZ" (which is the only format it validates for). (from r100986)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111558 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:29:13 +00:00
Sam Minnee
5f0fcc58ec BUGFIX HTMLEditorField->saveInto() can now find images with urlencoded information for resample (e.g. spaces in filenames) (from r100985)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111557 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:29:00 +00:00
Sam Minnee
30037f269c MINOR Updated r100966 to include spaces on ternary operator for readability and coding conventions (from r100975)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:27:34 +00:00
Sam Minnee
67db4ce22a FEATURE: MoneyField currency dropdown can be made from an associate array like array('NZD'=>'New Zealand Dollor', 'USD'=>"United States Dollor') as well (from r100966)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111550 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:27:09 +00:00
Sam Minnee
29623a639d MINOR: Correction on email address validator, and a unit test for EmailField php validation (from r100950)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111548 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:26:12 +00:00
Sam Minnee
ae66792c33 MINOR Added jQuery requirement to TreeDropdownField (see #5139) (from r100946)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111547 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:25:17 +00:00
Sam Minnee
e55102ef29 MINOR Using jquery.live instead of livequery on ImageFormAction.js (from r100886)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111534 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:14:55 +00:00
Andreas Piening
4d7429a393 BUGFIX: Added single quote as a valid local-part of an email address as per RFC5322. Other symbols still excluded although in the spec (from r100825)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@108806 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-08-03 01:07:18 +00:00
Andreas Piening
983fb1fc09 BUGFIX #5157 strftime() %F format parameter does not work on Windows - use %Y-%m-%d instead (from r100795)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@108762 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-08-02 01:00:44 +00:00
Ingo Schommer
af0f93c109 MINOR Removed <input name="MAX_FILE_SIZE"> from FileField and SimpleImageField, as it's a meaningless clientside setting thats not respected by any browser, nor part of any HTML spec (see http://bugs.php.net/bug.php?id=40387)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105913 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-30 22:36:24 +00:00
Ingo Schommer
1d80d77270 MINOR Fixed regression from r100774 (from r100775)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105650 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 05:01:46 +00:00
Ingo Schommer
e78dc5273d ENHANCEMENT Allowing custom popup requirements in ComplexTableField without subclassing through $requirementsForPopupCallback
MINOR Added getParentController() to TableListField_ItemRequest and ComplexTableField_Popup
MINOR Extending ComplexTableField_ItemRequest from TableListField_ItemRequest to avoid redundant code (from r100774)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105649 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 05:00:25 +00:00
Ingo Schommer
c81a788ba7 ENHANCEMENT Added 'updateImageForm', 'updateFlashForm', 'updateLinkForm' hooks to HtmlEditorField (the imageform hook was necessary to make the 'pixlr' module work) (see #3938) (from r100753)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105642 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:56:02 +00:00
Ingo Schommer
c8ac8a274d BUGFIX #5099 FileIFrameField fails when using it with a locale different to the default (from r100747)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105634 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:26:47 +00:00
Ingo Schommer
4e87fb5713 BUGFIX get TreeMultiselectField working with an array of items, rather than a relation. (from r100525)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:14:51 +00:00
Ingo Schommer
5a38c65156 API CHANGE TreeDropdownField no longer requires your object to have the Hierarchy extension (from r100512)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105589 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:13:05 +00:00
Ingo Schommer
9d9c0b31e9 BUGFIX: wrong constructor function name (from r100508)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105585 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:12:06 +00:00
Ingo Schommer
ecb6c8cb3f BUGFIX: replacing calls to deprecated Upload functions - using validator instead (related to r100057) (from r100496)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:03:46 +00:00
Ingo Schommer
45d8433d57 MINOR Pushed @deprecated 2.3 items out to 2.5 since they're still in use for now (from r100486)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105574 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:54:48 +00:00
Ingo Schommer
28f80b8da5 BUGFIX #5121 Fixed cache flushing for FieldSet when removing fields - thanks paradigmincarnate! (from r100417)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105564 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:51:35 +00:00
Ingo Schommer
00d19cc3d1 BUGFIX: FormAction input tag attributes were being doubly-escaped. (from r100407)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105561 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:50:37 +00:00
Ingo Schommer
e6dac14e9a BUGFIX #5087: Show default values in CTF 'add' popups. (from r99777)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105527 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 02:59:14 +00:00
Ingo Schommer
6460d09570 MINOR Fixed phpdoc documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@103385 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-23 00:11:41 +00:00
Ingo Schommer
fed0d1fe4b BUGFIX Fixed variable existence checks in setValue() in FormField::__construct() by checking for !== NULL (changed from isset($value) to $value in r99360) (from r99394)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102862 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:40:04 +00:00
Ingo Schommer
568f0d34bc BUGFIX Fixed MoneyField constructor - parent (FormField) constructor calls setValue() already, which needs to happen *after* setting certain field instances (from r99391)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102861 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:39:51 +00:00
Ingo Schommer
498c075ece ENHANCEMENT Allow locale/dateformat specific reordering of day, month, year input fields in DateField (from r99361)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102860 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:39:36 +00:00
Ingo Schommer
6227478f82 FEATURE New DatetimeField class (form field wrapper composed of DateField andTimeField)
FEATURE New DateField and TimeField form classes with more consistent API and easier localization
API CHANGE Date/time parsing in DateField, TimeField and DatetimeField defaults to i18n::get_locale() ('en_US') instead of using en_NZ/en_GB specific parsing. Use i18n::set_locale('en_NZ') in mysite/_config.php to revert to old behaviour.
API CHANGE  constructor parameter in TimeField needs to be in ISO date notation (not PHP's date())
API CHANGE TimeField, DateField and related subclasses use Zend_Date for date parsing, meaning they're stricer than the previously used strtotime()
API CHANGE Removed DMYCalendarDateField and CalendarDateField, use DateField with setConfig('showcalendar')
API CHANGE Removed CompositeDateField, DMYDateField, use DateField with setConfig('dmyfields')
API CHANGE Removed DropdownTimeField, use TimeField with setConfig('showdropdown')
API CHANGE Removed PopupDateTimeField, use DatetimeField
API CHANGE Changed 'date', 'month' and 'year' HTML field names to lowercase in DMYDateField
API CHANGE Removed support for ambiguous date formats in DateField, e.g. '06/03/03'. Use DateField->setConfig('dateformat', '<format>') to revert to this behaviour.
API CHANGE Removed  flag from DateField, CalendarDateField etc., use DateField->setConfig('min') and DateField->setConfig('max')
ENHANCEMENT Using Zend_Date for DateField and TimeField, with more robust date handling, starting localization support. Set globally via i18n::set_locale(), or for a field instance through setLocale(). Note: Javascript validation is not localized yet. (from r99360)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102859 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:38:40 +00:00
Ingo Schommer
deb038ad2f BUGFIX: fallback for changes in r98101, required if TreeDropdownField is used in a widgetarea, and does not know its field (from r98671)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102777 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:22:37 +00:00
Ingo Schommer
dd7273b27a MINOR Removed useless third argument to instantiation of itemClass in TableListField::generateExportFileData() (from r98544)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102768 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:20:28 +00:00
Ingo Schommer
c652311ce9 API CHANGE Made ComplexTableField not use Object::create() for item and popup classes to be consistent with TableListField. These can be overridden as itemClass and popupClass are public properties on ComplexTableField (from r98543)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102767 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:20:13 +00:00
Ingo Schommer
68ae667748 BUGFIX: Removed obsolete start argument from ComplexTableField_Item constructor. (from r98536)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102764 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:18:52 +00:00
Ingo Schommer
bfb10b849f BUGFIX Fixed missing third argument to ComplexTableField_Item when the parent class instantiates it (from r98448)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102759 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:16:07 +00:00
Ingo Schommer
8256228e69 MINOR Upgraded jQuery.entwine (formerly known as jQuery.concrete) to the latest trunk
MINOR Updated jQuery.concrete references to point to the new "entwine" name

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102695 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 05:45:29 +00:00
Ingo Schommer
b3e30ac819 MINOR set Print flag correctly on TLF
MINOR custom print template for SSReport TLF's that exposes the report title, and filters set (from r97138) (from r98154)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102621 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:26:52 +00:00
Ingo Schommer
eba6c9b492 MINOR: Fixed TableListField tests that don't set $_REQUEST['url'] (from r97127) (from r98153)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102620 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:26:38 +00:00
Ingo Schommer
19f566675b BUGFIX pagination was being applied (with a limit of NULL) to print and export actions. This was due to $_REQUEST['methodname'] not existing. (from r97114) (from r98152)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102619 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:26:27 +00:00
Ingo Schommer
64da35bca5 BUGFIX TreeMultiselectField_Readonly now posts the correct value to the server (from r97100) (from r98150)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102618 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:25:45 +00:00
Ingo Schommer
10537d5133 MINOR move sort column&direction into their own vars, otherwise, canSortBy(Date DESC) will always return false, since DESC is not part of the column name. (from r96411) (from r98137)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102609 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:16:34 +00:00
Ingo Schommer
be4c42f9d0 BUGFIX still use the correct methods to get a value, even if we're generating a CSV ($xmlSafe = false) (from r96212) (from r98136)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:16:21 +00:00
Ingo Schommer
4f461e4b99 MINOR fix field escaping in CSV export of TableListField (from r96157) (from r98135)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102607 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:16:08 +00:00
Ingo Schommer
f60c080337 BUGFIX: Don't default to sorted descending if you already have a different column sorted ascending. (from r96061) (from r98134)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102606 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:15:50 +00:00
Ingo Schommer
d743cdef78 BUGFIX: Make TableListField sort checking use SQLQuery::canSortBy() to let SSReprot_FakeQuery work.
ENHANCEMENT: Allow sort descending as well as ascending. (from r96054) (from r98132)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102604 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:15:23 +00:00
Ingo Schommer
21299ba686 ENHANCEMENT Allow user theme selection through SiteConfig, falling back to SSViewer::set_theme() as a default if there are none selected
MINOR Unit tests for SSViewer::current_theme() and SiteConfig::getAvailableThemes() (from r98110)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102597 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:13:12 +00:00
Ingo Schommer
4a2d71ae2a BUGFIX: Allow creation of TreeDropdownFields on forms with querystring URLs.
API CHANGE: Allow passing of an explicit map of dropdown items to a TreeDropdownField.
BUGFIX: Make use of the $this->value setting of TreeMultiselectFields. (from r95910) (from r98101)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:09:32 +00:00
Ingo Schommer
453faed88a API CHANGE: Refactored test for whether a SQLQuery can be sorted by a particular column into SQLQuery::canSortBy($fieldName) (from r95850) (from r98096)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102588 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:06:12 +00:00
Ingo Schommer
a78ffb7532 BUGFIX: Let FieldMap access non-data fields too (from r95825) (from r98095)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102587 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:57 +00:00
Ingo Schommer
da778dd2a9 BUGFIX: Make TableListField rely on SQLQuery for its count-generation.
BUGFIX: Make SQLQuery return an appropriate count if a HAVING clause is used. (from r95814) (from r98094)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102586 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:45 +00:00
Ingo Schommer
6848684334 MINOR: Initialise variables to fix unit test (from r95754) (from r98092)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102584 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:07 +00:00
Ingo Schommer
8ec4c25be7 MINOR: Don't try and access the ORM from ComplexTableField in situations where it shouldn't. (from r95544) (from r98089)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:01:59 +00:00
Ingo Schommer
fa5af56384 MINOR: Boundary condition check in TableListField for more helpful errors. (from r95543) (from r98088)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102580 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:01:39 +00:00
Ingo Schommer
5ba037cc04 BUGFIX: reintroducing the forceValue url param, so the TreeDropdownField value can be set via JS (previously if the item was deep within the tree structure it would not be selected) (from r98083)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102576 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:55:24 +00:00
Ingo Schommer
d4d3d63e99 BUGFIX: FileIFrameField throws sub-URLs error when changing cms to a non default language (#4767) (from r97984)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102562 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:46:39 +00:00
Ingo Schommer
c24c9c89a2 BUGFIX: File don't have method URL(), instead, we use $image->URL, which will call $image->getURL() (from r97783)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102532 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:38:37 +00:00
Ingo Schommer
73ba193ad6 ENHANCEMENT: Select the uploaded image after uploading by default. #4962 (from r97765)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102531 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:36:50 +00:00
Ingo Schommer
d294c0f755 BUGFIX: add custom search function, so the search catches also the Titles (search uses DataObject::get, which bypasses the getMenuTitle function) (from r97755)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102530 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:34:08 +00:00
Ingo Schommer
6994e715ca MINOR If CurrencyField->setValue() passed a null or empty value, default to 0.00 so number_format() has no issues converting the number (from r97566)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102509 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:59:55 +00:00
Ingo Schommer
7654557068 APICHANGE: removed SWFUpload. Refactored Content Editors uploader to use standard uploader. (from r97489)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102505 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:54:41 +00:00
Ingo Schommer
08b00bd5f4 MINOR Fixed setForm() invocation in Form::__construct() (see #4558, thanks ajshort) (from r97483)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102498 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:19:38 +00:00
Ingo Schommer
051878c6a4 BUGFIX Fixed NumericField->jsValidation(), now accepts negative numbers, making it more like the equivalent phpValidation(), which is using is_numeric() (see #4874, thanks Allisone) (from r97482)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102497 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:19:19 +00:00
Ingo Schommer
792deb3bad MINOR Use addExtraClass() in FormField::__construct() instead of direct assignment (see #4607, thanks Tjofras) (from r97481)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102496 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:19:01 +00:00
Ingo Schommer
fc77fb97f3 API CHANGE Moved GSTNumberField from sapphire/forms to new 'formfields_nz' module (from r97475)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102491 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:11:38 +00:00
Ingo Schommer
a46b205b0b API CHANGE Moved BankAccountField from sapphire/forms to new 'formfields_nz' module (from r97474)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102490 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:10:47 +00:00
Ingo Schommer
d2e310a773 BUGFIX: getByKey replaced with objectForKey (from r97307)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102442 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 05:01:09 +00:00
Ingo Schommer
a36f4bdac7 MINOR: added comments (from r97072)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102430 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:36:56 +00:00
Ingo Schommer
3385ec012f FEATURE: upgrading the search functionality of the TreeDropdownTree with pluggable search function
BUGFIX: the search was only operating on the part of the tree (as returned by markPartialTree), now it searches globally
MINOR: renamed 'filter' to 'search' (from r97031)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102424 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:33:56 +00:00
Ingo Schommer
2179389da3 BUGFIX: removed name attribute from label fields since this is invalid html. Ticket: #4887. PATCH via tobych (from r97013)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102418 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:31:02 +00:00
Ingo Schommer
227bfffc0b ENHANCEMENT: Added TabIndex to FormActions. Ticket: #4905. PATCH: via keeny (from r97011)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102417 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:30:41 +00:00
Ingo Schommer
745a724b9e MINOR Ensure DropdownField option elements have escaped the title correctly (from r96882)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102412 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:28:40 +00:00
Ingo Schommer
c077c77c25 BUGFIX: Use Controller::join_links() for all TableListField and ComplexTableField link building, to support form URLs with querystrings.
BUGFIX: If ComplexTableField::getParentRecord() can't find a record, just return null rather than erroring. (from r96555) (from r96649) (from r96775)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102407 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:27:03 +00:00
Ingo Schommer
89176afbc4 BUGFIX: Removed XSS holes (from r94823) (from r96773)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102402 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:21:00 +00:00
Ingo Schommer
7eb4e8ef83 BUGFIX: Fixed readonly form of TreeDropdownField when field is made readonly before value is set (from r94608) (from r96765)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102394 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:17:09 +00:00
Ingo Schommer
5bcfbe6622 BUGFIX: Allow opening of the detail pop-ups of a record on a ComplexTableField attached to a deleted page. (from r94593) (from r96762)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102393 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:16:54 +00:00
Ingo Schommer
1192b9ef2c BUGFIX: Resized images which return null or false are now ignored (from r96754)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102383 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:45:35 +00:00
Ingo Schommer
21a6cf52cc BUGFIX: Fixed reloading of TableFields after ajax save. (http://mingle.silverstripe.com/projects/air_nz_cms_enhancements/cards/154) (from r88921) (from r96427)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102327 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:35:47 +00:00
Ingo Schommer
155cce25e5 BUGFIX: Readonly TreeMultiSelectField has form linked properly (from r96362)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102325 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:35:17 +00:00
Ingo Schommer
ddbc3e96b3 MINOR Fixed OptionsetField->disabledItems omission from r99596
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@99708 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-23 04:48:56 +00:00
Ingo Schommer
41c04fe61b MINOR Making parameter optional for ComplexTableField_Item
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@99683 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-23 03:26:57 +00:00
Ingo Schommer
93895a4f0f ENHANCEMENT Added OptionsetField->setDisabledItems() to allow specifically disabling certain checkboxes
ENHANCEMENT Added CheckboxSetField->setDefaultItems() to tick specified checkboxes regardless of the value passed

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@99596 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-22 06:11:58 +00:00
Ingo Schommer
fcfccf6231 BUGFIX Fixed TreeMultiselectField/TreeDropdownField saving with 'unchanged' default values from constructor
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@99581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-22 04:37:33 +00:00
Ingo Schommer
e26158c522 BUGFIX Fixed TreeMultiselectField->Field() to respect settings, and give them priority over existing relations through getItems(). This is used in MemberTableField to set default groups for 'add member' popups.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@98879 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-12 04:01:41 +00:00
Ingo Schommer
13d744eeb3 BUGFIX Added missing Requirements to TreeDropdownField->Field() and TreeMultiSelect->Field() (merged and modified from r98852)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@98861 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-12 02:39:07 +00:00
Ingo Schommer
c3e213b690 ENHANCEMENT Allow overriding TableListField_Item on TableListField by setting the property itemClass (merged from r98428)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@98774 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-11 04:21:04 +00:00
Tom Rix
6f9177ef43 MINOR fixed validation on CurrencyField. Will no longer parse non-numeric characters out of input. Added test coverage.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@97057 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-01-18 00:56:29 +00:00
Sean Harvey
48211b4931 BUGFIX: pass $allowHTML through to the parent class (from r95339)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95636 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:49:28 +00:00
Sean Harvey
0d1f39ff88 BUGFIX: Fix fatal error when exporting a csv from a tablefield with a custom query (from r95108)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95634 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:49:14 +00:00
Sean Harvey
b52e49dee7 BUGFIX ComplexTableField - fixed sprintf() not enough arguments when the referrer has a % character in it, the referrer is now an argument instead of being hardcoded in the string (from r95093)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95633 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:48:06 +00:00
Sean Harvey
f663e4f949 BUGFIX: Fix fileiframefields dying when an image is attached and a folder is expanded via ajax (from r94461)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95617 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:42:15 +00:00
Sean Harvey
99c4609806 MINOR Fixed misspelled acronym for "Cross-site request forgery" (from r94420)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:40:46 +00:00
Sean Harvey
e615db96d7 BUGFIX: Don't throw a notice-level error if you access a setting that hasn't been set yet. (from r94349)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95598 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:38:56 +00:00
Sean Harvey
1548eab100 BUGFIX: convert ImageFormAction form prototype syntax to jQuery syntax, merged from r94304 (from r94332)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95596 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:38:28 +00:00
Sean Harvey
f7dfa4d2bc BUGFIX Fixed undefined calls to URL() in SimpleImageField, replacing them with getURL() instead (from r94301)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:37:58 +00:00
Sean Harvey
1588da54d8 ENHANCEMENT Added support for loading external plugins (with relative paths) in HtmlEditorConfig. This means relative paths can be separate from the plugin name, and fixes a bug where paths containing dashes were ignored by TinyMCE.init().
ENHANCEMENT Changed sapphire/thirdparty/tinymce-advcode to use the original plugin name, and specify its relative path through HtmlEditorConfig instead. (from r94060)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95582 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-16 05:30:46 +00:00
Andrew Short
bc80c1eff3 MINOR: Made ComplexTableField sub-forms testable by returning rather than echoing results.
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95035 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-13 05:22:33 +00:00
Andrew Short
1b66ce5a86 MINOR: Allow a validation error to be thrown when a DataObject is saved in ComplexTableField.
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95034 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-13 05:22:32 +00:00
Andrew Short
d5e2db7f5e BUGFIX: Included jQuery in SelectionGroup->FieldHolder(), and used new jQuery.live syntax.
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95033 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-13 05:22:31 +00:00
Ingo Schommer
3216c96a69 MINOR: reverted r93693 due to the field being required for the CMS (from r93701)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@93938 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-30 00:43:39 +00:00
Ingo Schommer
1345dd3e62 API CHANGE: removed deprecated RestrictedText fields (from r93693)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@93937 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-30 00:43:11 +00:00
Mark Stephens
69818fad17 ENHANCEMENT: Change to TreeDropdownField, giving it filtering behaviour as described in ticket http://open.silverstripe.org/ticket/3007 . Its disabled by default for legacy compatibility, but enabled for HtmlEditorField so that link editor is filterable for local links, via an extra boolean parameter on TreeDowndownField.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@93932 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-29 23:29:31 +00:00
Ingo Schommer
f3db094874 BUGFIX Escaping sprintf() arguments in ComplexTableField to avoid extraneous % characters in a referrer URL messing up the sprintf() invocation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@93745 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-27 01:22:21 +00:00
Will Rossiter
8855814b5a API CHANGE: removed deprecated ajax_render() method from CTF
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@93679 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-26 22:38:44 +00:00
Will Rossiter
bbb3378f28 API CHANGE: removed ConfirmedFormAction
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@93674 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-26 22:33:16 +00:00
Will Rossiter
05832a1dee API CHANGE: removed deprecated removeByFilter() function
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@93670 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-26 22:18:59 +00:00
Ingo Schommer
fba5841d9d MINOR Updated SWFUpload library to 2.5.0 alpha (see r91302)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92573 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:33:59 +00:00
Ingo Schommer
78ec0cbfa7 MINOR Updated jquery-concrete
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92558 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:33:12 +00:00
Ingo Schommer
dca8c0cb6f merging
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92557 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:33:06 +00:00
Ingo Schommer
926834db27 MINOR Removed redundant jquery-ui.js dependency from TabSet.php and Security.php
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92550 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:32:27 +00:00
Ingo Schommer
76d2886a70 MINOR Moved tiny_mce_imrpovements.js from jsparty/ to sapphire/javascript
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92547 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:32:16 +00:00
Ingo Schommer
4b1293771d MINOR Using jquery.concrete and jquery.selector on github through piston dependency management
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92542 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:31:55 +00:00
Ingo Schommer
d95f867945 ENHANCEMENT Triggering jQuery events in TreeSelectorField.js in preparation to switching the tree logic to jQuery. This prevents developers from using the soon-to-be-deprecated Observable prototype
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92541 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:31:47 +00:00
Ingo Schommer
28109df438 ENHANCEMENT Removed UniqueField.js dependency to CMS-related statusMessage() javascript class, and using jQuery even triggers instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92540 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:31:44 +00:00
Ingo Schommer
50dd9f3159 BUGFIX Adjusted PopupCalendarDateField->Field() to changed underlying CalendarDateField API: Generating the HTML markup without calling parent
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92533 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:31:23 +00:00
Ingo Schommer
beb4efef09 ENHANCEMENT Disabling form validation for right-panel forms in CMS in HtmlEditorField. None of the fields have validation attached to them at the moment, so the generic validation output is unnecessary bloat.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92528 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:31:11 +00:00
Ingo Schommer
1b138d6916 MINOR Removed layout_helpers.js dependency
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92516 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:30:42 +00:00
Ingo Schommer
b1baa84efb ENHANCEMENT Using jQuery UI datepicker in CalendarDateField
API CHANGE Removed javascript datepicker functionality in DMYCalendarDateField

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92512 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:30:31 +00:00
Ingo Schommer
2a53488bb8 ENHANCEMENT Storing last selected tab in a cookie for TabSet.js. Requires jquery.cookie plugin.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92508 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:30:21 +00:00
Ingo Schommer
d27e3e7b96 MINOR Moved jquery-layout and swfupload libraries to cms/thirdparty
MINOR Moved jquery-fitheighttoparent library to cms/javascript

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92504 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:30:09 +00:00
Ingo Schommer
863807a87d BUGFIX Setting tinymce spellchecker rpc URL via HtmlEditorConfig rather than patching it into the plugin sourcecode
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92503 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:30:02 +00:00
Ingo Schommer
a11db29672 MINOR Changed paths to moved thirdparty dependencies (mostly from /jsparty to /sapphire/thirdparty, /cms/javascript and /sapphire/javascript)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92502 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:29:59 +00:00
Ingo Schommer
32ada0f0af ENHANCEMENT Using "concrete" jQuery plugin for SilverStripe tabset
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92485 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:22:52 +00:00
Ingo Schommer
7856df5f37 ENHANCEMENT Using jQuery UI and "concrete" tabs for Security/login with multiple authentication methods (e.g. CMS-login and OpenID)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92484 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:22:49 +00:00
Ingo Schommer
2a74a8b14f ENHANCEMENT Using jQuery UI tabs in TabSet form field. Using custom javascript to ensure sizing of tabs within layout-managed containers.
API CHANGE Changed CSS-class in TabSet template from "tabstrip" to "ss-tabset".

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92483 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:22:47 +00:00
Ingo Schommer
70deaa44e4 ENHANCEMENT Changed markup of right panel forms in HtmlEditorField, titlebars and close buttons are now created through JavaScript. Also wrapped all fields in a container to make them easy to scroll in the panel
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92482 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:22:44 +00:00
Ingo Schommer
3e3fc3d7d7 ENHANCEMENT Using "concrete" jQuery plugin for SilverStripe tabset
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92479 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:22:39 +00:00
Ingo Schommer
deb691a481 ENHANCEMENT Using jQuery UI tabs for Security/login with multiple authentication methods (e.g. CMS-login and OpenID)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92478 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:22:36 +00:00
Ingo Schommer
b3f0a9a034 ENHANCEMENT Using jQuery UI tabs in TabSet form field. Using custom javascript to ensure sizing of tabs within layout-managed containers.
API CHANGE Changed CSS-class in TabSet template from "tabstrip" to "ss-tabset".

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92477 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:22:33 +00:00
Ingo Schommer
053431aaf0 MINOR Using jquery-latest.js in FileIframeField and RemoveOrphanedPagesTask
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92476 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 02:22:30 +00:00
Ingo Schommer
0f2c93d9f7 BUGFIX: Fix TreeDropdownFields throwing an exception. (from r92411)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92462 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 01:44:32 +00:00
Ingo Schommer
a099f7906f MINOR Added ComplexTableField::setController() which makes testing useful for switching between controllers (from r92134)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@92459 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-21 01:43:33 +00:00
Will Rossiter
0b3cb11262 BUGFIX: disabled swfupload in IE versions. MINOR: merged js order changes from r91542 and r91541
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@91551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-13 03:04:38 +00:00
Ingo Schommer
2daf84910c BUGFIX Disabling security token in HtmlEditorField->FlashForm(), its not passed in by the ajax request
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@91392 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-12 02:53:49 +00:00
Will Rossiter
1a4cfc6c20 BUGFIX: updated paths to swfupload. MINOR: cleaned up structure around image upload section in the site content box
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@91347 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-11 22:47:11 +00:00
Andreas Piening
e3f4c266e3 BUGFIX: use second argument only if its an array
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@90927 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-05 20:31:41 +00:00
Sam Minnee
050b6057ce API CHANGE: Allow fieldList arguments to Form::loadDataFrom() and Form::saveInto(), for situations where the data passed only applies to a segment of the form.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@90872 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-05 01:55:27 +00:00
Sam Minnee
6e23d7ebbb API CHANGE: Inserting $HiddenFields into a form template will show the input tags of all the hidden fields.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@90871 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-05 01:54:37 +00:00
Sam Minnee
e3fa5cae7f BUGFIX: Fix Form.FieldMap, used when constructing forms that have the HTML explicitly specified.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@90851 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-05 01:14:54 +00:00
Ingo Schommer
233a8fcd85 BUGFIX: was being passed to foreach without a check to see if it's an array or not. (from r86202)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@90834 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-05 00:29:21 +00:00
Ingo Schommer
06f71f6cb5 BUGFIX: Added required javascript files (behaviour, prototype, prototype_improvements) to the Field() method of TreeSelectorField.php (from r84320)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@90833 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-11-05 00:26:57 +00:00
Andrew Short
79773042be API CHANGE: Renamed conflicting classes to have an "SS_" namespace, and renamed existing "SS" namespace to "SS_". The affected classes are: HTTPRequest, HTTPResponse, Query, Database, SSBacktrace, SSCli, SSDatetime, SSDatetimeTest, SSLog, SSLogTest, SSLogEmailWriter, SSLogErrorEmailFormatter, SSLogErrorFileFormatter, SSLogFileWriter and SSZendLog.
MINOR: Replaced usage of renamed classes with the new namespaced name.

From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@90075 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-26 03:06:31 +00:00
Sam Minnee
9a83be9140 Merge branch 'master' of git@github.com:sminnee/sapphire
From: Sam Minnee <sam@silverstripe.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@90071 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-23 23:26:10 +00:00
Andrew O'Neil
c4e0d45742 BUGFIX: Remove blockquote from tinymce default plugin list - blockquote isnt a plugin in tinymce3.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@90051 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-23 02:24:09 +00:00
Andrew O'Neil
8679fd9883 FEATURE: Allow Text/Varchar fields to be configured to differentiate between NULL and empty string. (#4178, petebd)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@90036 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-23 01:29:55 +00:00
Sean Harvey
d3130e6dfe API CHANGE Fixed change in r89716 to be more semantic with FileIFrameField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89841 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 05:54:12 +00:00
Sean Harvey
7f7e3a0ba3 API CHANGE: TableListField customQuery and customCsvQuery won't automatically include ID, ClassName, and RecordClassName fields (from r87354)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89726 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:36:33 +00:00
Sean Harvey
2cc2f41b45 BUGFIX: disabling user ability to upload images into the CMS from their local computer (from r82573)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89716 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:26:01 +00:00
Sean Harvey
25e7f4413b BUGFIX Ensure that FileIFrameField gets the proper class, this could be a subclass of File instead
MINOR Make use of dataClass() in FileIFrameField instead of calling the same has_one() method in multiple places
(from r82175)



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89715 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-21 02:23:14 +00:00
Sean Harvey
e343391bfe MINOR Fixed invalid argument foreach() on CheckboxSetField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89342 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-17 23:33:13 +00:00
Ingo Schommer
6478062ceb BUGFIX Removed 'name' attribute from HeaderField markup - its invalid HTML to put in <h*> elements (#4623)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89333 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-17 00:01:55 +00:00
Sam Minnee
dfd45fb7fd BUGFIX: Fixed diabled image references for edit and delete links in CTF (from r88967)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89206 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:39:19 +00:00
Sam Minnee
96e449225e BUGFIX: If a CTF without a show action is made readonly, don't add the show action back. (from r88960)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89204 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:39:07 +00:00
Sam Minnee
5ec83b9bd0 BUGFIX: Fixed resolution of amibiguous has_many foreign keys in ComplexTableField to use the same logic as DataObject (from r88945)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89203 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:38:57 +00:00
Sam Minnee
5082cd8ffb MINOR removed debugging statement (from r88627)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89184 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:24:35 +00:00
Sam Minnee
3965ac5237 MINOR don't show invalid version links (from r88147)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89181 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 22:24:09 +00:00
Sam Minnee
7dd6d10cde MINOR added more documentation around SiteConfig. Also wrote unit tests for permissions inheritance off it. (from r86132)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89164 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 21:53:15 +00:00
Sam Minnee
4ab8055c29 #63 - Stable against restructures (from r84861)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@89155 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 21:46:13 +00:00
Andrew Short
1ccdcbac5d API CHANGE: Updated Form->FormAction() to use Controller::join_links() rather than relying on the action parameter (to preserve b/c).
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88991 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 00:02:05 +00:00
Andrew Short
5adfc28a43 BUGFIX: Reset broken file & link flags in HtmlEditorField->saveInto() before determining if a record contains broken links.
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88989 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-15 00:02:04 +00:00
Andrew Short
26ece45bb0 BUGFIX: Stopped HtmlEditorField->saveInto() from dying when encountering a link that cannot be made relative.
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88774 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-13 01:45:01 +00:00
Andrew Short
9b4d9993a4 FEATURE: Added SS_HTMLValue to provide a simple wrapper around DOMDocument to allow the manipulation of HTML snippets.
FEATURE: Re-instated broken link highlighting by manually checking all shortcodes in HtmlEditorField->Field(), and adding a class to broken ones.

From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88510 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-11 00:07:27 +00:00
Andrew Short
f29eceecff API CHANGE #3724: Unified the Link() method to accept an action parameter.
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88495 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-11 00:07:16 +00:00
Andrew Short
e533719d06 BUGFIX: Use Link() on the controller to generate to form action path.
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88493 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-11 00:07:14 +00:00
Andrew Short
1859ba502b FEATURE: Updated HtmlEditorField to use DOMDocument to more reliably parse image tracking and shortcode link tracking data.
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88492 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-11 00:07:13 +00:00
Andrew Short
73b0ea643f ENHANCEMENT #3279: Updated the link inserter to insert a shortcode rather than a plain HTML link.
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88491 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-11 00:07:12 +00:00
Andrew Short
264b484e82 ENHANCEMENT: Refactored TreeDropdownField to generate and manage the tree using Hierachy's ParentID data, rather than relying on the client.
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88482 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-11 00:07:05 +00:00
Andrew Short
fd7b322ed4 MINOR: Removed un-used HtmlEditorField button generation code that has been replaced with HtmlEditorConfig.
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88470 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-11 00:06:55 +00:00
Ingo Schommer
a0fd987b29 BUGFIX Filter both 'available' and 'new' languages in LanguageDropdownField for canTranslate() permissions
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88138 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-05 20:40:22 +00:00
Will Rossiter
af9e4f59f5 MINOR: Reverted previous commit
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88112 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-05 03:37:05 +00:00
Will Rossiter
620aa651aa FEATURE: added extend() call to enable FieldHolder() html to be customized via extensions.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@88104 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-10-05 02:17:19 +00:00
Sean Harvey
b77d088d47 Merged in parent::__construct() additions from branches/2.3 - r83580 and r83587
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86676 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-09-18 03:02:19 +00:00
Geoff Munn
69563972e5 MINOR FIX: columns quoted properly
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86528 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-09-17 00:18:43 +00:00
Geoff Munn
41b700d163 MINOR FIX: backticks converted to quotes
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86523 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-09-17 00:16:12 +00:00
Ingo Schommer
f86bc6f715 ENHANCEMENT Added TableListField->paginationBaseLink
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86338 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-09-15 04:11:13 +00:00
Sean Harvey
1912ca960b MINOR #3629 FileIFrameField If user clicks "Attach file" or "Replace file" without a source file, validation message will appear above the form
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@86129 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-09-11 03:14:55 +00:00
Ingo Schommer
47db2ab55e BUGFIX Detecting DataObjectSet for readonly transformations in CheckboxSetField (thanks martijn, #4527)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@85758 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-09-05 00:05:02 +00:00
Normann Lou
5a39ad8a94 BUGFIX: merge r 85079 from branches/iss to fix Payment Validation of php side when submit a OrderForm
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@85130 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-08-25 01:51:56 +00:00
Sean Harvey
fc372b9598 BUGFIX SelectionGroup should include jQuery and jQuery livequery plugin when it's used or it will fail
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84976 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-08-21 03:22:52 +00:00
Andrew O'Neil
66543e6002 NOTFORMERGE: Merged 84085 from 2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@84089 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-08-10 04:32:39 +00:00
Mateusz Uzdowski
e1ea8759be ENHANCEMENT ImageField now shows only images and folders under the 'From the File Store' tree
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@83346 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-31 00:46:07 +00:00
Ingo Schommer
77ab3e6038 MINOR PHP Notice bugfix in TableField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82096 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-17 02:27:13 +00:00
Ingo Schommer
946025adb9 API CHANGE Removed TableField->FieldSet() and TableField->SubmittedFieldSet(), please use Items() and TableField_Item->Fields() instead (merged branches/2.3-nzct)
BUGFIX Fixed re-loading of unsaved TableField form data (e.g. after a validation error). The (now removed) method SubmittedFieldSet() was setting incremental temporary identifiers ("new1", "new2", etc), which wasn't picked up by Items() (merged from branches/2.3-nzct)
BUGFIX Using $this->value instead of $_POST to process submitted data in TableField (merged from branches/2.3-nzct)
BUGFIX TableField validation logic iterates over TableField_Item instances to get all formfields, rather than creating their own set in SubmittedFieldSet()
MINOR Removed repitition of temporary Form generation in TableField by generateTableFieldItem() method (merged from branches/2.3-nzct)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82089 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-17 02:09:27 +00:00
Ingo Schommer
99d6f2241f MINOR Simplified TableField->sortData() code structure (no logic changes) (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82079 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-17 00:17:43 +00:00
Ingo Schommer
bc07a4644e MINOR Simplified TableField->saveData() code structure (no logic changes) (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82078 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-17 00:17:21 +00:00
Ingo Schommer
98cc45291b MINOR Code formatting in TableField (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82077 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-17 00:16:52 +00:00
Ingo Schommer
d3ff09df03 MINOR Removing TableField->delete(), was superseded by TableListField_ItemRequest->delete() a while ago (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82076 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-17 00:16:17 +00:00
Ingo Schommer
9a43bbc1ed ENHANCEMENT TableField_Item->createFields() returns FieldSet instead of DataObjectSet (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82075 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-17 00:15:39 +00:00
Ingo Schommer
92aecd6ab6 MINOR TableField documentation (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82074 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-17 00:13:42 +00:00
Ingo Schommer
a17f6e120b MINOR Improved naming in TableField->saveInto() (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82073 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-17 00:12:56 +00:00
Ingo Schommer
e6ade3d64b BUGFIX Including NumericField?.js in NumericField?, was previously extracted from CalendarDateField?.js (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82067 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:58:42 +00:00
Ingo Schommer
485eca829b BUGFIX Removed tabindex settings on DMYDateField, they were messing up the tab order in day/month/year fields (merged from branches/2.3-nzct)
BUGFIX Removed "numeric" class on day/month/year fields in DMYField, the auto-magic NumericField? javascript resetting thats triggered onkeyup() is just a bit too much for its own good (merged from branches/2.3-nzct)
BUGFIX Removed hiddenfield dependency on DMYDateField, save into three distinct input fields and validate accordingly. All underlying logic already works with this notation. (merged from branches/2.3-nzct)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82062 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:54:25 +00:00
Ingo Schommer
11b30e8db9 MINOR Moved NumericField? javascript logic from CalendarDateField?.js into new NumericField?.js. Removed unused DMYCalendarDateField javascript logic, the field behaves just fine with standard input fields and no auto-focus magic on the input fields. (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82061 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:52:35 +00:00
Ingo Schommer
8a20d5c1ad ENHANCEMENT Added TableField?->autoRelationSetting to allow for automatic saving into relationships (similiar to ComplexTableField? implementation) (merged from branches/2.3-nzct)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@82060 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 23:49:32 +00:00
Sean Harvey
82a68dd3bd MINOR Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81997 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-16 03:44:15 +00:00
Sam Minnee
212765ae5c MINOR: Made extract() call a little tighter.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81381 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-08 23:04:43 +00:00
Ingo Schommer
cf302011b8 BUGFIX Fixed Form->handleField() to first look for fieldByName() before falling back to dataFieldByName(). This was necessary for tabs and formfields having the same name, e.g. "Members" in the SecurityAdmin class. We have to ensure to return the data field instead of the (non-datafield) tab.
MINOR Added documentation about URL handling to Form

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81130 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-06 22:06:42 +00:00
Ingo Schommer
4a531820cd BUGFIX Accepting dot-notation in TabSet->fieldByName()
BUGFIX Using fieldByName() instead of dataFieldByName() in Form->handleField() to allow rendering of nested tabs through a URL

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81128 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-06 21:53:50 +00:00
Ingo Schommer
fcc6948e79 BUGFIX Setting brokenOnConstruct to FALSE in CompositeField::__construct() - it skips a constructor, hence breaking request handling (and therefore direct field access through /Form/Field/MyCompositeField/FieldHolder
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@81127 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-06 21:48:12 +00:00
Sean Harvey
1b1809f1a2 Merged from branches/2.3
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80873 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-02 07:18:18 +00:00
Sam Minnee
f41e2b474c ENHANCEMENT: Improved performance of admin/assets area.
BUGFIX: Fixed bug in 'sake interactive' error handling.
BUGFIX: Fixed bugs with MSSQL and Windows support.
API CHANGE: Added FormAction::setButtonContent()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80782 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-07-01 22:27:18 +00:00
Rainer Spittel
ca4ec1af03 ENHANCEMENT: enabled saveInto to use the setter method when available instead of passing through the form field values directly to the money class.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80521 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-30 03:16:28 +00:00
Sam Minnee
73cfe3ab84 API CHANGE: Added increase_time_limit_to(), which respects safe_mode.
API CHANGE: Added no-arg option to increase_memory_limit_to()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80241 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-28 02:36:46 +00:00
Sam Minnee
66b25f1e62 BUGFIX: Fixed CSRF warning in image form after selecting a folder.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80237 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-28 01:17:20 +00:00
Sam Minnee
c0c72e4c53 BUGFIX ajshort: Ensure that CSRF security token settings are passed from parent controllers/forms into child forms.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80225 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 08:48:42 +00:00
Sam Minnee
9069d5ae46 MINOR #3399: Removed last references to DefaultFieldHolder.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80220 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 07:00:01 +00:00
Sam Minnee
6bcabcbe46 BUGFIX #4306 simon_w: Fixed ConfirmedPasswordField::setValue()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@80192 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-27 04:00:10 +00:00
Normann Lou
96fac4432a MINOR: add document for ConfirmedPasswordField::setChildrenTitles().
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79852 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-23 07:47:45 +00:00
Normann Lou
ae864ba751 APICHANGE: add function ConfirmedPasswordField::setChildrenTitle() which can set each child of the field a customised title.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79851 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-23 07:46:12 +00:00
Normann Lou
72a6a4cbc3 FEATURE: roll back r79604 which is to make a ToggleCompositeField able to save back a boolean value if its name is a boolean field of the related object. the reason is this feature is not necessary cos SelectionGroup address the same thing.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79616 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-19 02:38:33 +00:00
Normann Lou
54a79cf9f3 FEATURE: make a ToggleCompositeField able to save back a boolean value if its name is a boolean field of the related object.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79604 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-19 01:38:34 +00:00
Normann Lou
cd59a9b1d7 MINOR: added $extraClass of a hidden field to its rendered html
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79603 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-19 01:36:09 +00:00
Normann Lou
1a32847855 BUGFIX: check isset($variable) before using $variable
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79602 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-19 01:34:06 +00:00
Sam Minnee
c52f67aae5 MINOR ajshort: Replaced usage of the deprecated split() function with preg_split().
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-18 09:34:17 +00:00
Sam Minnee
301989d203 BUGFIX #3922 simon_w: Perform form validation after the clicked button has been set.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@79567 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-06-18 08:22:30 +00:00