Ingo Schommer
bba1be3cd0
Merge pull request #4558 from sminnee/simplify-build-matrix-31
...
MINOR: Simplify build matrix for 3.x builds.
2015-08-31 10:18:00 +12:00
Daniel Hensby
ea757e72a6
Merge pull request #4560 from willmorgan/bugfixes/localstorage-win81-ie11
...
Fix localStorage for Windows 8.1 IE11 desktop mode
2015-08-29 21:15:19 +01:00
James Bolitho
0cb98bcce2
Fix localStorage for Windows 8.1 IE11 desktop mode
...
In IE11 windows 8 call to window.localStorage was throwing out an access denied error. Using try and catch manages the issue and allows the script to execute in IE 11 in desktop mode.
I think it is a problem with IE11 rather than the way Silverstripe is implementing the preview via an iframe from what I have been reading. http://blogs.msdn.com/b/ieinternals/archive/2009/09/16/bugs-in-ie8-support-for-html5-postmessage-sessionstorage-and-localstorage.aspx . It seems that the way IE11 deals with localStorage is broken in certain cases but I am not 100% certain of the cause yet as I have not been able to find a definitive answer. I only noticed it was a problem when a new client said they couldn't view the admin screen properly in IE11. I took a look in IE11 and I was experiencing the same problem which makes the admin interface layout screw up and the preview doesn't work due the error mentioned in the first post.
Instead of the original code I submitted I have amended it and added an additional function to test more robustly to see if localStorage is available and can be accessed properly. It is a copy of the code on a blog post Mathias Bynens has written about detecting if localStorage is available and can be used: https://mathiasbynens.be/notes/localstorage-pattern
I have added a console.warn as you suggested if localStorage is not available so that at least you get a warning if localStorage tests fail.
I have tested this on Windows 8.1: Firefox, Chrome & Mac: Firefox, Safari, Chrome and it seems to work as expected. On IE11 it displays the admin area correctly now but obviously doesn't save the preview settings between page loads if localStorage is not available.
2015-08-29 15:54:14 +01:00
Sam Minnee
ab44f5ef47
MINOR: Simplify build matrix for 3.x builds.
...
This is a companion to https://github.com/silverstripe/silverstripe-framework/pull/4556
but targeted at the build needs of SilverStripe 3.x. Commit into 3.1 and
then the merge forward into 3.2 and 3.
2015-08-29 15:50:49 +12:00
Daniel Hensby
48d00895ca
Merge pull request #4554 from halkyon/flush-docs
...
DOCS Add warning on flush not being run automatically by unit test commands.
2015-08-28 02:02:31 +01:00
Sean Harvey
03d2fc73c5
Add warning on flush not being run automatically by unit test commands.
2015-08-28 13:00:22 +12:00
Sean Harvey
eca781ed91
Merge pull request #3813 from nfauchelle/patch-1
...
Flush should be off by default - consistant
2015-08-28 12:49:24 +12:00
Ingo Schommer
28554dbe94
Merge pull request #4504 from dhensby/pulls/fields-fix
...
When loading data into a form, make sure its using ALL fields
2015-08-28 08:38:49 +12:00
Daniel Hensby
08dd8fda62
Merge pull request #4086 from xini/fix-remote-url-field
...
fix width of remote url field label to allow right-click-paste
2015-08-27 20:50:35 +01:00
Daniel Hensby
8015919932
Be defensive with token availability
2015-08-27 17:58:43 +01:00
Daniel Hensby
899eb0b235
FIX Use complete fieldlist for extracting data
2015-08-27 17:58:19 +01:00
Daniel Hensby
cffb11e568
TEST Ensure data is loaded into complete FieldList
2015-08-27 17:56:22 +01:00
Ingo Schommer
0c97192558
Merge pull request #4546 from dhensby/pulls/permission-docs
...
DOCS Adding docs for special Permission cases
2015-08-27 10:39:23 +12:00
Daniel Hensby
209bb94319
DOCS Adding docs for special Permission cases
2015-08-26 23:32:07 +01:00
Damian Mooyman
4fdfe3a0a2
Merge pull request #4543 from dhensby/pulls/members-can-view-themselves
...
FIX Members can access their own profiles in CMS
2015-08-27 09:43:43 +12:00
Daniel Hensby
2d4b743090
FIX Members can access their own profiles in CMS
2015-08-26 15:47:51 +01:00
Sam Minnée
a40e70f874
Merge pull request #4535 from kinglozzer/travis-notifications
...
Disable IRC notifications for Travis builds
2015-08-25 18:10:46 +12:00
Loz Calver
99a8a81e9a
Fix issues with tests and "subfolder" URLs
2015-08-25 11:49:01 +12:00
Loz Calver
71eb7d3364
Disable IRC notifications for Travis builds
2015-08-24 11:56:04 +01:00
Daniel Hensby
790dff7b81
Merge pull request #4525 from tractorcow/pulls/3.1/teamcity
...
MINOR Adjustment to teamcity output
2015-08-21 09:18:51 +01:00
Daniel Hensby
ab0572e7cc
DOCS Permission comments made a bit clearer
2015-08-21 09:16:46 +01:00
Damian Mooyman
465a3bea64
MINOR Adjustment to teamcity output
2015-08-21 17:30:50 +12:00
Damian Mooyman
d64852b2e8
Merge pull request #4517 from dhensby/pulls/access-all-areas
...
Fix issue where Access All CMS Sections doesnt work
2015-08-21 11:48:45 +12:00
Daniel Hensby
2cf7446d8e
Merge pull request #4519 from tractorcow/pulls/3.1/fix-setup
...
BUG Fix illegalExtensions breaking tests.
2015-08-21 00:41:38 +01:00
Damian Mooyman
fc212e030c
BUG Fix illegalExtensions breaking tests.
...
Revert #3979
2015-08-21 11:18:58 +12:00
Daniel Hensby
6eede57ff2
Fix issue where Access All CMS Sections doesnt work
2015-08-20 22:30:43 +01:00
Daniel Hensby
a4bd11149f
Merge pull request #4508 from kinglozzer/missing-var
...
FIX: Using undefined var in ModelAdmin
2015-08-18 16:31:32 +01:00
Loz Calver
8b638f56fb
FIX: Using undefined var in ModelAdmin
2015-08-18 15:37:15 +01:00
Sam Minnée
9eb2265a21
Merge pull request #4506 from dhensby/pulls/remove-nightly
...
Remove nightly build as PHP 7 support is explicitly off
2015-08-18 09:09:54 +12:00
Daniel Hensby
a73f9ba8fb
Remove nightly build as PHP 7 support is explicitly off
2015-08-17 16:50:05 +01:00
Sam Minnée
5911d50bca
Merge pull request #4477 from nickbooties/nickbooties-patch-1
...
Fixes #4424
2015-08-11 17:34:35 +12:00
Nick
c4c4d79c26
Fix for Issue #4424
...
Model Admin : 'Show Specification for' toggle link breaks if Title contains spaces.
Uses className for element ID on ImportSpec template.
2015-08-11 14:56:13 +10:00
Sam Minnée
5c3bf3d0a2
Merge pull request #4482 from kinglozzer/classinfo-nonexistant-class
...
Ensure ClassInfo is backwards compatible with non-existant classes
2015-08-10 15:45:32 +12:00
Will Morgan
a28bf97cf4
Merge pull request #4488 from SpiritLevel/patch-4
...
Spelling
2015-08-06 16:23:14 +01:00
David Alexander
44680d175c
Spelling
2015-08-05 21:34:35 +12:00
Sam Minnée
d419b667ef
Merge pull request #4485 from yabbagail/no-php7
...
Explicitly don't support PHP7
2015-08-05 18:06:52 +12:00
Abagail Yost
30bdcc5dc3
Explicitly don't support PHP7
2015-08-05 15:28:38 +10:00
Will Morgan
ca6a46f88d
Merge pull request #4481 from dhensby/pulls/fix-default-perm-failure
...
Fixing rubbish login message when trying to access the CMS
2015-08-04 16:38:52 +01:00
Loz Calver
687de33d0d
Ensure ClassInfo is backwards compatible with non-existant classes
2015-08-04 15:07:07 +01:00
Daniel Hensby
009458e342
Fixing rubbish login message when trying to access the CMS
2015-08-04 12:23:22 +01:00
Nick
1438a53900
Issue #4424
...
Model Admin : 'Show Specification for' toggle link breaks if Title contains spaces #4424
2015-08-04 15:57:38 +10:00
Nick
9ad64716cc
Issue #4424
...
Model Admin : 'Show Specification for' toggle link breaks if Title contains spaces #4424
2015-08-04 15:55:07 +10:00
Daniel Hensby
d0d34bde4a
Merge pull request #4473 from kinglozzer/gf-sortableheader-method-exists
...
Check that method 'hasMethod' exists in GridFieldSortableHeader
2015-08-03 18:45:25 +01:00
Loz Calver
1b6442058d
Check that method 'hasMethod' exists in GridFieldSortableHeader
2015-08-03 16:49:18 +01:00
Sam Minnée
4485b266e2
Merge pull request #4467 from camfindlay/patch-28
...
DOCS create() makes objects not classes.
2015-08-03 13:36:31 +12:00
Cam Findlay
ea16aca74b
DOCS create() makes objects not classes.
...
Thanks to Matthew at Cabbage Tree Creative for reporting.
2015-08-03 12:50:24 +12:00
Damian Mooyman
912b133ba1
Merge pull request #3949 from dhensby/pulls/case-sensitive-class-info
...
Ensuring classinfo is case insensitive
2015-07-28 22:36:53 +12:00
Daniel Hensby
ffbeac6b7d
Ensuring classinfo is case insensitive
2015-07-28 11:17:50 +01:00
Daniel Hensby
5f0d0ab66a
Merge pull request #4155 from kinglozzer/pulls/getfiletype-case
...
FIX: File::getFileType() was case sensitive (fixes #3631 )
2015-07-28 00:13:26 +01:00
Damian Mooyman
ae783e9598
Merge pull request #4042 from selay/3.1
...
Hardcoded http:// cause browser warnings in admin panel
2015-07-28 09:14:34 +12:00
