Robbie Averill
b0871ebd75
Merge pull request #8417 from creative-commoners/pulls/4.3/many-many-through-sorting-tests
...
Add more list sorting tests and fix many many through sorting
2018-10-03 13:30:20 +02:00
Robbie Averill
d1f30a20c2
Merge pull request #8408 from dhensby/pulls/4/test-cleanup
...
Test cleanup
2018-10-03 13:28:59 +02:00
Robbie Averill
d2b646cc13
Merge pull request #8286 from wilr/patches/mysql-create-table-issue
...
Check database has table before altering.
2018-10-03 13:24:59 +02:00
Robbie Averill
d74fed554a
Merge pull request #8427 from sminnee/fix-1397
...
FIX: Append any fields that don’t match name in insertBefore/insertAfter
2018-10-03 13:22:23 +02:00
Robbie Averill
6a5fb4999c
Merge pull request #8416 from lekoala/patch-14
...
raw2att accepts array, but sprintf doesn't
2018-10-03 13:21:43 +02:00
Robbie Averill
79f9d6b733
Merge pull request #8428 from sminnee/fix-2636
...
FIX: Don’t change state in ArrayList::getIterator()
2018-10-03 13:11:39 +02:00
Robbie Averill
2c186854c2
Merge pull request #8432 from sminnee/ss4-php73
...
NEW: Add test for PHP 7.3 support (SS4 version)
2018-10-03 13:10:21 +02:00
Maxime Rainville
f4c217f8a1
Merge pull request #8420 from open-sausages/pulls/4/searching-for-api
...
Add extension points for ModelAdmin search API
2018-10-03 16:57:05 +13:00
Robbie Averill
cb2b9498fb
API Deprecate updateSearchContextCallback and updateSearchFormCallback
2018-10-03 13:47:40 +13:00
Luke Edwards
bf60a699a5
Add extension points for ModelAdmin search API
2018-10-03 13:47:40 +13:00
Maxime Rainville
cefb81dabc
Merge pull request #8436 from creative-commoners/pulls/4.3/this-is-not-js
...
FIX Moving test to correct directory
2018-10-03 11:05:46 +13:00
Guy Marriott
5970fc2417
FIX Moving test to correct director
2018-10-03 10:47:17 +13:00
Robbie Averill
5a20bb5e20
Revert "FIX: Use DELETE FROM instead of TRUNCATE for clearTable"
...
This reverts commit 79c2b5ad42
2018-10-02 14:35:10 +02:00
Robbie Averill
c8e7672ede
Merge pull request #8414 from creative-commoners/pulls/4/searching-for-a-name-conflict
...
FIX Avoid having search fields with the same names as form elements
2018-10-02 13:43:59 +02:00
Robbie Averill
2ca089bcce
Merge pull request #8433 from sminnee/faster-cleartable
...
FIX: Use DELETE FROM instead of TRUNCATE for clearTable
2018-10-02 10:43:54 +02:00
Robbie Averill
fa44b50b4f
Merge pull request #8431 from kalicki2k/patch-1
...
added an http / https switch
2018-10-02 10:35:16 +02:00
Loz Calver
27076aeb93
Merge pull request #8430 from sminnee/fix-6300
...
FIX: Don’t use USE_FRM in MySQL repair. Fixes #6300 .
2018-10-02 10:28:17 +02:00
Sam Minnee
79c2b5ad42
FIX: Use DELETE FROM instead of TRUNCATE for clearTable
...
clearTable is mainly used for clearing data between tests. In this case,
there are very few or zero records, and DELETE FROM is quicker than
TRUNCATE, which works by deleting and recreating the table.
This materially speeds up test execution, at least on MySQL.
Implemented in SS3 at 815da76b056a716c8831d22bbf93528912cbcb28
2018-10-02 18:00:38 +13:00
Sebastian Kalicki
9051fb923d
removed http...
2018-10-02 05:19:27 +02:00
Sam Minnee
e1f2f89d37
NEW: Add test for PHP 7.3 support (SS4 version)
...
This also removed the allow_failures nightly build, reasoning that the
PHP 7.3 build is the primary test-case where, and allow_failures builds
are of limited value.
2018-10-02 14:48:49 +13:00
Sebastian Kalicki
c6c9ce8fbf
added an http / https switch
2018-10-02 00:10:55 +02:00
Sam Minnee
f2cbc1dfbb
FIX: Don’t use USE_FRM in MySQL repair. Fixes #6300 .
...
USE_FRM is a sufficiently dangerous option that it should require
manual DBA activity to carry out.
See http://dev.mysql.com/doc/refman/5.7/en/repair-table.html for more
info.
2018-10-02 10:48:47 +13:00
Sam Minnee
71dad5f685
FIX: Append any fields that don’t match name in insertBefore/insertAfter
...
Previous behaviour was to return false, which has been described as
a confusing bug on https://github.com/silverstripe/silverstripe-framework/issues/1397
where the issue was identified.
2018-10-02 10:39:48 +13:00
Sam Minnee
ad87890b2e
FIX: Don’t change state in ArrayList::getIterator()
...
This prevents the map-to-ArrayData conversion from changing object
state and making the result of toArray() non-deterministic.
Fixes #2636 . Other solutions were suggested on that ticket, but there is
no way of putting special code in for a SSViewer-specific iterator, and
having object state pre-emptively converted to ArrayData would
be an SS5-level change.
2018-10-02 09:56:09 +13:00
Robbie Averill
bfe2a7b7e6
Update testSearchFieldSchema to expect namespaced search fields
2018-10-01 12:44:19 +02:00
Maxime Rainville
755907d117
Merge pull request #8409 from open-sausages/pulls/4/treedropdown-caching
...
MINOR Add caching to the TreeDropdownField tree action
2018-10-01 13:56:21 +13:00
Guy Marriott
c503dbd634
Prefixing search filters for the React search form context
2018-10-01 13:38:32 +13:00
Maxime Rainville
13c89d0ed0
Add a comment and only apply caching if using the standard NumChildrenMethod
2018-10-01 11:29:51 +13:00
Dan Hensby
7e2d073dd6
Ignore assets dir that can be created on dev/build
2018-09-29 22:52:08 +01:00
Dan Hensby
3584598d7a
Minor improvements
2018-09-29 22:51:26 +01:00
Dan Hensby
b0e0566c93
Formatting
2018-09-29 22:51:26 +01:00
Dan Hensby
5a3cc9503b
Formatting
2018-09-29 22:51:26 +01:00
Dan Hensby
2ef63ddbc1
Remove unused function args
2018-09-29 22:51:26 +01:00
Dan Hensby
7a18cd98e0
Improve assertion type
2018-09-29 22:51:26 +01:00
Dan Hensby
90e74a608e
Throwing and catcing an error in tests is mad
2018-09-29 22:51:26 +01:00
Dan Hensby
3c532cea0c
Minor cleanup of DirectorTest
2018-09-29 22:51:26 +01:00
Dan Hensby
3a007d52e6
Code formatting
2018-09-29 22:51:18 +01:00
Robbie Averill
94d534383f
Merge pull request #8422 from hpeide/patch-1
...
Update index.md
2018-09-28 15:53:45 +02:00
Hans Philip Eide
140436692a
Update index.md
...
When exporting path to ~/.bash_profile the change do not take action before you reload the shell. Calling 'source ~/.bash_profile' executes the change.
2018-09-28 15:44:58 +02:00
Robbie Averill
d18b8eb9fb
Add more tests for descending sort orders
2018-09-28 15:42:45 +02:00
Robbie Averill
ac1fe5e9d5
FIX joinClass's default_sort is used when nothing else has been set already
2018-09-28 15:39:24 +02:00
Robbie Averill
4aa7fb70ee
Add tests that show that joinClass default_sort is not used and order is honoured
2018-09-28 15:38:37 +02:00
Robbie Averill
4d14e9b6b1
Merge pull request #8421 from creative-commoners/pulls/4.3/psr-5-deprecations
...
Update deprecation PHPDocs to be PSR-5 compliant
2018-09-28 14:18:54 +02:00
Loz Calver
10ff6c4f81
Merge pull request #8418 from creative-commoners/pulls/4.3/lower-complexity
...
MINOR Reduce some code complexity, update array syntax and injected SQLSelect etc
2018-09-28 12:51:08 +02:00
Robbie Averill
e4768e44b0
Use splat over call_user_func_array and reduce calls to func_get_args()
2018-09-28 12:32:20 +02:00
Robbie Averill
e57edcd060
Merge pull request #8387 from sminnee/fix-start-session-without-headers
...
FIX: Ensure existing session can be accessed if headers_sent()
2018-09-28 10:59:29 +02:00
Robbie Averill
f842ee2eec
Update deprecation PHPDocs to be PSR-5 compliant
...
See: https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#55-deprecated
2018-09-28 10:49:14 +02:00
Loz Calver
aec562f048
Merge pull request #8419 from 3Dgoo/patch-1
...
minor i18nEntityProvider.php API documentation fix
2018-09-28 10:21:37 +02:00
Loz Calver
289f65fa05
Merge pull request #8413 from open-sausages/pulls/4/classmanifest-exceptions
...
NEW Show file path on PHP parser exceptions
2018-09-28 10:20:38 +02:00
Sam Minnee
b98c87a6c5
FIX: Ensure existing session can be accessed if headers_sent()
...
If a session already exists, and Session::start() isn’t called until
after a large enough block of content is output, then headers_sent()
will be false. The previous code prevented the session from being
started in this case. That might makes sense for the creation of a new
session, but it prevent legitimate access to an existing session.
This mostly manifested when running debugging tools such as showqueries,
which may output content before the session is started.
2018-09-28 13:25:13 +12:00
