Hamish Friedlander
2916f2043c
NEW: Improve HTTP caching logic to automatically disable caching for requests that use the session.
...
This improvement makes it easier to set a side-wide default cache time without needing to worry about CSRF-protected forms, etc.
2013-01-08 17:47:05 +13:00
Sam Minnee
b114aa2488
BUGFIX: Added X-Forwarded-Protocol and User-Agent to Vary header.
2013-01-08 17:47:05 +13:00
Sam Minnee
729bcc95db
BUGFIX: Don't clear form messages unless forTemplate() is actually called.
...
BUGFIX: Clear session-stored form data as well as form error message.
2013-01-08 17:45:17 +13:00
Sam Minnee
abbee41b78
NEW: Add ReadonlyField::setIncludeHiddenField()
...
The new config setter restores the 2.4 behaviour of including <input type="hidden"> with a field. Although as a default, this option has security flaws; it is useful in a few circumstances and, if nothing else, is handy to make upgrading sites easier.
2013-01-08 17:45:17 +13:00
Sean Harvey
b63e55a77a
Merge pull request #993 from halkyon/htaccess_fix
...
Fixing .htaccess to ignore rewriting PHP files directly
2013-01-06 17:24:49 -08:00
Sean Harvey
baaa270ceb
Merge pull request #1032 from halkyon/datalist_filter_docs
...
Improve class naming and docs for DataList::applyFilterContext()
2013-01-06 17:23:43 -08:00
Sean Harvey
2140a621fb
Merge pull request #1067 from halkyon/shorthand_ternary_op
...
Remove unncessary variable from TreeDropdownField
2013-01-06 17:20:54 -08:00
Sean Harvey
68eb367d27
Remove unncessary variable from TreeDropdownField
2013-01-07 14:14:54 +13:00
Ingo Schommer
a0a317886b
Merge pull request #1077 from sunnysideup/patch-5
...
upgrading 'Setting up an environment for contributing to SilverStripe'
2013-01-06 13:08:06 -08:00
Nicolaas
9dcace9b32
upgrading 'Setting up an environment for contributing to SilverStripe' to heading 1
...
we do this to make it clearer that you can do the basic install OR a 'DEV' install - after that we list the advanced usage cases.
2013-01-05 11:26:21 +13:00
Ingo Schommer
5d9819be53
Clearer docs on using composer for contributions
2013-01-04 12:21:07 +01:00
Ingo Schommer
d872202ae5
Support for X-Reload header
...
Backported from 3.1. Required to get subsite's
"copy page to subsite" form submission working.
2013-01-03 20:43:51 +01:00
Nicolaas
a32451f72e
adding extension hook in GridFieldDetailForm.php
...
This hook is useful so that you can add additional fields / actions in a gridfield form that are not available in other settings (e.g. additional actions: previous / next / save and publish / unpublish / etc
2012-12-27 19:22:54 +13:00
Justin Martin
f431b35b88
BUG: Confirmed Password Field now copies attributes to child fields.
2012-12-27 09:25:15 +13:00
Nicolaas
3fca288873
Update forms/TextareaField.php
...
small edit to description of the field (usage). Removed reference to cols and rows parameters.
2012-12-26 22:29:36 +13:00
Ingo Schommer
3fd1769142
Added docs about which branch to choose
2012-12-21 14:26:51 +01:00
Ingo Schommer
f0f83b26a8
BUG Graceful handling of sprintf with too few params in i18n::_t()
...
Originally discovered as a problem with the 'GridFieldDetailForm.Saved' in nl.yml
2012-12-21 11:46:39 +01:00
Ingo Schommer
661a4a2492
Removed direct sprintf() usage from _t() calls
...
Parameterized strings are easier to understand,
and more fail-proof, don't fatal out when not enough sprintf() args
2012-12-21 11:46:38 +01:00
Ingo Schommer
c054ab49a2
Merge pull request #1053 from unclecheese/patch-11
...
Fix edge case in which uninitialized buttons are being destroyed.
2012-12-20 11:08:47 -08:00
Ingo Schommer
6bcffd66ad
Merge pull request #1063 from drzax/log-file-formatter-fix
...
BUGFIX Ensure has length before using string index access.
2012-12-20 10:19:03 -08:00
Ingo Schommer
d918c26782
Allow recursive includes in i18nTextCollector ( fixes #8133 )
2012-12-20 12:46:57 +01:00
Ingo Schommer
9ffd25225e
Don't complain about pre-replaced YAML fixture relations
2012-12-20 12:46:56 +01:00
Sean Harvey
aa3b358469
Adding test for SortColumn to SQLQueryTest
...
Mostly for the benefit of MSSQLDatabase which is having problems
with subselects and alias functions.
2012-12-20 15:52:46 +13:00
Simon Elvery
1a4eaaaf04
BUGFIX Ensure has length before using string index access.
2012-12-20 12:27:09 +10:00
Adam Judd
3a555d2bcb
Set 'active' correctly for accordion widget
...
The accordion widget was previously being passed true and false, where as it either expects true or the integer of the panel to show.
This fix sets it as either false or 0.
2012-12-18 23:22:37 -08:00
Stig Lindqvist
22efd3848e
BUG Calling DataObject::relField() on a object with an empty relation list
...
This causes a 'Fatal error: Call to a member function hasMethod() on a non-object'.
This can happen when displaying a field in a gridfield on a belongs_to relationship.
2012-12-19 16:47:07 +13:00
unclecheese
07fb756327
Fix edge case in which uninitialized buttons are being destroyed.
...
In certain cases, the button may not yet be initialized or may no longer have button properties at the time of removal from the DOM. Without this check, an uncaught exception is thrown.
2012-12-18 09:41:54 -05:00
Ingo Schommer
9b3aebd310
Allow HTML in FormField->setDescription()
2012-12-18 15:02:23 +01:00
uniun
6aba24b3e9
BUG removeRequiredField() should use array_splice() instead of unset()
...
Function unset() preserves numeric keys and method removeRequiredField() will give a PHP notice about nonexistent array key and loop won't iterate throughout all elements in array on second method call (and all subsequent).
So it's better to use foreach loop and array_splice() function (it doesn't preserve numeric keys).
2012-12-18 11:57:11 +02:00
Mateusz Uzdowski
d5a1c3d99a
BUG SS has problems handling + in URLs. Filter them out.
...
+ has a special meaning in the URLs so overall it's a good idea to
strip them out. Otherwise they would need to appear in their ugly url
encoded form "%2B".
Refer: http://open.silverstripe.org/ticket/7929
2012-12-18 09:44:47 +01:00
Ingo Schommer
8f239d6373
SimpleXML string casting in tests for older PHPUnit
2012-12-17 15:52:01 +01:00
Ingo Schommer
3b59d4a762
Updated translations
2012-12-17 11:45:09 +01:00
Ingo Schommer
e8f3e7b36e
Only reset test state in SapphireTest if its previously been set
...
That's not the case e.g. if the *first* test in a suite
is skipped, so setUp() is never executed completely.
2012-12-17 11:44:08 +01:00
uniun
55b611d99d
BUG Hardcoded project name in include_by_locale()
...
include_by_locale() should not use hardcoded default project name 'mysite' (fixes #7969 ).
2012-12-14 18:20:18 +02:00
Simon Welsh
683f388d1c
Merge pull request #1036 from howardgrigg/patch-5
...
Corrected link in Form field types docs
2012-12-14 02:15:54 -08:00
Howard Grigg
fbeaa4770a
Corrected link in Form field types docs
2012-12-14 23:13:08 +13:00
Ingo Schommer
4f5b3fa3a6
Readd SQlite to travis builds, having it fail harms TDD
2012-12-14 10:40:40 +01:00
Ingo Schommer
90084bb708
Separate PHPCS run on travis, don't fail whole build for it
2012-12-14 10:20:58 +01:00
Stig Lindqvist
681a0241e7
DOC Removed link to missing 'extending-the-cms.md'
2012-12-14 16:15:22 +13:00
Sam Minnee
244bc97794
Don't register a PGSQL failure as a Travis build failure.
...
Although PGSQL build will still be executed, a failure of that build won't registre as a Travis failure. This is a workaround until the PGSQL build has been fixed.
2012-12-14 14:28:26 +13:00
João Martins
bdc17198e8
tinymce language portuguese is not working
2012-12-14 00:47:32 +00:00
Ingo Schommer
f41f307118
Fixed spacing
2012-12-14 00:09:30 +01:00
Sean Harvey
c23df511cd
Improve class naming and docs for DataList::applyFilterContext()
2012-12-14 12:06:25 +13:00
Ingo Schommer
c6b1d4aa6b
API Storing alternative DB name in cookie rather than session
...
Session is not initialized by the time we need to use
the setting in DB::connect(). Cookie values get initialized
automatically for each request.
Tightened name format validation to ensure it can only
be used for temporary databases, rather than switching
the browser session to a different production database.
Encrypting token for secure cookie usage.
Added dev/generatesecuretoken to generate this token.
Not storing in YML config directly because of web access issues.
2012-12-13 23:21:48 +01:00
Ingo Schommer
7be8a2252f
Merge pull request #1024 from kinglozzer/8051-insert-media-duplicates
...
BUG Fix insert media form inserting images from other UploadFields (#8051 )
2012-12-12 14:25:19 -08:00
Naomi Guyer
92e4b4fc5b
Remove sub navigation for "Files" (fixes 7956)
...
Backport from master. Fixes display issues with expanded,
unselected submenus ... by removing them.
They're strictly not necessary since both "list" and "add"
modes can be reached through the default AssetAdmin UI.
2012-12-12 23:16:03 +01:00
Loz Calver
639cc0222c
BUG Fix insert media form inserting images from other UploadFields ( fixes #8051 )
...
The insert media form would pick up unwanted images from other
UploadFields. Limiting where it is looking to only the closest form
fixes this.
2012-12-12 15:55:33 +00:00
Ingo Schommer
2e9b5e9221
Merge branch 'orm-join-bug' of git://github.com/stojg/sapphire into stojg-orm-join-bug
2012-12-12 15:53:19 +01:00
Ingo Schommer
441bb5f74c
Added travis environment info output
2012-12-12 15:13:26 +01:00
Ingo Schommer
8fdea7a2ab
Merge pull request #1019 from nyeholt/injector_convert_service_params
...
BUG Fixed issue with convertServiceProperty
2012-12-12 01:07:47 -08:00