458 Commits

Author	SHA1	Message	Date
Robbie Averill	79e44b42fa	Merge branch '4.1' into 4.2	2019-02-19 08:37:07 +07:00
Robbie Averill	cb7f15a681	Merge branch '4.0' into 4.1	2019-02-19 08:36:41 +07:00
Robbie Averill	dc9d1b9cc0	FIX GridFieldPrintButton no longer assumes that children of GridField would implement their own print template	2019-01-28 11:45:55 +02:00
Maxime Rainville	db466fb013	MINOR Always cast formfield display value as a string to avoid 0 being blank	2019-01-25 13:34:36 +13:00
Robbie Averill	394dd4765c	NEW Scaffolded field labels now only have an uppercased first word	2019-01-07 17:52:28 +01:00
Kong Jin Jie	1667af8f5e	Add $disabledItems to check for disabled items instead of checking against $defaultItems ... Fixes #8688	2018-12-31 17:25:11 +08:00
Russell Michell	0397c54b5a	FIX: Fixes #8459 ... - Missing conditionals for optional constructor args - Missing calls to FieldList::setForm() - Missing guards around naive calls to Form::Fields()->foo()	2018-12-19 13:28:19 +13:00
Robbie Averill	5d7c5ffb07	Merge branch '4.3' into 4	2018-12-06 09:40:40 +00:00
Robbie Averill	08866f89d9	Merge branch '4.2' into 4.3	2018-12-06 09:40:05 +00:00
Robbie Averill	96bd17d469	Merge branch '4.1' into 4.2	2018-12-06 09:38:45 +00:00
Robbie Averill	3f532466d1	Merge branch '4.0' into 4.1	2018-12-06 09:37:52 +00:00
Guy Marriott	c7b5b1efd2	FIX Switching to use Controller::curr as it was using previously	2018-11-30 15:40:45 +13:00
Guy Marriott	32d096d9e5	DOCS Moving interface subscription to the abstract and adding a changelog entry	2018-11-30 15:40:45 +13:00
Guy Marriott	ddaa22986f	Updating StateStore interface not to define a constructor & fixing GridFieldFilterHeader to add required attributes	2018-11-30 15:40:45 +13:00
Guy Marriott	b4c8f699eb	FIX Provide alternatives to session for storing GridField_FormAction state	2018-11-30 15:40:45 +13:00
Loz Calver	441d079647	Merge pull request #8637 from creative-commoners/pulls/4.4/falsy-detail-component ... FIX getComponentByType can return null - prevent null pointer errors	2018-11-26 18:28:26 +01:00
Robbie Averill	f22a4b980b	FIX getComponentByType can return null - prevent null pointer errors	2018-11-26 16:01:46 +01:00
Robbie Averill	efa427fc45	FIX Remove redundant "rightGroup" logic and increase getRightGroupField to protected	2018-11-26 12:42:47 +01:00
Robbie Averill	1f1c344272	Merge branch '4.3' into 4 ... # Conflicts: # tests/php/Forms/ConfirmedPasswordFieldTest.php	2018-11-26 12:15:17 +01:00
Andre Kiste	1d9e40ba26	Use new plus icon (#8619) ... * Use new plus icon and refactor * MINOR: Add ability to customise the visibility of the `Previous`, `Next` and `Add` buttons at a `GridField` level * - Merge `showPrevious` and `showNext` to `showPagination` for grid fields - Update documentation - Improve performance for next/previous buttons by not fetching all list records - Refactoring * Refactor to fail gracefully on GridFieldPaginator * Fix merge	2018-11-23 12:40:18 +13:00
Serge Latyntcev	9ce6d91b76	FIX / TreeMultiselectField::objectForKey handles list of IDs correctly	2018-11-22 12:11:18 +13:00
Maxime Rainville	d74af1c17e	FIX Explicity mark nodes when searching nodes in TreeDropdownField #8621	2018-11-21 11:43:21 +13:00
Andre Kiste	cc712892a9	NEW Port betterbuttons to framework (#8569) ... * MINOR: Add `Previous`, `Next` and `Create New` actions in edit form If the form is opened via a grid field, the filters will be retained so the previous/next record opened will be correct * MINOR: Add ability to customise the visibility of the `Previous`, `Next` and `Add` buttons at a `GridField` level * Fix invalid action when pressing the `New` button in an edit form unless `betterbuttons` module was installed * - Merge `showPrevious` and `showNext` to `showPagination` for grid fields - Update documentation - Improve performance for next/previous buttons by not fetching all list records - Refactoring * Refactor to fail gracefully on GridFieldPaginator	2018-11-19 11:06:47 +13:00
Serge Latyntcev	15aaf9db9f	Fix a code style typo	2018-11-13 10:20:49 +13:00
Guy Marriott	b2dd22fb50	Merge pull request #8506 from creative-commoners/pulls/4.3/all-the-unit-tests ... NEW Adding a stack more unit tests for logging and some form fields	2018-11-11 10:31:24 +13:00
Loz Calver	bbb208e1dd	Merge pull request #8499 from sminnee/fix-1489 ... FIX: CheckboxSetField can now save into DBMultiEnum	2018-11-09 10:40:55 +01:00
Robbie Averill	24d6527845	Merge branch '4.3' into 4	2018-11-09 11:39:27 +02:00
Serge Latyntcev	4b4fbabed5	FIX TreeMultiselectField passes value 'unchanged' as null to ORM for 'ID' column key	2018-11-08 15:41:46 +13:00
Robbie Averill	358cef0cdf	Merge pull request #8514 from wilr/pulls/lookup-injector ... FIX use Injector for FormField::castedCopy	2018-11-07 19:20:36 +02:00
Robbie Averill	64c2938c96	Merge branch '4.3' into 4	2018-11-06 11:05:22 +01:00
Aaron Carlino	0ba275cb40	Merge branch '4.2' into 4.3	2018-11-06 15:09:01 +13:00
Sam Minnee	76255c9fb5	FIX: CheckboxSetField can now save into DBMultiEnum ... Fixes https://github.com/silverstripe/silverstripe-framework/issues/1489	2018-11-05 17:40:28 +13:00
Luke Edwards	97180c2612	Fix readonly grid state always being truthy (#8562)	2018-11-02 14:28:47 +13:00
Luke Edwards	8866e7674a	BUG: Fix duplicate plugins on HTML editor fields (#8559) ... * BUG: Fix duplicate plugins on HTML editor fields * Add new test	2018-11-02 12:26:53 +13:00
Luke Edwards	c7b8b80e8b	Persist GridField readonly state, add view button (#8535) ... * Persist GridField readonly state, add view button * Minor clarity fixes	2018-11-01 11:12:52 +13:00
Andre Kiste	511c368e8c	Merge pull request #8521 from open-sausages/pulls/4.3/searching-for-legacy ... Add config to force legacy filter header globally	2018-10-29 14:57:21 +13:00
Robbie Averill	b02a6fa02d	FIX Replace usage of Convert JSON methods with json_encode	2018-10-28 21:15:29 +00:00
Luke Edwards	3284bf48d6	Fix search filtering relations and clear filters (#8477)	2018-10-26 14:43:56 +13:00
Luke Edwards	d879148bff	Add config to force legacy filter header globally	2018-10-26 14:28:15 +13:00
Will Rossiter	66a404ad1a	FIX use Injector for FormField::castedCopy ... Allows LookupField to be replaced with user specificed classes.	2018-10-24 12:13:14 +13:00
Maxime Rainville	af46381dca	MINOR Correct implementation of single lookup field when valueToLabel returns null	2018-10-23 11:54:26 +13:00
Robbie Averill	bea4101e21	Add tests for DisabledTransformation, PrintableTransformation and PrintableTransformation_TabSet	2018-10-20 20:06:02 +02:00
Robbie Averill	449b2cf291	Add tests for DefaultFormFactory	2018-10-20 19:47:11 +02:00
Robbie Averill	97209bc919	Add edge case unit tests for DateField	2018-10-20 18:15:42 +02:00
Robbie Averill	c06cf4820e	BUG Readonly and disabled CurrencyFields no longer always returns dollar currency sign, now respect config	2018-10-20 17:47:16 +02:00
Robbie Averill	d56bad7568	Add tests for edge cases in CurrencyField	2018-10-20 17:33:59 +02:00
Robbie Averill	8929b8204f	More validation tests for ConfirmedPasswordField	2018-10-20 17:21:25 +02:00
Robbie Averill	c418ee2915	NEW Add getters and setters for public properties in ConfirmPasswordField, add tests ... Some of the validation parts of ConfirmPasswordField are previously untested, this adds tests	2018-10-20 16:43:49 +02:00
Robbie Averill	60b375d995	Add more tests for CheckboxField_Readonly and CompositeField, improve PHPDocs	2018-10-20 15:44:23 +02:00
bergice	a6a1743997	BUG: Fix ENTER not triggering form save button as GridFields used submit type buttons	2018-10-18 12:37:24 +13:00
Aaron Carlino	57756f38cb	Revert bd6c4fd	2018-10-17 14:54:03 +13:00
Robbie Averill	7215637673	Merge pull request #8460 from open-sausages/pulls/4/lazy-loadable-gidfield ... API Add a new GridFieldLazyLoader component	2018-10-11 13:43:10 +02:00
Loz Calver	dca2d47127	Merge pull request #8357 from creative-commoners/pulls/4.3/fix-i18n ... FIX Text collector translations now compile without errors	2018-10-11 13:16:23 +02:00
Maxime Rainville	250d925810	MINOR Update CompositeField::__construct to call setChildren #8460	2018-10-11 15:25:34 +13:00
Maxime Rainville	98afbfe9b4	Implement Peer review feedback #8460	2018-10-11 14:56:06 +13:00
Maxime Rainville	ef439f9306	MINOR Correct GridField_DataManipulator PHPDOC to not assume DataList ... Tweak GridField_DataManipulator to not assume only DataList will be provided. Use the SS_List Interface instead. (#8460)	2018-10-11 12:06:21 +13:00
Maxime Rainville	2e2ca5a4a7	Make sure LazyLoader still woks after a readonly transofrmation (#8460)	2018-10-11 11:56:39 +13:00
Robbie Averill	bd6c4fdda0	Merge pull request #8440 from creative-commoners/pulls/4.3/its-indestruc-tab-le ... NEW TabSet react component is no longer structural	2018-10-09 22:05:53 +02:00
Robbie Averill	d1281a571a	FIX Escape HTML in PHPDoc to fix API docs from rendering incorrectly	2018-10-09 10:46:45 +02:00
Maxime Rainville	fdb53311ba	Fix linting issue.	2018-10-09 17:32:42 +13:00
Maxime Rainville	bfb6518176	Tweak the logic to empty lazy list.	2018-10-09 17:32:42 +13:00
Maxime Rainville	d2a51471e9	Don't lazy load tab that are not in a TabSet.	2018-10-09 17:32:42 +13:00
Maxime Rainville	5276b6cbb1	API Add FieldList::getContainerField	2018-10-09 17:32:42 +13:00
Maxime Rainville	bdb53979aa	API Create a new GridFieldLazyLoader GridField component	2018-10-09 17:32:42 +13:00
Sam Minnee	e5d3b28a4d	FIX: Don’t break validation on selects without a source. ... Fixes cases where there are no valid values or an empty-string value is manually added rather than using setEmptyString() Fixes #4849 Fixes #7159	2018-10-06 11:53:17 +13:00
Robbie Averill	ee24413c30	Merge branch '4.2' into 4	2018-10-03 15:28:05 +02:00
Robbie Averill	d74fed554a	Merge pull request #8427 from sminnee/fix-1397 ... FIX: Append any fields that don’t match name in insertBefore/insertAfter	2018-10-03 13:22:23 +02:00
Robbie Averill	6a5fb4999c	Merge pull request #8416 from lekoala/patch-14 ... raw2att accepts array, but sprintf doesn't	2018-10-03 13:21:43 +02:00
Raissa North	90afb2037a	NEW TabSet react component is no longer structural	2018-10-03 16:36:17 +13:00
Robbie Averill	cb2b9498fb	API Deprecate updateSearchContextCallback and updateSearchFormCallback	2018-10-03 13:47:40 +13:00
Luke Edwards	bf60a699a5	Add extension points for ModelAdmin search API	2018-10-03 13:47:40 +13:00
Robbie Averill	c8e7672ede	Merge pull request #8414 from creative-commoners/pulls/4/searching-for-a-name-conflict ... FIX Avoid having search fields with the same names as form elements	2018-10-02 13:43:59 +02:00
Sam Minnee	71dad5f685	FIX: Append any fields that don’t match name in insertBefore/insertAfter ... Previous behaviour was to return false, which has been described as a confusing bug on https://github.com/silverstripe/silverstripe-framework/issues/1397 where the issue was identified.	2018-10-02 10:39:48 +13:00
Maxime Rainville	755907d117	Merge pull request #8409 from open-sausages/pulls/4/treedropdown-caching ... MINOR Add caching to the TreeDropdownField tree action	2018-10-01 13:56:21 +13:00
Guy Marriott	c503dbd634	Prefixing search filters for the React search form context	2018-10-01 13:38:32 +13:00
Maxime Rainville	13c89d0ed0	Add a comment and only apply caching if using the standard NumChildrenMethod	2018-10-01 11:29:51 +13:00
Robbie Averill	f842ee2eec	Update deprecation PHPDocs to be PSR-5 compliant ... See: https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#55-deprecated	2018-09-28 10:49:14 +02:00
Thomas Portelange	fdd5acff5d	raw2att accepts array, but sprintf doesn't ... it's not very likely to happen (it did in my case :-) ) but if the value is an array, sprintf will fail (because raw2att accepts array, but sprintf doesn't). i suggest to json encode any array data to ensure it's safely included in the html. Or we should throw proper exceptions to make sure invalid values do not result in a php error.	2018-09-27 12:12:59 +02:00
Guy Marriott	c54e7317d2	FIX Avoid having search fields with the same names as form elements	2018-09-27 17:39:50 +12:00
Thomas Portelange	f103648f8c	value can be something else than a string ... if the value is not a string (an array for instance), sprintf will fail	2018-09-26 11:35:40 +02:00
Maxime Rainville	77339b7e75	MINOR Add caching to the TreeDropdownField tree action	2018-09-26 17:24:06 +12:00
Robbie Averill	0276f6c089	FIX Revert semver break in adding GridField type hint to method signature	2018-09-24 13:39:33 +02:00
Andre Kiste	e8fd49b394	Merge pull request #8381 from open-sausages/pulls/4.2/sort-out-your-field ... BUG Changes being detected on TreeMulti as values not sorted	2018-09-21 16:38:56 +12:00
Luke Edwards	4ac4cdc91b	Merge pull request #8348 from caffeineinc/bugfix/3357 ... BUG Add GridField Readonly Transformation (#3357)	2018-09-21 14:54:37 +12:00
Luke Edwards	3fc49dd4ce	Lint fixes and allow a few other components by default	2018-09-20 13:32:52 +12:00
Luke Edwards	db63f55fbb	BUG Changes being detected on TreeMulti as values not sorted	2018-09-18 13:24:55 +12:00
Raissa North	588bf83e12	NEW Add hideNav flag to schema defaults	2018-09-18 10:45:36 +12:00
Luke Edwards	a33866ff4c	Merge pull request #8353 from open-sausages/pulls/4.2/2227-show-link-tracking ... API: Add Link Tracking section to Relations developer guide	2018-09-13 14:23:34 +12:00
bergice	01db5c9e98	API: Add Link Tracking section to Relations developer guide and describe show_sitetree_link_tracking, show_file_link_tracking. ... Refactor form scaffolder.	2018-09-13 11:02:09 +12:00
Robbie Averill	b555bb83b8	Merge pull request #8359 from creative-commoners/pulls/4/HTMLEditorSchema ... Add schema information for HTMLEditorField	2018-09-10 09:53:12 +02:00
Robbie Averill	373a8afeb5	Merge branch '4.2' into 4	2018-09-06 13:26:46 +02:00
Dylan Wagstaff	f13ee4486d	Add schema information for HTMLEditorField ... This allows React form builders (or other such view layer builders in a headless environment) to obtain the details that would otherwise only be rendered in a PHP side template. Some of the details are critical for rendering correctly, and are necessary to be passed through - particularly when moving toward replacing the Entwine initiator for TinyMCE with a React component in `silverstripe/admin`. I new interface method has been added to the abstract class for HTML editor configs in order to facilitate this. It is not itself abstract as this would break backwards compatiblity with any existing custom config (aside from the TinyMCE one which we're editing here), which is most certainly not what we want.	2018-09-06 14:35:11 +12:00
Maxime Rainville	cc22024e9a	ADD New search component for GridFields (#1777)	2018-09-04 11:35:17 +12:00
Robbie Averill	2254459310	FIX Text collector translations now compile without errors	2018-09-03 08:21:05 +02:00
Robbie Averill	94f5d32f41	Merge pull request #8351 from open-sausages/pulls/4.2/move-to-your-other-left ... BUG Use classes for TinyMCE alignment buttons	2018-08-31 10:18:03 +12:00
Luke Edwards	234b795f89	BUG Use classes for TinyMCE alignment buttons	2018-08-31 09:02:17 +12:00
Simon Gow	4c3a068859	Issue 3357 - Add GridField Readonly Transformation ... GridField doesn't have a valid readonly state if it's value is set to an Object without `forTemplate()`. The default behaviour is to render a ReadonlyField, but given GridField is a complex type this isn't suitable. This bugfix provides a transformation method to render only components that are whitelisted to provide a readonly state. @see #3357 - https://github.com/silverstripe/silverstripe-framework/issues/3357	2018-08-29 14:47:06 +12:00
Robbie Averill	83e461abbf	Merge branch '4.2' into 4	2018-08-27 16:15:57 +12:00
Robbie Averill	a87165c299	Merge pull request #8326 from creative-commoners/pulls/4.2/remove-double-encoding ... FIX Remove double escaping of HTML values in print views	2018-08-27 13:37:32 +12:00
Luke Edwards	6164d01d65	FIX GridField delete button to offer archive action if possible (#8325) ... * FIX GridField delete button to offer archive action if possible * Refactor archive action to versioned module * Fix GridFieldDeleteAction test	2018-08-24 13:13:32 +12:00