Guy Sartorelli
862a65eacc
MNT Fix unit tests ( #11409 )
2024-09-30 18:32:17 +13:00
Guy Sartorelli
de515d3bbf
MNT Resolve deprecation warnings in tests ( #11364 )
2024-09-11 12:16:59 +12:00
Guy Sartorelli
9e6ecde87c
Merge pull request #11334 from creative-commoners/pulls/5.2/analyze-table
...
FIX Run ANALYZE TABLE before fetching table stats
2024-08-15 09:00:55 +12:00
Steve Boyd
25a41de8b5
FIX Run ANALYZE TABLE before fetching table stats
2024-08-14 15:16:23 +12:00
Guy Sartorelli
7b91207c12
FIX Don't error if template global is null ( #11331 )
2024-08-09 09:27:38 +12:00
Guy Sartorelli
f93c9a9a34
Merge pull request #11321 from creative-commoners/pulls/5.2/normalise-external
...
FIX Do not suffix trailing slash to external links
2024-08-07 12:51:33 +12:00
Steve Boyd
8c80a4fd1e
FIX Do not suffix trailing slash to external links
2024-08-07 10:38:25 +12:00
Guy Sartorelli
3a36665da7
Merge pull request #11319 from creative-commoners/pulls/5.2/clear-table
...
FIX Clear table logic for MySQL 8
2024-08-06 16:17:00 +12:00
Guy Sartorelli
485bbc2774
MNT Ignore phpstan errors we can't fix. ( #11326 )
2024-08-06 16:09:11 +12:00
Guy Sartorelli
9fae48bbd7
FIX Allow clearing lazyloaded SearchableDropdownField. ( #11324 )
2024-08-06 15:35:36 +12:00
Steve Boyd
c3f0104a89
FIX Clear table logic for MySQL 8
2024-08-06 15:20:43 +12:00
Guy Sartorelli
a8d0d1ef58
TLN Update translations ( #11323 )
2024-08-06 12:41:30 +12:00
Guy Sartorelli
1ac3428466
MNT Run module-standardiser ( #11317 )
2024-08-01 18:30:36 +12:00
Guy Sartorelli
7c27e9dfb4
Merge pull request #11312 from archiprocode/pulls/5.2/sqlselect-from-alias
...
FIX Don't generate table alias for "from" statement that are not column names
2024-07-30 09:32:52 +12:00
Maxime Rainville
f91b279ef0
FIX Don't generate table alias for "from" statement that are not column names.
2024-07-30 08:36:27 +12:00
Guy Sartorelli
d9bccaff3d
ENH Don't use keywords self ( #11313 )
2024-07-29 16:53:22 +12:00
Guy Sartorelli
4693e3f378
Merge pull request #11309 from creative-commoners/pulls/5.2/clear-table
...
FIX Truncate table to clear table
2024-07-22 09:03:07 +12:00
Steve Boyd
539d4645b9
FIX Truncate table to clear table
2024-07-19 21:13:34 +12:00
Guy Sartorelli
b6e347ef3d
Merge pull request #11308 from creative-commoners/pulls/5.2/ss-2024-001
...
[SS-2024-001] Set convert_unsafe_embeds to true
2024-07-17 11:38:17 +12:00
Guy Sartorelli
ff6ab16871
Merge pull request #11307 from creative-commoners/pulls/5.2/cve-2024-32981
...
[CVE-2024-32981] Disallow `data:text/html` in data attributes
2024-07-17 11:37:13 +12:00
Guy Sartorelli
b8d20dc9d5
[CVE-2024-32981] Disallow data:text/html
in data attributes
2024-07-17 11:04:27 +12:00
Steve Boyd
60155dad41
[SS-2024-001] Set convert_unsafe_embeds to true
2024-07-17 10:56:18 +12:00
Guy Sartorelli
c13ec34113
FIX Don't strip <header>
tag from HTMLValue
( #11302 )
2024-07-09 13:18:29 +12:00
Johannes Hammersen
1943f9d417
FIX DBForeignKey scaffolding missing parameter ( #11295 )
...
Co-authored-by: johannes.hammersen <Johannes.Hammersen@funkemedien.de>
2024-07-03 14:23:25 +12:00
Guy Sartorelli
e677b12202
Merge pull request #11287 from johannesx75/fix-remove-write-from-SearchableDropdownTrait
...
FIX remove write from SearchableDropdownTrait
2024-06-26 13:09:32 +12:00
Guy Sartorelli
23c1a0f849
MNT Run module-standardiser ( #11283 )
2024-06-20 12:16:30 +12:00
johannes.hammersen
ce5cfcac61
FIX Remove write from SearchableDropdownTrait
...
In the SearchableDropdownTrait::saveInto method, if the field is a has_one relationship, $record->write() was called. FormField and any other instances of saveInto should not call write - that should be called by the form itself.
2024-06-19 11:13:54 +02:00
Guy Sartorelli
27873939f4
Merge pull request #11270 from creative-commoners/pulls/5.2/remove-self
...
ENH Use class name instead of self
2024-06-18 14:40:44 +12:00
Steve Boyd
620c1b0469
ENH Use class name instead of self
2024-06-18 09:37:39 +12:00
Guy Sartorelli
1e0b9056f5
FIX Don't load data up front for lazy-loaded searchable dropdown ( #11278 )
2024-06-17 11:59:59 +12:00
Mason Dechaineux
9546450cf2
improve DataList and ArrayList docblock comments for PHPStorm ( #11263 )
...
addresses #11247
2024-05-31 10:59:04 +12:00
Sabina Talipova
f0aaba5504
FIX HTMLEditorField is not able to show html or xml code examples ( #11243 )
2024-05-22 09:39:36 +12:00
Hernold Koch
470293a6d2
FIX 'which' check in 'sake' now works for aliases ( #11232 )
2024-05-20 11:04:44 +12:00
Guy Sartorelli
50a0018363
FIX many_many through should allow subclasses ( #11230 )
...
```php
class HomePage extends Page
{
private static $many_many = [
'HeroImages' => [
'through' => PageImageLink::class,
'from' => 'Page',
'to' => 'Image',
]
];
}
```
```php
class PageImageLink extends DataObject
{
private static $has_one = [
'Page' => SiteTree::class,
'Image' => Image::class,
];
}
This fails because the linking object's relation class doesn't exactly match the owner. Sharing the linking objects across various entries in the ancestry should be a supported use case.
Co-authored-by: Aaron Carlino <unclecheese@leftandmain.com>
2024-05-13 14:15:37 +12:00
Dominik Beerbohm
0f6d210602
FIX Correctly eagerload polymorphic has_one relations ( #11204 )
2024-05-08 11:12:51 +12:00
Guy Sartorelli
241d03b352
TLN Update translations ( #11224 )
2024-05-08 09:31:04 +12:00
Guy Sartorelli
a198c91628
FIX Don't throw exception for empty eagerloaded relation ( #11220 )
2024-05-06 18:06:54 +12:00
Guy Sartorelli
a92baeaf6f
FIX Allow double dots in path when not attempting directory traversal ( #11219 )
2024-05-06 13:15:26 +12:00
Thomas Portelange
44f77ecdac
MNT add nullable return types to PHPDocs ( #11192 )
2024-04-29 09:02:59 +12:00
Guy Sartorelli
cfeb678816
Merge pull request #11185 from beerbohmdo/fix/issue-11170
...
FIX Ensure eagerLoading don't load has_one twice (#11170 )
2024-04-18 13:40:53 +12:00
Dominik Beerbohm
135f9c6d30
FIX Ensure eagerLoading don't load has_one twice ( #11170 )
2024-04-18 13:27:50 +12:00
Guy Sartorelli
908bdcfc31
Merge pull request #11199 from kinglozzer/11197-oob-exception
...
FIX: OutOfBoundsException when recipe-core isn't installed (fixes #11197 )
2024-04-16 13:32:21 +12:00
Loz Calver
a53301f673
FIX: OutOfBoundsException when recipe-core isn't installed ( fixes #11197 )
2024-04-15 16:59:59 +01:00
Guy Sartorelli
6743de4356
FIX Remove ambiguity for polymorphic queries ( #11195 )
2024-04-12 09:40:34 +12:00
github-actions
97a8da8c7d
Merge branch '5.1' into 5.2
2024-04-03 05:54:35 +00:00
Thomas Portelange
cca2f7059b
ENH Update PHPDocs for methods with missing nullable return types ( #11187 )
2024-04-02 13:33:09 +13:00
github-actions
74abb03133
Merge branch '5.1' into 5.2
2024-03-22 08:36:08 +00:00
Guy Sartorelli
8aab888d50
FIX Fix link for managing roles ( #11178 )
2024-03-21 12:49:10 +13:00
github-actions
90298002a4
Merge branch '5.1' into 5.2
2024-03-19 23:26:25 +00:00
Guy Sartorelli
e68af4de40
Merge branch '4' into 5.1
2024-03-20 12:15:22 +13:00