Commit Graph

16961 Commits

Author SHA1 Message Date
Paul Clarke
82eea479e8 Adjust tab height (was a mix of 2px and 3px) 2016-09-14 14:09:02 +12:00
Christopher Joe
190ed628bc API PreviewThumbnail now uses ScaleMaxWidth
This will mean that if a thumbnail image is smaller than the preview_width defined, then it will no longer get blown up to the defined size.
2016-09-14 14:09:01 +12:00
Christopher Joe
ee5b4fd8d3 Tabs support in new file/image editor
Introducing <Tabs> component based on react-bootstrap
Better support for nested fields in FormBuilder
Tweaks to get FormBuilder working with frameworktest BasicFieldsPage fields
Added exception in FormBuilder when Component is defined but not found
Added check in SingleSelectField for empty value before adding one in
Added temporary workaround for CompositeFields with no name (another story to address the actual problem)
Added asset_preview_height for File image preview, matches the defined CSS max-height
Added documentation to DBFile::PreviewLink() method
2016-09-14 14:08:59 +12:00
Paul
955d75b219 Insert media into TinyMCE modal, styling fixes and improvements (#5967)
* Remove interference of nested for__fieldgroup-item

* Adjust position of dropdown field

* Remove divider lines, adjust position of upload area

Clean up styles a bit too

* Adjust position of image

* Mostly css tidy up, added use of a few variables

* Toggle arrow was showing other icon because of icon height

* All buttons in toolbars remove margin below, adjust button link color

* Reorder sort and filter, add toolbar styles

* Add button styles to toolbar

* Remove some of the linting issues

* Added new panel variables

* Simplify variable

* Replace panel variable, insert media dialog positioning

* Update with new variable name, reduce space below toolbar

* Build

* Uploading file spacing, toolbar styles added

* Visual uploads, error upload fixes, edit details panel spacing

* Add toolbar to upload modal

* build

* Build

* increase width of pagination on gridfield

* Add height to uploading items only

* Build

* Added class back for beat test to pass
2016-09-14 13:48:33 +12:00
Daniel Hensby
60250903cb Merge pull request #5994 from open-sausages/pulls/4.0/preview-panel
API Move preview panel to CMS module
2016-09-13 15:11:57 +01:00
Damian Mooyman
9b1c24cf4c API Move preview panel to CMS module
BUG Fix preview area flashing on section navigation
Fix source file issue
2016-09-13 13:20:17 +12:00
Ingo Schommer
7bc6f3ee9f Enforce JS var declaration with value (#5993)
This caught us out recently where code did a strict type check for `myVar === undefined`.
The var was defined as `let myVar;`, without a value - so the check returned false (it's `null`).
To avoid this situation, we've decided to enforce declarations with values.
Note that preference should be given to single, immutable assignments via const where possible.

See http://eslint.org/docs/rules/init-declarations
2016-09-13 11:02:15 +12:00
Daniel Hensby
8b8996f4a4 Merge pull request #5985 from open-sausages/pulls/4.0/codeclimate-better-excludes
Improved CodeClimate excludes
2016-09-12 09:46:04 +01:00
Ingo Schommer
778b821797 Improved CodeClimate excludes
Exclude lang folders, make other includes less verbose
by using globs, see https://docs.codeclimate.com/docs/excluding-files-and-folders
2016-09-12 18:55:47 +12:00
Ingo Schommer
1c021bd3e4 Merge pull request #5982 from pandauxstudio/patch-1
Update 01_Error_Handling.md
2016-09-12 18:35:49 +12:00
Daniel Hensby
3f92767512 Merge pull request #5979 from open-sausages/pulls/4.0/groupeddropdown-include-ns
Fix GroupedDropdownField include namespace
2016-09-12 00:54:42 +01:00
Zaid Al-Dabbagh
d0aa0cb911 Update 01_Error_Handling.md
Indentation error causes yaml parsing error.
2016-09-12 10:51:30 +12:00
Ingo Schommer
90e2f56a22 Merge pull request #5977 from sminnee/remove-manual-includes
FIX: Remove unnecessary manual includes
2016-09-10 15:13:56 +12:00
Ingo Schommer
68c6137f29 Fix GroupedDropdownField include namespace
Follow up from https://github.com/silverstripe/silverstripe-framework/pull/5921
2016-09-10 15:05:45 +12:00
Sam Minnee
5a786624aa FIX: Remove unnecessary manual includes
Core.php can rely on composer’s autoloader now that classes are PSR-4
compliant.

If you stuck to the core modules, you could even remove ClassLoader’s
autoloader, but this would break any module that hasn’t been updated
to support PSR-4, so I’ve left it in.

In the future, it would be good to apply SilverStripe’s auto-loader
only to those modules that aren’t coded to use PSR-4, as it would
make class loading more predictable.
2016-09-10 11:13:23 +12:00
Damian Mooyman
bfd9cb1aca Rename SS_ prefixed classes (#5974) 2016-09-09 18:43:05 +12:00
Damian Mooyman
f5d71dc8ec Merge pull request #5975 from silverstripe/pulls/4.0/clarify-upgrader-docs
Clarify upgrader docs
2016-09-09 14:21:13 +12:00
Ingo Schommer
01fdb7949f Clarify upgrader docs 2016-09-09 13:54:54 +12:00
Ingo Schommer
484b6f6c62 Merge pull request #5968 from open-sausages/pulls/4.0/upgrade-guide
Restructure 4.0.0.md
2016-09-09 13:35:07 +12:00
Ingo Schommer
97c2baedeb Less verbosity in upgrading guide 2016-09-09 13:33:52 +12:00
Damian Mooyman
fe5925726e
Restructure 4.0.0.md 2016-09-09 13:16:09 +12:00
Daniel Hensby
1b6242ac64 Merge pull request #5970 from open-sausages/pulls/4.0/fix-folder-validate
BUG Fix issue with Folder::validate() failing on allowed_extensions
2016-09-08 11:44:31 +01:00
Daniel Hensby
a5494504ff Merge pull request #5971 from open-sausages/pulls/4.0/core-include
BUG fix core include
2016-09-08 09:47:58 +01:00
Damian Mooyman
d4de776a45 BUG fix core include 2016-09-08 19:19:32 +12:00
Damian Mooyman
d2229ce8a6 BUG Fix issue with Folder::validate() failing on allowed_extensions 2016-09-08 18:07:34 +12:00
Ingo Schommer
8f26908b3b Merge pull request #5969 from open-sausages/pulls/4.0/fix-case
Fix case of required paths
2016-09-08 17:58:58 +12:00
Damian Mooyman
eaac957248
Fix case of required paths 2016-09-08 17:53:44 +12:00
Ingo Schommer
15d62fe788 Merge pull request #5921 from open-sausages/pulls/4.0/namespace-everything
API Apply all SilverStripe namespaces to framework
2016-09-08 17:44:20 +12:00
Damian Mooyman
77d1677304
Fix issue with core/Core.php includes
Fix PHP 5.5 compatibility issue
2016-09-08 16:31:02 +12:00
Damian Mooyman
8dd644d25d
API Namespace all classes
Namespace all templates
Move difflib and BBCodeParser2 to thirdparty
Remove deprecated API marked for removal in 4.0
2016-09-08 10:23:17 +12:00
Daniel Hensby
918fb94396
Merge branch '3' 2016-09-07 09:31:23 +01:00
Daniel Hensby
3fd9fe3aa0
Merge branch '3.4' into 3 2016-09-07 09:22:06 +01:00
Daniel Hensby
5959419645
Merge branch '3.3' into 3.4 2016-09-07 09:21:50 +01:00
Daniel Hensby
b80dc6450a
Merge branch '3.2' into 3.3 2016-09-07 09:21:21 +01:00
Damian Mooyman
9455ced41a Merge pull request #5959 from dhensby/pulls/3.2/bad-strpos-fix
FIX Bad strpos call in HTTP::register_etag()
2016-09-07 12:05:57 +12:00
Daniel Hensby
e7ecf6cf15
FIX Bad strpos call in HTTP::register_etag() 2016-09-06 23:32:57 +01:00
Ingo Schommer
a45657b369 Merge pull request #5942 from open-sausages/pulls/4.0/react-15
Update to React v15.0 and react-bootstrap fork
2016-09-06 21:40:54 +12:00
Ingo Schommer
65718770d6 Update to React v15.0 2016-09-06 21:39:20 +12:00
Ingo Schommer
0cc91d3b38 Use react-bootstrap-ss fork
The react-bootstrap project won't update their codebase for TWBS4 compat
until they're out of alpha (https://github.com/react-bootstrap/react-bootstrap/issues/1187).
So we have to work in a fork for the meantime.
2016-09-06 21:36:58 +12:00
Ingo Schommer
b14804fc2d Merge pull request #5958 from open-sausages/pulls/4.0/react-button-loading-indicator
Fix button loading indicator
2016-09-06 21:15:05 +12:00
Ingo Schommer
57d885f406 Updated dist files 2016-09-06 20:40:20 +12:00
Ingo Schommer
f7f1cf0e87 Fix SingleSelectField readonly view 2016-09-06 20:40:14 +12:00
Ingo Schommer
1d3aaf368e Popover docs 2016-09-06 20:39:41 +12:00
Ingo Schommer
b53ce4c190 FIX Button loading indicator
See silverstripe/silverstripe-framework#5941
2016-09-06 20:39:32 +12:00
Ingo Schommer
3b71b7731a Merge pull request #5943 from open-sausages/pulls/4.0/template-lookup-redux
API Update template lookup to late resolution for performance reasons
2016-09-06 20:27:11 +12:00
Daniel Hensby
10f429d8d8 Merge pull request #5950 from open-sausages/pulls/4.0/change-class-cleanup
API use injector for DataObject::newClassInstance()
2016-09-06 07:53:51 +01:00
Damian Mooyman
efb004b72a
API use injector for DataObject::newClassInstance()
API Fail on invalid class type change
2016-09-06 14:10:51 +12:00
Damian Mooyman
c9b6e9bac0
API Update template lookup to late resolution for performance reasons
API Update behaviour of form fields to use standard template lookup mechanism
API Support custom "type" parameter to template lookup
2016-09-06 12:54:03 +12:00
Daniel Hensby
2fbd1658dd Merge pull request #5949 from open-sausages/pulls/4.0/document-iconv
Document iconv a bit better
2016-09-06 00:00:29 +01:00
Ingo Schommer
f40ed07dec Merge pull request #5940 from open-sausages/pulls/4.0/filter-updates
API Change behaviour of filter API to support injected search filter classes
2016-09-06 08:01:37 +12:00