Commit Graph

21303 Commits

Author SHA1 Message Date
Guy Marriott
80ca7c2531 Commenting the PR template so it's not included in PR messages by default (#8967)
This works as Markdown is just augmented raw HTML
2019-05-13 15:49:07 +12:00
Robbie Averill
eaace98629
Merge pull request #8975 from aNickzz/patch-1
Swap argument order for implode
2019-05-11 09:47:49 +12:00
aNickzz
28be2b2263
Swap argument order for implode
I noticed this squiggly red line while perusing the code.

The PHP doc says
`implode ( string $glue , array $pieces ) : string`
> implode() can, for historical reasons, accept its parameters in either order. For consistency with explode(), however, it may be less confusing to use the documented order of arguments.
2019-05-11 00:32:23 +09:30
Robbie Averill
89a7707c33
Merge pull request #8972 from kalicki2k/patch-2
Update 00_Configuration.md
2019-05-09 22:38:22 +12:00
Sebastian Kalicki
e83edf7e94
Update 00_Configuration.md 2019-05-09 11:28:11 +02:00
Robbie Averill
f0ab53733c
Merge pull request #8969 from vinstah/patch-1
Update docs for GridField_ActionMenuItem required parameters
2019-05-09 09:03:26 +12:00
Vinnie
168a4fe489
Update docs for GridField_ActionMenuItem required parameters
I found these errors while going through this tutorial,
missing ```use use SilverStripe\Forms\GridField\GridField;```

interface GridField_ActionMenuItem required parameters on  getTitle() and getGroup()

incorrect if statement on getExtraData() - $field is not defined
2019-05-09 09:01:54 +12:00
Aaron Carlino
2bdf1eac0a Merge branch '4.4' into 4 2019-05-06 16:03:35 +12:00
Aaron Carlino
ba15972d5c Added 4.4.0-rc1 changelog 2019-05-06 15:36:07 +12:00
Aaron Carlino
fc63ac8fed Update translations 2019-05-06 14:57:47 +12:00
Guy Marriott
856e841955 FIX Ensuring pagination buttons have a consistent state to work off of (#8957) 2019-05-06 14:42:25 +12:00
Guy Marriott
371588e8b1
Merge pull request #8961 from indygriffiths/patch-1
NEW Only get an authenticator if it's an object
2019-05-06 14:27:18 +12:00
Maxime Rainville
8ee50d2ba7 API Remove DataObjectSchema::getFieldMap() (#8960)
Introduced as a less public API in https://github.com/silverstripe/silverstripe-assets/pull/227
2019-05-06 12:33:23 +12:00
Robbie Averill
feafd4239e Merge branch '4.4' into 4 2019-05-06 10:21:30 +12:00
Indy Griffiths
5dc57518c2
NEW Filter out authenticators that are falsy
Use-case: if a module is defining its own authenticator and you want to disable it, as it seems we don't have `unregister_authenticator()` anymore and I can't spot how to remove YAML-based injected properties, then this lets you mark it as null or false to prevent it from erroring out when it attempts to call `supportedServices()`
2019-05-04 20:58:48 +12:00
Maxime Rainville
692295d48f
Merge pull request #8964 from open-sausages/pulls/4.4/tweak-dot-upgrade-yml
BUG Rewrite deprecation notice for declared_permissions
2019-05-03 19:13:44 +12:00
Maxime Rainville
2a91b777c6 BUG Rewrite deprecation notice for declared_permissions 2019-05-03 19:02:19 +12:00
Robbie Averill
5337e6d048 API Replace FormActions with anchors to enable panel-based loading in GridField navigation buttons (#8953)
* FIX Add accessibility labels and titles to previous, next, and add new buttons in GridFields

* API Replace FormActions with anchors to enable panel-based loading in GridField navigation buttons

* FIX Previous and Next links are now correctly disabled when end of lists are reached

* Add English translations
2019-05-03 15:03:59 +12:00
Guy Marriott
ed7aaff7da
Merge branch '4.4' into 4 2019-05-03 09:47:13 +12:00
Guy Marriott
82c8225502
Merge branch '4.3' into 4.4 2019-05-03 09:45:25 +12:00
Guy Marriott
e7bb508391
Merge pull request #8956 from open-sausages/pulls/4.3/custom-aliases-to-be
Backward compatible behaviour for SQLConditionalExpression::getJoins
2019-05-03 09:40:25 +12:00
Ingo Schommer
1f78e8ae80 NEW Clean up secureassets module artefacts (#8948)
See https://github.com/silverstripe/silverstripe-assets/issues/231
2019-05-02 21:05:19 +12:00
Andre Kiste
48db515fbd NEW Fix folder permissions (#8950)
* Add `FixFilePermissionsHelper` subtask
* Changed name to folder permissions, added more loggin
2019-05-02 16:28:57 +12:00
Serge Latyntcev
3d777cfb8a Backward compatible behaviour for SQLConditionalExpression::getJoins 2019-05-02 15:39:36 +12:00
Ingo Schommer
0696045e59 NEW Legacy thumbnail migration task (#8924)
* NEW Legacy thumbnail migration task

See https://github.com/silverstripe/silverstripe-assets/issues/235
Makes a start at https://github.com/silverstripe/silverstripe-assets/issues/219 as well

* API Removed migrate_legacy_file support

For the vast majority of sites, you really don't want to run your file migration as part of dev build.
The step is involved enough to warrant it's own task.
I don't think this is an API change, since the setting won't have affect
for anyone who has already enabled it - they would've already done the one-off migration.

See https://github.com/silverstripeltd/open-sourcerers/issues/91
and https://github.com/silverstripe/silverstripe-assets/issues/235
2019-05-02 09:33:53 +12:00
Robbie Averill
6b8f0eae30
Merge pull request #8952 from creative-commoners/pulls/4.4/hide-better-buttons-without-paginator
FIX Don't add "better buttons" previous and next without a paginator
2019-05-01 16:07:31 +12:00
Guy Marriott
ecfe039e72
FIX Don't add "better buttons" previous and next without a paginator 2019-05-01 15:48:03 +12:00
Ingo Schommer
2e5c7b9f2d Merge remote-tracking branch 'origin/4.4' into 4 2019-04-30 13:34:27 +12:00
Sam Minnée
2c09c83899 DOC: Add breakdown of PHP support by version (#8947)
Currently, this information requires that you open different pages and blogposts and and compare the information yourself.
This is more helpful.
2019-04-30 13:07:15 +12:00
Andre Kiste
0c6c57f1ef Add getFieldMap method to retrieve a list of all fields for any giv… (#8892)
* Add `getFieldMap` method to retrieve a list of all fields for any given class

* Add `TagsToShortcodeTask` to upgrading guide

Adding after the file migration part as this is where it makes the most sense to run it.

* `getFieldMap` accepts an array

* Move to `DataObjectSchema`

* Add `HTMLVarchar` to documentation
Minor refactoring

* Add test for checking that `subclassesfor` works without the base class
Add test `DataObjectSchema::getFieldMap` returns the correct array

* Remove cms dependency
2019-04-30 10:43:14 +12:00
Adrian Humphreys
e648fd31f9 Docs: Update Dynamic_Default_Fields.md (#8941) 2019-04-30 09:00:09 +12:00
Garion Herman
5c4367f46b Use environment variables in example SMTP config
Currently the email documentation provides an example of how to use the SMTP adapter in SwiftMailer, but this example hardcodes the password in the config file which is a security issue. It is possible to reference environment variables instead, so we should document and encourage this.
2019-04-30 08:59:54 +12:00
Adrian Humphreys
212a99c904 Add info around namespacing with controllers 2019-04-30 08:59:29 +12:00
Ingo Schommer
da91f44c00 DOCS File migration changes for 4.4.0 (#8910)
* DOCS File migration changes for 4.4.0

See https://github.com/silverstripe/silverstripe-versioned/issues/177

* Update docs/en/02_Developer_Guides/14_Files/03_File_Security.md

Co-Authored-By: chillu <ingo@silverstripe.com>

* Corrected statements on archived/versioned files

* Corrected statement on filesystem paths of protected vs. public

* Update docs/en/02_Developer_Guides/14_Files/03_File_Security.md

Co-Authored-By: chillu <ingo@silverstripe.com>

* Clarify redirect behaviour
2019-04-30 08:59:25 +12:00
Matt Peel
a61cb1de99 Fix reference to webconfig.php, an invalid file
The upgrading docs reference webconfig.php, which is incorrect and has never existed. I presume the docs mean to reference web.config, which is the IIS configuration file.

I've also fixed a couple of minor spelling mistakes and mentioned Apache for htaccess and IIS for web.config so people know what they're for.

[ci skip]
2019-04-30 08:55:03 +12:00
Andre Kiste
2bcf8b5ff3 More verbose file migration logging
See https://github.com/silverstripeltd/open-sourcerers/issues/91

* Add `PreformattedEchoHandler`

cherry-picked from 4c3f3e6bea99b46b689e5b23d1bd1498a4ac696c

* Batch log messages for every 100 file.
Also make logger work for stdout

* Update src/Logging/PreformattedEchoHandler.php

Co-Authored-By: bergice <bergice@users.noreply.github.com>
2019-04-30 08:54:48 +12:00
Maxime Rainville
e95dde8f1e DOC Update change log to reference updated migration task (#8945)
* DOC Update change log to reference updated migration task

* Update docs/en/04_Changelogs/4.4.0.md
2019-04-30 08:50:33 +12:00
Maxime Rainville
54cb591f54 DOC Update change log to reference updated migration task (#8945)
* DOC Update change log to reference updated migration task

* Update docs/en/04_Changelogs/4.4.0.md
2019-04-30 08:45:29 +12:00
Adrian Humphreys
4155b9f483 Docs: Update Dynamic_Default_Fields.md (#8941) 2019-04-29 10:21:13 +12:00
Robbie Averill
6d271f0a18
Merge pull request #8943 from Cheddam/patch-1
DOCS: Use environment variables in example SMTP config
2019-04-29 10:00:20 +12:00
Garion Herman
cb37172947
Use environment variables in example SMTP config
Currently the email documentation provides an example of how to use the SMTP adapter in SwiftMailer, but this example hardcodes the password in the config file which is a security issue. It is possible to reference environment variables instead, so we should document and encourage this.
2019-04-29 09:53:22 +12:00
Robbie Averill
3b5934b09e
Merge pull request #8942 from adrhumphreys/patch-2
Add info around namespacing with controllers
2019-04-26 16:39:03 +12:00
Adrian Humphreys
8206538f31
Add info around namespacing with controllers 2019-04-26 14:22:04 +12:00
Ingo Schommer
15396116e5 DOCS File migration changes for 4.4.0 (#8910)
* DOCS File migration changes for 4.4.0

See https://github.com/silverstripe/silverstripe-versioned/issues/177

* Update docs/en/02_Developer_Guides/14_Files/03_File_Security.md

Co-Authored-By: chillu <ingo@silverstripe.com>

* Corrected statements on archived/versioned files

* Corrected statement on filesystem paths of protected vs. public

* Update docs/en/02_Developer_Guides/14_Files/03_File_Security.md

Co-Authored-By: chillu <ingo@silverstripe.com>

* Clarify redirect behaviour
2019-04-24 14:00:48 +12:00
Robbie Averill
b5b4014280 Update branch alias to 4.5.x-dev 2019-04-21 11:10:17 +12:00
Robbie Averill
86e683c5ec Remove obsolete branch alias 2019-04-21 11:09:40 +12:00
Robbie Averill
8c6bf7ce53 Merge branch '4.3' into 4.4 2019-04-21 11:09:25 +12:00
Robbie Averill
c8a21484d0
Merge pull request #8909 from silverstripe/pulls/fix-upgrading-docs
Fix reference to webconfig.php, an invalid file
2019-04-21 01:30:51 +12:00
Matt Peel
91f168955d Fix reference to webconfig.php, an invalid file
The upgrading docs reference webconfig.php, which is incorrect and has never existed. I presume the docs mean to reference web.config, which is the IIS configuration file.

I've also fixed a couple of minor spelling mistakes and mentioned Apache for htaccess and IIS for web.config so people know what they're for.

[ci skip]
2019-04-21 01:29:47 +12:00
Robbie Averill
523456ae09
Merge pull request #8921 from creative-commoners/pulls/4.3/threshold-count-in-sql
FIX Calculate threshold condition with SQL rather than PHP
2019-04-21 01:25:24 +12:00