tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
20,789 Commits 31 Branches 527 Tags 162 MiB
76936d863d
Commit Graph

20789 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Ingo Schommer
25759ffc5f NEW Show file path on PHP parser exceptions 2018-09-28 08:58:47 +12:00
Robbie Averill
1b0293d8c5 Replace array syntax, use some strict comparison and remove unnecessary elseif 2018-09-27 17:37:37 +02:00
Robbie Averill
594fa30b82 Remove redundant elseif complexity and switch to short array syntax 2018-09-27 17:29:52 +02:00
Robbie Averill
0c7ced1513 Refactor sorting tests to use a dataprovider 2018-09-27 17:18:19 +02:00
Robbie Averill
c7d522ff6d Add tests for sorting HasManyList 2018-09-27 17:09:24 +02:00
Robbie Averill
adb4d1f92d MINOR Reduce some code complexity, update array syntax and injected SQLSelect etc 2018-09-27 16:40:23 +02:00
Robbie Averill
3321c6b39d Add tests for sorting many many through list without a table alias 2018-09-27 14:34:37 +02:00
Thomas Portelange
fdd5acff5d
raw2att accepts array, but sprintf doesn't 
it's not very likely to happen (it did in my case :-) ) but if the value is an array, sprintf will fail (because raw2att accepts array, but sprintf doesn't). i suggest to json encode any array data to ensure it's safely included in the html. Or we should throw proper exceptions to make sure invalid values do not result in a php error.
 2018-09-27 12:12:59 +02:00
Loz Calver
89df5515ae
Merge pull request #8415 from DorsetDigital/patch-8 
Doc update - add FQCN to example code
 2018-09-27 11:29:42 +02:00
DorsetDigital
da38505446
Doc update - add FQCN to example code 
Add fully qualified classname to aggregate caching example
 2018-09-27 10:21:01 +01:00
Guy Marriott
c54e7317d2
FIX Avoid having search fields with the same names as form elements 2018-09-27 17:39:50 +12:00
Robbie Averill
2f67be61c1
Merge pull request #8410 from lekoala/patch-13 
FormField::debug should handle all types of values
 2018-09-26 14:30:55 +02:00
Thomas Portelange
f103648f8c
value can be something else than a string 
if the value is not a string (an array for instance), sprintf will fail
 2018-09-26 11:35:40 +02:00
Dan Hensby
b3d2d4c1b1
Remove redundant code 2018-09-26 10:11:28 +01:00
Dan Hensby
db43d57618
Remove commented out test 2018-09-26 10:11:28 +01:00
Dan Hensby
fe5b431200
Use Member::actAs rather than setting and unsetting member 2018-09-26 10:11:20 +01:00
Sam Minnée
a31a496362
Merge pull request #8399 from lekoala/patch-12 
var_export does not handle circular references
 2018-09-26 20:58:25 +12:00
Maxime Rainville
77339b7e75 MINOR Add caching to the TreeDropdownField tree action 2018-09-26 17:24:06 +12:00
Dan Hensby
6b618b44c9
Remove regex in favour of simple assertContains 2018-09-26 00:36:58 +01:00
Dan Hensby
cb361e8caf
Remove unused code from ControllerTest 2018-09-26 00:30:20 +01:00
Dan Hensby
15bf13daa9
Dont use willReturn assertions to assert argument types 2018-09-26 00:21:37 +01:00
Dan Hensby
7d15d0af70
Refactor email validation into provider based test 2018-09-25 23:15:18 +01:00
Robbie Averill
f5929d87e0 DOCS Update do blocks for DataQuery::having() to reflect correct input types 2018-09-25 17:46:42 +02:00
Robbie Averill
a8070dcfc3
Merge pull request #8404 from Carlo1139/patch-1 
Typo in code snippet
 2018-09-25 10:39:51 +02:00
Carlo1139
748409e61a
Typo in code snippet 
Changed $ction to $action
 2018-09-25 10:35:19 +02:00
Sam Minnée
5b7a84141b NEW: Add Hierarchy::prepopulate_numchildren_cache() (#8380) 
* NEW: Add Hierarchy::prepopulate_numchildren_cache()
API: Hierarchy::stageChildren() customisations must be applied to the base class and not include record-specific behaviour.

Adds the ability to prepopulate the cache for Hierarchy::numChildren()
in a batch.

Note that this optimisation means that stageChildren() is not called on
each record in order to calculate numChildren(). This means that the
structure of the stageChildren() query must be the same for all records
and the behaviour cannot be customised only for a subclass of the base
data class. For example, apply your customisations to SiteTree and not
a subclass.

This is an useful part of optimising the query count on tree generation.
See https://github.com/silverstripe/silverstripe-framework/issues/8379

* NEW: Add Hierarchy::prepopulateTreeDataCache()

This provides a more extensible way of preopulating caches for optimised
tree generation.

Fixes https://github.com/silverstripe/silverstripe-framework/issues/8391
 2018-09-25 12:25:23 +12:00
Robbie Averill
3eacecbb1c
Merge pull request #8398 from open-sausages/pulls/4/test-flush 
FIX Don't flush manifests in tests by default
 2018-09-25 00:19:32 +02:00
Robbie Averill
f2556ded1c
Merge pull request #8400 from creative-commoners/pulls/4.3/semver-break 
FIX Revert semver break in adding GridField type hint to method signature
 2018-09-24 13:56:15 +02:00
Robbie Averill
0276f6c089 FIX Revert semver break in adding GridField type hint to method signature 2018-09-24 13:39:33 +02:00
Thomas Portelange
72b25d1a97
var_export does not handle circular references 
this often happens in SilverStripe, a plain print_r is much safer
 2018-09-24 12:31:06 +02:00
Loz Calver
f01473f1b3
Merge pull request #8390 from caffeineinc/bugfix/8389-login-attempt-performance-issues 
Performance issues with BasicAuth and LoginAttempts
 2018-09-24 10:24:29 +02:00
Ingo Schommer
a2bb70c46d FIX Don't flush manifests in tests by default 
It's massively slowing down test execution,
particularly for rapid execution through test-driven-development (TDD)
 2018-09-24 18:12:35 +12:00
Robbie Averill
d11911d4dd
Merge pull request #8394 from littlegiant/pulls/4.2/http-status-codes 
BUG Prevent error on valid response status codes
 2018-09-21 13:19:29 +02:00
Andre Kiste
e8fd49b394
Merge pull request #8381 from open-sausages/pulls/4.2/sort-out-your-field 
BUG Changes being detected on TreeMulti as values not sorted
 2018-09-21 16:38:56 +12:00
Luke Edwards
4ac4cdc91b
Merge pull request #8348 from caffeineinc/bugfix/3357 
BUG Add GridField Readonly Transformation (#3357)
 2018-09-21 14:54:37 +12:00
Damian Mooyman
1d5ecd342e
BUG Prevent error on valid response status codes 2018-09-21 14:54:26 +12:00
Simon Gow
c269a987d5 Performance issues with BasicAuth and LoginAttempts 
Two functions interact with the LoginAttempt object which when used in conjunction with BasicAuth result in significant performance degradation over time, as the LoginAttempts Table fills.

This fix adds an index to the lookup column EmailHashed and removes the Email filter part of getByEmail() so it can use the index resulting in a much faster query.

For more information see https://github.com/silverstripe/silverstripe-framework/issues/8389
 2018-09-20 13:34:03 +12:00
Luke Edwards
3fc49dd4ce Lint fixes and allow a few other components by default 2018-09-20 13:32:52 +12:00
Robbie Averill
3b7802bb51
Merge pull request #8388 from sminnee/showqueries-backtrace 
NEW: Add ?showqueries=backtrace
 2018-09-19 11:21:36 +02:00
Sam Minnee
40dde226fd NEW: Add ?showqueries=backtrace 
This variant of showqueries will include a backtrace after each query.
This is extremely verbose but can be helpful when diagnosing where
queries have come from.

This is something that I have frequently added as a local hack on my
environment, I figured that exposing it as a formal feature would be
useful.
 2018-09-19 14:28:40 +12:00
Luke Edwards
f1893adea9
Merge pull request #8385 from open-sausages/pulls/4/proppa-pig 
Update docs to reflect prop-types change
 2018-09-19 13:14:15 +12:00
Luke Edwards
d9d22a2895 Update docs to reflect prop-types change 2018-09-19 10:05:49 +12:00
Luke Edwards
db63f55fbb BUG Changes being detected on TreeMulti as values not sorted 2018-09-18 13:24:55 +12:00
Robbie Averill
fb1b513b7e
Merge pull request #8378 from creative-commoners/pulls/4/override-get-schema-defaults 
NEW Add hideNav flag to schema defaults
 2018-09-18 01:01:07 +02:00
Raissa North
588bf83e12 NEW Add hideNav flag to schema defaults 2018-09-18 10:45:36 +12:00
Ingo Schommer
605ea158e8
Merge pull request #8361 from open-sausages/pulls/4/release-docs 
Release process docs
 2018-09-17 13:55:53 +12:00
Luke Edwards
a33866ff4c
Merge pull request #8353 from open-sausages/pulls/4.2/2227-show-link-tracking 
API: Add Link Tracking section to Relations developer guide
 2018-09-13 14:23:34 +12:00
bergice
01db5c9e98 API: Add Link Tracking section to Relations developer guide and describe show_sitetree_link_tracking, show_file_link_tracking. 
Refactor form scaffolder.
 2018-09-13 11:02:09 +12:00
Ingo Schommer
7f05c7c6d4 DOCS Clarified latest vs. next 2018-09-13 08:11:07 +12:00
Ingo Schommer
793d6615eb DOCS Don't mention 5.3, its unsupported 2018-09-13 08:09:27 +12:00