Steve Boyd
75d31c2cd3
Cache glob results for _configure_database.php
2020-04-10 23:15:12 +12:00
Loz Calver
3ad4b93daa
Merge pull request #9456 from open-sausages/pulls/4/avoid-tempdatabase-infinite-loop
...
BUG Infinite loops in TempDatabase (fixes #8902 )
2020-04-09 09:28:57 +01:00
Ingo Schommer
a50e15e5ee
FIX Avoid VACUUM on test dbs in Postgres
...
The Postgres implementation was always faulty,
but the database exception was swallowed until
See https://github.com/silverstripe/silverstripe-framework/pull/9456 .
Now that the the exception is only swallowed the first time,
the second recurrence will cause failing test execution.
This is a bit of an awkward fix, but the indirection "through" DataObject doesn't allow for anything else without changing public API surface.
The logic goes from TempDatabase to DBSchemaManager, then through the closure into DataObject->requireTable(),
then back into DBSchemaManager->requireTable(). And updateschema() is subclassed in SQLite3, making it difficult to add more arguments.
VACUUM is described as:
> VACUUM reclaims storage occupied by dead tuples. In normal PostgreSQL operation, tuples that are deleted or obsoleted by an update are not physically removed from their table; they remain present until a VACUUM is done. Therefore it's necessary to do VACUUM periodically, especially on frequently-updated tables.
https://www.postgresql.org/docs/9.1/sql-vacuum.html
Since test databases are short-lived, there's no reason to delete dead tuples, they'll be garbage collected when either the transaction is rolled back, or the database is destroyed after the test run.
2020-04-09 14:43:16 +12:00
Loz Calver
f1c74c3570
Merge pull request #9415 from botzkobg/4
...
Form validation should throw ValidationException
2020-04-08 09:33:20 +01:00
Ingo Schommer
052c5cbc38
BUG Infinite loops in TempDatabase ( fixes #8902 )
...
Ugly, but so is the original implementation that this works around (swallowing an exception to trigger functionality)
2020-04-08 13:58:02 +12:00
tdenev
1d85981537
Refactoring the form validation in the action to be more readable and in the SS standards based on the code review
2020-04-07 22:46:32 +01:00
Loz Calver
bcab982aa7
Merge pull request #9452 from botzkobg/GridFieldDocsUpdate
...
Fix issue with the GridField documenation
2020-04-06 09:38:44 +01:00
tdenev
d6fc7fe804
Fix issue with the GridField documenation - many_many_extraFields code example
2020-04-05 18:53:21 +01:00
Robbie Averill
f77f725355
Merge pull request #9447 from mattclegg/docs__GridFieldDetailForm_ItemRequest-httpError
...
[DOCS] Better debug text for errors generated by GridFieldDetailForm_ItemRequest
2020-04-02 13:05:49 -07:00
Robbie Averill
d3b19069b3
Apply suggestions from code review
...
Add double quotes around object title
2020-04-02 12:51:13 -07:00
Dan Hensby
d1075f29b8
Remove empty parameter as per feedback
2020-04-02 12:11:35 +01:00
Dan Hensby
9e0ed0a50a
Fix spaces around concatenation operator
2020-04-02 12:09:22 +01:00
Dan Hensby
bb03d314ff
Include phpcs as a dev dependency
2020-04-02 12:06:40 +01:00
Dan Hensby
5bf2ac83ee
Merge branch '4.5' into 4
2020-04-01 19:23:47 +01:00
Loz Calver
39fab1974a
Merge pull request #9435 from unclecheese/pulls/4.5/wha-diff
...
BUGFIX: Ensure diff arrays are one-dimensional
2020-04-01 09:16:20 +01:00
Robbie Averill
dcd54ecec0
Merge pull request #9448 from mattclegg/patch-5
...
[DOCS] Member::logInAs is not a valid example
2020-03-31 11:12:49 -07:00
Matt Clegg
e80f1b2b83
[DOCS] Member::logInAs is not a valid example
...
Member::logInAs doesn't exist as a static function.
Additionally, `logInAs` does exist as a function in SapphireTest.php, so, should this be updated to also use `Member::actAs` for consistency?
2020-03-31 18:20:21 +05:45
mattclegg
24bc80ed35
[DOCS] Better debug text for errors generated by GridFieldDetailForm_ItemRequest
2020-03-31 12:09:16 +05:45
Loz Calver
5952a7ce71
Merge pull request #9444 from mattclegg/docs-13_i18n
...
[DOCS] Example should be valid YAML
2020-03-27 16:34:40 +00:00
mattclegg
ba3deb9b72
[DOCS] Example should be valid YAML
2020-03-27 20:31:25 +05:45
Daniel Hensby
1fb574a5bd
NEW: Variadic URL parameter matches for url_handlers ( #9438 )
...
* Add wildcard URL parameter matches for url_handlers
* Extra tests for wildcard parameters
* Add a PHP warning if more params appear after wildcard param
2020-03-25 09:16:13 +13:00
Robbie Averill
5002f514b3
FIX Capitalisation fixes in welcome back message ( #9439 )
2020-03-23 15:54:30 +13:00
Aaron Carlino
37e8720fe5
Linting
2020-03-17 16:21:46 +13:00
Aaron Carlino
7ad5f1bb14
BUGFIX: Ensure diff arrays are one-dimensional
2020-03-17 15:57:28 +13:00
Robbie Averill
b6512edec8
Merge pull request #9434 from mattclegg/bugfix--silverstripe-admin--requirements
...
[BUGFIX] silverstripe/admin is not required to be installed
2020-03-16 09:48:39 -07:00
mattclegg
06dab6b539
[BUGFIX] silverstripe/admin is not required to be installed
...
If the silverstripe/admin module is not installed then the javascript/css requirements fail to load
2020-03-16 18:54:01 +05:45
Garion Herman
8be411541d
Merge pull request #9430 from mattclegg/patch-3
...
[DOCS] Update link to reactjs_redux_and_graphql
2020-03-16 17:15:52 +13:00
Garion Herman
8a64101621
Merge pull request #9427 from ramono/role-option
...
Add "option" to list elements that belong to "listbox"
2020-03-16 17:12:14 +13:00
Garion Herman
88660e6435
Merge pull request #9426 from creative-commoners/pulls/4.5/change-atomic-job-title
...
DOC Update atomic MigrationTask description
2020-03-16 15:19:33 +13:00
Robbie Averill
71264bda54
Merge pull request #9431 from mattclegg/patch-4
...
[DOCS] Missing line termination in example
2020-03-14 06:45:45 -07:00
Matt Clegg
101c189c16
[DOCS] Missing line termination in example
2020-03-14 15:19:17 +05:45
Matt Clegg
ecb4cd889e
[DOCS] Update link to reactjs_redux_and_graphql
2020-03-13 14:28:23 +05:45
Ramon Lapenta
9c7eac481e
Add "option" to list elements that belong to "listbox"
...
The accessibility attribute `role="listbox"` requires its immediate children to be set as `role="option"`, currently they don't have this option and accessibility tests are failing.
2020-03-10 11:10:04 -06:00
Steve Boyd
667495eaf9
Merge branch '4.5' into 4
2020-03-06 10:53:28 +13:00
Steve Boyd
687435a2f1
Merge branch '4.4' into 4.5
2020-03-06 10:52:22 +13:00
Steve Boyd
2e875a04ae
Merge pull request #9381 from webbuilders-group/bugfix-timefield-readonly
...
BUGFIX: Fixed issue where TimeField_Readonly would only show "(not set)"
2020-03-06 10:38:57 +13:00
Steve Boyd
6d6cc65927
Update description
2020-03-06 09:57:31 +13:00
Loz Calver
152e0f4125
Merge pull request #9423 from creative-commoners/pulls/4/doc-file-migration-typo
...
DOC TagsToShortcodeTask name typo fixed in the File migration guide
2020-03-03 09:18:26 +00:00
Serge Latyntcev
335cc1245e
DOC TagsToShortcodeTask name typo fixed in the File migration guide
2020-03-03 13:55:05 +13:00
Garion Herman
18f74ad4da
Merge branch '4.5' into 4
2020-02-28 11:48:18 +13:00
UndefinedOffset
bba0f2f72f
BUGFIX: Fixed issue where TimeField_Readonly would only show "(not set)" instead of the value
2020-02-24 09:59:00 -04:00
botzko
a1f0f2f45d
Form validation should throw ValidationException instead of calling unexisting method "addErrorMessage()"
2020-02-21 23:55:38 +00:00
Loz Calver
ab3448c4f1
Merge pull request #9414 from zubairaziz/patch-1
...
Fix Related section at bottom of document
2020-02-21 15:00:28 +00:00
Zubair
9733060d1c
Fix Related section at bottom of document
2020-02-21 09:53:57 -05:00
Robbie Averill
2936f6e0d2
Merge pull request #9412 from creative-commoners/pulls/4.5/php-7.4-stable-build
...
Update Travis config to use stable PHP 7.4 release
2020-02-20 16:22:48 +13:00
Garion Herman
a65e65409f
Upgrade Travis config to Xenial
2020-02-20 16:07:14 +13:00
Garion Herman
d5149a8e38
Update Travis config to use stable PHP 7.4 release
2020-02-20 14:01:22 +13:00
Serge Latyntcev
6c39962b7a
Merge branch '4.5' into 4
2020-02-19 10:21:11 +13:00
Serge Latyntcev
6c2f179a43
Merge branch '4.4' into 4.5
2020-02-19 10:20:50 +13:00
Serge Latyntsev
91f091f418
Merge pull request #9410 from blueo/patch-1
...
Update CVE number to CVE-2019-19325
2020-02-19 10:15:52 +13:00
