Ingo Schommer
ade3ac4547
MINOR documentation
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73340 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-18 17:00:42 +00:00
Ingo Schommer
b6e115a874
ENHANCEMENT Added Form->MessageType() to Form->extraClass() to make sure every tag in a formfield HTML container can be styled based on the validation results (previously it was only possible to style a <span class="message"> tag inside the container)
...
MINOR FormFied documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73228 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-17 11:38:52 +00:00
Ingo Schommer
fbabb9b31f
ENHANCEMENT Added CSS class "validationerror" to Form markup with validation errors. This makes it easy to evaluate a new form after an ajax call and give the user feedback independent of the form rendering, e.g. in ModelAdmin
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73030 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-13 10:19:10 +00:00
Ingo Schommer
4499d1a8d0
ENHANCEMENT Allowing item-specific permissions in TableListField and subclasses (through TableListField_Item->Can() and DataObject->can*() methods). Adding "disabled" icons to template.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73028 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-13 10:07:27 +00:00
Ingo Schommer
8fe1809344
ENHANCEMENT Making $fieldList argument in HasManyCTF and ManyManyCTF optional to adhere to changed parent implementation
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@73026 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-13 10:05:57 +00:00
Sean Harvey
b8c803f520
BUGFIX Added an <img> HTML alt attribute to CalendarDateField output HTML so that this field is W3C compliant for <img> elements
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72982 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-12 21:47:44 +00:00
Ingo Schommer
969a95eff7
BUGFIX Removed hardcoded field value removals in Form->validate() for creditcard info
...
ENHANCEMENT Optionally returning JSON data or HTML form representations from Form submissions if Form->validate() fails (if HTTP Accept is set to 'application/json')
ENHANCEMENT Limiting usage of prototype-validation responses in Form->validate() to form instances with $javascriptValidationHandler=='prototype' (which is the default setting). This enables us to return richer JSON data on validation errors without making assumptions about javascript methods on clientside through eval'ed responses (specifically Validator.js->validationError())
API CHANGE Deprecated Validator->getError() and Validator->getCombinedError(), use getErrors() instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72979 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-12 16:47:29 +00:00
Sean Harvey
ea8030d955
BUGFIX CalendarDateField requires prototype to be included at all times in order for the calendar javascript to work - so ensure that it is included (this broke on the front end if prototype wasn't included via Requirements).
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72957 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-12 02:20:45 +00:00
Sean Harvey
9dc761d449
ENHANCEMENT Updated Form->forAjaxTemplate() to select the same templates as Form->forTemplate() that was changed in r72950
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72951 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-12 01:47:21 +00:00
Sean Harvey
e5712d46ef
ENHANCEMENT Allow setting the Form template by calling Form->setTemplate('MyTemplateName') without having to subclass Form
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72950 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-12 01:43:56 +00:00
Sean Harvey
278463f572
MINOR Removed call to parent::Field() in CalendarDateField that is not being used
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72872 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-11 01:53:21 +00:00
Sam Minnee
189f0567f8
Merged from branches/2.2
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72811 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-10 22:17:26 +00:00
Sam Minnee
08a5a7c387
Merged from branches/2.3
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72803 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-10 22:08:52 +00:00
Ingo Schommer
55e0a713db
MINOR Documentation
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72778 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-10 15:03:34 +00:00
Sean Harvey
41aac525b5
ENHANCEMENT DateField validation is now enabled through DateField::$validation_enabled so that it can be optionally disabled by setting it to false
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72753 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-10 02:32:42 +00:00
Andrew O'Neil
635e2c3df6
Merged from 2.3
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72453 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-04 03:44:11 +00:00
Ingo Schommer
8f0979eb78
BUGFIX Using Validator::getJavascriptValidationHandler() to determine instance settings, and fall back to static defaults in Validator->includeJavascriptValidation(), instead of setting instance-specific parameters in __construct() calls. This means Validator.js won't be included if handlers are globally disabled.
...
ENHANCEMENT Added Validator::getJavascriptValidationHandler()
API CHANGE Deprecated Validator::showErrors()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@72373 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-03-03 02:24:29 +00:00
Sean Harvey
df36ae07e8
ENHANCEMENT Allow getting extra field data for a many-to-many relation by calling getExtraData() on a ComponentSet and passing the component name, and child ID
...
ENHANCEMENT Hooked up setting field values for many_many_extraFields into ComplexTableField. See r71613 for the original many-to-many auto setting addition
BUGFIX When editing an existing record, many-to-many auto setting wasn't being done because saveComplexTableField() is called on ComplexTableField_ItemRequest
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@71635 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-11 00:10:37 +00:00
Sean Harvey
fa4c42d642
ENHANCEMENT Allow auto setting a many-to-many relation on ComplexTableField in the similar fashion of auto setting the foreign key for a one-to-many or one-to-many relation.
...
ENHANCEMENT Added DataObject::many_many_extraFields() for getting the many_many_extraFields fields for a component name on both sides of a many-to-many relation.
MINOR Added test for many_many_extraFields in DataObjectTest
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@71613 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-10 06:04:36 +00:00
Sean Harvey
f6add2dc75
BUGFIX Fixed potential PHP notice in TableField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@71326 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-03 23:20:58 +00:00
Sean Harvey
12e0205bdd
MINOR Fixed wrong case of Debug class name for consistency
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@71298 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-03 05:14:04 +00:00
Andrew O'Neil
60f75c5ca4
Merged changes from 2.3 branch
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@71172 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-02-01 23:49:53 +00:00
Ingo Schommer
095084fb22
BUGFIX Using array_diff_key() instead of array_diff() in LanguageDropdownField to avoid language with existing translations showing up in the "available translations" dropdown for page CMS fields
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@70321 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-18 23:07:51 +00:00
Ingo Schommer
b7d394008e
MINOR Merged from branches/2.3
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@69957 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-10 11:35:50 +00:00
Ingo Schommer
0747fc6d52
MINOR merged from branches/2.3
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@69856 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-07 23:00:54 +00:00
Ingo Schommer
a16825d9a3
ENHANCEMENT Added support for custom CSS classes to Form (similiar to FormField implementation) through Form->addExtraClass()
...
MINOR Improved formatting and readability of Form->FormAttributes()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@69742 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-06 02:16:16 +00:00
Ingo Schommer
085346f0e0
MINOR Merged from branches/2.3
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@69704 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-05 06:19:48 +00:00
Saophalkun Ponlu
a32a79e816
MINOR: fixed some alignments
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@69685 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-01-05 03:06:57 +00:00
Saophalkun Ponlu
11d0491abf
IMPROVEMENT: image alignment options. ticket #1877
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@69557 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-12-19 13:36:59 +00:00
Ingo Schommer
d26f08b481
MINOR merged branches/2.3 into trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@67465 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-12-04 22:38:32 +00:00
Sam Minnee
96c5be8252
Updating queries to be more DB agnostic
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@66507 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-24 09:31:14 +00:00
Sam Minnee
93438e0be2
API CHANGE: Adding double quotes to all table and field references (a work in progress)
...
API CHANGE: DataObject::get()'s GROUP BY clause is only generated for MySQL as it needs to be improved for other databases to accept it.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@66427 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-23 23:28:16 +00:00
Sam Minnee
a3d3fb65a9
Updated SQL queries to be ansi compatable
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@66401 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-23 00:31:06 +00:00
Sam Minnee
2984355f43
Merged branches/2.3 into trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@66395 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-22 03:33:00 +00:00
Sam Minnee
3d9532db83
Merged branches/2.3
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@66108 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-18 01:48:37 +00:00
Will Rossiter
8052c5dce4
Merged pre-2.3-oct08 into trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@66080 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-17 22:59:17 +00:00
Sean Harvey
a25320a99c
ENHANCEMENT Added possibility of search for images and flash before inserting into the content editor in CMS
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65820 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-13 04:55:23 +00:00
Sean Harvey
1458d5b973
BUGFIX Fixed deletion of RedirectorPage
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65769 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-13 01:43:38 +00:00
Sam Minnee
b39d3811ff
Refactored tabstrip.js to use livequery for loading
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65717 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-12 22:28:07 +00:00
Sam Minnee
73a075a491
FEATURE #594 : Added javascript-on-demand support
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65688 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-12 04:31:33 +00:00
Ingo Schommer
5df97fba10
ENHANCEMENT Added CompositeField->fieldPosition()
...
ENHANCEMENT Supporting recursion into nested sets in FieldSet->insertAfter()/TabSet->insertAfter()/CompositeField->insertAfter()
API CHANGE Deprecated CompositeField->insertBeforeRecursive(), use CompositeField->insertBefore()
ENHANCEMENT Renamed CompositeField->beforeInsert() to CompositeField->onBeforeInsert() to avoid confusion with insertBefore()
ENHANCEMENT Added CompositeFieldTest
ENHANCEMENT Added unit tests for FieldSet->insertBefore()/insertAfter()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-11 02:35:54 +00:00
Sam Minnee
58dbe416ee
Merged from branches/2.2
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65523 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-10 03:51:35 +00:00
Ingo Schommer
fdeaececb1
BUGFIX Respecting $dontEscape in FormAction
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65335 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-05 23:21:50 +00:00
Ingo Schommer
c172e823ea
BUGFIX Using empty title in TreeDropdownField->Field() if the related DataObject cannot be found
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65293 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-05 15:58:46 +00:00
Sean Harvey
d145c50cc2
ENHANCEMENT Folder name can now be used for uploading files. Ticket #3026 - Thanks simon_w!
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65266 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-05 03:56:22 +00:00
Sam Minnee
020a92eda8
BUGFIX #2992 : Fixed T_PAAMAYIM_NEKUDOTAYIM error in RequestHandler
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65250 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-05 01:59:27 +00:00
Ingo Schommer
61a856503e
BUGFIX Calling parent constructor in ComplexTableField_ItemRequest, was confusing RequestHandler
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65212 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-04 13:52:03 +00:00
Sean Harvey
dc8876223e
MINOR Code formatting on HtmlEditorField functions
...
MINOR phpDoc of HtmlEditorField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65205 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-04 04:12:54 +00:00
Ingo Schommer
c539687eb2
MINOR Fixed PHP Notices in TreeMultiSelectField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65145 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-03 13:47:40 +00:00
Sean Harvey
99589e626f
BUGFIX Fix potential PHP notice opening a ComplexTableField popup
...
MINOR Code formatting in ComplexTableField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@65127 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-11-03 02:33:08 +00:00
Sean Harvey
e9f65ed8e1
BUGFIX Fixed wrong case of class names for ImageIFrameField causing errors
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64976 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-31 02:09:04 +00:00
Sam Minnee
cd699e3d89
API CHANGE #2857 - Renamed RequestHandlingData to RequestHandler
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64953 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-30 22:03:21 +00:00
Normann Lou
132f4ae5ca
CurrencyField::jsValidation() needs to register its validateCurrency function mulitiple times with different FormID for working in a popup of ComplexTableField where FormID is changed.
...
In general all Form Fields should imply with this rule if a page contain mulitiple forms, but this is not under our current developing cycle, since our form fields validation is changing to use jQuery.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64896 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-30 01:02:57 +00:00
Ingo Schommer
41075078fd
BUGFIX Fixed title-handling in FormAction, regression from r64410
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64879 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-29 16:12:23 +00:00
Sean Harvey
c013b02dc8
MINOR Code formatting in TextareaField->Field()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64871 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-29 03:13:38 +00:00
Sam Minnee
f5e636ac43
Changed default # of rows on HTMLEditorField from 15 to 30
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64863 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-29 02:39:09 +00:00
Sean Harvey
68326a5eac
BUGFIX Avoid ajax evaluator errors by checking if $resizedImage actually exists before calling relativePath() on it
...
MINOR Code formatting cleanup
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64850 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-28 23:20:14 +00:00
Sean Harvey
673e0508b1
MINOR Added deprecated note to ConfirmedFormAction
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64786 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-27 22:50:24 +00:00
Will Rossiter
03830e1baa
BUGFIX: merged patch from ajshort to fix checkbox fields in the cms
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64770 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-25 11:19:31 +00:00
Sam Minnee
f7a3e95851
Added LinkText field to link inserter
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64759 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-24 05:12:22 +00:00
Sean Harvey
691776a254
ENHANCEMENT Changed FormField->Field() to make use of FormField->createTag() over complicated dynamic string building
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64682 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-23 10:39:11 +00:00
Hayden Smith
c004cc9b2f
BUGFIX: Fixed incorrectly reverted methods related to sizing of the popup.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64604 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-21 21:42:27 +00:00
Sean Harvey
a78b5a2efb
BUGFIX Fixed extra class addition on various FormField->Field() methods
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64601 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-21 20:58:11 +00:00
Sean Harvey
bd023527e6
ENHANCEMENT Used _t() entity instead of hardcoded "not set" string in TextareaField->Field()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64558 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:58:31 +00:00
Sean Harvey
fda6ab0afb
MINOR Unnecessary check of trim() twice on TextareaField->Field()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64557 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:54:04 +00:00
Sean Harvey
62a28cab64
ENHANCEMENT Clearer indication of setting disabled attribute in DropdownField->Field() since the disabled attribute shouldn't be set if the field isn't to be disabled
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64556 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:52:47 +00:00
Sean Harvey
719bc5dff4
MINOR whitespace removal
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64555 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:32:14 +00:00
Sean Harvey
a16f55b068
ENHANCEMENT Clearer indication of setting disabled attribute in CheckboxField->Field() since the disabled attribute shouldn't be set if the field isn't to be disabled
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64553 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:22:01 +00:00
Sean Harvey
2fd43fccfa
ENHANCEMENT If TextField->disabled has been set to true, then add the "disabled" attribute to the input type text attribute list
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:18:25 +00:00
Sean Harvey
f5a39b5c2c
ENHANCEMENT Made use of FormField->createTag() functionality for creating a textarea field in TextareaField->Field()
...
MINOR Documentation tweaks in TextareaField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:05:05 +00:00
Sean Harvey
1611deb019
MINOR Convert::raw2att() isn't required because FormField->createTag() already does this
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64550 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 10:03:20 +00:00
Normann Lou
249c7a7d12
APICHANGE: delete GenericDataAdmin, RelatedDataEditor, DropdownField_WithAdd and their related code (js, css, etc) from cms, sapphire, "GenericDataAdmin" name space has also been deleted from lang files. They are all added in the new module "genericdataadmin"
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64528 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-20 00:20:00 +00:00
Sean Harvey
8e1f647252
MINOR Added to @deprecated note for TypeDropdown about why this class shouldn't be used
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64505 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-19 00:41:16 +00:00
Sean Harvey
7048077184
API CHANGE Removed HtmlOneLineField. This field has been deprecated for some time now, and it does not work.
...
API CHANGE Changed HTMLVarchar->scaffoldFormField() to use HtmlEditorField instead of HtmlOneLineField, which does not work.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64504 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-19 00:18:55 +00:00
Normann Lou
e30b5e3f22
MINOR: documenting my new method, correct a coding convention about whitespace
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64460 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 22:22:32 +00:00
Ingo Schommer
00eaa1b5b7
BUGFIX Removed $headingLevel reference from LabelField (was supposed to go into HeaderField)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64438 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 14:03:10 +00:00
Ingo Schommer
06671277a7
BUGFIX Second constructor argument $title for HeaderField should be optional for legacy reasons
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64437 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:54:21 +00:00
Ingo Schommer
cb5d772111
MINOR deprecation notes
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64429 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:44:20 +00:00
Ingo Schommer
794ae40f8f
API CHANGE Moved CheckboxFieldDisabled class to more common CheckboxField_Disabled notation
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64428 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:44:05 +00:00
Ingo Schommer
80b5bfd4d2
API CHANGE Removed NoScriptField, please use LiteralField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64426 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:31:57 +00:00
Ingo Schommer
82e1ad8d8a
API CHANGE Removed EncryptField, use PasswordField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64425 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:31:34 +00:00
Ingo Schommer
e95c5657ff
API CHANGE Changed constructor parameters for LabelField and Header: First parameter is now $name, not $title. Necessary change to consistently support labelled fields which can be identified and modified within a FieldSet, and in the DOM structure. Both HeaderField and LabelField still acceppt old notation through checking the parameter signature with func_get_args().
...
API CHANGE Moved setAllowHTML() to DataLessField
ENHANCEMENT Using createTag() to create HeaderField and LabelField, which adds support for HTML id attributes and extra css classes through addExtraClass()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64421 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:26:25 +00:00
Ingo Schommer
ab891c67ec
API CHANGE Removed LabelledLiteralField, use LiteralField
...
API CHANGE Removed NamedLabelField, use LabelField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64420 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:22:36 +00:00
Ingo Schommer
461354bb47
MINOR Misc deprecation notes
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64419 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 13:00:30 +00:00
Sean Harvey
b8ef87d24a
MINOR phpDoc comment error fix
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64411 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 11:50:55 +00:00
Sean Harvey
3e13bd8307
ENHANCEMENT Made use of createTag() on FormAction->Field()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64410 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 11:50:13 +00:00
Ingo Schommer
8cf23e6d6c
API CHANGE Removed NoScriptFormAction, use unobtrusive scripting
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64407 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 11:34:25 +00:00
Ingo Schommer
e9a2e5d464
API CHANGE Removed deprecated ComplexRequiredFields, use RequiredFields and custom javascript instead
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64399 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 10:51:09 +00:00
Ingo Schommer
c67d1b6425
API CHANGE Removed FormField->setExtraClass(), use FormField->addExtraClass()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64379 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 08:41:34 +00:00
Ingo Schommer
b45e583d29
API CHANGE Removed deprecated CustomValidator class
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64372 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 08:33:44 +00:00
Ingo Schommer
f7a0c5db04
API CHANGE Removed deprecated EditForm classa
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64371 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 08:33:21 +00:00
Sean Harvey
89b3241584
MINOR Whitespace changes in TextField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64344 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 02:34:46 +00:00
Sean Harvey
8a385d9fc0
Removed TextField_Disabled - this is unnecessary
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64343 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 02:34:31 +00:00
Normann Lou
9ba71a54da
MINOR: delete some unnecessary duplicated variable in a assignment statement.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64338 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 02:00:12 +00:00
Normann Lou
2c384e732f
Feature: attach extraClasses to a CurrencyField when it is transform to readonly
...
API: add CurrencyField_Readonly
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64326 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 00:49:34 +00:00
Normann Lou
480f18ab48
BUGFIX: $this->extraData is not alway set for an TableField_Item
...
API: add funcion TableField_Item::IsAddRow()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64325 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 00:47:01 +00:00
Normann Lou
ab0503fe22
Feature: attach extraClasses to a FormField when it is transform to readonly
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64324 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 00:43:00 +00:00
Normann Lou
19d5b377a8
API: add TextField_Disabled
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64323 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-16 00:36:50 +00:00
Sean Harvey
972558df3f
BUGFIX If DropdownField->Field() lack of source checking before looping through it
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64320 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 23:25:55 +00:00
Ingo Schommer
2ddc6f13e8
BUGFIX Fixed DropdownField handling of Iterator objects rather than arrays in the newly created getSource()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64318 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 21:44:38 +00:00
Ingo Schommer
dada15629a
ENHANCEMENT Added BankAccountField::is_valid_array_structure() to avoid PHP Notices when converting empty array values
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64305 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 12:57:17 +00:00
Ingo Schommer
c8c9c2166d
ENHANCEMENT Added DropdownField->setEmptyString() and DropdownField->setHasEmptyDefault() to decrease constructor arguments and allow for modification of behaviour after calling construtor. Added DropdownField->getSource() to dynamically include empty defaults at rendering-time rather than construction time. Adjusted DropdownField subclasses to new behaviour
...
ENHANCEMENT Added DropdownFieldTest
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64304 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 12:39:09 +00:00
Will Rossiter
28bfea28b8
BUGFIX: fixed default_country_value so that it will actually call the default country if IP lookup doesnt work
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64275 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 03:26:24 +00:00
Andrew O'Neil
68aaa32e86
BUGFIX Fix disappearing fields when a field without a name was being pushed onto a FieldSet (eg a CompositeField)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64263 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-15 01:30:14 +00:00
Ingo Schommer
ff93176f70
ENHANCEMENT Making confirmation message in ConfirmedFormAction translatable
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64252 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 23:07:05 +00:00
Ingo Schommer
3b16fe9b59
BUGFIX Fixed ComplexTableField->saveComplexTableField() success message object link - was assuming same context as ComplexTableField_ItemRequest
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64251 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 23:06:22 +00:00
Ingo Schommer
d5a37d40dd
ENHANCEMENT Showing image thumb before input field in a separate block <div class="thumbnail"> in SimpleImageField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64238 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 21:46:52 +00:00
Ingo Schommer
6feab01a6f
BUGFIX Fixed FormScaffolder string literal parsing FALE in getFieldSet()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64237 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 21:38:37 +00:00
Ingo Schommer
524d7a9011
ENHANCEMENT Disrecard $includeRelations setting when scaffolding $has_one relationships in FormScaffolder - use $restrictFields to limit instead
...
BUGFIX Using fieldLabel() for $has_one relationships in FormScaffolder
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64224 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-14 19:31:18 +00:00
Ingo Schommer
a24ccecb69
FEATURE Added ForeignKey and used it in relation- and databasefield getters in DataObject
...
FEATURE Added FormScaffolder for more flexible scaffolding of FieldSets from DataObject metadata
API CHANGE Removed DataObject->addScaffoldRelationFields(), now in separate class FormScaffolder
API CHANGE Changed parameters for DataObject->scaffoldSearchFields() to unify them with scaffoldFormFields()
API CHANGE Added optional $params parameter to DataObject->getCMSFields() to be passed on to scaffoldFormFields()
API CHANGE Renamed DataObject->getFormFields() to getFrontEndFields()
ENHANCEMENT Added $params parameter to all DBField->scaffoldFormField() subclasses
API CHANGE Added third optional parameter $object to DBField::create() to comply with ForeignKey and PrimaryKey constructors
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64157 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-13 22:20:41 +00:00
Hayden Smith
8a1ab89b84
BUGFIX: Fixed order of arguments.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64109 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-12 22:21:35 +00:00
Ingo Schommer
8cc5625708
ENHANCEMENT Ability to add title constructor arguments to Tab and TabSet classes to resolve i18n issues with untranslated or unreferencable Tabs (see #2359 )
...
ENHANCEMENT Support for $field_labels in relation tabs created by DataObject->addScaffoldRelationFields()
ENHANCEMENT Type checking and user errors for Tab and TabSet constructor arguments
ENHANCEMENT Supporting titles in FieldSet->findOrMakeTab()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64073 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 16:00:50 +00:00
Ingo Schommer
9d596f6157
ENHANCEMENT Using i18n fieldlabels for column-headlines in TableListField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64067 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-10 12:13:23 +00:00
Ingo Schommer
d2e5662d47
MINOR Formatting
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64014 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 20:27:01 +00:00
Ingo Schommer
18855687fc
BUGFIX Making less assumptions about object structure in FieldSet->addFieldToTab() error messages
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@64007 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 15:15:39 +00:00
Ingo Schommer
67f144e1a5
BUGFIX Fixed Form->loadDataFrom() to properly populate FormField->setValue() when an object is passed as the first parameter (needed e.g. for CheckboxSetField->setValue()) - see mailinglist discussion at http://groups.google.com/group/silverstripe-dev/browse_thread/thread/717bada8ccafdd70
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63998 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 14:37:46 +00:00
Sean Harvey
d794b11910
BUGFIX Added missing slash in TableListField_Item->Link()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63945 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 02:20:35 +00:00
Sam Minnee
fce3767389
API CHANGE: Added support for dot syntax to FieldSet::fieldByName()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63922 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-09 00:32:10 +00:00
Hayden Smith
f0af7dd9a5
Corrected reverted merge. ComplexTableField::setPopupSize is now present.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63882 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 19:22:07 +00:00
Sam Minnee
cf5b6342df
BUGFIX: Fix FieldSet::replaceField() so that it doesn't clobber tabs
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63824 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:37:12 +00:00
Sam Minnee
1b1751457e
Removed relational CTFs reliance on DataObject->ClassName
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63820 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:35:27 +00:00
Sam Minnee
51447b89ab
BUGFIX: Fixed pagination in TableListField after hsmith's changes
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63819 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:32:33 +00:00
Sean Harvey
332da65edb
MINOR Tidied up argument list for Object::create() in ComplexTableField->AddForm()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63815 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 02:40:10 +00:00
Ingo Schommer
431afe234f
BUGFIX PHP Notice in InlineFormAction_Readonly
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63809 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 02:03:05 +00:00
Hayden Smith
634ed7b70c
Merged from branches/nzct-trunk. Use 'svn log -c <changeset> -g' for full commit message. Merge includes stability fixes and minor refactor of TableListField and ComplexTableField.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63806 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 02:00:12 +00:00
Ingo Schommer
78c052af9e
API CHANGE Deprecated Form->loadNonBlankDataFrom() - it was duplicating loadDataFrom() without allowing for the same options, and it was buggy in its definition of "blank" by doing non-typesafe checks with if($value) $field->setValue($value) which resulted in '0' strings not being loaded
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63764 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 17:52:27 +00:00
Ingo Schommer
9d405ed4ae
ENHANCEMENT Reformatted and documented Form->loadDataFrom() - no functionality changed
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63763 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 17:44:46 +00:00
Ingo Schommer
0084e993cc
MINOR Documentation for Form class
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63760 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 16:47:01 +00:00
Ingo Schommer
f009e8de8a
API CHANGE Moved PostBackup class to module (see r63758)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63759 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 16:42:25 +00:00
Sam Minnee
ce42fd3f26
BUGFIX: Fixed createTag for proper generation of DropdownField blank items
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63716 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 03:03:00 +00:00
Ingo Schommer
802317c705
FEATURE Added HTTP method override support to HTTPRequest and Form (through $_POST['_method'] or $_SERVER['X-HTTP-Method-Override']), incl. unit tests
...
ENHANCEMENT Added Form->FormHttpMethod()
ENHANCEMENT Added HTTPRequest->httpMethod()
ENHANCEMENT Added HTTPRequest::detect_method()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63679 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-06 14:58:01 +00:00
Ingo Schommer
21859d3d97
ENHANCEMENT Added FieldSet->hasTabSet() incl. unit test
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63628 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 18:29:43 +00:00
Ingo Schommer
7ab2748034
BUGFIX php notice in CountryDropdownField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63627 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 18:28:50 +00:00
Ingo Schommer
e5d4bf6216
BUGFIX Disabled user_error in ComplexTableField->sourceID() when no formfield 'ID' is found in ComplexTableField->$detailFormFields - not strictly required as we can deduce it from the URL. It was causing conflicts with DataObject->scaffoldFormFields() not returning an 'ID' field
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63622 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 16:19:31 +00:00
Ingo Schommer
82d6b7e640
BUGFIX Escaping added database columns in queries for TableListField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63618 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 15:57:01 +00:00
Ingo Schommer
a672459973
MINOR Documentation
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63617 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 15:56:14 +00:00
Ingo Schommer
8f3b3fedaa
MINOR Documentation
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63616 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 15:55:39 +00:00
Sam Minnee
5fb39c998e
Fixed FormField::createTag() generation for empty <select> tag, which meant that page version history was displayed in single-language mode
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 02:59:38 +00:00
Sam Minnee
7fbeb7d6c5
BUGFIX: Fixed ComplexTableField export
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 02:25:49 +00:00
Ingo Schommer
6bd34d3e53
ENHANCEMENT Using ss.i18n in all sapphire form fields with clientside language strings
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63567 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 00:47:08 +00:00
Sam Minnee
6694936cc8
Updated BankAccountField to allow setting it to blank without a notice-level error
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-02 22:41:17 +00:00
Sam Minnee
f8c1f84a0d
#2397 - Fixed HTMLEditorField style dropdown
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63548 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-02 22:15:37 +00:00
Sam Minnee
a34ff7589b
BUGFIX: Removed notice-level errors in ListboxField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63527 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-02 10:09:29 +00:00
Sean Harvey
2c773d0d69
MINOR phpdoc tweaks
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63490 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-02 00:34:16 +00:00
Ingo Schommer
b33aaf81ae
ENHANCEMENT Setting SimpleImageField->allowedExtensions to sensible defaults
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63470 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 18:33:30 +00:00
Ingo Schommer
b548ee6360
API CHANGE Deprecated Form->resetData() - use Form->resetField()
...
ENHANCEMENT Added Form->resetField()
MINOR Documentation for Form
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63468 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 18:32:10 +00:00
Sean Harvey
c08f6e4dbb
MINOR Code formatting changes for readability and consistency in DropdownField->Field()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63420 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 20:08:17 +00:00
Sean Harvey
fb1b0b4381
MINOR Fixed PHP notices in ListboxField->Field() by defining the variables first
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63385 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 03:21:28 +00:00
Ingo Schommer
2c11afb2df
BUGFIX wrong jsparty PATH references
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63296 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 18:49:55 +00:00
Sean Harvey
11e09aa0d6
ENHANCEMENT Tidied up DropdownField->Field() by making use of FormField->createTag() as other FormField subclasses such as TextField do
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63289 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 10:31:06 +00:00
Sean Harvey
ba509c5336
ENHANCEMENT Moved UserDefinedForm and related code, templates, CSS and javascript out of cms and sapphire classes into userforms/trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63249 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 03:18:23 +00:00
Ingo Schommer
fabf01d076
ENHANCEMENT Introduced constants for system paths like /sapphire in preparation for a more flexible directory reorganisation. Instead of hardcoding your path, please use the following constants: BASE_PATH, BASE_URL, SAPPHIRE_DIR, SAPPHIRE_PATH, CMS_DIR, CMS_PATH, THIRDPARTY_DIR, THIRDPARTY_PATH, ASSETS_DIR, ASSETS_PATH, THEMES_DIR, THEMES_PATH
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63175 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 13:12:20 +00:00
Ingo Schommer
e2b626434a
MINOR Documentation for image uploads
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63174 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 13:08:56 +00:00
Ingo Schommer
9371f4688b
ENHANCEMENT Introduced constants for system paths like /sapphire in preparation for a more flexible directory reorganisation. Instead of hardcoding your path, please use the following constants: BASE_PATH, BASE_URL, SAPPHIRE_DIR, SAPPHIRE_PATH, CMS_DIR, CMS_PATH, THIRDPARTY_DIR, THIRDPARTY_PATH, ASSETS_DIR, ASSETS_PATH, THEMES_DIR, THEMES_PATH
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63154 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-27 16:02:38 +00:00
Sam Minnee
6915ac9bc7
Turned dos line endings into unix
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63113 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-26 02:22:51 +00:00
Sam Minnee
9f05546c1e
Fixed bug with ComplexTableField inappropriately referencing a relation field that doesn't exist
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62998 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-24 05:24:51 +00:00
Sam Minnee
a47f5834a2
BUGFIX: Fixed bug introduced into AssetTableField by previous CTF change
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62909 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-23 03:15:49 +00:00
Sam Minnee
2dcda9bd91
BUGFIX: Fixed a number of really basic problems with a number of date fields - got basic loading and saving working across them all
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62885 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-23 01:44:40 +00:00
Sam Minnee
ed311db3bf
ENHANCEMENT: ComplexTableFilters used to edit relations have their filter automatically set, as well as the foreign key on new records.
...
API CHANGE: TableListField::sourceFilter() can be overloaded to change the querying logic.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62883 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-23 01:24:03 +00:00
Ingo Schommer
be90ef6573
ENHANCEMENT Allowing empty selection in TypeDropdown
...
ENHANCEMENT Allowing to specify dropdown title field in TypeDropdown->setTitleFieldName() - patch by nicolaas (#2689 )
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62848 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-22 18:59:00 +00:00
Sam Minnee
b87bdee3ee
Added CountryDropdownField::defaultToVisitorCountry(false):
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62692 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-18 21:33:23 +00:00
Sam Minnee
a6577d9749
Fixed bug with preivous CheckboxSetField change
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62648 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-18 03:16:03 +00:00
Sam Minnee
442af1a7ca
Fixed loadDataFrom for CheckboxSetFields that are used to edit a many-many relation, if loadBlanks is set to true
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62641 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-18 02:50:14 +00:00
Saophalkun Ponlu
6b6209019c
comment Debug.traceback that occur when the field is a tab
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62599 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-17 22:31:01 +00:00
Sean Harvey
955d500a95
BUGFIX createTag() on FormField subclasses should use getTabIndex() instead of getTabIndexHTML() as createTag() is responsible for generating the HTML, and all we need is the tabindex value
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62490 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-16 23:14:31 +00:00
Sean Harvey
1e12016ed6
MINOR FileField->Field() code formatting changes
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62424 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-16 02:14:25 +00:00
Saophalkun Ponlu
b32cf74642
Added empty string as a default (first item)
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62386 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-15 05:01:37 +00:00
Sean Harvey
b7a2e4c8f2
BUGFIX Type checking problem in LookupField->Field(), merged in from r62387
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62381 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-15 04:32:53 +00:00
Sam Minnee
8b83c68f4c
Fixed ConfirmedPasswordField validation for min password length
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62331 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-12 05:40:55 +00:00
Sean Harvey
1ba9c9a90a
API CHANGE Moved DataReport and SQLReport into the ecommerce module, since this is the only place it is used, plus it's going to be deprecated soon anyway
...
BUGFIX Removed DataReport.js calls in LeftAndMain until we figure out a better way of doing
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62325 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-12 04:58:06 +00:00
Sam Minnee
6e5b511c46
BUGFIX: Allow creation of a tab and a field of the same name; bug cause by the duplicate field merging code introduced recently.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62320 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-12 04:42:24 +00:00
Sean Harvey
07f40d2cc6
API CHANGE Deprecated LabelledLiteralField by adding a @deprecated note with alternate approaches, and added a PHP notice for people currently using it
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62316 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-12 03:48:13 +00:00
Sean Harvey
0c7d39e792
API CHANGE Moved ProgressBar and support files to newsletter/trunk module, as this is the module where it's used
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62309 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-12 03:22:20 +00:00
Sam Minnee
5393392c48
Fixed bugs with #1403 changes made in r62218.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62268 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-11 06:24:40 +00:00
Sam Minnee
62414fdfa6
FEATURE: #1403 - addFieldToTab(), push(), insertBefore(), etc will allow duplicates - the old field is replaced with the new.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62211 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-11 00:02:49 +00:00
Sam Minnee
0075040f87
API CHANGE: TableListField::ajax_refresh is deprecated. Removed all calls to it from the core, instead getting HTML fragments by visiting the field's URL.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61683 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-28 04:14:22 +00:00
Sam Minnee
556031ce34
Fixed bug in TableListField::ajax_refresh
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61613 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-27 04:58:08 +00:00
Normann Lou
6a897d7bfa
getSummaryFields() will also get those summary fields defined in Member's decorator applied to the results and export
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61509 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-26 01:45:52 +00:00
Sean Harvey
413b309d17
Reverted r61492
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61497 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-25 23:32:12 +00:00
Sean Harvey
8dff62d3cb
API CHANGE Deprecated GroupedDropdownField, DropdownField should now be used instead
...
ENHANCEMENT DropdownField now allows for <optgroup> elements in the field source by passing in a two dimensional array - this was taken from GroupedDropdownField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61485 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-25 08:58:38 +00:00
Sean Harvey
bb0dd22164
ENHANCEMENT RequiredFields->php() uses quotes around title of field, falling back to the name of the field if title isn't available
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61420 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-22 04:16:33 +00:00
Sam Minnee
65604f4ab6
Fixed saving of TableField and added tests
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61411 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-22 03:33:43 +00:00
Sam Minnee
8505039954
Undeprecated a critical feature of TableField, and reimplemented in the Group's permission field. Cleaned up its implementation to be more in line with TableListField
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61370 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-22 00:47:36 +00:00
Will Rossiter
e085ee19d7
BUGFIX: fixed ManyMany relation for same object
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61292 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-21 05:30:49 +00:00
Romain Louis
5689ec0caa
MINOR setRelationAutoSetting function adding
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61217 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 22:47:46 +00:00
Sam Minnee
0e1289bdf2
Merged branches/kiwiselect into trunk
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61184 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 06:31:12 +00:00
Sean Harvey
7912aa3b4a
MINOR Fixed PHP notice in CheckboxSetField when transforming to readonly
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61164 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 05:16:30 +00:00
Sean Harvey
09af15d382
BUGFIX sourceFilter should be a string, not an array
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61162 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 05:13:53 +00:00
Sean Harvey
3ae2a7e605
MINOR PHPdoc for FieldSet->replaceField()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61161 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 05:11:07 +00:00
Sean Harvey
700cb7c68b
MINOR PHP notice fix for FileIFrameField->Field()
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61160 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 05:10:15 +00:00
Sean Harvey
d69c3d6a1a
ENHANCEMENT Added FieldSet->removeFieldsFromTab() which does exactly what removeFieldFromTab() does, but with an array of field names
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61157 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 05:03:50 +00:00
Sean Harvey
2b49d18350
BUGFIX HtmlEditorField_Toolbar->LinkForm() for editing a link inside an HtmlEditorField instance was showing page titles using the "Title"
...
field, changed to "MenuTitle" to be consistent with the main CMS site tree and to avoid confusion
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61155 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:57:55 +00:00
Sean Harvey
7f6be42004
ENHANCEMENT Added getter method for CompositeField->children
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61149 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:41:55 +00:00
Sean Harvey
dc5607d8f0
ENHANCEMENT If title not passed into TextareaField constructor, it defaults to the name value
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61147 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-20 04:36:45 +00:00
Sam Minnee
ec9a40ee50
Fixed bug in TableListField sort links
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61065 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-19 10:07:28 +00:00
Sam Minnee
292140897a
Allow querystrings in arguments passed to Controller::join_links()
...
Fix FormField::Link() to allow querystrings in the form's action
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61064 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-19 10:06:43 +00:00
Saophalkun Ponlu
505fef0791
Removed double quoute from the from fields as it means field terminator
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60937 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 04:23:24 +00:00
Sam Minnee
3fe588bbf5
Added ComplexTableField::getCustomFieldsFor() that you can overload in subclasses of ComplexTableField to create alternative pop-up forms
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60910 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:50:39 +00:00
Saophalkun Ponlu
ffb5d82bc2
replaced <br /> with newline for CSV export
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60907 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:41:38 +00:00
Sam Minnee
75ae9859ae
API CHANGE: Added Validator::set_javascript_validation_handler() and ->setJavscriptValidatorHandler(), to choose a different way of dealing with javascript validation. Currently 'none' and 'prototype' are the only legal options, but 'jquery' would be an obvious thing to implement.
...
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60894 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-18 00:07:37 +00:00