4c3a5441b2
Merge branch '4.6' into 4
2020-09-09 13:58:35 +12:00
27c1c72912
FIX ModuleManifest::getModuleByPath fix to ensure right module is returned ( #9569 )
...
* FIX: ModuleManifest::getModuleByPath returns the wrong module #9561
Co-authored-by: Nicolaas Thiemen <nt@sunnysideup.co.nz>
2020-09-09 13:47:36 +12:00
adaf793ddb
BUG Always validate Member credentials against DRAFT stage ( #9671 )
2020-09-08 11:47:04 +12:00
622cf8b914
FIX: Drop parameter names in Injector instantiation to preserve behaviour in PHP 8
...
Fixes #9667
2020-09-07 17:24:00 +12:00
e0f3797489
FIX: Remove deprecated & non-functional default argument config
...
This throws deprecation errors on PHP 8.
Fixes #9666
2020-09-07 17:24:00 +12:00
08010d5933
NEW Support namespace tokens in ClassInfo::parse_class_spec()
...
The T_NAME_QUALIFIED and T_NAME_FULLY_QUALIFIED tokens are introduced
in PHP 8, and encapsulate theentire FQCN, replacing the previous
structure of a group of T_STRINGs and T_NS_SEPARATORs.
2020-09-07 17:23:56 +12:00
ff04f97149
Add return type
...
Co-authored-by: Robbie Averill <robbie@averill.co.nz>
2020-09-01 08:43:36 -07:00
3575070b9d
FIX Removing selected column detail only if having is empty (MySQL "feature")
2020-09-01 16:21:43 +12:00
f9fc4f6641
FIX Allow for BC for DB adapters that return an actual boolean when selecting boolean literals in SQL
2020-09-01 16:20:07 +12:00
ef0af7ae9c
FIX Exists statements can't remove GROUP BY if there's a HAVING clause as it might rely on an aggregate
2020-09-01 16:20:07 +12:00
91591373d6
NEW Add exists as a method to the DataQuery API that will generate an SQL "exists" query
...
The exists query in SQL allows the query optimiser (engine specific) to execute these queries much faster - often only needing the presence of an index to return "yes it exists".
2020-09-01 16:20:07 +12:00
7474a76d1b
Merge pull request #9657 from creative-commoners/pulls/4/expose-recipe-core-version
...
NEW Add recipe-core to default VersionProvider module list
2020-08-28 10:36:58 +12:00
699913406b
NEW Added a dev view to output the current config from dev/config ( #9542 )
...
* #3236 Added dev/config view
* Refactored use of echo to
* Added config/audit for matching missing property definitions in the current config
* Minor enhancements to dev/config implementation
2020-08-28 07:19:03 +12:00
9aa2642d03
Merge pull request #9639 from creative-commoners/pulls/4/embed-performance
...
NEW Cache embed shortcodes
2020-08-27 12:15:24 +12:00
680adbd10b
NEW Add recipe-core to default VersionProvider module list
...
Recipe versions are a more useful indicator than the framework module
version, so if installed we want to show the recipe-core version. The
cms module expands upon this to include recipe-cms.
2020-08-26 14:49:11 +12:00
7c84171d5b
NEW: Improved task runner UI. ( #9540 )
...
Co-authored-by: Sacha Judd <sjudd@silverstripe.com>
2020-08-26 11:11:13 +12:00
efdd359485
Fixed spelling and changed to shorthand array
2020-08-23 14:31:06 +02:00
a380cc7444
Added exception for enumerated array ( #9644 )
...
\SilverStripe\View\ArrayData::__construct() throws error when passed an enumerated array #9644
2020-08-22 13:48:59 +02:00
7377d094c0
FIX: Include missing security page titles when CMS not installed ( fixes #9648 )
2020-08-21 14:55:06 +01:00
c143941e44
Merge pull request #9628 from creative-commoners/pulls/4/version-provider
...
NEW Additional logic for VersionProvider
2020-08-21 14:25:23 +12:00
abd0f3fbf3
Fix DataList->column mutating underlying DataQuery
2020-08-21 09:25:27 +10:00
b810b7d5c9
API: Allow for user-created objects to have values passed in the constructor ( #8591 )
2020-08-20 12:28:31 +12:00
7304acb171
NEW Cache embed shortcodes
2020-08-12 12:14:05 +12:00
e19ef240f7
NEW VersionProvider now supports recipes as well as modules
2020-08-11 13:04:48 +12:00
26b8b7964e
Rename DefaultEllipsis to defaultEllipsis
2020-08-07 09:48:42 +12:00
896c0e4388
BUG Use proper ellipsis character in the various summary method.
2020-08-06 19:37:03 +12:00
c2ed6a4cd6
NEW: WithMockTime callback.
2020-08-06 11:18:39 +12:00
65c3295917
Merge branch '4.6' into 4
2020-08-05 10:52:49 +12:00
e368c370ff
Merge pull request #9627 from creative-commoners/pulls/4.6/try-catch-config-db-paths
...
FIX Handle DatabaseAdapterRegistry cache exception
2020-08-03 09:19:02 +01:00
b59f75dd50
FIX Handle DatabaseAdapterRegistry cache exception
...
Co-authored-by: Loz Calver <lozcalver@bigfork.co.uk>
2020-08-03 10:57:27 +12:00
8287fad24d
Merge branch '4.6' into 4
2020-07-29 11:38:49 +12:00
52d38a8b4a
Merge pull request #9615 from creative-commoners/pulls/4.6/embed-iframe-dimensions
...
FIX Set iframe dimension attributes specified in shortcode
2020-07-28 11:04:24 +12:00
f0936d4c1e
FIX Set iframe dimension attributes specified in shortcode
2020-07-27 18:04:03 +12:00
e2443763a6
Merge pull request #9064 from creative-commoners/pulls/4.5/filter-interface
...
NEW Add FilterInterface and retrofit into URLSegmentFilter
2020-07-27 11:18:23 +12:00
f264ff8616
PATCH: improving @return values in docblocks
2020-07-23 22:40:14 +12:00
d292eb8840
PATCH: fix doctype return type hints: add null
2020-07-23 21:10:17 +12:00
5e7f0a5685
Merge pull request #9599 from martinheise/groupeddropdown-readonly
...
BUG Readonly version of GroupedDropdownField
2020-07-21 09:21:52 -07:00
404f450ac3
BUG Readonly version of GroupedDropdownField
...
GroupedDropdownField was showing empty values in Readonly mode due to not correctly handling the hierarchical source array.
Uses flattened source now in GroupedDropdownField->performReadonlyTransformation()
2020-07-21 09:23:30 +02:00
56f15b1c14
FIX Try Catch for embeded media ( #9424 )
...
* Try Catch for embeded media
* added missing namespaces, translatable message INVALID_URL
* generate tag only once
* catch after closing bracket
* space after comma
* Update src/View/Shortcodes/EmbedShortcodeProvider.php
* Linting
Co-authored-by: ivan@digitalgarage.ro <ivan@digitalgarage.ro>
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
Co-authored-by: Loz Calver <kinglozzer@gmail.com>
2020-07-17 19:38:01 +12:00
84b4057a9a
Merge pull request #9406 from chrispenny/feature/standardise-get-cms-validator
...
v4 improvement: Standardise getCMSValidator for DataObjects/Forms
2020-07-16 15:58:33 -07:00
34eb170075
Merge branch '4.6' into 4
2020-07-16 11:45:25 +12:00
65e0233258
PATCH: using standard way to refer to classes Group and PermissionRoleCode
2020-07-14 07:50:05 +12:00
d408a4e714
Merge branch '4.6' into 4
2020-07-13 12:28:14 +12:00
fbe0f5a981
Merge branch '4.5' into 4.6
2020-07-13 12:27:02 +12:00
2b9ef6be16
Merge tag '4.6.0' into 4.6
...
Release 4.6.0
2020-07-13 12:26:06 +12:00
8d6a248431
Merge remote-tracking branch 'origin/4.6' into 4
2020-07-11 09:07:39 +12:00
cce2b16309
[CVE-2020-6164] Remove/deprecate unused controllers that can potentially give away some information about the underlying project.
2020-07-10 17:57:06 +12:00
8518987cbd
[CVE-2019-19326] Stop honouring X-HTTP-Method-Override header, X-Original-Url header and _method POST variable. Add SS_HTTPRequest::setHttpMethod()
2020-07-10 17:56:15 +12:00
996c1b5719
[CVE-2020-6164] Remove/deprecate unused controllers that can potentially give away some information about the underlying project.
2020-07-10 15:03:18 +12:00
71db45b18b
[CVE-2019-19326] Stop honouring X-HTTP-Method-Override header, X-Original-Url header and _method POST variable. Add SS_HTTPRequest::setHttpMethod()
2020-07-10 14:57:26 +12:00
fae61c0f1d
Merge pull request #9582 from open-sausages/pulls/fix-gridfielddatacolumns-callback
2020-07-09 11:58:39 -07:00
0ed340faa9
Merge pull request #9584 from open-sausages/pulls/4.5/plain-method-for-chinese-character
...
BUG Tweak DBHTMLText::Plain to avoid treating some chinese characters…
2020-07-09 23:13:12 +12:00
c3f0ac7718
Merge branch '4.5' into 4.6
2020-07-09 14:33:57 +12:00
f8360356e0
Merge branch '4.4' into 4.5
2020-07-09 14:28:28 +12:00
b780c4f504
BUG Tweak DBHTMLText::Plain to avoid treating some chinese characters as line breaks.
2020-07-09 13:33:43 +12:00
1f0a78e57b
FIX More context for GridFieldDataColumns callbacks
...
This emulates the callback signature from
GridFieldEditableColumns in the symbiote/silverstripe-gridfieldextensions module, which extends GridFieldDataColumns. In case canEdit() fails, this component passes control back to the parent (rendering a standard column content rather than a formfield). Which can become an issue if you've defined custom 'callback' handlers on setDisplayFields() - GridFieldDataColumns passes in only one arg (`$record`), while GridFieldEditableColumns passes in three (`$record`, `$col` and `$grid`).
While you could argue that this is a bug in the other module,
I think this additional context is beneficial for the main
GridFieldDataColumns use case as well, and it just happens to fix that bug.
2020-07-09 09:33:21 +12:00
3bf89b2d13
FIX Try Catch for embeded media ( #9424 )
...
* Try Catch for embeded media
* added missing namespaces, translatable message INVALID_URL
* generate tag only once
* catch after closing bracket
* space after comma
* Update src/View/Shortcodes/EmbedShortcodeProvider.php
* Linting
Co-authored-by: ivan@digitalgarage.ro <ivan@digitalgarage.ro>
Co-authored-by: Steve Boyd <emteknetnz@gmail.com>
Co-authored-by: Loz Calver <kinglozzer@gmail.com>
2020-07-03 13:04:54 +12:00
01d3b4fd96
FIX: Set many-many-through joinRecord on newly added records.
...
When many-many-through relations are queried, a joinRecord is set on
each DataObject in the list to provide the extra fields defined on
the connector object. This didn’t previously happen when the record
was first add()ed to a list. This fixes that bug.
2020-07-02 15:18:12 +12:00
ec83959f2c
API Remove UpgradeBootstrap (not part of our official API)
2020-06-30 21:35:51 +12:00
57d75c89d5
NEW Added onAfterBuild ( #9545 )
...
* Added onAfterBuild
* Remove arbitrary argument
2020-06-30 16:56:14 +12:00
16914bfdfc
Merge pull request #9531 from alessandromarotta/patch-1
...
DBField Documentation correction
2020-06-30 13:00:20 +12:00
00ee8d8abf
BUGFIX: Re-declare $items to be an ArrayList if it's null
...
getBackLink() modified to tolerate empty ArrayList
2020-06-29 16:07:24 +03:00
824b5e0b67
BUGFIX: Ensure $items isn't null in GridFieldDetailForm_ItemRequest->Breadcrumbs() prior to performing operations on it.
2020-06-29 14:13:49 +03:00
658ca4deb1
MINOR: Add noindex metatag to debugview
2020-06-25 12:09:28 +12:00
714c4cba9c
Merge pull request #9546 from andrewandante/feature/disambiguate_first_methods_on_lists
...
deprecate First and Last in order to disambiguate for array lists
2020-06-23 14:46:29 +12:00
b4669ad1bb
FIX 4.6 regression in the TempDatabase reset schema logic
2020-06-22 16:17:14 +12:00
09dca5fa9e
Update deprecation notice to 5.0.0
...
Co-authored-by: Robbie Averill <robbie@averill.co.nz>
2020-06-18 21:40:20 +01:00
34f660a311
Update src/View/SSViewer_BasicIteratorSupport.php
...
Co-authored-by: Robbie Averill <robbie@averill.co.nz>
2020-06-18 21:39:32 +01:00
4df45f4fe0
Merge pull request #9550 from jakxnz/pulls/4/docs-regarding-cached-get-ones
...
Added documentation regarding some cached ORM scenarios
2020-06-17 09:04:07 -07:00
6813c0f7e8
Added documentation regarding some cached ORM scenarios
2020-06-17 17:17:04 +12:00
9eadef19d3
Merge pull request #9544 from jakxnz/pulls/4.6/dataextension-doc-blocks
2020-06-15 23:32:59 -07:00
1a6e2da995
Merge pull request #9543 from jakxnz/pulls/4.6/undeclared-private-statics
2020-06-15 23:16:57 -07:00
7c95237e8d
update template docs, move deprecation to 5.0, capitalise Is
2020-06-15 12:25:13 +01:00
dadac00c19
Added array declaration to `GridFieldDetailForm_ItemRequest::$formActions`
...
Co-authored-by: Robbie Averill <robbie@averill.co.nz>
2020-06-15 11:45:33 +12:00
1edd8fd754
Added array declaration to `DevelopmentAdmin::$registered_controllers`
...
Co-authored-by: Robbie Averill <robbie@averill.co.nz>
2020-06-15 11:45:10 +12:00
fcc7a9ce5b
Added array declaration to `VersionProvider::$modules`
...
Co-authored-by: Robbie Averill <robbie@averill.co.nz>
2020-06-15 11:44:43 +12:00
dfe8d23ffc
Added extra type-hints to DataExtension DocBlocks
2020-06-12 13:45:14 +12:00
2e0e04f701
fix deprecation notices
2020-06-12 01:38:24 +01:00
7d87ba72d5
Merge branch '4.6' into 4
2020-06-12 11:20:53 +12:00
4daccfab67
Merge branch '4.5' into 4.6
2020-06-12 11:20:13 +12:00
bac826bc06
deprecate First and Last in order to disambiguate for array lists
2020-06-11 23:45:42 +01:00
2175de9560
Adjusted DataExtension DocBlocks to another degree of detail
2020-06-12 10:19:15 +12:00
0d6572a2d6
Added DocBlocks to DataExtension methods
2020-06-11 17:04:45 +12:00
84235c6518
Adjusted missing definitions to only include definitions referenced by framework
2020-06-11 14:28:47 +12:00
dfc01457d6
#3236 Added missing config definitions (private statics)
2020-06-11 13:35:15 +12:00
fa406c1115
Documentation correction
2020-06-02 09:33:52 +02:00
4303917ac5
DOCS Form::loadDataFrom constants in docblock
...
... missing MERGE_ prefix as defined in this class
2020-05-28 16:40:12 +01:00
eb658e0705
Merge pull request #9528 from silverstripe-terraformers/bugfix/remove-recursive-write-rebased
...
Remove recursive write until its fixed [Rebased]
2020-05-28 17:12:36 +12:00
d320026375
Remove recursive write until its fixed
2020-05-28 14:34:55 +12:00
d4165db690
Update getter name to getCMSCompositeValidator
2020-05-28 12:23:35 +12:00
8ba65313e9
Add internal note for protected method
2020-05-28 11:18:46 +12:00
bca4be77ed
Update name to CompositeValidator. Add docblocks
2020-05-28 11:18:46 +12:00
a2b57f0801
Update DefaultFormFactory extension point. Use array for validators
2020-05-28 11:18:46 +12:00
11e2005b9b
Add deprecation notice for 4.6 and update docs
2020-05-28 11:18:46 +12:00
f977f9734c
Add base updateValidatorList method to DataExtension
2020-05-28 11:18:46 +12:00
b45a3561df
Implemented PR feedback. Added some initial test cov
2020-05-28 11:18:46 +12:00
d7dd93f7a7
Standardise getCMSValidator for DataObjects/Forms
2020-05-28 11:18:46 +12:00
acccdd8a1c
Merge branch '4.5' into 4
2020-05-26 14:31:06 +12:00
42bb28965c
Merge branch '4.4' into 4.5
2020-05-26 14:30:27 +12:00
395893b559
Merge branch '4.3' into 4.4
2020-05-26 14:30:02 +12:00
Steve Boyd
Nicolaas
Maxime Rainville
Sam Minnee
Garion Herman
Guy Marriott
Jackson Darlow
Mojmir Fendek
Dylan Grech
Dylan Grech
Loz Calver
Mason Dechaineux
Martin Heise
rdigitalg
Robbie Averill
Ingo Schommer
Andre Kiste
Tom Yrjas
Aaron Carlino
Serge Latyntcev
Andrew Aitken-Fincham
Alessandro Marotta
Christopher Darling
Adrian Humphreys
cpenny