Commit Graph

1912 Commits

Author SHA1 Message Date
Steve Boyd af933e8226 MNT Double quote yaml string, fix phpcs warnings 2020-11-30 11:37:35 +13:00
Guy Marriott b0762593da
Merge branch '4.6' into 4.7 2020-11-17 15:46:54 -08:00
Guy Marriott 6a5cee69ab
Merge pull request #9766 from tractorcow/pulls/4.6/faster-dev-build 2020-11-17 15:43:21 -08:00
Steve Boyd ad839fdd6e Merge branch '4.6' into 4.7 2020-11-16 12:10:48 +13:00
Damian Mooyman 5d45bbdd0d
Update src/ORM/DatabaseAdmin.php
Co-authored-by: Guy Marriott <guy.the.person@gmail.com>
2020-11-13 11:48:50 +13:00
Damian Mooyman 2753516783
Fail over if calling deprecated method 2020-11-13 08:27:53 +13:00
Damian Mooyman 405a1f7cb6
ENHANCEMENT Better optimised class name migration with substantially fewer queries
Fixes #9752
2020-11-12 16:10:28 +13:00
Steve Boyd 6e77d5eada NEW DataObject related objects service 2020-10-29 09:29:26 +13:00
Garion Herman e89ae93ac9 FIX Harden hasMethod() against invalid values
This method should typehint the incoming value once union types are
available, but for now this ensures that method_exists() is not called
on scalar values, which is unsupported in PHP 8.
2020-10-28 09:34:33 +13:00
Garion Herman 91f831cd0b ENH Improve scalar response handling
This resolves an issue where method_exists() was being called on scalar
response values, which is not supported in PHP 8.
2020-10-26 13:20:47 +13:00
Steve Boyd 0e064300d9 ENH Add disabled attribute to SelectionGroup 2020-10-22 21:15:50 +13:00
Bernard Hamlin f00f64120d
NEW Allow setting sql_mode via config (#9721) 2020-10-22 15:01:30 +13:00
Garion Herman 256bd53557 DEP Remove unused league/flysystem requirement
This has been shifted to silverstripe/assets instead.
2020-10-13 12:15:56 +13:00
wernerkrauss 941df19e88
ENH Improve YamlReader exception message (#9731)
Fixes #9690
2020-10-12 22:38:13 +13:00
Serge Latyntcev 58ed426653 FIX TinyMCEConfig image size presets handle incorrect values 2020-10-12 17:31:59 +13:00
Serge Latyntcev 034bace213 FIX TinyMCEConfig image size presets handle incorrect values 2020-10-12 16:54:29 +13:00
Aaron Carlino 544b137328 Merge branch '4.6' into 4 2020-10-05 14:03:05 +13:00
Aaron Carlino 8053bc7a72 Merge branch '4.5' into 4.6 2020-10-05 13:49:06 +13:00
Sam Minnée 4ab36ac210
Merge pull request #9717 from robbieaverill/pulls/4.7/improve-stuff
Update spaces in syntax, single quotes, early returns where possible
2020-10-02 19:45:05 +13:00
Robbie Averill 7184703a57
Merge pull request #9516 from alessandromarotta/isLockectOut-call-LoginAttempt-getByEmail
isLockedOut() in Member.php call LoginAttempt::getByEmail but it passes to it the unique_identifier_field instead $this->Email
2020-10-01 17:43:30 -07:00
Robbie Averill 4d54a2110f Update spaces in syntax, single quotes, early returns where possible 2020-10-01 17:36:14 -07:00
Guy Marriott 478d487f0e
Merge pull request #9707 from robbieaverill/pulls/4.7/exceptions 2020-10-01 17:16:43 -07:00
Daniel Hensby fe45655a2b
Merge pull request #9698 from sminnee/pulls/symfony4
Symfony 4 support
2020-09-30 23:22:51 +01:00
Garion Herman 8ad4c4e024 FIX Fix namespace parsing under PHP 8, tweak readability of parser
$hadNamespace was ambiguously named, so the original PHP 8 support
update marked it true when it was strictly meant to indicate that a
namespace separator token had been encountered, resulting in bungled
parsing of complex class specs like Class(["arg" => true]).
2020-09-30 16:16:30 +13:00
Aaron Carlino 2042d1c6b0
MINOR: Allow DevelopmentAdmin to have subclasses (#9702) 2020-09-26 21:21:16 +12:00
Robbie Averill ae1e17edec Update exception assertions in tests and remove deprecated annotations 2020-09-25 10:06:49 -07:00
Robbie Averill 27bd5d12e3 ENH Replace E_USER_ERROR errors with exceptions 2020-09-24 23:51:21 -07:00
Sam Minnee 9247bc8b79 NEW: Add Symfony 4 support alongside Symfony 3
- Remove duplicate key in YML file
 - Remove deprecated yaml dump indentation set (the constructor arg works in both ^3 and ^4)

Fixes #9274
2020-09-21 19:09:08 +12:00
Dan Hensby ae0ece2b02
Merge pull request #9665 from creative-commoners/pulls/4/php8-fqcn-token 2020-09-18 20:44:22 +01:00
Sam Minnee 0d7c5a9ece NEW Add/remove callbacks on RelationList
This provides a mechanism for adjusting the behaviour of these
relations when building more complex data models.

For example the following example has a status field incorporates a
Status field into the relationship:

```php
function MyRelation() {
  $rel = $this->getManyManyComponents(‘MyRelation’);
  $rel = $rel->filter(‘Status’, ‘Active’);

  $rel->addCallbacks()->add(function ($relation, $item, $extra) {
    $item->Status = ‘Active’;
    $item->write();
  });
}
```

Introduces a new library dependency: http://github.com/sminnee/callbacklist
2020-09-18 13:33:42 +12:00
Maxime Rainville acce4c4ce7 BUG Remove old boostrap 3 CSS class 2020-09-16 11:03:27 +12:00
Loz Calver bca0f28b62
FIX: Make template parser error on mismatched brackets (fixes #8845) 2020-09-15 16:54:24 +01:00
Loz Calver bfc3b4b468
FIX: Stop empty comments breaking the template parser (fixes #8742) 2020-09-15 16:54:22 +01:00
Sam Minnee 85252ca05e FIX: Ensure Embed options are always array
This maintains support for embed 3.0.0.
2020-09-15 17:40:42 +12:00
Garion Herman f1c94e6d54 FIX Allow quotes in expected ReflectionExceptions within tests 2020-09-15 17:40:42 +12:00
Garion Herman 44685eceba FIX Support PHP 8 namespace tokens in i18nTextCollector 2020-09-15 17:40:42 +12:00
Garion Herman bad0662291 FIX Disable libxml_disable_entity_loader() calls in PHP 8 2020-09-15 17:40:42 +12:00
Sam Minnee b3dd27953b NEW: Allow league/csv ^9
Hopefully this has better PHP 8 support.
2020-09-15 17:40:42 +12:00
Sam Minnee 09fb33e657 FIX: Avoid passing non-class to get_parent_class()
Throws errors in PHP 8
2020-09-15 17:40:42 +12:00
Sam Minnee 5cb3d07f44 FIX: Avoid pass-literal-by-reference warning in PHP 8 2020-09-15 17:40:42 +12:00
Steve Boyd ab50e2cc51 Merge branch '4.6' into 4 2020-09-15 13:44:57 +12:00
Steve Boyd e339549e0d
Merge pull request #9649 from kinglozzer/9648-security-titles
FIX: Include missing security page titles when CMS not installed (fixes #9648)
2020-09-15 13:43:59 +12:00
Sam Minnee 2143660c3f FIX: Add class_exists() guards to SapphireTest
This test helper has a number of hooks to other parts of the
and required many class_exists() guards to operate without them

This has come out of PoC development work as part of:
https://github.com/silverstripe/silverstripe-framework/issues/9679

But can stand-alone as a mergeable PR.
2020-09-14 13:49:21 +12:00
Steve Boyd 015ea8cfc8 Merge branch '4.6' into 4 2020-09-11 11:54:23 +12:00
Damian Mooyman ac6f34846e
BUG Resolve issue where TreeMultiSelectField would error loading its value (#9604)
* BUG Resolve issue with TreeMultiSelectField not retaining value in some situations
E.g. in an elemental form
2020-09-11 11:52:36 +12:00
Robbie Averill de61681dec
Merge pull request #9634 from open-sausages/pulls/4/ellipsis
BUG Use proper ellipsis character in the various summary method.
2020-09-10 14:48:33 -07:00
Maxime Rainville 8bcfa57342 BUG Make PasswordEncryptor::check more resistent to timing attacks 2020-09-10 22:17:50 +12:00
Maxime Rainville acdebcdba7 Fix unit test 2020-09-10 17:08:13 +12:00
Steve Boyd 02827a6670 FIX Problem with direct compare in SELECT statement causing incompatibility with SQL Server database
Co-authored-by: Tomas Bilek
2020-09-10 14:48:09 +12:00
Jackson Darlow 2753f823ee
DOC Added a tip to docs describing how to set a cookie for less than a day (#9552)
DOC Added a tip to docs describing how to set a cookie for less than a day
Co-authored-by: Garion Herman <garion@silverstripe.com>
2020-09-10 12:34:33 +12:00