tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity
8,305 Commits 31 Branches 527 Tags 162 MiB
4c9fa6276d
Commit Graph

2808 Commits

Author SHA1 Message Date
Ingo Schommer
b5e9b911d3 BUGFIX Removed double quoting of $where parameter in Translatable::get_existing_content_languages() (fixes #6203, thanks cloph) (from r114080) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@114081 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:20:02 +13:00
Ingo Schommer
253083bc81 MINOR Documentation for Aggregate caching (from r114077) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@114078 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:20:02 +13:00
Sean Harvey
10d283a641 BUGFIX #6201 Use of set_include_path() did not always include sapphire paths in some environments 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@113976 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:20:02 +13:00
Saophalkun Ponlu
8381858d58 MINOR: Make sure that Translatable creates a translated parent of SiteTree only when the parent is not translated (from r113955) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@113956 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:20:01 +13:00
Sean Harvey
febcc15c3a MINOR Fixed spaces with tabs in Core 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@113924 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:20:01 +13:00
Sean Harvey
b7d7a86b51 MINOR Fixed spaces with tabs for Core::getTempFolder() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@113923 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:20:01 +13:00
Ingo Schommer
a9e611d721 ENHANCEMENT Allowing i18nTextCollector to discover entities in templates stored in themes/ directory (thanks nlou) (from r113918) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@113919 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:20:01 +13:00
Sean Harvey
68eebd8023 BUGFIX ErrorPage::requireDefaultRecords() case where no assets directory causes an fopen() error. Ensure assets directory is created before attempting to write error page files 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@113590 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:20:00 +13:00
Ingo Schommer
d2b489b4ef BUGFIX Clear static marking caches on Hierarchy->flushCache() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@113277 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:59 +13:00
Ingo Schommer
1aadb8c990 MINOR Using SecurityToken in ViewableData->getSecurityID() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@113274 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:58 +13:00
Ingo Schommer
20b41e1904 MINOR Documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@113241 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:58 +13:00
Sean Harvey
f58644116d BUGFIX Renamed MySQLQuery::__destroy() renamed to __destruct() so that it is called properly after the object is destroyed 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@112288 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:57 +13:00
Sean Harvey
9f673c1e9a MINOR Reverted regression in r112272 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@112278 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:57 +13:00
Sean Harvey
e81f11cc60 ENHANCEMENT MySQLDatabase::renameField() no longer checks that the field exists in fieldList(). alterField() does no such check, so it should be consistent. Removing this should provide a small performance improvement as well 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@112272 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:57 +13:00
Sean Harvey
5453c1a99d BUGFIX #3910 Setting timezone parameter to MySQLDatabase::__construct() should use $this->query() to be consistent 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111889 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:56 +13:00
Sean Harvey
14d9011658 ENHANCEMENT MySQLDatabase::getVersion() now uses mysql_get_server_info() which has been supported since PHP 4. This gives us a better version than say "5.1", instead we now get something like "5.1.51" 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111868 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:55 +13:00
Sean Harvey
80caa74d9d MINOR Revert r111850 to MySQLDatabase::getVersion as version comparisons need to happen, and this will strip out non-numeric characters e.g. "ubuntu1" or "lenny4" which are prefixed on some Linux distros 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111852 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:55 +13:00
Sean Harvey
5019881d1d MINOR dev/build now shows database name and version next to "Building database ..." text 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111851 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:55 +13:00
Sean Harvey
f0b68587bc ENHANCEMENT Make use of mysql_get_server_info() when calling MSSQLDatabase::getVersion(), if there's a problem getting info this way, falls back to using query for VERSION() details 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111850 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:55 +13:00
Sean Harvey
9d78fbb983 BUGFIX #6055 ErrorPage should always create static error page files when dev/build is called if they don't exist 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111842 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:55 +13:00
Ingo Schommer
622fda969f MINOR Fixed documentation in Datetime (fixes #6062, thanks nicolaas) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111787 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:54 +13:00
Sean Harvey
10f8318e32 BUGFIX DB::connect() should not rely on $_SESSION existing, so we check isset() to supress any warnings of undefined indexes 
MINOR Code formatting tidy of DB::connect() function


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111772 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:54 +13:00
Sean Harvey
47227a9395 BUGFIX ContentController::SiteConfig() should look to the SiteTree record so an alternate SiteConfig is considered, if this method doesn't exist on the data record then fall back to the default SiteConfig 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111255 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:53 +13:00
Sean Harvey
451fa7664b MINOR Spelling corrections to Director comments 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111123 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:52 +13:00
Sean Harvey
aa5eacc6ff ENHANCEMENT #6023 Shorten SSViewer cached template path for readability of the filenames, and also so Windows doesn't break on long paths 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111086 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:52 +13:00
Ingo Schommer
3cc576d69a MINOR Documentation for constants in Core.php 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111052 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:52 +13:00
Ingo Schommer
f4ae35b55a BUGFIX Unset $default_session when using Session::clear_all() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111049 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:52 +13:00
Ingo Schommer
1b5ec9bd50 BUGFIX: Don't require a current controller for Session::get/set/etc to work. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111043 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:51 +13:00
Ingo Schommer
94f03523b5 ENHACENEMENT: Change behaviour of the MenufestBuilder to use spl_autoload_register instead of traditional __autoload. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@111038 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:50 +13:00
Sean Harvey
ae89969321 BUGFIX Fixed column names that were not quoted that broke PostgreSQL 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@110944 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:50 +13:00
Sean Harvey
92c04a6a1c BUGFIX Fixed double quotes around column names in Versioned::augmentDatabase() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@110914 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:50 +13:00
Will Rossiter
f9a84974b6 BUGFIX: delete orphaned records from versioned tables when updating. #5936 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@110901 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:50 +13:00
Ingo Schommer
1ae4d04246 MINOR Avoid using ASP-style tags in SSViewer comments, it confuses PHP with asp_tags=ON (fixes #5976, thanks ezero) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@110836 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:49 +13:00
Will Rossiter
1f0d664150 BUGFIX: ensure that pages can only be requested from staging and live 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@110759 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:49 +13:00
Sean Harvey
c5bf8a31cb ENHANCEMENT #5977 Added optional argument to ClassInfo::getValidSubClasses() and removed harcoded SiteTree 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@110467 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:49 +13:00
Sean Harvey
d566ac4292 MINOR Warning about install.php existing for root site tree node as well (SiteConfig form) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@110440 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:49 +13:00
Andreas Piening
0e156f1759 MINOR: added missing closing tag 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@110243 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:49 +13:00
Sean Harvey
e65bfb893d MINOR Make dev/build not constantly show a changed index because of whitespace between VersionID and Version in the index spec 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@110205 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:48 +13:00
Andreas Piening
3a210c397a MINOR: only call next() in iterator validation on initialisation or after reset NOT if current value is invalid 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@110190 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:48 +13:00
Mateusz Uzdowski
0e60353e05 BUGFIX: makeRelative would return "false" for the root path, empty string is expected - fix that 
BUGFIX: change the check in forceSSL to work on Windows - it sets the $_SERVER['https'] to off, instead of null 



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109712 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:47 +13:00
Rainer Spittel
2d7b75d4cb BUGFIX: getItem didn't consider the PostgreSQL SQL syntax. Columns with Capital letters must be quoted. Added quotes to the where clause in getItem. I didn't added quotes to the baseTable because it causes PostgreSQL errors (tables can not be double quoted, just single quoted). 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109591 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:47 +13:00
Andreas Piening
0226781e37 MINOR: neatly quote identifiers 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109405 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:47 +13:00
Luke Hudson
4311966880 Revert "MINOR: Applied patch from walec51 for <% control %> on empty set (#5579) Also added unit tests by ischommer" 
This was not supposed to be pushed out yet.

This reverts commit 9c2aafa414948314236674e31fd756797d695139.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109177 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:47 +13:00
Sean Harvey
0cbde73445 API CHANGE #5873 DataObjectSet::shift() now performs a proper shift instead of unshift (wrong). Please use DataObjectSet::unshift($item) if unshifting was intended! 
API CHANGE Added DataObjectSet::pop()
MINOR Unit tests for DataObjectSet::shift(), DataObjectSet::unshift() and DataObjectSet::pop()


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109156 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:46 +13:00
Sean Harvey
9d33d6abaa MINOR Doc update for Director::forceSSL() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109152 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:46 +13:00
Luke Hudson
0e3bea57ce MINOR: Applied patch from walec51 for <% control %> on empty set (#5579) Also added unit tests by ischommer 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109127 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:46 +13:00
Sam Minnee
c488c6c93b ENHANCEMENT Session::set_cookie_path() and Session::set_cookie_domain() are now possible. This is useful for sharing cookies across all subdomains, for example. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109101 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:45 +13:00
Sean Harvey
730725fe86 BUGFIX SiteTree decorated canView() checks not being passed through to SiteTree::canView() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109082 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:45 +13:00
Sean Harvey
34a4aa5b00 BUGFIX StringField::setNullifyEmpty() should assign the given value boolean, not evaluate whether it's true or not 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@109081 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:45 +13:00
Andreas Piening
4659068c3f MINOR: remove SQL table alias keyword AS 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108961 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:44 +13:00
Sean Harvey
8b8df80ccb MINOR Fixed tests not working on the web side as redirection to https would occur 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108666 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:44 +13:00
Sean Harvey
7725426327 ENHANCEMENT #3828 500 server error page is created by default on dev/build 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108644 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:44 +13:00
Will Rossiter
de5462c9ef MINOR: allow $icon to be overridden on ErrorPages. PATCH via martljn (#5875). 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108640 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:44 +13:00
Sean Harvey
f9257a6035 ENHANCEMENT New Member records are populated with the currently set default through i18n::set_locale() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108499 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:43 +13:00
Sean Harvey
c7bef99190 BUGFIX Undefined variable destURL in Director::forceWWW() (regression from r107094) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108492 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:43 +13:00
Ingo Schommer
0d042e9a06 MINOR Making "todo" tab title translatable 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108441 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:43 +13:00
Sean Harvey
54f6acfc21 MINOR Fixed Director::forceSSL() breaking unit tests because headers were already sent 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108435 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:43 +13:00
Sean Harvey
c52529215f ENHANCEMENT #2856 Limiting of relative URLs for Director::forceSSL() using a map of PCRE regular expressions 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108428 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:42 +13:00
Sean Harvey
b4101984e4 BUGFIX Fixed ContentNegotiator to handle HTML and XHTML base tags properly when converting, regression from r108413 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108421 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:42 +13:00
Ingo Schommer
92ab004781 ENHANCEMENT Added argument to SQLQuery->leftJoin()/innerJoin() (#5802, thanks stojg) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108418 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:41 +13:00
Carlos Barberis
fa65f5edce ENHANCEMENT: Full-text search with double quotes returns too many results. ticket #5733. Thanks ktauber. 
Using htmlentities($keywords,ENT_NOQUOTES) instead of proposed solution


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108417 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:41 +13:00
Sean Harvey
5f383eea6b BUGFIX #5855 SSViewer::get_base_tag() should produce a properly closed base tag for XHTML (thanks smorris!) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108413 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:41 +13:00
Sean Harvey
52f1d1b17d BUGFIX Undefined variable when calling DataObject::many_many_extraFields() and relation name couldn't be found for the component 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108400 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:41 +13:00
Carlos Barberis
900d4ea23a BUGFIX: DataObjects without the Versioned decorator cannot have a "Version" field. ticket #5775. Thanks ajshort 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108399 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:41 +13:00
Carlos Barberis
dc8dee7dd9 BUGFIX: Added condition to avoid error creating "PastMember" cookie on dev/build (ticket #5780) Thanks simon_w 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108397 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:41 +13:00
Ingo Schommer
5a8f4b4605 MINOR Added warning about Director::set_dev_servers() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108049 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:40 +13:00
Sam Minnee
36bdb52823 BUGFIX: Don't have any host-based dev servers set by default. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108027 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:40 +13:00
Sam Minnee
cc1584cf12 ENHANCEMENT: Show a warning inside the the CMS if you've neglected to delete install.php 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108024 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:39 +13:00
Will Rossiter
797c8bf3f3 ENHANCEMENT: added getter to get array back out of an ArrayData instance. MINOR: updated docblocks in ArrayData 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@108012 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:39 +13:00
Ingo Schommer
78ac0fe3d6 ENHANCEMENT Allowing custom messages and permission codes in BasicAuth::protect_entire_site() 
ENHANCEMENT Making $permissionCode argument optional for BasicAuth::requireLogin(). If not set the logic only checks for a valid account (but no group memberships)
ENHANCEMENT Using SS_HTTPResponse_Exception instead of header()/die() in BasicAuth::requireLogin() to make it more testable

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107867 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:38 +13:00
Sean Harvey
7fc3d8bd09 MINOR Reverted r107831 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107838 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:38 +13:00
Sean Harvey
cf4be93f87 BUGFIX dev/build always reporting index change because of a whitespace in the index column names 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107831 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:38 +13:00
Ingo Schommer
71a9ff089d MINOR Moved class-specific documentation from doc.silverstripe.org back into class-level PHPDoc 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107725 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:38 +13:00
Will Rossiter
b0bb478615 MINOR: removed whitespace 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107586 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:38 +13:00
Will Rossiter
ce7cf0113c BUGFIX: fixed inclusion of environment file when document root is the web root 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107585 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:37 +13:00
Ingo Schommer
b20f1fd59d BUGFIX Remove dummy entry created by Versioned if record is first written to Live stage (fixes #5596, thanks muzdowski) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107537 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:37 +13:00
Saophalkun Ponlu
b8f27de42e ENHANCEMENT: html2raw now properly replace strong tag with asterix #5494 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107443 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:37 +13:00
Ingo Schommer
fcd9858271 MINOR Better error handling in i18n::get_language_name() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107437 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:36 +13:00
Saophalkun Ponlu
f9ea2613e6 ENHANCEMENT: allow adding a new a field to ArrayData 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107434 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:36 +13:00
Carlos Barberis
e344eb0dcc MINOR: Fixed Documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107430 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:36 +13:00
Carlos Barberis
4833ecbfd0 ENHANCEMENT: Added documentation and changed static names 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107429 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:36 +13:00
Carlos Barberis
30b4699734 ENHANCEMENT: Added static to set regeneration of default pages (ticket #5633) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107426 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:36 +13:00
Will Rossiter
7e30018e8d BUGFIX: Only highlight strings more than 2 characters long. #4949 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107423 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:36 +13:00
Ingo Schommer
8dee93b523 BUGFIX Allowing dev/build in "live" mode when Security::database_is_ready() returns FALSE (typically happens when an existing SilverStripe project is upgraded and database columns in Member/Permission/Group have been added) (fixes #4957) 
MINOR Using Object::create() in DevelopmentAdmin to make objects mockable
ENHANCEMENT Added Security::$force_database_is_ready to mock database_is_ready() state
ENHANCEMENT Added permission check exception in TaskRunner and DatabaseAdmin if SapphireTest::is_running_test() returns TRUE (necessary for DevelopmentAdminTest)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107415 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:36 +13:00
Ingo Schommer
423a526c8d MINOR Documentation in DataObjectSet 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107400 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:35 +13:00
Ingo Schommer
342d739504 MINOR Changed "no_NO" locale for Norwegian into the more commonly used "nb_NO" in i18n class, meaning translations from translate.silverstripe.com can actually be selected now (fixes #5746) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107394 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:35 +13:00
Sean Harvey
a10bb202af ENHANCEMENT Use array_combine() instead of custom logic for ArrayLib::valuekey() (thanks paradigmincarnate!) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107380 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:35 +13:00
Sean Harvey
3be26a4cec ENHANCEMENT #5352 Decouple date display from i18n locales, users now have access to change their date and time formats in Member::getCMSFields() using Member_DatetimeOptionsetField field 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107326 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:35 +13:00
Ingo Schommer
7e65d3c5af MINOR Documentation in File and Folder class 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107265 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Will Rossiter
d5ae174e95 MINOR: updated generator tag URL 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107214 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Andreas Piening
58e7936004 MINOR: force exclusive connection 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107175 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Will Rossiter
f7f237f119 ENHANCEMENT: abstracted protocol detection out to Director::protocol() #5450 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107094 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Will Rossiter
12aedc0e30 ENHANCEMENT: in referencing a file in combine_files() it should fall back to standard requirement tags if combining has been disabled eg dev mode 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107091 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Will Rossiter
c6364e5548 BUGFIX: prevented HTTPRequest->shift() throwing notices when shifting multiple elements. APICHANGE: SS_HTTPRequest->shift($multiple) no longer returns an array of size $multiple spaced with nulls, it returns an array up to the size of $multiple. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107090 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Will Rossiter
b834248ddc BUGFIX: fixed notice level errors getting through 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107089 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Andreas Piening
7be9ca0c7e MINOR: return false rather than error out in case SS_Query:: is not a resource 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@107030 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Andreas Piening
b5ad10bff1 MINOR: mysql_fetch_row() expects resource, this will fatal if query was e.g. UPDATE when iterating a result because MySQLQuery::nextRecord() is used by Iterator::valid() and MySQLQuery:: is bool in this case 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106938 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:33 +13:00
Ingo Schommer
422d654dae BUGFIX Re-enabling theme in ErrorPage->doPublish() (it's usually disabled in the publication context through LeftAndMain->init()) 
MINOR Reverted r88633, it breaks <base> tag in static HTML for ErrorPage->doPublish()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106777 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Ingo Schommer
3dc526c00f ENHANCEMENT Calling Image->deleteFormattedImages() in Image->onBeforeWrite() (#5423) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106705 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:32 +13:00
Luke Hudson
8079bfd417 MINOR: Correct typo in comments 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106313 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:31 +13:00
Ingo Schommer
25b65b71cf BUGFIX Checking for the same combined filename in Requirements::combine_files() to avoid irrelevant error messages 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106225 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:31 +13:00
Will Rossiter
41ec792cb4 ENHANCEMENT: added prefix and suffix support to ContextSummary 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106200 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:31 +13:00
Will Rossiter
b7d073d910 BUGFIX: if running in cli do not output html tags when rebuilding the db 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106154 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Sam Minnee
493fb1be55 BUGFIX: Replaced Versioned's unique index definition with an array syntax. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106120 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Sam Minnee
afdf8afaf4 BUGFIX: Fixed SiteTree::IsModifiedOnStage() for an edge-case that was identified when deleteFromStage() stopped manipulating the current record. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106082 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Sam Minnee
5fbc19f5be BUGFIX: Don't let deleteFromStage() kill the ID of the original record. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106080 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Sam Minnee
3f6005fd6a BUGFIX: Add a unique index to SiteTree_versions.RecordID+Version. Fix saving methods to support this. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106079 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Sam Minnee
e1753a35e5 BUGFIX: Throw an exception if you try an delete an unsaved or already-deleted record 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@106078 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:30 +13:00
Carlos Barberis
20fe6e8f6f BUGFIX: reverted revision 105890 to fix build 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105903 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:29 +13:00
Carlos Barberis
3bbcb31364 ENHANCEMENT: Added method for $this->request->latestParam() backwards compatibility with Director::urlParam() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105890 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:29 +13:00
Will Rossiter
eecac2f069 APICHANGE: refactored methods in session to use coding conventions 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105756 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:29 +13:00
Ingo Schommer
003d43f3ac BUGFIX Moved SiteTree->ParentID property to Hierarchy extension (fixes #5638) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105668 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:28 +13:00
Ingo Schommer
93f05f8acb BUGFIX More specific regex in Requirements->includeInHTML() to avoid duplicating information by matching HTML5-style <header> tags instead of <head> (fixes #5640) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105667 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:28 +13:00
Ingo Schommer
0742a38732 MINOR Using ASSETS_DIR and THEMES_DIR constant in Image, ManifestBuilder, Requirements, File (fixes #5619) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105282 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:27 +13:00
Ingo Schommer
24b365d4e2 BUGFIX Stricter object type checks in ViewableData->hasValue() and ViewableData->XMLval(). Broke in cases when SS_HTTPResponse is returned which doesn't extend from Object, hence doesn't have an exist() method (fixes #5524, thanks hamish) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105278 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:27 +13:00
Ingo Schommer
3aabb05d90 MINOR Documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105188 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:26 +13:00
Will Rossiter
9d36286291 MINOR: increased height of the todo text field in the cms 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105139 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:26 +13:00
Ingo Schommer
2927d55ccd MINOT Translation in SiteTree (#5603, thanks Pike) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105057 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:26 +13:00
Ingo Schommer
a6c968b3f3 MINOR Checking for headers_sent() before setting cookies in Versioned::choose_site_stage() to avoid problems with URL parameters like showqueries=1 and ContentController calling choose_site_stage() (fixes #5557) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105027 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:26 +13:00
Ingo Schommer
0960bdd76a MINOR Documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105011 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:26 +13:00
Ingo Schommer
cc592f98c2 MINOR Documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105009 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:25 +13:00
Ingo Schommer
9b11232961 MINOR Documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@105005 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:25 +13:00
Ingo Schommer
a6d019bd76 MINOR Documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104996 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:25 +13:00
Ingo Schommer
a0d4b58908 BUGFIX Fixed i18nTextCollector when used with i18nEntityProvider - class manifest is now stored lowercase, which means i18n::get_owner_module() didnt work reliably 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104995 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:25 +13:00
Ingo Schommer
a809289a25 MINOR Removed duplicated code in i18nTextCollector, more defensive checks for get_owner_module() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104992 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:25 +13:00
Ingo Schommer
416c8fcc2a MINOR Allowing translation of "save" button in SiteConfig->getCMSActions() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104978 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:25 +13:00
Will Rossiter
a9b238885c ENHANCEMENT: added Month function for consistency 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104935 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:25 +13:00
Ingo Schommer
d7cb0fc39d MINOR Fixed hidden mbstring reliance in SiteTree->generateURLSegment() (broken in r104679) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104883 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:24 +13:00
Mark Stephens
2eb9884ec9 BUGFIX: catch case of plugin not returning translations for the locale 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104847 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:24 +13:00
Mark Stephens
8e1f2b645c ENHANCEMENT: added plugins to i18n to support modules that provide custom translations. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104827 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:24 +13:00
Ingo Schommer
eb178cc75e MINOR Documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104795 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:24 +13:00
Ingo Schommer
36eb2c91ff MINOR Documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104769 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:24 +13:00
Ingo Schommer
4246cad180 MINOR Documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104767 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:24 +13:00
Andreas Piening
fffb0b91a4 MINOR: fixed umlauts 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104733 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:24 +13:00
Sam Minnee
656191c70b MINOR: fixed api doc 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104682 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:23 +13:00
Sam Minnee
76dfdd85ea BUGFIX: Make URLs lowercase 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104679 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:23 +13:00
Sam Minnee
cff1cf10d3 BUGFIX: Fixed Translatable::canEdit() to suit new permission customisation scheme 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104678 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:23 +13:00
Sam Minnee
9e56293931 ENHANCEMENT: Macrons, umlauts, etc, are now transliterated when inserted into URLS. API CHANGE: Added Transliterator class, which uses iconv() or strtr() to convert characters with diacritical marks to their ASCII equivalents. API CHANGE: Added Extension hook updateURLSegment for SiteeTree. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104671 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:22 +13:00
Sam Minnee
22e310dacd BUGFIX: Director::test() shouldn't break if $_SESSION isn't set. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104670 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:22 +13:00
Sam Minnee
8424f9c496 API CHANGE: Moved site tree permission extension to a 3-state system (true, false, null, where null means "no effect") 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104669 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:22 +13:00
Sam Minnee
bb5a333837 BUGFIX: Generate stage/live links using Controller::join_links() instead of string concatenation. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104581 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:21 +13:00
Sam Minnee
d8b6b59ebd BUGFIX: Fixed Controller::join_links() handling of fragment identifiers 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104580 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:21 +13:00
Ingo Schommer
32dfef3a2f MINOR Documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104483 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:21 +13:00
Sam Minnee
4fd6d3ad39 BUGFIX: When finding an old page in the 404 handler, favour existing subpages over historical ones. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104468 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:21 +13:00
Sam Minnee
2bc1af1752 BUGFIX: Fix legacy URL redirection for pre-nestedurls URLs, after it has been enabled. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104463 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:21 +13:00
Ingo Schommer
9f2a6ed501 MINOR Migrated various API-style documentation from doc.ss.org 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104157 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:20 +13:00
Ingo Schommer
d7134392d7 MINOR Documentation for DB::manipulate() (moved from http://doc.silverstripe.org/manipulation-arrays) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104121 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:20 +13:00
Luke Hudson
281e22b71e FEATURE: Add dev/build/defaults to call requireDefaultRecords 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104093 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:20 +13:00
Luke Hudson
2e6451f99b MINOR: Recognize and allow HTTP/422 response code 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104092 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:19 +13:00
Ingo Schommer
2210783c68 BUGFIX ViewableData->castingClass() cuts off last character of a casting definition if it has bracketed arguments (fixes #5536, thanks ajshort) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104063 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:19 +13:00
Ingo Schommer
f3e01c98b7 BUGFIX Fixed Database->requireTable() for Mysql 4.1 (fixes #5517, thanks gw0) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103957 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:19 +13:00
Will Rossiter
655faf0c39 APICHANGE: changed the modulus offset to 1 to correctly order sets 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103792 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:17 +13:00
Sam Minnee
29d4e5258f MINOR: Restored docblock of SQLQuery::unlimitedRowCount() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103692 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:17 +13:00
Sam Minnee
e86cf93f35 BUGFIX: Fixed ordering by aggregate columns for DataObject::get() calls with joins. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103620 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:16 +13:00
Sam Minnee
6f9aa32ccc BUGFIX: Fixed unlimitedRowCount() for grouped queries 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103613 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:16 +13:00
Sam Minnee
1df4ba601e BUGFIX: Ensure that group by of many-many queries with extraFields is set correctly. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103612 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:16 +13:00
Andreas Piening
907f6f7ead MINOR: recache tables if cache is empty 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103606 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:16 +13:00
Sam Minnee
6a72c21f0e BUGFIX #5362: Fixed duplicate removal on DataObject:get() with join argument for all databases. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103588 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:16 +13:00
Ingo Schommer
c8a338dcab ENHANCEMENT Added i18n::set_default_locale() to set standard locale (which is different from "current locale" retrieved through i18n::get_locale()) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103581 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:16 +13:00
Ingo Schommer
c8163eb609 BUGFIX Renamed Nested URLs are automatically redirected to their new location with 301 HTTP status code in ModelAsController/ContentController (fixes #5393, thanks cbarberis) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103461 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:15 +13:00
Ingo Schommer
219c5ff893 BUGFIX Allow EDIT_SITECONFIG permission selection in admin/security (fixes #5459) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103448 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:15 +13:00
Ingo Schommer
1f1dda8643 MINOR Fixed phpdoc documentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103398 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:15 +13:00
Ingo Schommer
df671a35f3 MINOR Fixed phpdoc documentation (from r103390) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103391 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:15 +13:00
Ingo Schommer
6f0df9eb19 MINOR Fixed phpdoc documentation (from r103385) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103388 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:15 +13:00
Sam Minnee
7b4261ed38 BUGFIX: Don't show error when adding default SiteConfig records after upgrading a site. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103341 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:14 +13:00
Ingo Schommer
2107985272 MINOR Enum DBField class should default to ExactMatchFilter to avoid wrong results with overlapping Enum values in LIKE queries (see #5434) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103322 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:14 +13:00
Geoff Munn
2518421b64 BUGFIX: static publishing now uses the last non-null theme, OR the value defined in StaticPublisher::static_publisher_theme. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103255 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:14 +13:00
Hamish Friedlander
f7c3c35a13 BUGFIX: r101093 broke casting of values from the failover object. Add lookup to the failover for casting info, and add test 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103240 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:14 +13:00
Mateusz Uzdowski
b6ab3b4ed0 ENHANCEMENT: allow onAfterPublish and onBeforePublish handlers directly on Page classes (#5112) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103198 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:13 +13:00
Geoff Munn
d21e7b0623 BUGFIX: default sort column now quoted 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103182 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:13 +13:00
Ingo Schommer
6410432a3a BUGFIX Only replace double slashes in SS_HTTPRequest->__construct() for relative- its a failsafe against wrongly formatted URLs like 'admin//assets' instead of 'admin/assets', but breaks absolute URLs with 'http://' prefix 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103099 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:13 +13:00
Mateusz Uzdowski
f410107b40 MINOR: fixed the error message on class conflict (#5439, patch submitted by rorschach) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103093 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:13 +13:00
Mateusz Uzdowski
2889e57590 BUGFIX: disallow numeric actions - numeric array indexes are incorrectly picked up as allowed actions (#5331) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103092 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:13 +13:00
Mateusz Uzdowski
9ac7da146b ENHANCEMENT: allow to check for any changed fields on the DataObject, this is expected behaviour when isChanged function is called without parameters (#5421, patch by walec51) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103047 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:13 +13:00
Carlos Barberis
7037afc879 BUGFIX: added optional separator for http_build_query in HTTP:setGetVar(). this fixes sorting columns in ModelAdmin (ticket #5325). 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@103012 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:12 +13:00
Ingo Schommer
0b44d49167 MINOR Using canView() instead of deprecated can('view') in ContentController 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102909 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:12 +13:00
Carlos Barberis
f413c30d91 ENHANCEMENT: added language (Ticket #5390) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102899 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:12 +13:00
Ingo Schommer
a948824c43 BUGFIX Fixing RquestHandler->checkAccessAction() on PHP 5.2 - ReflectionMethod->class returns inconsisent results in older PHP versions. (see r102003) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102730 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:12 +13:00
Sean Harvey
f6731e3efb BUGFIX Float should always be not null and default 0 in the database 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102686 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:12 +13:00
Ingo Schommer
3588f6cf16 BUGFIX Using i18n::get_locale() in ContentController->ContentLocale() to ensure the correct locale can be used in templates withouth Translatable enabled (broken in r97207, thanks DesignCity) (from r102544) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102545 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:12 +13:00
Ingo Schommer
551d8d9af3 MINOR Fixed undefined variable in SiteTree::can_edit_multiple() (broken in r83442) (from r102516) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102518 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:12 +13:00
Sean Harvey
53f2f7a873 BUGFIX #5316 Float and Double should never try to save NULL as the "null" value 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102460 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:12 +13:00
Will Rossiter
49ddb8d247 BUGFIX: delete from published site never calls canDeleteFromLive(). (via marcus #5364) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102386 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:12 +13:00
Mark Stephens
4568ac057d BUGFIX: SSViewer now allows cli to do a flush on non-dev environments 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102300 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:12 +13:00
Sam Minnee
6cf35458bd BUGFIX: Fixed bug with SiteTree::onBeforeWrite() that broke subsites. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102094 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:11 +13:00
Sam Minnee
04fe15cc7c BUGFIX #5343: Call DataObject::onBeforeWrite only once for SiteTree 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102084 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:11 +13:00
Sam Minnee
20a61098c6 BUGFIX #5337: Allow decoration of DataObject 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102081 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:11 +13:00
Andreas Piening
6db693a09e MINOR: added abstract datetime helper functions 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102077 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:11 +13:00
Ingo Schommer
4c71c667e3 BUGFIX Fixed SiteTree::page_type_classes() to exclude 'SiteTree' even if on array position 0 - slight difference in return values from Postgres to MySQL (fixes #5336) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102074 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:11 +13:00
Ingo Schommer
f6a8976121 BUGFIX Fixed SiteTree::page_type_classes() removal of base class (was broken if database driver returned classes in arbitrary order, e.g. in Postgres) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102026 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:10 +13:00
Ingo Schommer
09353a2b6c MINOR Fixed indentation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102009 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:10 +13:00
Ingo Schommer
c85b71623a BUGFIX Prevent handling of controller actions which return $this avoid infinite loops in RequestHandler->handleRequest (thanks Hamish!) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102004 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:10 +13:00
Ingo Schommer
4c74f45361 API CHANGE Disallow methods/actions in RequestHandler->checkAccessAction() which are implemented on parent classes (e.g. ViewableData and Object), unless access is controlled through $allowed_actions. This limits information exposure from getters used in template contexts. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@102003 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:10 +13:00
Ingo Schommer
9ae7fe67a5 BUGFIX Checking for existing redirections in FormResponse::respond (fixes #5208) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101958 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:10 +13:00
Sam Minnee
a4b4bd7fcd BUGFIX: Ensure that DataObject IDs are numbers and no string equivalents of numbers - 3 not '3' 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101939 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:09 +13:00
Tom Rix
ccd46b0bcc MINOR take advantage of an alternate path for error pages 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101883 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:09 +13:00
Sam Minnee
6892f1d196 BUGFIX #4188 simon_w: Let require tags in templates be conditional 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101867 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:09 +13:00
Sam Minnee
4864553aca BUGFIX: Recover if a manifestClassParse file doesn't have the necessary content. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101866 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:09 +13:00
Hamish Friedlander
04299df886 API CHANGE: Allow cached blocks within control and if blocks, as long as that control or if block is contained within an uncached block, not a cached block 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101833 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:09 +13:00
Will Rossiter
9bb41119e7 BUGFIX: preserve the port value if given in HTTP::setGetVar (#5280). BUGFIX: allow username only input rather than user:pass combo. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101793 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:08 +13:00
Geoff Munn
deaa1d675e BUGFIX: disable function re-enabled 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101792 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:08 +13:00
Ingo Schommer
ec642f1fad MINOR Marked DataObject::has_own_table() as static 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101782 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:08 +13:00
Ingo Schommer
0e4a042ece BUGFIX Always including "Locale" field in Translatable->getCMSFields() regardless of "excluded" page types. Necessary to enable form state serialization for fields like TreeSelectorField on a VirtualPage (fixes #5269) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101747 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:08 +13:00
Ingo Schommer
d41539ad22 BUGFIX Versioned->publish() with $createNewVersion=TRUE now increases version number of in-memory object (fixes #5261) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101739 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:08 +13:00
Sean Harvey
e36c38dbc1 BUGFIX #5277 Sort of default SiteTree records is now explicitly set to avoid strange ordering set by SiteTree::onBeforeWrite for default records 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101724 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:08 +13:00
Ingo Schommer
227dd2375c BUGFIX Don't replace "home/" URLSegment in SiteTree->RelativeLink() if Translatable is enabled and the homepage is not on the root level (nested URLs allows you to have homepages called "en/home" and "ru/home") (fixes #5244) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101711 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:07 +13:00
Sean Harvey
a894e5c1fe MINOR Reverted r101670 as it broke assumptions made in RedirectorPageTest 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101671 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:07 +13:00
Sean Harvey
b8520cc20c ENHANCEMENT RedirectorPage ExternalURL field now defaults to http:// to be consistent with the "Another website" option for HtmlEditorField LinkForm 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101670 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:07 +13:00
Sean Harvey
0e77cfbb09 BUGFIX #5259 RedirectorPage and HtmlEditorField TinyMCE integration now prefixes http:// if no prefix is found 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101668 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:06 +13:00
Sean Harvey
935db2a9c5 BUGFIX #5245 Sometimes page records will have a NULL ParentID value, it should be a number even if it's 0 (thanks wrossiter!) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101657 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:06 +13:00
Sean Harvey
20f0da7c05 BUGFIX #5243 Undefined Convert functions in ViewableData replaced with working versions. Thanks benediktb! 
MINOR Updated ViewableDataTest to verify ViewableData changes


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101638 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:06 +13:00
Geoff Munn
fcfd9e15a1 BUGFIX: test that the class exists before running subclass tests 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101631 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:06 +13:00
Mateusz Uzdowski
89c7430600 BUGFIX: put back into the SSNavigator the archived site link (#5251) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101623 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:06 +13:00
Mateusz Uzdowski
4bd3712206 BUGFIX: the function makes an assumption we are working on Draft site, and breaks if we are not. Rewritten to be stage-independent, as get_version (open #5231) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101603 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:06 +13:00
Will Rossiter
28c0d8171b MINOR: fixed notice level error 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101600 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:06 +13:00
Sam Minnee
5dfadd0e9c BUGFIX: HTTP::setGetVar() returns a relative URL if a relative URL is passed, to make behaviour closer to 2.3 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101392 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:05 +13:00
Sean Harvey
4a516d8eed MINOR Removed rewritest.php places in sapphire since it's no longer part of the phpinstaller/branches/2.4 package 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101353 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:05 +13:00
Ingo Schommer
3e8b155557 BUGFIX Fixed SiteTree->Content link shortcode parsing introduced in r101093 (#5227) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101302 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:04 +13:00
Ingo Schommer
1a30c9f8ff BUGFIX Checking for existence of "ShowInMenus" property in Folder->liveChildren() and stageChildren() (#5190) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101264 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:04 +13:00
Ingo Schommer
a3812e28a5 MINOR Fixed missing closing <div> in ContentController->successfullyinstalled() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101254 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:04 +13:00
Ingo Schommer
7028a42658 BUGFIX Don't delete index.php after successful installation - in ContentController->deleteinstallfiles(). URL routing might rely on it without mod_rewrite. 
BUGFIX Require ADMIN permissions for ContentController->deleteinstallfiles() - together with retaining index.php this removed a vulnerability where unauthenticated users can disrupt mod_rewrite-less URL routing. 

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101227 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:04 +13:00
Sam Minnee
f9836b0f01 BUGFIX: Pass correct class to allowPrimaryKeyEditing in yaml fixture 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101171 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:03 +13:00
Sam Minnee
52538032a8 BUGFIX: Don't recreate a missing draft page when calling SiteTree::doUnpublish() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101170 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:03 +13:00
Sam Minnee
5ab421e946 BUGFIX: Fixed versioning of pages 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101165 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:03 +13:00
Sam Minnee
d825a6bb5c BUGFIX: Prevent failed migrateVersion writes from breaking versioning system in future writes. 
BUGFIX: MAke site tree pages go green when you save a new draft.
API CHANGE: Add option for DataObjectDecorator::onAfterSkippedWrite()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101155 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:03 +13:00
Sean Harvey
682e7d0f1a BUGFIX #5214 ViewableData::obj() was creating a DBField without a fieldname argument and caused problems, one example is the version panel of the CMS 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101154 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:02 +13:00
Sam Minnee
f2bb6baa9f BUGFIX: Ensure that Versioned works on classes with underscores in the names. (from r100905) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101153 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:02 +13:00
Sam Minnee
f3a666b89f BUGFIX: Fixed issues with broekn link tracking 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101138 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:02 +13:00
Hamish Friedlander
267de8887a API CHANGE: Partial cache adjustments - now supports nested cache blocks (which are independant of their containing cache block), conditionals to control if a given cache block is active, and includes hash of template code in key (so template changes mean cache is invalidated). Changes template control for cache block to <% cached %>, to which the now deprecated <% cacheblock %> is aliased, and an additional template control <% uncached %> has been added. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101137 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:02 +13:00
Ingo Schommer
b37fede7d1 MINOR Localized "dependent pages" features in SiteTree->getCMSFields() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101134 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:02 +13:00
Sam Minnee
7c920762ae BUGFIX: Allow classes to be referred to with casing that differs from their definition. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101131 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:02 +13:00
Sam Minnee
3aad86d9be API CHANGE: Added SiteTree::VirtualPages() and SiteTree::DependentPages() accessors. 
BUGFIX: Improved reliabilty of broken link tracking.
ENHANCEMENT: Added 'Dependent pages' tab to CMS, to show virtuals, redirectors, and backlinks that point to this page.
BUGFIX: Don't mark a page as changed on stage if the only thing that has changed is broken link metadata

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101127 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:02 +13:00
Sam Minnee
34d53dc42d BUGFIX: Flush cache after deleting an item. 
BUGFIX: Fixed databaseFieldsOnly version of DataObject::getChangedFields()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101116 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:01 +13:00
Sam Minnee
25836a1bea BUGFIX: Fixed bugs with copying custom fields into Virtual pages, generally made virtual pages more robust and performant. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101112 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:01 +13:00
Sam Minnee
48d3f48edb BUGFIX: Fixed link rewriting to work on other HTMLText fields (from r99517) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101110 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:01 +13:00
Sam Minnee
021d339372 BUGFIX: Return true if SiteTree:doUnpublish() succeeds. (from r99515) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101109 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:01 +13:00
Sam Minnee
5a68d0f3b5 BUGFIX: Update Object::parse_class_spec() to handle arrays. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101105 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:01 +13:00
Geoff Munn
9395633251 BUGFIX: call_user_func_array changed to PHP 5.1 compatible notation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101099 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:01 +13:00
Sam Minnee
43b0ee21c6 API CHANGE: Replaced eval based creation of extension and field objects with Object::create_from_string(). 
API CHANGE: Introduced new function Object::create_from_string() to instantiate an object from a string like 'Int(50)'

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101093 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:01 +13:00
Sean Harvey
470082d12d BUGFIX Cookies set to a value other than NULL (effectively unsetting the cookie) will now use the httpOnly parameter by default for better XSS protection (from r101045) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101046 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:00 +13:00
Sam Minnee
5fc298cf1e API CHANGE: Made MySQL fulltext search optional, activated with MySQLFulltextSearchable::enable() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101044 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:19:00 +13:00
Sam Minnee
2a22e73615 API CHANGE: Pass the full extension string as the 2nd argument to DataObjectDecorator::extraStatics() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101043 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:59 +13:00
Sean Harvey
e9d9c7d84c BUGFIX Image should pass through the title to Image_Cached so that Image::getTag() can produce a more useful alt attribute instead of just the filename (from r101003) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@101005 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:59 +13:00
Sean Harvey
66ede9ce14 MINOR Removed unused variable in SiteTree::MetaTags() 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100992 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:59 +13:00
Sam Minnee
3f3c2b2fe9 BUGFIX: Fixed file-write testing issues in requirements combined file generation 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100982 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:58 +13:00
Sam Minnee
f057d60adc BUGFIX: Remove cache for Hierarchy::AllChildren() and Hierarchy::AllChildrenIncludingDeleted(), since they increase memory usage unnecessarily. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100980 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:58 +13:00
Sam Minnee
46586185f6 BUGFIX: Don't make CMS loading slow if the combined javascript files can't be written. 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100979 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:58 +13:00
Ingo Schommer
dd649257fe MINOR Renamed SiteTree->getEditFormFields() to getCMSFields() (including new decorator hook for 'updateCMSFields'). Renamed SiteTree->getEditFormActions() to getCMSActions() (including new decorator hook for 'updateCMSActions'). Old API was never released 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100967 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:58 +13:00
Ingo Schommer
c79a9d5a03 ENHANCEMENT Redirecting to translated page when original is requested with a 'locale' GET parameter (e.g. 'about-us/?locale=de_DE' will redirect to 'ueber-uns' with a 301 HTTP response). Implemented in ContentController->handleRequest(). (see #5001) 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100937 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:57 +13:00
Sean Harvey
a93107f4d4 BUGFIX SiteTree::getSiteConfig() should always fall back to using a default if an alternate config wasn't found 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@100932 467b73ca-7a2a-4603-9d3b-597d59a354a9
 2011-02-02 14:18:57 +13:00