tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-02 22:28:37 +02:00
Code Issues Projects Releases Wiki Activity

BUGFIX: Generate stage/live links using Controller::join_links() instead of string concatenation.

Browse Source 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@104581 467b73ca-7a2a-4603-9d3b-597d59a354a9
This commit is contained in:
Sam Minnee 2010-05-11 05:35:12 +00:00
parent d8b6b59ebd
commit bb5a333837
2 changed files with 7 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
core/control/ContentController.php
View File

@ -118,7 +118,7 @@ class ContentController extends Controller {
Session::clear('currentStage');
Session::clear('archiveDate');
return Security::permissionFailure($this, sprintf($message, "$link?stage=Live"));
return Security::permissionFailure($this, sprintf($message, Controller::join_links($link, "?stage=Live")));
}
}

12
core/control/SilverStripeNavigatorItem.php
View File

@ -97,8 +97,8 @@ class SilverStripeNavigatorItem_StageLink extends SilverStripeNavigatorItem {
} else {
$draftPage = Versioned::get_one_by_stage('SiteTree', 'Stage', '"SiteTree"."ID" = ' . $page->ID);
if($draftPage) {
$pageLink = $draftPage->AbsoluteLink();
return "<a href=\"$pageLink?stage=Stage\" class=\"newWindow\" target=\"site\" style=\"left : -1px;\">". _t('ContentController.DRAFTSITE', 'Draft Site') ."</a>";
$pageLink = Controller::join_links($draftPage->AbsoluteLink(), "?stage=Stage");
return "<a href=\"$pageLink\" class=\"newWindow\" target=\"site\" style=\"left : -1px;\">". _t('ContentController.DRAFTSITE', 'Draft Site') ."</a>";
}
}
}
@ -111,7 +111,7 @@ class SilverStripeNavigatorItem_StageLink extends SilverStripeNavigatorItem {
function getLink($page) {
if(Versioned::current_stage() == 'Stage') {
return $page->AbsoluteLink() . '?stage=Stage';
return Controller::join_links($page->AbsoluteLink(), '?stage=Stage');
}
}
}
@ -129,8 +129,8 @@ class SilverStripeNavigatorItem_LiveLink extends SilverStripeNavigatorItem {
} else {
$livePage = Versioned::get_one_by_stage('SiteTree', 'Live', '"SiteTree"."ID" = ' . $page->ID);
if($livePage) {
$pageLink = $livePage->AbsoluteLink();
return "<a href=\"$pageLink?stage=Live\" class=\"newWindow\" target=\"site\" style=\"left : -3px;\">". _t('ContentController.PUBLISHEDSITE', 'Published Site') ."</a>";
$pageLink = Controller::join_links($livePage->AbsoluteLink(), "?stage=Live");
return "<a href=\"$pageLink\" class=\"newWindow\" target=\"site\" style=\"left : -3px;\">". _t('ContentController.PUBLISHEDSITE', 'Published Site') ."</a>";
}
}
}
@ -143,7 +143,7 @@ class SilverStripeNavigatorItem_LiveLink extends SilverStripeNavigatorItem {
function getLink($page) {
if(Versioned::current_stage() == 'Live') {
return $page->AbsoluteLink() . '?stage=Live';
return Controller::join_links($page->AbsoluteLink(), '?stage=Live');
}
}
}