Commit Graph

1449 Commits

Author SHA1 Message Date
Sam Minnee
4acd84a837 Trap potential data-integrity bug
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60778 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 22:20:14 +00:00
Ingo Schommer
c706dbdcc1 BUGFIX Fixed TableListField->Link() to allow for instanciation without a form/controller (e.g. for unit tests)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60757 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 08:19:02 +00:00
Ingo Schommer
d38d7208b7 BUGFIX Fixed ScaffoldINGComplexTableField file name
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60756 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 07:12:25 +00:00
Ingo Schommer
125ca5801b BUGFIX Fixed DataObject::fieldLabels() to detect labels on inherited database fields
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60726 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 04:43:47 +00:00
Ingo Schommer
4dc20e699d ENHANCEMENT Removed recently added DataObject::$result_permissions and replaced with more specific TableListField::permissions_for_object()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60724 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 04:43:15 +00:00
Ingo Schommer
16a5b9b745 BUGFIX Fixed partial merge from nzct (originally from r47039, partially merged in r60440)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60723 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 04:38:22 +00:00
Sam Minnee
3942a9b609 Ensure that a theme template is tried before getting a non-theme template
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60717 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 03:57:46 +00:00
Sam Minnee
50790d8098 Added logging of SSViewer and Controller behaviour when using ?debug_request=1
API CHANGE: Template precedence changed.  Page_results now takes precedence over HomePage.  That is, all action templates of parent classes take precedence over the actionless templates.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60711 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 03:35:13 +00:00
Ingo Schommer
e7cbdbc07d BUGFIX Fixed $this reference in static Member call
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60710 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-14 03:30:32 +00:00
Saophalkun Ponlu
7063547b58 API CHANGE: Allow DataObject searchablefields to be decorated with updateSearchableFields
API CHANGE: Allow Group CMS fields to be decorated with updateCMSFields
API CHANGE: TableListField utility links no longer have target=_blank

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60665 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 23:57:53 +00:00
Saophalkun Ponlu
e020ff3f25 Removed error when saving checkboxsetfield with no values.
Added tests for CheckboxSetField

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60664 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 23:56:27 +00:00
Ingo Schommer
cb2919f56d ENHANCEMENT Added Maori to i18n::$common_languages
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60645 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 22:09:06 +00:00
Ingo Schommer
67e427cdf6 BUGFIX Reinstated error_handling(E_ALL) for dev environments in main.php after clarifying with sam - we want to force developers to recard notice-level errors unless they expicitly opt-out in their _config.php
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60643 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 21:49:52 +00:00
Ingo Schommer
3663221773 ENHANCEMENT Showing error level in custom error handlers on DebugView and CliDebugView
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60637 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 08:40:02 +00:00
Ingo Schommer
be2d56e7d7 BUGFIX Disabled mandatory override of default PHP error handler to E_ALL when in dev mode (which means you have no way of overriding error_reporting() in your _config.php, and by that no way of disabling e.g. E_NOTICE level errors)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60636 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 08:24:14 +00:00
Sam Minnee
8b3056fcd0 Removed notice level error when ArrayLib::valuekey() is passed an empty array
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60612 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 04:33:33 +00:00
Sam Minnee
7f72a0120b Correct line numbers in error source fragment view
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:54:50 +00:00
Sam Minnee
ab6d6dd32f Ensure that MySQLDatabase::tableList() always returns an array
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60607 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:54:04 +00:00
Sam Minnee
26f3dc26da Fix error in Geoip when REMOTE_ADDR isn't set
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60606 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:43:37 +00:00
Sam Minnee
300dfa9d07 Include full traces in unit test failures, for easier debugging
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60605 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:42:45 +00:00
Sam Minnee
ec96a10a20 Removed unnecessary chatter from test runner
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60604 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:41:54 +00:00
Sam Minnee
cad5130fb5 Improved db/build output for CLI
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60603 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:41:21 +00:00
Sam Minnee
45ee7149d7 Improved robustness of FunctionalTest HTML testing.
Removed junk output from stderr

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60602 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:40:56 +00:00
Sam Minnee
1a73ef447e Added Debug::get_rendered_backtrace() for rendering backtraces from other contexts (such as exceptions)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60601 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 03:40:06 +00:00
Sam Minnee
12868bab9f Added DatabaseAdmin::clearAllData() to empty out a database.
Improved performance of testrunner so that it doesn't create a new database for each test, instead only once per test run.

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60597 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 02:47:14 +00:00
Sam Minnee
9dcb89bf51 Removed warning when session_regenerate_id can't be set. It's not strictly necessary and just causes testing headaches
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60592 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 02:31:11 +00:00
Sam Minnee
00677d8cb7 Passed controller argument to ChangedPasswordForm constructor
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60586 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 01:58:54 +00:00
Sam Minnee
788ec0e536 Fixed MemberAuthenticator::authenticationFailedUnknownUser code
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60582 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 01:48:54 +00:00
Sam Minnee
0bdc8fad81 Improve CLI use of Debugging tools and test execution.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60581 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 01:47:05 +00:00
Sam Minnee
0e0fc7a1cb Allow flush=1 to be added as 2nd argument to cli-script.
Removed code that used 2nd arg as HTTP_HOST value, in favour of more robust $_FILE_TO_URL_MAPPING

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60579 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 01:44:43 +00:00
Sam Minnee
128e5e4a05 Add checks to see if REMOTE_ADDR is set before making use of it.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60578 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 01:43:49 +00:00
Sam Minnee
48b60fa710 Improvements to better allow for CLI-based testing
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60577 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 01:43:09 +00:00
Sam Minnee
222a1a139f Ensure that IP-based security can't be bypassed if an IP address isn't set.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60575 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 01:42:56 +00:00
Sam Minnee
cb86fdb3d1 BUGFIX: Fixed bug with unpaginated TableListFields. Added tests for TableListField pagination
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60573 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 01:39:46 +00:00
Sam Minnee
26051153b8 Added tests for random queries
Improved DataObjectTest to use more helpful assertions

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60572 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 00:44:52 +00:00
Sam Minnee
11ea5dd0c7 Fixed bug in Requirements::clear()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60563 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-13 00:01:07 +00:00
Hayden Smith
b512e4bd3b Changed Debug::loadErrorHandlers to use value returned by error_reporting() rather than E_ALL. This way, the user can adjust the error handler screens with the error_reporting function.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60555 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 23:50:28 +00:00
Hayden Smith
62d0de45d8 Merged [47094]: Fixes Session IP addresses in reverse order.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60546 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 23:14:00 +00:00
Hayden Smith
af9657bd8c Blocked [47093].
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60544 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 23:06:29 +00:00
Hayden Smith
8447e7fca5 Refactored [47092]: Add TableListField::getCastedValue
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60543 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 23:04:14 +00:00
Hayden Smith
f7ff65c04d Merged [47091]: Added Round and NiceRound to Float.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60536 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 22:47:08 +00:00
Hayden Smith
19da6e3128 Refactored [47088]: File::getFullPath now compares the filename with Director::baseFolder and returns filename if the filename stars with Director::baseFolder.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60529 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 22:26:52 +00:00
Hayden Smith
339c580aee Blocked [47084]: Needs refactoring for new Sapphire code which provides similar functionality.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60526 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 22:20:37 +00:00
Hayden Smith
78c2615821 Refactored [47082]: Modified Member::mapInCMSGroups to make use of CMSMain::providePermissions.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60522 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 22:14:36 +00:00
Hayden Smith
ef08421ed7 Merged [47081]: Modified construction of manifest to allow custom definition of MANIFEST_FILE constant filename in _config.php.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60515 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 21:59:32 +00:00
Hayden Smith
9852fd104b Merged [47080]: Fix for pagination when using customSourceItems in TableListField.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60514 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 21:48:07 +00:00
Hayden Smith
25808a11da Merged [47079]: Fix for template logic.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60512 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 21:44:18 +00:00
Hayden Smith
f0733c4c45 Refactored [47078]: AccessLogEntry will be created via an object extension.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60511 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 21:41:00 +00:00
Hayden Smith
ed98195b14 Blocked [47074] to [47077].
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60510 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 21:35:34 +00:00
Hayden Smith
f2e8c234b3 Merged [47074]: Added register and unregister as aliases to Authenticator.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@60509 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-12 21:32:00 +00:00