Maxime Rainville
a589bcb092
Merge pull request #8729 from emteknetnz/bugfix/htmlvalue-getcontent
...
Ensure document is not falsey before attempting to clone it
2019-01-29 09:11:04 +13:00
Loz Calver
785e9f123f
Replace self:: with static:: for shortcode methods
2019-01-28 14:51:34 +00:00
Robbie Averill
dc9d1b9cc0
FIX GridFieldPrintButton no longer assumes that children of GridField would implement their own print template
2019-01-28 11:45:55 +02:00
Guy Marriott
fad221bf1c
Merge pull request #8756 from open-sausages/pulls/4/string-cast-dropdownfield-entry-title
...
MINOR Always cast formfield display value as a string to avoid 0 being blank
2019-01-28 12:09:20 +13:00
Guy Marriott
7ee0dff391
Merge pull request #8745 from open-sausages/pulls/4/add-extra-message-to-MigrateFileTask
...
MINOR Add message to inform user that the task can be run again
2019-01-28 09:24:00 +13:00
Maxime Rainville
db466fb013
MINOR Always cast formfield display value as a string to avoid 0 being blank
2019-01-25 13:34:36 +13:00
Benedikt Seidl
d530bc2fb6
fix user feedback when jquery could not be loaded
2019-01-24 20:51:48 +01:00
Robbie Averill
d8cd085190
Merge branch '4.3' into 4
2019-01-24 17:14:09 +02:00
Maxime Rainville
39297b8640
MINOR Add message to inform user that the task can be run again without issue
2019-01-23 18:40:15 +13:00
Simon Gow
c28670ebed
#8724 - Session timeout regression
...
Only emit the session refresh cookie if the session timeout is set.
2019-01-18 10:07:53 +13:00
Simon Gow
af08328e8e
Existing sessions need to set a new cookie on each request, if the
...
session exists, otherwise our expiry is never updated and sessions
can't roll on every request.
2019-01-17 17:37:35 +13:00
Steve Boyd
7ea218aa1c
Ensure document is not falsey before attempting to clone it
2019-01-16 16:24:45 +13:00
Maxime Rainville
13486ca80e
MINOR Add unit test for Requirements::add_i18n_javascript()
2019-01-16 10:36:53 +13:00
Maxime Rainville
c6214b855f
MINOR Update add_i18n_javascript to load lowercase-dash language files
2019-01-15 15:04:39 +13:00
Damian Mooyman
34ac228029
BUG Fix issue with assertListEquals() ignoring field getters
2019-01-11 11:35:11 +13:00
Aaron Carlino
ab5bbda88c
Merge branch '4.3' into 4
2019-01-10 12:31:27 +13:00
Maxime Rainville
1e01deea39
NEW Make resources dir configurable ( #8519 )
...
* NEW Make resources dir configurable.
* Removing reference to old `resources` and updating doc #8519
* Rrtarget to 4.4 release.
* DOC Reference SS_RESOURCES_DIR in Environment doc.
* API Add a Resources method to SilverStripe\Core\Manifest\Module to read the resources-dir from composer.json
* Clean up reference to SS_RESOURCES_DIR env var
* Set default resources-dir
* Update test to use RESOURCES_DIR const in expected resource url method
* Correcting typos
Co-Authored-By: maxime-rainville <maxime@rainville.me>
* MINOR Correctubg minor typos
* DOCS Document the intricacies of exposing static assets.
2019-01-09 15:35:45 +13:00
Robbie Averill
068c240d38
Update src/Core/CustomMethods.php
...
Co-Authored-By: jchenevey <jchenevey@users.noreply.github.com>
2019-01-08 15:27:38 -05:00
Joe Chenevey
3730d84d18
Update CustomMethods.php
...
Switch to an early `continue` rather than wrapping contents of `foreach` in an `if` and indenting.
2019-01-08 15:24:21 -05:00
Joe Chenevey
afceccb9a6
CustomMethods->removeMethodsFrom Warnings
...
Check to ensure `self::$extra_methods[$class][$method]` exists before trying to retrieve its value. Silences warnings generated by updating a controller's failover.
2019-01-08 15:14:23 -05:00
Robbie Averill
7c96feef37
Merge branch '4.3' into 4
2019-01-08 12:27:48 +01:00
Robbie Averill
394dd4765c
NEW Scaffolded field labels now only have an uppercased first word
2019-01-07 17:52:28 +01:00
Kong Jin Jie
1667af8f5e
Add $disabledItems to check for disabled items instead of checking against $defaultItems
...
Fixes #8688
2018-12-31 17:25:11 +08:00
Russell Michell
0397c54b5a
FIX: Fixes #8459
...
- Missing conditionals for optional constructor args
- Missing calls to FieldList::setForm()
- Missing guards around naive calls to Form::Fields()->foo()
2018-12-19 13:28:19 +13:00
Simon Gow
d01585cc98
#8543 Resolve Duplicate Headers
...
- fix linting
2018-12-19 12:39:32 +13:00
Simon Gow
1edfa4d956
#8543 Resolve Duplicate Headers
...
- Replace session name lookup with function to also check secure cookies
- Added timeout which defaults to 0 (same as PHP)
- Removed php7 style of session_start from PR
- moved session_start into headers sent block to prevent warnings.
2018-12-19 12:39:32 +13:00
Simon Gow
4eb6669c08
#8543 Resolve Duplicate Headers
...
Put cookie_lifetime back into the session parameters.
2018-12-19 12:39:32 +13:00
Simon Gow
2deb8f4176
Resolve Duplicate Headers
...
Ensure only a single Set-Cookie header is returned from Session once
we have data to save. Include backwards compatibility for PHP56
2018-12-19 12:39:32 +13:00
Maxime Rainville
7f6b80f87d
Correct session doc typo
2018-12-14 13:01:22 +13:00
Guy Marriott
87b74b9cc1
Correcting Max's eggrigious typos
...
Co-Authored-By: maxime-rainville <maxime@rainville.me>
2018-12-13 13:50:35 +13:00
Maxime Rainville
6e214e2e8b
DOCS Updating Session doc to reflect that you need to operation on an instance.
2018-12-13 11:05:49 +13:00
Robbie Averill
470093de2f
Merge pull request #8650 from sminnee/nested-vendor
...
FIX: Manifest should ignore vendor folders within packages contained in vendor
2018-12-12 19:52:03 +00:00
Aaron Carlino
ab116cd5d9
Merge branch '4.1' into 4.2
2018-12-12 15:56:53 +13:00
Robbie Averill
74698af402
[SS-2018-020] Ensure that table names are escaped to prevent possible SQL injection
2018-12-11 20:57:18 +13:00
Robbie Averill
8bd747d12a
[SS-2018-020] Ensure that table names are escaped to prevent possible SQL injection
2018-12-11 20:56:55 +13:00
Robbie Averill
fecedc2d98
[SS-2018-020] Ensure that table names are escaped to prevent possible SQL injection
2018-12-11 20:56:40 +13:00
Robbie Averill
48bd335648
[SS-2018-020] Ensure that table names are escaped to prevent possible SQL injection
2018-12-11 20:55:58 +13:00
Robbie Averill
5d7c5ffb07
Merge branch '4.3' into 4
2018-12-06 09:40:40 +00:00
Robbie Averill
08866f89d9
Merge branch '4.2' into 4.3
2018-12-06 09:40:05 +00:00
Robbie Averill
96bd17d469
Merge branch '4.1' into 4.2
2018-12-06 09:38:45 +00:00
Robbie Averill
3f532466d1
Merge branch '4.0' into 4.1
2018-12-06 09:37:52 +00:00
Guy Marriott
6edcbe9086
Merge pull request #8592 from open-sausages/pulls/4.0/tree-multiselect-null
...
FIX TreeMultiselectField passes value 'unchanged' as null to ORM
2018-12-06 14:23:48 +13:00
Guy Marriott
c7b5b1efd2
FIX Switching to use Controller::curr as it was using previously
2018-11-30 15:40:45 +13:00
Guy Marriott
32d096d9e5
DOCS Moving interface subscription to the abstract and adding a changelog entry
2018-11-30 15:40:45 +13:00
Guy Marriott
ddaa22986f
Updating StateStore interface not to define a constructor & fixing GridFieldFilterHeader to add required attributes
2018-11-30 15:40:45 +13:00
Guy Marriott
b4c8f699eb
FIX Provide alternatives to session for storing GridField_FormAction state
2018-11-30 15:40:45 +13:00
Sam Minnee
0c17ffc944
FIX: Manifest should ignore vendor folders within packages contained in vendor
...
Without this change vendor/silverstripe/framework/vendor/silverstripe/config
will be pick up by the manifest, which is inappropriate.
Although this doesn’t happen often, it can occur if you have run
“composer install” within vendor/silverstripe/framework, which can be
done either accidentally or (in my case) as part of running the
framework tests isolated from the rest of your project (which is closer
to the execution model on Travis)
Note that the presence of the ‘nestedvendor.txt’ file tests that this
works without any explicit changes to the PHP of the tests, since it’s
merely confirming that such a file is *not* picked up.
2018-11-30 13:52:25 +13:00
Loz Calver
3f8551df41
Merge pull request #8462 from sminnee/nondestructive-enum
...
FIX: Make all enums non-destructive, not just ClassName
2018-11-28 16:42:12 +01:00
Loz Calver
441d079647
Merge pull request #8637 from creative-commoners/pulls/4.4/falsy-detail-component
...
FIX getComponentByType can return null - prevent null pointer errors
2018-11-26 18:28:26 +01:00
Robbie Averill
f22a4b980b
FIX getComponentByType can return null - prevent null pointer errors
2018-11-26 16:01:46 +01:00