Commit Graph

4548 Commits

Author SHA1 Message Date
Sam Minnee
458f3b1197 MINOR: neatly quote identifiers (from r109405)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112826 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:25:19 +00:00
Sam Minnee
46a38e972f MINOR: return a fail instead of an error (from r109382)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112825 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:25:03 +00:00
Sam Minnee
102375954a MINOR Remove whitespace if Surname field set on Member, but not FirstName (from r109334)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112824 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:24:43 +00:00
Sam Minnee
38f9e74fba MINOR Tests for Member::getName() and Member::setName() (from r109333)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112823 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:24:04 +00:00
Sam Minnee
00ddc0ff83 MINOR: trim space off end of firstname if surname is not set. #5925 (from r109330)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112822 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:23:44 +00:00
Sam Minnee
99fde26091 MINOR CSSContentParser::__construct() now gives a better error if the content could not be parsed. This will mostly happen if tidy isn't present. (from r109274)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112821 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:23:00 +00:00
Sam Minnee
e92a2da304 BUGFIX: $val is now cast as an int to prevent strings always returning true (YES) (from r109168)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112820 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:21:45 +00:00
Sam Minnee
f929d2ee6d MINOR phpDoc updates for SS_LogFileWriter and SS_LogEmailWriter (from r109165)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112819 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:21:32 +00:00
Sam Minnee
11907212fc Revert "BUGFIX: sort order of widgets is now fixed."
This reverts commit 1e7781ba2b8ac30333a20d9a1b0bcb9b4ba5b0b0. (from r109163)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112818 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:21:10 +00:00
Sam Minnee
496e9bcef6 API CHANGE #5873 DataObjectSet::shift() now performs a proper shift instead of unshift (wrong). Please use DataObjectSet::unshift($item) if unshifting was intended!
API CHANGE Added DataObjectSet::pop()
MINOR Unit tests for DataObjectSet::shift(), DataObjectSet::unshift() and DataObjectSet::pop() (from r109156)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112817 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:20:56 +00:00
Sam Minnee
a7d0b685ec BUGFIX: Validator::requiredField() should check the required field submitted value is an array before check strlen(). Some fields submitted as an array, e.g. MoneyField (from r109155)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112816 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:20:38 +00:00
Sam Minnee
fcc20b5e1a BUGFIX Fixed ContentNegotiator to handle HTML and XHTML base tags properly when converting, regression from r108413 (from r108421)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112815 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:20:07 +00:00
Sam Minnee
a588ae305c BUGFIX #5855 SSViewer::get_base_tag() should produce a properly closed base tag for XHTML (thanks smorris!) (from r108413)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112813 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:06:25 +00:00
Sam Minnee
53b974053a MINOR: Blocking unnecessary revisions
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112789 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:59:02 +00:00
Sam Minnee
ea1157f5b2 MINOR Doc update for Director::forceSSL() (from r109152)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112788 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:58:52 +00:00
Sam Minnee
97be4d2ca6 BUGFIX: Remove () that was breaking coverage report (from r109128)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112787 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:58:40 +00:00
Sam Minnee
634a3afeff MINOR: Applied patch from walec51 for <% control %> on empty set (#5579) Also added unit tests by ischommer (from r109127)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112785 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:58:23 +00:00
Sam Minnee
0bcb61f261 BUGFIX: sort order of widgets is now fixed. (from r109106)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112784 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:56:39 +00:00
Sam Minnee
f20e83eeaf MINOR: Fix links etc, and remove www. from SS urls (from r109105)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112783 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:56:25 +00:00
Sam Minnee
cda6638281 ENHANCEMENT: Added -v / --verbose option to dev/tests/*, to make it output every single test name before it starts that test. (from r109104)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112782 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:56:02 +00:00
Sam Minnee
cf6907931b API CHANGE Member::set_session_regenerate_id() can now be used to disable Member::session_regenerate_id() which can break setting session cookies across all subdomains of a site (from r109103)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112781 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:55:33 +00:00
Sam Minnee
f8ec13a1ab BUGFIX: Themed permissionFailure messages (from r109102)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112780 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:55:20 +00:00
Sam Minnee
215cbb6b36 ENHANCEMENT Session::set_cookie_path() and Session::set_cookie_domain() are now possible. This is useful for sharing cookies across all subdomains, for example. (from r109101)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112779 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:55:02 +00:00
Sam Minnee
bf935d5a5e MINOR: Clear out the test database in between each salad scenario. (from r109100)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112778 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:54:45 +00:00
Sam Minnee
0d6cb295c4 Added dev/tests/emptydb to clear out test session databases. (from r109099)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112777 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:54:31 +00:00
Sam Minnee
829d532b6a BUGFIX Group::getCMSFields() should use Tab instances with a fixed name instead of translated one, leaving the translation for the tab title instead (from r109083)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112776 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:54:16 +00:00
Sam Minnee
d6fdc57db7 BUGFIX SiteTree decorated canView() checks not being passed through to SiteTree::canView() (from r109082)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112775 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:54:02 +00:00
Sam Minnee
adfab98adb BUGFIX StringField::setNullifyEmpty() should assign the given value boolean, not evaluate whether it's true or not (from r109081)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112774 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:53:46 +00:00
Sam Minnee
e6976a8458 BUGFIX Count() call on a non-object in File::BackLinkTrackingCount() (from r109079)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112773 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:53:21 +00:00
Sam Minnee
db8035e1a1 MINOR Added tests for File::getURL() and File::getAbsoluteURL() (from r109066)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112772 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:52:57 +00:00
Sam Minnee
f99e6059b1 BUGFIX Fixed File::getAbsoluteURL() absolute generation (from r109063)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112771 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:52:36 +00:00
Sam Minnee
46f1994da4 BUGFIX File::getAbsoluteURL() should return a URL, not a filesystem path (from r109062)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112770 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:52:21 +00:00
Sam Minnee
58d6cbf81a MINOR: remove SQL table alias keyword AS (from r108961)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112769 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:51:53 +00:00
Sam Minnee
7f3f167748 ENHANCEMENT: make RestfulService support PUT method. (from r108942)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112768 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:51:33 +00:00
Sam Minnee
b8ee6f6af5 BUGFIX Added specific border case for array form data in RequiredFields::php() (from r108811)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112767 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:51:18 +00:00
Sam Minnee
8ced8772aa BUGFIX: Fixed validation to accept arrays (FileField case) (from r108792)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112766 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:50:59 +00:00
Sam Minnee
43f4500cd6 MINOR Fixed tests not working on the web side as redirection to https would occur (from r108666)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112765 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:50:37 +00:00
Sam Minnee
83e31e1f8a MINOR Fixed DirectorTest to restore it's REQUEST_URI state to the original one after each test method is run (from r108665)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112764 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:50:15 +00:00
Sam Minnee
d295d682c5 ENHANCEMENT #3828 500 server error page is created by default on dev/build (from r108644)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112763 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:49:53 +00:00
Sam Minnee
9a036a6fad MINOR: allow $icon to be overridden on ErrorPages. PATCH via martljn (#5875). (from r108640)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112761 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:48:04 +00:00
Sam Minnee
4b1f71d67b BUGFIX NumericField javascript does not accept negatives, make use of isNaN built-in javascript function instead of custom regex (from r108633)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112760 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:47:43 +00:00
Sam Minnee
b7f21302bc MINOR Fixed failing test as session being set before logging out and losing BackURL (from r108518)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112759 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:47:19 +00:00
Sam Minnee
f23921b815 BUGFIX #5627 Clear session on logout (from r108515)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112758 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:47:05 +00:00
Sam Minnee
8fd8d87de4 BUGFIX EMAIL_BOUNCEHANDLER_KEY cannot be defined (from r108513)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112757 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:46:46 +00:00
Sam Minnee
c0e2017cfc BUGFIX Validator/RequiredFields should not regard "0" as an empty value (from r108512)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112756 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:43:38 +00:00
Sam Minnee
b2c7c944de BUGFIX SapphireTest::create_temp_db() should restore the SS error handler from the PHPUnit one temporarily in case there's any errors building (from r108509)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112755 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:42:53 +00:00
Sam Minnee
d28d7510af MINOR Fixed failing tests because of locale not being set to the default in SapphireTest::setUp() (from r108500)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112754 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:37:55 +00:00
Sam Minnee
60c78eb54d ENHANCEMENT New Member records are populated with the currently set default through i18n::set_locale() (from r108499)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112753 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:37:43 +00:00
Sam Minnee
50e9025bbb BUGFIX Undefined variable destURL in Director::forceWWW() (regression from r107094) (from r108492)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112752 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:37:22 +00:00
Sam Minnee
4aa299c4f2 MINOR Making "todo" tab title translatable (from r108441)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112751 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:37:07 +00:00