Commit Graph

4492 Commits

Author SHA1 Message Date
Sam Minnee
43c0e432ed BUGFIX CurrencyField doesn't accept negative value (#5769, thanks simon_w) (from r108422)
BUGFIX: Take note of output format when building Location header for RestfulServer (from r108427)


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112744 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:32:18 +00:00
Sam Minnee
684e76e36b ENHANCEMENT Added argument to SQLQuery->leftJoin()/innerJoin() (#5802, thanks stojg) (from r108418)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112732 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:58:43 +00:00
Sam Minnee
e5a07227c2 ENHANCEMENT: Full-text search with double quotes returns too many results. ticket #5733. Thanks ktauber.
Using htmlentities($keywords,ENT_NOQUOTES) instead of proposed solution (from r108417)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112731 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:58:23 +00:00
Sam Minnee
3ddd5647a1 BUGFIX #5862 JSON output of JSONDataFormatter now uses quotes for keys to be safer (from r108409)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112729 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:55:06 +00:00
Sam Minnee
066bf90f02 BUGFIX Member_ProfileForm should fallback to english text for save button if no translation defined for current language (from r108408)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112727 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:54:17 +00:00
Sam Minnee
ca7edd5ca5 BUGFIX Undefined variable when calling DataObject::many_many_extraFields() and relation name couldn't be found for the component (from r108400)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112726 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:53:59 +00:00
Sam Minnee
2058ee31ee BUGFIX: DataObjects without the Versioned decorator cannot have a "Version" field. ticket #5775. Thanks ajshort (from r108399)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112725 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:53:19 +00:00
Sam Minnee
c4a72efd52 BUGFIX: Added condition to avoid error creating "PastMember" cookie on dev/build (ticket #5780) Thanks simon_w (from r108397)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112724 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:53:03 +00:00
Sam Minnee
58a50b7351 BUGFIX: Applied/edited paradigmincarnate's patch to quote plaintext email with htmlEmail (#5120) (from r108396)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112723 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:51:54 +00:00
Sam Minnee
229bea6dd4 MINOR: Add trailing slash to image tag (thanks to mattclegg) (from r108376)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112722 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:51:05 +00:00
Sam Minnee
ce06d13fd6 MINOR Cross-referencing some documentation (from r108375)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112721 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:50:48 +00:00
Sam Minnee
b90e3a680c BUGFIX: the autoselection on linking sidebar for downloads did not work properly: the item would not be selected when the user clicked a link in the editor. Only numeric IDs were permitted, but the TreeDropdownField now supports other columns as IDs too, so enabled that for autoselection.
BUGFIX: asset search would fail - typo in request var and the sql query had unnecessarily escaped quotes (from r108351)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112720 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:50:30 +00:00
Sam Minnee
2262f3f25e MINOR Disallowing more potentially active file extensions in cms/.htaccess
BUGFIX Re-allowing direct execution in sapphire/thirdparty/tinymce/plugins/spellchecker/rpc.php (necessary for cms spellchecker, was disabled by global .htaccess rule) (from r108207)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112719 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:48:58 +00:00
Sam Minnee
507ade69cd MINOR Removed debug (from r108196)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112717 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:43:29 +00:00
Sam Minnee
f01cd57736 BUGFIX #5837 cache_dir not writable by Zend when accessing the CMS, because of Windows default which should be the sapphire TEMP_FOLDER (from r108195)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112716 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:43:11 +00:00
Sam Minnee
2ec9234da6 BUGFIX Bypass BasicAuth when in CLI mode so unit tests can run (regression from r104962) (from r108193)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112715 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:42:45 +00:00
Sam Minnee
cc15a7935e MINOR Added warning about Director::set_dev_servers() (from r108049)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112714 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:42:31 +00:00
Sam Minnee
aa4503845f MINOR Documentation in CSVBulkLoader (from r108048)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112712 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:42:12 +00:00
Sam Minnee
298a6d320b BUGFIX: Don't have any host-based dev servers set by default. (from r108027)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112711 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:41:51 +00:00
Sam Minnee
a707f925ad BUGFIX: Don't allow reinstalling without first making the user manually delete mysite/_config.php (from r108026)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112710 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:41:32 +00:00
Sam Minnee
d30b478690 MINOR: Added test for #5662 (calling delete twice) (from r108025)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112708 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:40:56 +00:00
Sam Minnee
bcdf352a71 ENHANCEMENT: Show a warning inside the the CMS if you've neglected to delete install.php (from r108024)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112707 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:40:18 +00:00
Sam Minnee
dbba63ae9e BUGFIX: Don't allow direct access to PHP files in sapphire module, except for main.php and static-main.php (from r108023)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112706 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:39:50 +00:00
Sam Minnee
c35349f90d ENHANCEMENT: added getter to get array back out of an ArrayData instance. MINOR: updated docblocks in ArrayData (from r108012)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112705 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:39:19 +00:00
Sam Minnee
bd96d249f0 MINOR Fixed incorrect word "colon" with "dot" (from r108002)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112704 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:37:11 +00:00
Sam Minnee
7254c00aef BUGFIX #5833 Duplicate IDs when two similar date formats in Member_DatetimeOptionsetField containing different delimiters (e.g / and .) replaced to an empty string (from r108001)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112703 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:34:09 +00:00
Sam Minnee
0e3693f99e BUGFIX: tests now pass when the locale is set to something other than 'en_US' in the mysite's _config.php file (from r107940)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112702 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:33:41 +00:00
Sam Minnee
93eb6214b7 ENHANCEMENT Allowing custom messages and permission codes in BasicAuth::protect_entire_site()
ENHANCEMENT Making $permissionCode argument optional for BasicAuth::requireLogin(). If not set the logic only checks for a valid account (but no group memberships)
ENHANCEMENT Using SS_HTTPResponse_Exception instead of header()/die() in BasicAuth::requireLogin() to make it more testable (from r107867)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112701 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:29:35 +00:00
Sam Minnee
ad68943003 BUGFIX dev/build always reporting index change because of a whitespace in the index column names (from r107831)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112700 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:27:12 +00:00
Sam Minnee
ea50868156 BUGFIX Added a clearing div after the date and time fields, not the best way of doing it but the only way as the overflow css trick for clearing fields doesn't work with the time dropdown (from r107811)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112698 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:26:13 +00:00
Sam Minnee
30efd55852 ENHANCEMENT Added class to time icon in TimeField so it can be styled (from r107810)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112697 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:25:59 +00:00
Sam Minnee
c5f4926d4d BUGFIX Fixed DateField->validate() with keyed, but empty array values
MINOR Fixed DateField/TimeField validation message translation (wrong sprintf() nesting) (from r107789)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112696 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:25:41 +00:00
Sam Minnee
61012967cf MINOR Fixed TimeField validation _t() entity name (from r107787)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112695 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:25:17 +00:00
Sam Minnee
171fdd6050 BUGFIX Using actual date format settings in DateField/TimeField->validate() messages (from r107786)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112694 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:23:40 +00:00
Sam Minnee
40bc9ced5d BUGFIX Limit 'showcalendar' javascript option to DateField instances (rather than applying to all available) (from r107785)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112693 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:22:56 +00:00
Ingo Schommer
fd6fa62388 MINOR Fixed merge error
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112616 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 04:02:54 +00:00
Ingo Schommer
a0dd4ff8f0 MINOR Moved class-specific documentation from doc.silverstripe.org back into class-level PHPDoc (from r107725)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:55:22 +00:00
Ingo Schommer
eed13a7384 MINOR: removed whitespace (from r107586)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112607 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:54:31 +00:00
Ingo Schommer
d794381e98 BUGFIX: fixed inclusion of environment file when document root is the web root (from r107585)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112605 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:54:12 +00:00
Ingo Schommer
1c54a6dc77 BUGFIX Case insensitive extension checks in File::validate() (fixes #5781, thanks simon_w) (from r107539)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112604 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:53:54 +00:00
Ingo Schommer
b64015e2cf BUGFIX Remove dummy entry created by Versioned if record is first written to Live stage (fixes #5596, thanks muzdowski) (from r107537)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112603 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:53:14 +00:00
Ingo Schommer
577e82a123 BUGFIX Fixed Member->PasswordEncryption defaults when writing new Member without setting a password. Fixes critical issue with MemberTableField saving in admin/security, where new members are stored with a cleartext password by default instead of using the default SHA1 (see #5772) (from r107532)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112602 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:52:38 +00:00
Ingo Schommer
bd927c9355 ENHANCEMENT: html2raw now properly replace strong tag with asterix #5494 (from r107443)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112600 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:51:55 +00:00
Ingo Schommer
e07d56096d BUGFIX Allowing DatetimeField->saveInto() to save a partial array notation with missing 'time' value (from r107441)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112599 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:51:21 +00:00
Ingo Schommer
52bd0cc4bb API CHANGE Using FieldHolder() instead of Field() for subfields in DatetimeField->FieldHolder(), in order to get configuraton settings for javascript DateField (from r107439)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112598 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:49:06 +00:00
Ingo Schommer
d67c43ad7d ENHANCEMENT Using jQuery UI datepicker in DateField and DatetimeField instead of outdated DHTML calendar.js (fixes #5397)
ENHANCEMENT Abstracted optional DateField->setConfig('showcalendar') logic to DateField_View_JQuery (from r107438)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112597 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:48:39 +00:00
Ingo Schommer
ab918e8546 MINOR Better error handling in i18n::get_language_name() (from r107437)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112596 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:47:44 +00:00
Ingo Schommer
f097b678d8 ENHANCEMENT: allow adding a new a field to ArrayData (from r107434)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112595 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:47:27 +00:00
Ingo Schommer
cfe9b518a5 MINOR: Fixed Documentation (from r107430)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:46:54 +00:00
Ingo Schommer
556e753fee ENHANCEMENT: Added documentation and changed static names (from r107429)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112593 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:46:32 +00:00