Commit Graph

2032 Commits

Author SHA1 Message Date
Sam Minnee
8f41e08139 BUGFIX: Don't recreate a missing draft page when calling SiteTree::doUnpublish() (from r101170)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111967 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:49:52 +00:00
Sam Minnee
dd7bba3f6f BUGFIX: Fixed versioning of pages (from r101165)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111964 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:48:48 +00:00
Sam Minnee
c6b8148052 BUGFIX: Prevent failed migrateVersion writes from breaking versioning system in future writes.
BUGFIX: MAke site tree pages go green when you save a new draft.
API CHANGE: Add option for DataObjectDecorator::onAfterSkippedWrite() (from r101155)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111963 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:48:07 +00:00
Sam Minnee
7d248e6835 BUGFIX #5214 ViewableData::obj() was creating a DBField without a fieldname argument and caused problems, one example is the version panel of the CMS (from r101154)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111962 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:47:48 +00:00
Sam Minnee
79459d72ad BUGFIX: Ensure that Versioned works on classes with underscores in the names. (from r100905) (from r101153)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111961 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:42:45 +00:00
Sam Minnee
e09cc66e94 BUGFIX: Fixed issues with broekn link tracking (from r101138)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111960 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:42:25 +00:00
Sam Minnee
5e00afc9c8 API CHANGE: Partial cache adjustments - now supports nested cache blocks (which are independant of their containing cache block), conditionals to control if a given cache block is active, and includes hash of template code in key (so template changes mean cache is invalidated). Changes template control for cache block to <% cached %>, to which the now deprecated <% cacheblock %> is aliased, and an additional template control <% uncached %> has been added. (from r101137)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111959 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:41:48 +00:00
Sam Minnee
3650b571fc BUGFIX: Allow classes to be referred to with casing that differs from their definition. (from r101131)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111958 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:41:13 +00:00
Sam Minnee
ab46f9d2b1 BUGFIX ManifestBuilder::up_children() should be declared as static as it's called statically (from r100918)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111957 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:39:57 +00:00
Ingo Schommer
3f2cc791ac MINOR More common language in Date->TimeDiff() ("in 2 hours" instead of "2 hours away") (fixes #5402)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111840 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-10 05:06:50 +00:00
Sam Minnee
d19bf168b0 API CHANGE: Added SiteTree::VirtualPages() and SiteTree::DependentPages() accessors.
BUGFIX: Improved reliabilty of broken link tracking.
ENHANCEMENT: Added 'Dependent pages' tab to CMS, to show virtuals, redirectors, and backlinks that point to this page.
BUGFIX: Don't mark a page as changed on stage if the only thing that has changed is broken link metadata (from r101127)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:52:46 +00:00
Sam Minnee
bfc354ab7e BUGFIX: Flush cache after deleting an item.
BUGFIX: Fixed databaseFieldsOnly version of DataObject::getChangedFields() (from r101116)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111592 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:50:43 +00:00
Sam Minnee
7426ce027c BUGFIX: Fixed bugs with copying custom fields into Virtual pages, generally made virtual pages more robust and performant. (from r101112)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111591 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:49:37 +00:00
Sam Minnee
e2b6291a30 BUGFIX: Fixed link rewriting to work on other HTMLText fields (from r99517) (from r101110)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111590 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:48:47 +00:00
Sam Minnee
ca0550bb3a BUGFIX: Return true if SiteTree:doUnpublish() succeeds. (from r99515) (from r101109)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111589 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:48:07 +00:00
Sam Minnee
3db905bc42 BUGFIX: Update Object::parse_class_spec() to handle arrays. (from r101105)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111587 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:47:08 +00:00
Sam Minnee
310272bc7e BUGFIX: call_user_func_array changed to PHP 5.1 compatible notation (from r101099)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111586 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:46:55 +00:00
Sam Minnee
cc355a4f18 API CHANGE: Replaced eval based creation of extension and field objects with Object::create_from_string().
API CHANGE: Introduced new function Object::create_from_string() to instantiate an object from a string like 'Int(50)' (from r101093)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111585 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:46:41 +00:00
Sam Minnee
9f2ca79c67 BUGFIX Cookies set to a value other than NULL (effectively unsetting the cookie) will now use the httpOnly parameter by default for better XSS protection (from r101045) (from r101046)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111570 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:40:50 +00:00
Sam Minnee
ce173efce3 API CHANGE: Made MySQL fulltext search optional, activated with MySQLFulltextSearchable::enable() (from r101044)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111569 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:32:48 +00:00
Sam Minnee
ec067ab08a API CHANGE: Pass the full extension string as the 2nd argument to DataObjectDecorator::extraStatics() (from r101043)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:32:30 +00:00
Sam Minnee
47df057e63 BUGFIX Image should pass through the title to Image_Cached so that Image::getTag() can produce a more useful alt attribute instead of just the filename (from r101003) (from r101005)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111565 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:30:56 +00:00
Sam Minnee
2154e0585d MINOR Removed unused variable in SiteTree::MetaTags() (from r100992)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111563 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:30:26 +00:00
Sam Minnee
2e66aff365 BUGFIX: Fixed file-write testing issues in requirements combined file generation (from r100982)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111556 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:28:48 +00:00
Sam Minnee
32038ab3ce BUGFIX: Remove cache for Hierarchy::AllChildren() and Hierarchy::AllChildrenIncludingDeleted(), since they increase memory usage unnecessarily. (from r100980)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111555 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:28:32 +00:00
Sam Minnee
dd44a010cf BUGFIX: Don't make CMS loading slow if the combined javascript files can't be written. (from r100979)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111554 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:28:02 +00:00
Sam Minnee
059866556a MINOR Renamed SiteTree->getEditFormFields() to getCMSFields() (including new decorator hook for 'updateCMSFields'). Renamed SiteTree->getEditFormActions() to getCMSActions() (including new decorator hook for 'updateCMSActions'). Old API was never released (from r100967)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:27:23 +00:00
Sam Minnee
94d98b18ac ENHANCEMENT Redirecting to translated page when original is requested with a 'locale' GET parameter (e.g. 'about-us/?locale=de_DE' will redirect to 'ueber-uns' with a 301 HTTP response). Implemented in ContentController->handleRequest(). (see #5001) (from r100937)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111545 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:24:01 +00:00
Sam Minnee
37bc333882 BUGFIX SiteTree::getSiteConfig() should always fall back to using a default if an alternate config wasn't found (from r100932)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111544 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:21:59 +00:00
Sam Minnee
ee81852097 MINOR Fixed phpDoc argument in ViewableData::hasValue() (from r100922)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111542 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:21:32 +00:00
Sam Minnee
2e49064341 BUGFIX DataObject::hasValue() is now compatible with parent ViewableData::hasValue() (this also fixes E_STRICT standards in PHP) (from r100921)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111541 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:21:06 +00:00
Sam Minnee
ddce6c2210 BUGFIX RequestHandler::handleRequest is now compatible with Controller::handleRequest in that SS_HTTPRequest is the type hint for the $request parameter (from r100919)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111540 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:20:49 +00:00
Sam Minnee
aa7d2449d9 BUGFIX Produce XHTML compliant URLs in HTTP::setGetVar() by default (regression from r98373, see #5101) (from r100904)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111538 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:16:47 +00:00
Sam Minnee
a9ab6321bc BUGFIX #5138: DataObjectSet::removeDuplicates() removes objects of different classes with the same ID (from r100896)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111535 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:15:33 +00:00
Julian Seidenberg
6c541940e4 MINOR: updated comments on new methods that duplicate relations to be compatible with PHPDoc
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@110909 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-09-17 02:27:44 +00:00
Julian Seidenberg
c32a6e34a0 BUGFIX: fix to #110845 to allow parsing of the DataObject file in PHP 5.2 and below.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@110863 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-09-16 05:53:16 +00:00
Julian Seidenberg
ed666b71b7 ENHANCEMENT: DataObject and SiteTree duplicate now duplicate relations (except for has_many relations, as the object at the other end of such a relation has an existing relation to the original object and that should not be modified by the duplication)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@110845 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-09-16 03:40:34 +00:00
Andreas Piening
4ea1e6e3c1 BUGFIX Use "wb" argument in ManifestBuilder fopen() calls for better cross-platform compatibility (from r100862)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@108830 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-08-03 03:50:43 +00:00
Andreas Piening
ccda3bbc20 BUGFIX #5157 If paths are longer than 255 characters, fopen() produces an "Invalid argument" error, shorten the paths by using basename() instead of realpath() on the manifest filename when producing the cache path in ManifestBuilder (from r100861)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@108814 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-08-03 02:24:17 +00:00
Andreas Piening
e59e0431e4 MINOR: Director::currentPage() is deprecated but shouldn't throw a notice-level error until the next major release. (from r100670)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@108761 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-08-02 00:43:51 +00:00
Ingo Schommer
53b02f6d99 BUGFIX Moved SiteTree?->ParentID property to Hierarchy extension (fixes #5638) (from r105668)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105786 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-27 21:29:48 +00:00
Ingo Schommer
06f18485a9 MINOR Improved help texts around permissions (from r100784)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105651 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 05:02:08 +00:00
Ingo Schommer
9f6bf696c6 MINOR dont copy embargo or expiry to virtual page (from r100772)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105648 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:59:45 +00:00
Ingo Schommer
5c965330c3 ENHANCEMENT you can now choose your site locale at install time (from r100769)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105645 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:58:00 +00:00
Ingo Schommer
a0d1c7d2b1 BUGFIX: Date::now() supplies wrong string - it misses leading zeroes on hours (from r100767)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105644 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:57:43 +00:00
Ingo Schommer
0a91f30722 BUG FIX: column names quoted properly (from r100690)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105621 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:22:50 +00:00
Ingo Schommer
96ebc35cee BUG FIX: column names quoted properly (from r100687)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105620 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:22:35 +00:00
Ingo Schommer
f661501019 BUG FIX: the default value for decimals are now cast as (doubles) (from r100686)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105619 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:22:21 +00:00
Ingo Schommer
6f936bf10d API CHANGE: dbDataType function created (from r100651)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105616 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:21:21 +00:00
Ingo Schommer
25c2b79718 BUGFIX DB::getConnect() should be properly declared as a static function (from r100627)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105615 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:21:07 +00:00
Ingo Schommer
4ec18cc701 MINOR Cookie - removed unncessary extending of Object since this class only has a bunch of static functions (from r100625)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105612 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:19:57 +00:00
Ingo Schommer
2e5b68174a MINOR Convert - removed unncessary extending of Object since this class only has a bunch of static functions (from r100624)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105611 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:19:38 +00:00
Ingo Schommer
3f14112a62 MINOR ArrayLib - removed unncessary extending of Object since this class only has a bunch of static functions (from r100623)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105610 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:19:23 +00:00
Ingo Schommer
0dd37f0da9 MINOR Removed double slashes from path in Requirements_Backend::process_combined_files() (from r100618)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105608 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:19:00 +00:00
Ingo Schommer
f3ce3e1e85 BUGFIX Fixed filemtime() check in Requirements_Backend::process_combined_files() not getting the right path (from r100616)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105607 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:18:48 +00:00
Ingo Schommer
3ac0edc117 MINOR Requirements_Backend::process_combined_files() only needs one location where the combined file is (from r100615)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105606 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:18:29 +00:00
Ingo Schommer
86e799f008 BUGFIX Proper check for combined file path in Requirements_Backend::process_combined_files() (from r100614)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105605 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:18:14 +00:00
Ingo Schommer
94801d75ff ENHANCEMENT Stored combined files in assets/_combinedfiles by default (from r100536)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105600 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:17:05 +00:00
Ingo Schommer
656eccc7a4 MINOR Removed Requirements:: static call and replace with instance (from r100533)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105598 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:16:33 +00:00
Ingo Schommer
9a438d26b0 ENHANCEMENT #3387 Requirements now has a new static function called Requirements::set_combined_files_folder() for setting where the combined files should belong (from r100528)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105596 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:15:43 +00:00
Ingo Schommer
7d8ac7662b MINOR Removed end php tag for Requirements and RequirementsTest (from r100514)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105591 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:14:00 +00:00
Ingo Schommer
9c03cc7fe1 API CHANGE Refactored Requirements to use Requirements_Backend at all times - this makes testing far easier. Thanks tobych!
MINOR Updated RequirementsTest to test Requirements_Backend instead of global statics (from r100513)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105590 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:13:45 +00:00
Ingo Schommer
593448929a MINOR can always create top level if admin (from r100511)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105588 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:12:51 +00:00
Ingo Schommer
a1d9d8b890 API CHANGE Removed deprecated Image::loadUploaded() (deprecated from the parent::loadUploaded for which it called), please use Upload directly instead! (from r100498)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105587 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:12:31 +00:00
Ingo Schommer
56ba78b2a5 API CHANGE Removed deprecated function RootURLController::get_homepage_urlsegment(), please use RootURLController::get_homepage_link() instead! (from r100493)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105579 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:58:22 +00:00
Ingo Schommer
046dd623be API CHANGE Removed deprecated function SiteTree::get_by_url(), please use SiteTree::get_by_link() instead! (from r100492)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105578 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:57:46 +00:00
Ingo Schommer
93d405c4a3 MINOR Fixed tabbing in DataObjectSet (from r100491)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105577 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:56:02 +00:00
Ingo Schommer
a06e2af9ef API CHANGE Removed deprecated methods DataObjectSet::filter_map() and DataObjectSet::map_multiple() - please use map() instead! (from r100490)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105576 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:55:47 +00:00
Ingo Schommer
7e8a2c10c9 MINOR Changed places of Object::extInstance() to Object::getExtensionInstance() and added a notice if extInstance is used in future (from r100487)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105575 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:55:30 +00:00
Ingo Schommer
584e8a5ee6 MINOR Changed @deprecated note for Director::redirectBack to 2.5 as it's still widely used (from r100483)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105573 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:54:29 +00:00
Ingo Schommer
dd7e7f813d MINOR Fixed regression of Convert::json2obj() not working when json_decode() is being used (from r100461)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105571 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:53:58 +00:00
Ingo Schommer
d5e48d55dc ENHANCEMENT #4599 DataObjectSet now uses more array functions instead of performing equivalent tasks - thanks simon_w! (from r100453)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105570 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:53:43 +00:00
Ingo Schommer
f7c34fc73c MINOR phpDoc bits for Convert Services_JSON functions (from r100424)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:52:56 +00:00
Ingo Schommer
30b2a950fe ENHANCEMENT Convert JSON functions now use the Services_JSON library where appropriate instead of custom code, and if json_decode() or json_encode() are available these are used
MINOR Added unit tests for Convert JSON functions (from r100423)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105567 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:52:38 +00:00
Ingo Schommer
ffa1267516 BUGFIX: Fix mismatch with $all_locales and $common_locales (#5096) (from r100406)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105560 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:50:19 +00:00
Ingo Schommer
5db5bbf9df BUGFIX: PHP 5.1 requires an array rather than a string for call_user_func() (from r100367)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105553 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:44:54 +00:00
Ingo Schommer
e5eff98e15 BUGFIX: Show Language dropdown in English (#5098) (from r100359)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:44:31 +00:00
Ingo Schommer
179641d972 MINOR correct order of OBW (from r100323)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:43:28 +00:00
Ingo Schommer
d8478a8f59 BUGFIX SQL Error is a member is not part of any groups (from r100053)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105548 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:40:56 +00:00
Ingo Schommer
3bd114256b MINOR added Rfc2822 method to SS_Datetime. Fixed bug where dates in DataObject would not set times. (from r100032)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105546 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:40:37 +00:00
Ingo Schommer
052f71f4b3 MINOR LastEdited/Created dates are now mockable via SS_Datetime (from r100008)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105545 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:40:11 +00:00
Ingo Schommer
b632c8ff88 BUGFIX: Fix #5097, Translatable uses augmentValidURLSegment to check that URLSegment is valid (from r99850)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105539 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:18:25 +00:00
Ingo Schommer
0ab57094a0 API CHANGE: SiteTree::validURLSegment extendable (#5907)
Uses $this->extend('augmentValidURLSegment')
so that (for instance) Translatable can hook this. (from r99849)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105538 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:16:54 +00:00
Ingo Schommer
097eb6b649 Revert "FEATURE: Use tidied HTML in DataDifferencer"
This reverts commit a0d2f7b3e289d12dedcdbd02ae52eec3e6718340. (from r99848)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105537 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:15:54 +00:00
Ingo Schommer
b3409a2ea3 MINOR Reverted r99522 as this will cause problems if File records are deleted when the resampled images are linked to in the content fields (from r99823)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105533 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:06:35 +00:00
Ingo Schommer
271584e43b MINOR Fixed phpdoc documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@103390 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-23 01:04:16 +00:00
Ingo Schommer
6460d09570 MINOR Fixed phpdoc documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@103385 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-23 00:11:41 +00:00
Ingo Schommer
af88731959 MINOR Merge error
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102887 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 06:25:00 +00:00
Ingo Schommer
36d7efb95c BUGFIX #4974: Improve accuracy of ManifestBuilder::parse_file() cache, to remove a source of upgrade bugs. (from r99738)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102877 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 05:36:56 +00:00
Ingo Schommer
1f5654ed19 BUFGFIX: Prevent selection of self as parent (see #5106) (from r99732)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102876 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 05:36:33 +00:00
Ingo Schommer
5ce40aab7f BUGFIX: Show 'Inherit' option for edit and view all the time (since we now have SiteConfig) (from r99587)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102870 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:42:07 +00:00
Ingo Schommer
efc69855ac BUGFIX Image::onBeforeDelete() now calls deleteFormattedImages() so resampled images in the filesystem are cleaned up (from r99522)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102868 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:41:43 +00:00
Ingo Schommer
a20e559256 BUGFIX: tablename and columns quoted properly (from r99490)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102865 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:40:45 +00:00
Ingo Schommer
720bcfa61d BUGFIX: batch_permission_check returns null rather than empty array when user has no permissions (from r99443)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102863 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:40:16 +00:00
Ingo Schommer
6227478f82 FEATURE New DatetimeField class (form field wrapper composed of DateField andTimeField)
FEATURE New DateField and TimeField form classes with more consistent API and easier localization
API CHANGE Date/time parsing in DateField, TimeField and DatetimeField defaults to i18n::get_locale() ('en_US') instead of using en_NZ/en_GB specific parsing. Use i18n::set_locale('en_NZ') in mysite/_config.php to revert to old behaviour.
API CHANGE  constructor parameter in TimeField needs to be in ISO date notation (not PHP's date())
API CHANGE TimeField, DateField and related subclasses use Zend_Date for date parsing, meaning they're stricer than the previously used strtotime()
API CHANGE Removed DMYCalendarDateField and CalendarDateField, use DateField with setConfig('showcalendar')
API CHANGE Removed CompositeDateField, DMYDateField, use DateField with setConfig('dmyfields')
API CHANGE Removed DropdownTimeField, use TimeField with setConfig('showdropdown')
API CHANGE Removed PopupDateTimeField, use DatetimeField
API CHANGE Changed 'date', 'month' and 'year' HTML field names to lowercase in DMYDateField
API CHANGE Removed support for ambiguous date formats in DateField, e.g. '06/03/03'. Use DateField->setConfig('dateformat', '<format>') to revert to this behaviour.
API CHANGE Removed  flag from DateField, CalendarDateField etc., use DateField->setConfig('min') and DateField->setConfig('max')
ENHANCEMENT Using Zend_Date for DateField and TimeField, with more robust date handling, starting localization support. Set globally via i18n::set_locale(), or for a field instance through setLocale(). Note: Javascript validation is not localized yet. (from r99360)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102859 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:38:40 +00:00
Ingo Schommer
bf8f089caf BUGFIX: Disable some permission caching for now, as it was breaking unit tests (from r98504) (from r99303)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102854 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:11:38 +00:00
Ingo Schommer
da2a530274 BUGFIX: SiteTree::batch_permission_check() doesn't recurse with ID=0 calls
ENHANCEMENT: SiteTree::batch_permission_check() populates its own cache (from r97900) (from r99302)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102853 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:11:18 +00:00
Ingo Schommer
3dc4486f3b MINOR Added Requirements for SilverStripeNavigator (see r99080) (from r99097)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102845 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:08:02 +00:00
Ingo Schommer
14fb2a387f BUGFIX: Only show live link when page has been published (from r97839) (from r99089)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102844 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:07:26 +00:00
Ingo Schommer
ab9dffb735 BUGFIX: Make sure draft/published links go to the right subsite (from r97747) (from r99087)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102842 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:06:43 +00:00
Ingo Schommer
65473615d9 MINOR Partially reverted r99079 - SiteTree->getNavigatorItems() was refactored to SilverStripeNavigator::get_for_record() (from r99081)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102840 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:04:44 +00:00
Ingo Schommer
fc6ffa5e94 FEATURE: Add Link to silverstripe navigator (from r97407) (from r99080)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102839 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:03:40 +00:00
Ingo Schommer
54330495a2 APICHANGE: Use the same navigator items in the CMS that are used on the frontend (from r97395) (from r99079)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102837 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:00:43 +00:00
Ingo Schommer
7c057cbecb MINOR adjustments to ensure that the cached permissions were actually hit (from r98835) (from r99068)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102835 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:59:54 +00:00
Ingo Schommer
8bdeeba73e BUGFIX: Ensure that ModelAsController::init() can trigger redirections. (from r98702) (from r99067)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102834 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:59:37 +00:00
Ingo Schommer
ffd0774839 BUGFIX: Fixed SiteTree_versions version numbers for published virtual pages. (from r98675) (from r99065)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102833 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:58:16 +00:00
Ingo Schommer
000d892256 MINOR refactored setting/getting strict hierarchy setting. (from r98654) (from r99064)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102832 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:57:45 +00:00
Ingo Schommer
809072d1bf API CHANGE: Let sitetree extensions prepopulate permisson cache for their own permissions. (from r98650) (from r99063)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102831 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:57:21 +00:00
Ingo Schommer
a5c2a3e564 MINOR more unit tests around loose hierarchy (from r98509) (from r99062)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102830 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:56:51 +00:00
Ingo Schommer
658e24ea45 MINOR added enforce_strict_hierarchy option, and tests around not cascading deletions (from r98498) (from r99059)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102829 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:56:22 +00:00
Ingo Schommer
9c5303285a BUGFIX: Generate SiteTree_version records for VirtualPages more reliably. (from r98309) (from r99052)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102828 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:54:36 +00:00
Ingo Schommer
87b98eaa66 BUGFIX: fix incorrect link in CMS (from r97408) (from r99050)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102826 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:53:19 +00:00
Ingo Schommer
c1165c2ca0 BUGFIX: Make sure CMS link knows when its currently in the CMS (from r97403) (from r99049)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102825 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:52:52 +00:00
Ingo Schommer
9284d63827 FEATURE: Make navigator items more overloadable (from r97376) (from r99047)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102824 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:52:28 +00:00
Ingo Schommer
8a781341c9 FEATURE: Refactor links in $SilverStripeNavigator so modules can add extras (from r97299) (from r99046)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102823 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:51:56 +00:00
Ingo Schommer
728a401631 MINOR fix typo (from r98980)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102819 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:50:41 +00:00
Ingo Schommer
45c5163c18 BUGFIX fix for #5076 (from r98957)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102818 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:50:21 +00:00
Ingo Schommer
0759568db5 MINOR Added brackets around strpos() check just to be sure it works (from r98898)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102814 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:48:52 +00:00
Ingo Schommer
5049a87737 BUGFIX Fixed strpos() check in BASE_URL check (from r98897)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102812 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:47:57 +00:00
Ingo Schommer
0a5321dd10 BUGFIX Installer now opens if mod_rewrite is disabled. Using index.php instead of rewriting the URL didn't quite work with the new BASE_URL, so we need to take this case into account as well (from r98895)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102811 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:47:37 +00:00
Ingo Schommer
feabab3808 BUGFIX: modified float to have the same database table schema as int. Now defaults to zero and 'not null' (from r98847)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102805 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:45:20 +00:00
Ingo Schommer
d3e45dfc7a BUGFIX Fixed quoting on ContentController::successfullyinstaller() - this broke certain databases like PostgreSQL (from r98777)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102796 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:31:20 +00:00
Ingo Schommer
746b2f2f0a BUGFIX #5053 Aggregate::query() should not set an orderby clause, otherwise databases will complain (from r98776)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102795 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:31:06 +00:00
Ingo Schommer
16f79a6dd8 BUGFIX: columns quoted properly (from r98694)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102794 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:30:49 +00:00
Ingo Schommer
ce04a46d57 BUGFIX: Fixed ManifestBuilder::has_been_included() (from r98693)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102793 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:30:30 +00:00
Ingo Schommer
b54937e5dd MINOR Removed debug code
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102783 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:05:18 +00:00
Ingo Schommer
944d013086 MINOR Fixed SiteTree->canViewStage(), merge error from r94253
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102781 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:28:51 +00:00
Ingo Schommer
624b63ebb1 BUGFIX Fixed ManifestBuilder::get_themes() not to assume an existing themes/ folder (from r98537)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102765 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:19:10 +00:00
Ingo Schommer
9f2f88fb28 BUGFIX: Fix virtual pages not returning correct content (from r98520)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102762 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:17:29 +00:00
Ingo Schommer
74643c8e51 MINOR Partially reverted accidental commit r102759
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102760 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:16:58 +00:00
Ingo Schommer
bfb10b849f BUGFIX Fixed missing third argument to ComplexTableField_Item when the parent class instantiates it (from r98448)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102759 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:16:07 +00:00
Ingo Schommer
ecc73e0cfc BUGFIX: Fixed infinite loop in FILE_TO_URL_MAPPING lookup when calling arbitrary scripts via CLI (from r98434)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102658 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:24:48 +00:00
Ingo Schommer
6a1cb91c9f MINOR Partially reverted r98382 which added unnecessarily defensive checking to Hierarchy->allChildren() (from r98404)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102652 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:23:18 +00:00
Ingo Schommer
dc21cb9ae0 BUGFIX Fixed Hierarchy->loadDescendantIdList() to call setOwner() on the extension instance. This was necessary due to underlying Object/Extension changes in 2.4.
MINOR Fixed HierarchyTest assertions around including grand children counts (from r98403)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102651 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:23:06 +00:00
Ingo Schommer
28fd09115a BUGFIX #5044 Hierarchy::loadDescendantIDListInto() now uses Object::getExtensionInstance('Hierarchy') instead of going through __call(), as PHP 5.3 has issues converting references to values (from r98382)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102649 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:22:12 +00:00
Ingo Schommer
6f411a359a API CHANGE HTTP::setGetVar() always returns absolute URLs. Use Director::makeRelative() to make them relative again.
API CHANGE HTTP::setGetVar() combines any GET parameters in PHP array notation (e.g. "foo[bar]=val") instead of replacing the whole array
BUGFIX HTTP::setGetVar() uses parse_url() and http_build_query() to add query parameters to an existing URL, instead of doing its own regex-based parsing. This means existing GET parameters are correctly url encoded. (from r98373)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102647 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:21:33 +00:00
Ingo Schommer
e43f6d8a0d MINOR Documentation (from r98372)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102646 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:20:59 +00:00
Ingo Schommer
c5fda512d6 BUGFIX: Don't force SSL when running from CLI (from r98272)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102639 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:19:00 +00:00
Ingo Schommer
0a4d5ca990 BUGFIX: Updated SiteConfig-based theme selection to remove inappropriate coupling from SSViewer (from r98263)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102636 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:18:10 +00:00
Ingo Schommer
d7f2925dc8 APICHANGE: Refactor Versioned so a single state is kept for stage, archived date, or any module specific reading modes (from r98161) (from r98224)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102633 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:16:57 +00:00
Ingo Schommer
5ff636c6b4 MINOR make showing virtual pages tab conditional
MINOR made virtual page tracking sitetree tablelistfield subsite agnostic (from r98005) (from r98223)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102630 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:29:51 +00:00
Ingo Schommer
a2883d0354 MINOR removed redundant method call (from r97817) (from r98222)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102629 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:29:35 +00:00
Ingo Schommer
b7c59241df BUGFIX: Let ModelAsController::init() extensions trigger redirections. (from r97767) (from r98221)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102628 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:29:24 +00:00
Ingo Schommer
031835a361 ENHANCEMENT roll batch permissions in to a generic function (from r97748) (from r98219)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102627 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:29:03 +00:00
Ingo Schommer
9fdc7cb2ff BUGFIX Don't allow translations of VirtualPage (until we can reliably copy data between locales) (see #5000) (from r98217)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102626 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:28:34 +00:00
Ingo Schommer
a3b49b1566 MINOR: fixed typos in the comments (from r98201)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102625 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:28:13 +00:00
Ingo Schommer
c63256fb0f MINOR: added quotes (from r98199)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102624 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:28:00 +00:00
Ingo Schommer
9f4413421d MINOR: use DB doubles only in MySQL, fall back to float (from r98178)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102623 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:27:46 +00:00
Ingo Schommer
447ec71471 MINOR better error reporting for broken redirector & virtual pages (from r97185) (from r98155)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102622 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:27:30 +00:00
Ingo Schommer
99be47c479 MINOR if the $fieldname to DOS->sort has a direction in it, split it out, and pass it. (from r96482) (from r98140)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102612 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:17:25 +00:00
Ingo Schommer
864a15db8e MINOR redirector link tracking is more intelligent (from r96461) (from r98139)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102611 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:17:11 +00:00
Ingo Schommer
9b650a4e6c MINOR remove sort direction when running canSortBy. Also added test coverage for this. (from r96428) (from r98138)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102610 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:16:50 +00:00
Ingo Schommer
83ccc4f6d9 BUGFIX: Don't make ManifestBuilder choke on empty files. (from r96058) (from r98133)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102605 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:15:37 +00:00
Ingo Schommer
5044de817e BUGFIX: removing search&replace victim, using unpopulated cache. Reverted to AllChildren, which calls the cache itself. (from r98111)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102598 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:13:27 +00:00
Ingo Schommer
21299ba686 ENHANCEMENT Allow user theme selection through SiteConfig, falling back to SSViewer::set_theme() as a default if there are none selected
MINOR Unit tests for SSViewer::current_theme() and SiteConfig::getAvailableThemes() (from r98110)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102597 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:13:12 +00:00
Ingo Schommer
1e20e55c68 MINOR don't HTML-format queries from showqueries if this is an AJAX request. (from r95855) (from r98097)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102589 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:06:24 +00:00
Ingo Schommer
453faed88a API CHANGE: Refactored test for whether a SQLQuery can be sorted by a particular column into SQLQuery::canSortBy($fieldName) (from r95850) (from r98096)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102588 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:06:12 +00:00
Ingo Schommer
da778dd2a9 BUGFIX: Make TableListField rely on SQLQuery for its count-generation.
BUGFIX: Make SQLQuery return an appropriate count if a HAVING clause is used. (from r95814) (from r98094)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102586 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:45 +00:00
Ingo Schommer
2ae6f896e3 Add some nice date formats (from r95772) (from r98093)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102585 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:26 +00:00
Ingo Schommer
753a8804ac ENHANCEMENT ManifestBuilder::get_manifest_info() now uses ManifestBuilder::get_themes() instead of doing it's own retrieval of available themes
MINOR Added ManifestBuilderTest::testThemeRetrieval() to test ManifestBuilder::get_themes() (from r98091)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102583 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:02:52 +00:00
Ingo Schommer
72bb124951 MINOR: Edit-case checking of data in ViewableData::$failover for better error message. (from r95560) (from r98090)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102582 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:02:18 +00:00
Ingo Schommer
0ee0244a01 MINOR added direct links to items in the backlinks report (from r88277) (from r98085)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102578 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:00:41 +00:00
Ingo Schommer
7bd479156b MINOR Changed MySQLDatabase::now() block comment to be more useful (from r98059)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102572 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:53:25 +00:00
Ingo Schommer
a5dde231b6 API CHANGE Decimal now allows setting a default value properly
MINOR Unit tests for Decimal field type default value through new test class DecimalTest (from r98056)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102571 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:53:13 +00:00
Ingo Schommer
529ed1dd1d MINOR: niced the way MultiEnums call requireField to give alternative adapter access (from r98043)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102570 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:50:15 +00:00
Ingo Schommer
a2055d1d67 MINOR: use ENUM hack for dealing with SET legacy values (from r98042)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102569 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:49:58 +00:00
Ingo Schommer
92a25a3e68 FEATURE: added support for MySQL data type SET used in MultiEnum FEATURE: added datetime helper functions (from r98041)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:49:40 +00:00
Ingo Schommer
25ad651966 APICHANGE: rename the class "Cache" to "SS_Cache" (ref ticket: #4997) (from r97996)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102564 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:48:06 +00:00
Ingo Schommer
98de6165ea MINOR: groupby works for SQLite too (from r97985)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102563 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:46:51 +00:00
Ingo Schommer
1997485ba3 BUGFIX #5009: Removed inappropriate field-detection change on multienums with no default (from r97980)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102561 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:46:27 +00:00
Ingo Schommer
9e9dcb1b96 MINOR: Better error message on bad Enum default (from r97979)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102560 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:45:53 +00:00
Ingo Schommer
37e9c9e569 BUGFIX: remove the possibility that Director::isDev() could be recursively called when putting isDev=1 in $_GET, addressed in ticket #4978 (http://open.silverstripe.org/ticket/4978) (from r97926)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102556 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:45:00 +00:00
Ingo Schommer
6c0efa68de BUGFIX Allowing translations of VirtualPage by not copying over original Locale property (see #5000) (from r97912)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102554 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:44:23 +00:00
Ingo Schommer
48bd1ffa24 BUGFIX If a Group doesn't have any specific TRANSLATE_<locale> edit rights, but has general CMS access (CMS_ACCESS_CMSMain, CMS_ACCESS_LeftAndMain, ADMIN), then assign TRANSLATE_ALL permissions as a default. Necessary to avoid locking out CMS editors from their default language (see #4940 and 4941) (from r97911)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102553 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:44:03 +00:00
Ingo Schommer
6fb2a2a2e0 MINOR Removed debug code (from r97910)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:43:44 +00:00
Ingo Schommer
ee4174c0e2 Added values for new permission code 'VIEW_DRAFT_CONTENT' test (from r97898)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:43:29 +00:00
Ingo Schommer
9a04ca62d2 Added test for new permission code. (from r97897)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102550 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:42:50 +00:00
Ingo Schommer
22fde45409 ENHANCEMENT: 2.4 tickets (#4670) new permission code to view draft w/o CMS access (from r97896)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102549 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:34:28 +00:00
Ingo Schommer
54d166c4ce ENHANCEMENT: 2.4 tickets (#4670), new permission code to view draft stage w/o CMS access (from r97895)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102548 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:33:49 +00:00
Ingo Schommer
930b051182 BUGFIX Checking that URL controller in HTTPRequest->match() is a subclass of Controller, not RequestHandler (which would include nested controllers like Form or FormField subclasses that shouldn't be accessible on their own toplevel URL namespace) (from r97881)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102547 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:30:43 +00:00
Ingo Schommer
d43c990e56 BUGFIX Using i18n::get_locale() in ContentController->ContentLocale() to ensure the correct locale can be used in templates withouth Translatable enabled (broken in r97207, thanks DesignCity)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102544 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:05:45 +00:00
Ingo Schommer
279031cc3a MINOR fix call to undefined method when a virtual page picks up the wrong object. (from r97875)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102540 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:44:25 +00:00
Ingo Schommer
731269988e MINOR PHP notice error (from r97838)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102539 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:43:52 +00:00
Ingo Schommer
68fb898c6d API CHANGE: Added cancelSchemaUpdate() and doesSchemaNeedUpdating() to the Database class (from r97827)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102538 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:43:10 +00:00
Ingo Schommer
d62b3303f0 API CHANGE Fixed i18n _t() calls without namespaces in template includes: They now default to setting the include filename as namespace, rather than the including template (#4915, #3400 - thanks Henk_Poley, jwalsoe, walec51) (from r97797)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102534 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:39:15 +00:00
Ingo Schommer
29ea7e0b98 BUGFIX Use BASE_PATH and BASE_URL instead of data from $_SERVER.
API CHANGE: Determine default BASE_PATH/BASE_URL from the __FILE__ content, so that the script that initiated the Sapphire process doesn't matter.  This means that index.php doesn't need to manipulate those variables. (from r97731)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102528 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:15:04 +00:00
Ingo Schommer
40899c3bfb BUGFIX: Don't rely on the current working directory for any file access; use BASE_PATH. (from r97728)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102527 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:14:36 +00:00
Ingo Schommer
efa09e60a5 MINOR: replaced proprietary update query with one that is ANSI compliant in doPublish() (from r97705)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102526 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:11:58 +00:00
Ingo Schommer
891de73b31 MINOR Fixed undefined variable in SiteTree::can_edit_multiple() (broken in r83442)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102516 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 22:46:40 +00:00
Ingo Schommer
fa8c4b128c BUGFIX: Fixed potential data corruption issue when you are changing the class of a SiteTree subclass between two subclasses that share a fieldname. (from r97594)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102514 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 22:30:07 +00:00
Ingo Schommer
69543bb575 BUGFIX #4929: Fixed Object::add_static_vars() for uninherited static.s (from r97586)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102510 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 22:00:25 +00:00
Ingo Schommer
1417722d9e API CHANGE #4929: Add $class argument to DataObjectDecorator::extraStatics() (from r97582)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102508 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:58:35 +00:00
Ingo Schommer
b70c2df842 MINOR Using SiteTree::get_by_link() in SiteTree->requireDefaultRecords() (see #4590) (from r97484)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102499 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:19:54 +00:00
Ingo Schommer
f331e2e1a6 BUGFIX: Was using custom_database_fields in Aggregate, not database_fields, and so aggregates for the common fields (LastEdited, Created, ClassName) would fail (from r97414)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102489 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:10:21 +00:00
Ingo Schommer
2969a7ee44 FEATURE: Add partial caching support to SSViewer. (from r97391)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102488 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:09:54 +00:00
Ingo Schommer
4e850f6011 FEATURE: Add aggregate calculation to DataObject, allowing (cached) calculation of Max, Min, Count, Avg, etc (from r97390)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102448 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 05:04:34 +00:00
Ingo Schommer
1039cfade4 FEATURE Allowing translation of SiteConfig (including toplevel permission groups)
BUGFIX Fixed SiteConfig->canView()/canEdit() to respect empty CanViewType/CanEditType assignments. (from r97370)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102445 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 05:02:31 +00:00
Ingo Schommer
40466ccb02 BUG FIX: The 5.1 replacement array_fill_keys function now made available to the cron jobs (from r97300)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102441 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 05:00:40 +00:00
Ingo Schommer
6eb4d67c86 BUGFIX: Let users without a specific TRANSLATE_ permission edit the default locale, so that things don't break when you install the Translatabe module. (from r97267)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102435 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:41:34 +00:00
Ingo Schommer
36dbefedcf BUGFIX Fixed URLSegment access for translated homepages in SiteTree->RelativeLink (#4781, thanks martijn) (from r97211)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102434 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:39:50 +00:00
Ingo Schommer
e717044628 API CHANGE Deprecated ContentController->LangAttributes(). Use ContentLocale() instead and write attribute names suitable to XHTML/HTML templates directly in the template.
ENHANCEMENT Added ContentController->ContentLocale() to allow XHTML/HTML specific lang= attribute settings in custom template code (see #4858). Removed <meta http-equiv="Content-Language"...> tag in SiteTree->MetaTags().
ENHANCEMENT Updated blackcandy theme to use new $ContentLocale attribute to set the locale of the current page (in Page.ss) (from r97207)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102433 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:39:35 +00:00
Ingo Schommer
3fe5af85a4 MINOR Reverted 'single instance only' feature from r79868, delayed until later release (see #4277) (from r97182)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102431 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:38:58 +00:00
Ingo Schommer
a7e3ff2fe1 BUGFIX: Fixed bug in r97036 (from r97051)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102429 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:36:44 +00:00
Ingo Schommer
469d0b7708 BUGFIX: Use locally included Zend framework components in favour of those installed with PEAR (from r97036)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102426 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:34:59 +00:00
Ingo Schommer
2f0bc863e7 ENHANCEMENT: include menu title in default search. PATCH via lubzee #4508 (from r97028)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102423 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:33:29 +00:00
Ingo Schommer
46a5670aed FEATURE: added Session::clearAll() functionality. ENHANCEMENT: Added Unit Tests covering Session API. MINOR: Tided up formatting in session class and included doc comments for API level documentation (from r97024)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102422 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:32:28 +00:00
Ingo Schommer
8a8501c854 FEATURE: Use tidied HTML in DataDifferencer (from r97018)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102420 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:31:35 +00:00
Ingo Schommer
474a6a9931 API CHANGE #3600 Inconsistency in File::getURL() which returns an absolute URL, when it should be relative - please use getAbsoluteURL() instead for old behaviour
API CHANGE #3600 Image no longer has an explicit getURL() method, instead it inherits getURL() from File which returns a relative URL (from r96988)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102415 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:29:56 +00:00
Ingo Schommer
24105c9adb BUGFIX: Fixed bug in VirtualPage::isPublishable() when CopyContentFromID not set (from r96941)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102413 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:28:56 +00:00
Ingo Schommer
2f849222f8 BUGFIX: fixed onBeforeDuplicate calling before page existed (from r96879)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102411 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:28:22 +00:00
Ingo Schommer
7b3e45539b MINOR: added hooks for extending duplicate page functionality (from r96877)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102410 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:28:07 +00:00
Ingo Schommer
9fc3256025 BUGFIX: Don't let Versioned archive tables clutter the global state when testing.
BUGFIX: Don't let mocked datetimes clutter the global state when testing. (from r96640) (from r96648) (from r96774)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102403 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:21:30 +00:00
Ingo Schommer
31bf50d69d MINOR when a parent page is unpublished, unpublish all related virtual pages, includes test coverage (from r94777) (from r96771)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102399 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:19:11 +00:00
Ingo Schommer
c0dfaa0b51 BUGFIX: Don't set the nodelete class on the CMS tree on load, since this is now handled by the batch-action system with an Ajax call. (from r94762) (from r96770)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102397 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:18:05 +00:00
Ingo Schommer
112fe3c1d4 MINOR track virtual pages that link to the current page (from r94700) (from r96768)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102396 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:17:44 +00:00
Ingo Schommer
07ad87a09a BUGFIX: Don't let users edit the location in the Behaviour tab if they don't have sitetree reorganise permission (from r94609) (from r96767)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102395 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:17:25 +00:00
Ingo Schommer
d9bd1af9ec BUGFIX: Don't publish virtual pages on regular page publish unless the page has already been published. (from r93529) (from r96760)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102391 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:14:36 +00:00
Ingo Schommer
679d48c2ff BUGFIX: Virtual pages can be deleted from the live site even when the're not publishable. (from r93319) (from r96758)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102389 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:13:26 +00:00
Ingo Schommer
bed078c16d API CHANGE: Added canDeleteFromLive permission to SiteTree, separate from canPublish (from r93315) (from r96756)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102388 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:12:45 +00:00
Ingo Schommer
6167cad850 BUGFIX: Fixed notice-level errors when checking permissions of pages that don't exist anywhere (from r93166) (from r96755)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102387 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:12:14 +00:00
Ingo Schommer
b124fafb0b MINOR: Removed debugging information: (from r93151) (from r96753)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102382 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:45:16 +00:00
Ingo Schommer
46db9796a5 BUGFIX: Add a default list of allowed extensions so that the CMS works reasonably out of the box.
BUGFIX: Allow files that don't have an extension (most notably folders)
BUGFIX: Ensure that file URL rewriting works if you rename a page twice without publishing.
BUGFIX: Ensure that the page doesn't go green after URLs are rewritten
ENHANCEMENT: Recognise HTTP_X_FORWARDED_HOST header and use that in place of HTTP_HOST (from r93148) (from r96752)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102381 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:42:51 +00:00
Ingo Schommer
c83e6718b7 API CHANGE: Define VirtualPage::isPublishable() so that people know not to even request publication if it's not allowed. (from r93098) (from r96751)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102380 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:41:23 +00:00
Ingo Schommer
e362790abd BUGFIX: Fixed bug in r93095 (from r93097) (from r96750)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102379 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:41:02 +00:00
Ingo Schommer
08075929ba API CHANGE: Added DataObjectDecorator::cacheKeyComponent() to ensure that the cached behind DataObject::get_one() is appropriately specific (from r93095) (from r96749)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102378 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:40:50 +00:00
Ingo Schommer
b8246bb433 BUGFIX: Update virtual pages semantics to grab content from the published version of the source page when you publish the virtual page, and to not allow publication before their source page is published. (from r92209) (from r96748)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102377 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:40:09 +00:00
Ingo Schommer
02353639d6 BUGFIX: Amended some references to HTTPResponse, replacing with SS_HTTPResponse (from r96746)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102373 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:35:58 +00:00
Ingo Schommer
1ad6130b64 MINOR: Fixed SiteTree::canEdit() for records not yet saved to DB (from r92193) (from r96745)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102372 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:35:43 +00:00
Ingo Schommer
a7d39ef9c1 MINOR: can_edit_multiple() should return false, not 0, for permission failure. (from r92192) (from r96744)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102370 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:35:28 +00:00
Ingo Schommer
c672061024 BUGFIX: Use live permissions if the stage page has been deleted. (from r91761) (from r96741)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102367 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:34:21 +00:00
Ingo Schommer
967e218758 BUGFIX: Make virtual page broken link detection work across subsites. (from r91311) (from r96740)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102366 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:34:04 +00:00
Ingo Schommer
848b7805e2 API CHANGE: Added Hierarchy::numHistoricalChildren() and Versioned::get_including_deleted_query()
API CHANGE: Added numChildrenMethod arg to getChildrenAsUL, markPartialTree, markChildren, markingFinished
BUGFIX: Clear the bypassStaticCache cookie when you return to the live site. (from r91165) (from r96739)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102365 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:33:46 +00:00
Ingo Schommer
6f8f7ba90a MINOR if looking at a specific stage, set a cooking to bypass static cacheing (from r91006) (from r96738)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102364 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:33:08 +00:00
Ingo Schommer
4a3986a28c MINOR virtual pages are now marked as broken if their pointer page is deleted (from r90996) (from r96737)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102363 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:32:51 +00:00
Ingo Schommer
43fb34a748 BUGFIX: Include newly set fields in the differences shown by DataDifferencer (from r90264) (from r96736)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102361 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:32:34 +00:00
Ingo Schommer
db859b793a BUGFIX: Use draft site permissions over published, if available. (from r90220) (from r96735)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102357 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:04:15 +00:00
Ingo Schommer
e921b376bc API CHANGE: Don't generate TestOnly DataObjects in the database immediately; instead let test developers specify them in SapphireTest::$extraDataObjects.
API CHANGE: Added SapphireTest::resetDBSchema() (from r90054) (from r96734)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102356 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:03:16 +00:00
Ingo Schommer
219c57b7bd BUGFIX: Call onBeforeUnpublish/onAfterUnpublish events in doDeleteFromLive, because they amount to the same thing. (from r90001) (from r96732)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102354 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:57:56 +00:00
Ingo Schommer
6b85948404 BUGFIX: Fixed broken link correction when a page is deleted. (from r89989) (from r96731)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102353 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:57:01 +00:00
Ingo Schommer
d56bc3e4dc BUGFIX: Added better handling of rendering SiteTree objects, to prevent test errors. (from r89963) (from r96729)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102351 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:53:16 +00:00
Ingo Schommer
007b309e62 BUGFIX: Reset the methods applied to classes after adding/removing extensions. (from r89957) (from r96726)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102348 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:50:38 +00:00
Ingo Schommer
d89552485e BUGFIX: Prevented notice-level error when publishing HTMLText fiels on tables other than SiteTree. (from r89908) (from r96724)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102346 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:49:50 +00:00
Ingo Schommer
1c0b6163f3 BUGFIX: Fixed image link rewriting in virtual pages. (from r89904) (from r96721)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102344 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:49:23 +00:00
Ingo Schommer
19911cd241 BUGFIX: Fixed SiteTree::rewriteFileURL() (from r89804) (from r96717)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102340 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:47:19 +00:00
Ingo Schommer
cec98c6b63 MINOR fix syntax error (from r89472) (from r96716)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102339 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:47:04 +00:00
Ingo Schommer
c726569bcf BUGFIX Version field weird'ed up rollback functionality (from r89464) (from r96715)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102338 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:46:47 +00:00
Ingo Schommer
603657b943 MERGE merged back a whole bunch of defect fixes from trunk (from r87846) (from r96712)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102336 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:45:52 +00:00
Ingo Schommer
670bd4bce4 MINOR changed the method to get a page's siteconfig, it is now subsite aware. (from r89870) (from r96710)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102335 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:44:06 +00:00
Ingo Schommer
5c6f3d59d7 BUGFIX: alternative function for versions of PHP prior to version 5.2 (from r96681)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102333 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:43:32 +00:00
Ingo Schommer
22e789e916 BUGFIX: Allow set objects as properties if the property is not a database field (from r96663)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102329 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:36:30 +00:00