Commit Graph

382 Commits

Author SHA1 Message Date
Hayden Smith
3f6a86738b Added PHP doc for the ValidationException thrown by DataObject::write
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63892 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 20:50:28 +00:00
Hayden Smith
fc2c16efdf DataObject::write now throws a ValidationException rather than calling user_error if the call to DataObject::validate fails. This allows the validation exception to be caught and handled by tests or other controllers.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63891 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 20:42:09 +00:00
Sam Minnee
09cb773f5c BUGFIX: SiteTree::onAfterPublish() will still pass an object to the handlers on the first publish
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63823 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 03:36:38 +00:00
Sean Harvey
9f0718f6df BUGFIX: Fixed array_key_exists check in DataObject->setField that was failing when DataObject->record was not yet initialised by DataObject->setField.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63813 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 02:25:26 +00:00
Hayden Smith
634ed7b70c Merged from branches/nzct-trunk. Use 'svn log -c <changeset> -g' for full commit message. Merge includes stability fixes and minor refactor of TableListField and ComplexTableField.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63806 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-08 02:00:12 +00:00
Sam Minnee
09cbef9146 BUGFIX: Fixed bug in getCMSFields scaffolding of relations
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63739 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-07 04:03:24 +00:00
Ingo Schommer
e1e2329c90 ENHANCEMENT Consistently allowing for $restrictFields and $fieldClasses parameters passed to DataObject->scaffoldFormFields(), DataObject->scaffoldSearchFields(), DataObject->scaffoldCMSFields()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63651 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-05 19:22:54 +00:00
Ingo Schommer
7da3497668 ENHANCEMENT Using DataObject->Title for has_one dropdowns generated in DataObject->scaffoldFormFields()
MINOR Removed scaffolded header field in DataObject->scaffoldFormFields()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63632 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 22:47:06 +00:00
Ingo Schommer
df199ebc2b ENHANCEMENT Added DataObject->scaffoldCMSFields() to simplify overloading of getCMSFields(). scaffoldCMSFields() automatically converts scaffoldFormFields() to a tabset
ENHANCEMENT Added DataObject->fieldLabel() and removed $fieldname parameter from DataObject->fieldLabels($fieldName) to simplify overloading of fieldLabels() for i18n

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63630 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 18:38:52 +00:00
Ingo Schommer
02ae284e10 FEATURE Added DataObject->getFormFields() - uses DataObject->scaffoldFormFields() by default. Added DataObjectDecorator->updateFormFields() for easy customization
ENHANCEMENT Calling DataObjectDecorator->updateCMSFields() in DataObject->getCMSFields() - was previously only called in SiteTree instances

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63623 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 16:21:09 +00:00
Ingo Schommer
1307d3da41 BUGFIX Making sure that Dataobject->getManyManyJoin() inserts a valid database table for the relation - not all component classes returned by ComponentSet->ownerClass are valid tables (see r54797 and r60909 for previous commits on this issue)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63621 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 16:11:46 +00:00
Ingo Schommer
370343016f ENHANCEMENT Only list ID field in DataObject->summaryFields() if no summaryfields are defined (or can be autodetected). Listing all fields was not feasible, as some subclasses have more fields than fits the column layout
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63620 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-03 16:01:51 +00:00
Ingo Schommer
882b4bc4e1 ENHANCEMENT Checking for instanceof DataObject instead of has_one() in DataObject->update() to support virtual relations as well (fix to r63531)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63554 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-02 22:47:01 +00:00
Ingo Schommer
892becb520 ENHANCMENT Checking for valid has_one relationship on dot-notation-usage in DataObject->update
MINOR Documentation in DataObject

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63531 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-02 13:58:08 +00:00
Sam Minnee
a231c15669 BUGFIX: Fixed DataObject::dbObject() operation with CompositeDbFields
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63509 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-02 03:28:01 +00:00
Sam Minnee
cba8e71170 ENHANCEMENT: Added support for dot syntax to DataObject::update()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63493 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-02 00:45:13 +00:00
Sean Harvey
2c773d0d69 MINOR phpdoc tweaks
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63490 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-02 00:34:16 +00:00
Ingo Schommer
2a02c8f08a MINOR Documentation in ErrorPage
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63466 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 14:57:06 +00:00
Ingo Schommer
5d3e815967 API CHANGE Changed parameters for Debug::friendlyError()
ENHANCEMENT Using DebugView class in Debug::friendlyError()
ENHANCEMENT Using Debug::friendlyError() in HTTPResponse class if status code signifies error (only on live environments in non-ajax requests)
ENHANCEMENT Showing contact information in Debug::friendlyError() from Email::getAdminEmail()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63465 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 14:43:43 +00:00
Sam Minnee
ca884b809d BUGFIX #2753: Couldn't have fields named the same as methods
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63432 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-10-01 00:55:25 +00:00
Ingo Schommer
8502f4064d MINOR documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63370 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 02:06:46 +00:00
Ingo Schommer
bf896a2cfd API CHANGE Deprecated DataObject->fieldExists() - please use hasField(), hasDatabaseField(), hasOwnTableDatabaseField()
ENHANCEMENT Added DataObject->hasOwnTableDatabaseField(), replaced legacy usage of fieldExists()
ENHANCEMENT Renamed cached static "fieldExists" to "_cache_hasOwnTableDatabaseField"
ENHANCEMENT Added DataObjectTest test cases for checking various field existence levels
API CHANGE Deprecated DataObject->listOfFields() - use custom code instead

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63337 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-30 00:20:30 +00:00
Ingo Schommer
150d41b4c7 API CHANGE Removed SiteTree->canView_page() - originally created under the false assumption that SiteTree->can('view_page') is still valid. Every canView() can be instance specific. Original patch by simon_w in r53183 and #2198
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63310 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-29 21:41:20 +00:00
Ingo Schommer
97263cd09c ENHANCEMENT Using HTTP Status 301 for RedirectorPage class, to be nice to search engines and improve SEO (with 200 page rank gets split between pages, with 301 its all transferred to the target page)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63181 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 19:50:53 +00:00
Ingo Schommer
3f3346fd93 API CHANGE Removed Text->Att(), use Text->ATT_val() instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63177 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 13:14:03 +00:00
Ingo Schommer
e7f3e3487d API CHANGE Deprecated Varchar->Attr(), use Varchar->ATT_val() instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63176 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 13:13:16 +00:00
Ingo Schommer
e2b626434a MINOR Documentation for image uploads
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63174 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-28 13:08:56 +00:00
Ingo Schommer
9371f4688b ENHANCEMENT Introduced constants for system paths like /sapphire in preparation for a more flexible directory reorganisation. Instead of hardcoding your path, please use the following constants: BASE_PATH, BASE_URL, SAPPHIRE_DIR, SAPPHIRE_PATH, CMS_DIR, CMS_PATH, THIRDPARTY_DIR, THIRDPARTY_PATH, ASSETS_DIR, ASSETS_PATH, THEMES_DIR, THEMES_PATH
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63154 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-27 16:02:38 +00:00
Sean Harvey
bd6a645857 MINOR: Fix phpdoc parsing error
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63125 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-26 04:26:06 +00:00
Sean Harvey
525e5b14c6 MINOR: Fix phpdoc parsing error
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63122 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-26 04:19:45 +00:00
Sam Minnee
6915ac9bc7 Turned dos line endings into unix
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63113 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-26 02:22:51 +00:00
Ingo Schommer
b27797598f MINOR Removed stale version number from <meta name="generator"> tag (#1908)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63080 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-25 14:23:24 +00:00
Sam Minnee
1be18b792c EHANCEMENT #2853 - You can now use db/build instead of db/build?flush=1
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@63020 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-25 00:03:09 +00:00
Sam Minnee
2a1d4376e2 BUGFIX #2390: Not indexed pages are removed from sitemap.xml
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62910 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-23 03:16:23 +00:00
Sam Minnee
08643b3b4b BUGFIX #2721 - Show decent preview on FileIFrameField
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62892 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-23 02:18:02 +00:00
Sam Minnee
fcc687fff2 MINOR: Added some more api doku for DataObject::
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62877 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-23 00:17:58 +00:00
Sam Minnee
fd88d31d9d BUGFIX: More robust setting of defaults; necessary due to altered ViewableData::__isset()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62875 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-23 00:10:41 +00:00
Sam Minnee
184352ec05 ENHANCEMENT #2417: Replaced http://www.yoursite.com with the actual base URL
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62867 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-22 22:52:12 +00:00
Ingo Schommer
2d8656e72b API CHANGE Deprecated Member::isInGroup() - use Member::inGroup() instead
ENHANCEMENT Allowing usage of ID, Code-String or Object as $group parameter in Member::inGroup()


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62847 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-22 16:07:28 +00:00
Ingo Schommer
73dd86bd8e ENHANCEMENT Using optional $member parameter for DataObject::can*() methods
MINOR Added documentation to DataObject about permission handling


git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62841 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-22 16:02:03 +00:00
Ingo Schommer
c57ce5f1a4 FEATURE Formatting MySQL error messages with newlines through new SQLFormatter class (used in MySQLDatabase)
ENHANCEMENT Using CliDebugView to report errors on ajax requests (with plaintext output)
ENHANCEMENT Removed "ERROR:" prefix hack for ajax error responses - clientside evaluation should inspect HTTP status codes instead

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62467 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-16 18:12:07 +00:00
Sam Minnee
d072e280e4 Merged branches/roa into trunk
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62321 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-12 04:49:15 +00:00
Sean Harvey
f01b881003 MINOR HTMLVarchar->scaffoldFormField() was referencing a class name of different case that didn't exist (change it to the correct one to be sure)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62313 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-12 03:32:04 +00:00
Andrew O'Neil
3eaa025df4 Allow MetaTags to be extended by a decorator.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62295 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-12 02:07:46 +00:00
Sean Harvey
c9f5e1ef58 ENHANCEMENT Added prepValueForDB() which is called on DBField->writeToManipulation which ensures formatting of value before insertion to DB on a per-DBField type basis.
ENHANCEMENT Added DBFieldTest to test prepValueForDB()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@62267 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-11 06:22:33 +00:00
Normann Lou
66b6a32c8d BUGFIX: not all decorators has a summary_fields defined, so the code need to deal with this.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61975 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-04 23:10:20 +00:00
Andrew O'Neil
770bdfa42b FEATURE #2594 - Allow decoration of getCMSActions() (simon_w)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61824 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-09-01 04:45:38 +00:00
Sam Minnee
e9615040e1 ENHANCEMENT: Added dev/tests/startsession and dev/tests/endsession to allow the use of fixtures with external test frameworks, such as Windmill
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61627 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-27 08:19:46 +00:00
Sam Minnee
872b24003b ENHANCEMENT: wakeless - Added SQLQuery::filtersOnID()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61618 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-27 05:16:44 +00:00
Normann Lou
417ab6400d FEATURE: relate groups with column selections in SearchForm of CRM Admin
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@61605 467b73ca-7a2a-4603-9d3b-597d59a354a9
2008-08-27 04:11:58 +00:00