Commit Graph

4646 Commits

Author SHA1 Message Date
Sam Minnee
2699eb3b5b ENHANCEMENT MySQLDatabase::renameField() no longer checks that the field exists in fieldList(). alterField() does no such check, so it should be consistent. Removing this should provide a small performance improvement as well (from r112272)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112948 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:08:32 +00:00
Sam Minnee
65713da5d7 MINOR Comment about HTMLValue::setContent() stripping out of carriage returns (from r111950)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112947 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:07:45 +00:00
Sam Minnee
f0dc6c65ca BUGFIX Ensure that \r carriage return characters get stripped out before setting content in HTMLValue::setContent(). DOMDocument will transform these into &#13 entities, which is apparently XML spec, but not necessary for us as we're using HTML (from r111949)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112946 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:07:27 +00:00
Sam Minnee
c2989908c8 BUGFIX #6089 Avoid javascript error when "Allow drag & drop reordering" enabled, and attempt to drag a file from one folder to another is performed (from r111932)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112945 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:07:06 +00:00
Sam Minnee
be40e11c72 BUGFIX #6096 RSSFeed::feedContent() restores previous state of SSViewer::get_source_file_comments() after temporarily disabling it (thanks paradigmincarnate!) (from r111914)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112944 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:06:53 +00:00
Sam Minnee
8222d72d39 MINOR #6083 FileTest doesn't remove test folders and files created during test (from r111903)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112943 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:06:39 +00:00
Sam Minnee
31f0ceac07 BUGFIX Filesystem::removeFolder() did not remove files that ended with a "." when this is a valid file. Remove the regex and replace with specific case for "." and ".."
MINOR Code syntax formatting of Filesystem::removeFolder() (from r111898)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112942 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:06:25 +00:00
Sam Minnee
ef8419f11d ENHANCEMENT #4903 MemberLoginForm field for "You are logged in as %s" message customisation (thanks walec51!) (from r111891)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112941 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:05:23 +00:00
Sam Minnee
b40544e694 BUGFIX #6066 Form::__construct() should respect hasMethod on passed in Controller instance if it's available (thanks paradigmincarnate!) (from r111890)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112940 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:04:58 +00:00
Sam Minnee
bb183add33 BUGFIX #3910 Setting timezone parameter to MySQLDatabase::__construct() should use $this->query() to be consistent (from r111889)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112939 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:04:40 +00:00
Sam Minnee
aa1d6c72f0 MINOR Moved GD::set_default_quality() function to the top of the file to align with conventions (from r111888)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112938 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:04:14 +00:00
Sam Minnee
6d423c9f9b ENHANCEMENT #3775 Added getter to GD so you can retrieve the internal GD resource being used. Made setGD public so you can override the GD yourself as well (from r111887)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112937 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:04:00 +00:00
Sam Minnee
3c681b0324 #4029 On the fly form validation works in Opera as well (from r111880)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112936 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:03:47 +00:00
Sam Minnee
f51f5bc958 BUGFIX Ensure that windows-style newlines ("\r\n") don't get converted to their XML entity representation through DOMDocument in SS_HTMLValue->setContent() (from r111878)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112935 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:03:29 +00:00
Sam Minnee
fd7babe5a0 ENHANCEMENT Show "Database Configuration" section of installer requirements for reference (collapsed by default) (from r111873)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112934 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:03:16 +00:00
Sam Minnee
e2cb7001ce ENHANCEMENT MySQLDatabase::getVersion() now uses mysql_get_server_info() which has been supported since PHP 4. This gives us a better version than say "5.1", instead we now get something like "5.1.51" (from r111868)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112933 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:03:03 +00:00
Sam Minnee
429434811f MINOR Revert r111850 to MySQLDatabase::getVersion as version comparisons need to happen, and this will strip out non-numeric characters e.g. "ubuntu1" or "lenny4" which are prefixed on some Linux distros (from r111852)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112932 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:02:42 +00:00
Sam Minnee
4af7d7aa34 MINOR dev/build now shows database name and version next to "Building database ..." text (from r111851)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112931 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:02:02 +00:00
Sam Minnee
849bca4a3d ENHANCEMENT Make use of mysql_get_server_info() when calling MSSQLDatabase::getVersion(), if there's a problem getting info this way, falls back to using query for VERSION() details (from r111850)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112930 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:01:50 +00:00
Sam Minnee
1fc540c16b MINOR Fixed regression from r111843 (i18nText, MemberDatetimeFieldTest, MemberTest) (from r111844)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112929 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:01:35 +00:00
Sam Minnee
89c3349a1c BUGFIX More common defaults for en_US.xml used by Zend_DateFormat (and DateField/DatetimeField), with less error prone numerical format replacing the Zend default of shortened month names (fixes #6071, thanks dalesaurus)
BUGFIX Correct locale mapping in DateField_View_JQuery for "en_US" and "en_NZ"
MINOR Fixed form validation message in DateField to include actual date format, rather than a hardcoded value (from r111843)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112928 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:01:18 +00:00
Sam Minnee
5e0b978263 BUGFIX #6055 ErrorPage should always create static error page files when dev/build is called if they don't exist (from r111842)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112927 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:00:35 +00:00
Sam Minnee
9bed2ca4f3 BUGFIX RFC 2822 compliant validation of email adresses in EmailField->jsValidation() and EmailField->validate() (fixes #6067, thanks paradigmincarnate) (from r111841)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112925 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:57:52 +00:00
Sam Minnee
7d09ef3e60 MINOR Change matchesRoughly threshold slightly in DbDatetimeTest to allow for slower database server connections (from r111821)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112924 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:55:50 +00:00
Sam Minnee
6449e3a1a7 MINOR Added FulltextSearchable::get_searchable_classes() in order to introspect currently searchable classes, added FulltextSearchableTest, added documentation (from r111789)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112923 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:53:36 +00:00
Sam Minnee
3388642d6b MINOR Fixed documentation in CheckboxSetField (fixes #6068, thanks paradigmincarnate) (from r111788)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112922 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:53:24 +00:00
Sam Minnee
8d5b417619 MINOR Fixed documentation in Datetime (fixes #6062, thanks nicolaas) (from r111787)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112921 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:53:11 +00:00
Sam Minnee
d328c7cc53 BUGFIX DB::connect() should not rely on $_SESSION existing, so we check isset() to supress any warnings of undefined indexes
MINOR Code formatting tidy of DB::connect() function (from r111772)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112920 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:52:59 +00:00
Sam Minnee
dd92459517 MINOR CoreTest::testGetTempPathInProject() will try to create a temp dirs when running. CoreTest::tearDown() will now remove these temp dirs when the test finishes (from r111748)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112919 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:52:46 +00:00
Sam Minnee
25af09b0f6 MINOR #5943 Debug::text() boolean values are amended with (bool) so they don't get confused with "true" or "false" which could be strings (thanks Pigeon!) (from r111676)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112918 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:52:33 +00:00
Sam Minnee
2dca48ba09 MINOR: Unit test breaks if another module or project extends Folder (from r111669)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112917 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:52:20 +00:00
Sam Minnee
d6c1d3b28d MINOR Fixed SQL quoting bug in FolderTest (caused by r111493) (from r111496)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112916 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:51:22 +00:00
Sam Minnee
d542ddbb40 ENHANCEMENT Making "sake" script more portable by using "/usr/bin/env" shebang instead of "/bin/bash" (fixes #6045, thanks sychan) (from r111495)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112915 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:50:34 +00:00
Sam Minnee
4e0450b590 BUGFIX Changing File->Filename property from arbitrary limitation on VARCHAR (255 characters) to TEXT (65k characters) to ensure the framework can handle deeply nested filesystem trees (fixes #6015, thanks muzdowski) (from r111494)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112909 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:05:29 +00:00
Sam Minnee
b2624e0012 BUGFIX Moving folder after executing Folder::findOrMake will not set the Filenames properly. Invoking updateFilesystem() in File->onAfterWrite() instead of onBeforeWrite(), and avoid caching in FIle->getRelativePath() (fixes #5994 and #5937, thanks muzdowski) (from r111493)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112908 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:00:57 +00:00
Sam Minnee
29515b2e01 BUGFIX Removing overloaded TableField->sourceItems() method, which enables features of the underlying TableListField implementation, such as pagination and source item caching (fixed #5965, thanks martijn) (from r111492)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112907 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:56:23 +00:00
Sam Minnee
976f96ee0a ENHANCEMENT Added "module=" argument to FullTestSuite (to support comma-separated module lists) (from r111489)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112906 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:55:44 +00:00
Sam Minnee
dd1c02cd90 BUGFIX: Search didn't respect searchableClasses passed to FulltextSearchable::enable() (from r111464)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112905 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:54:51 +00:00
Sam Minnee
0d19b45155 MINOR: Add translation correction for Czech and add Slovakian translation in cms and sapphire (js). Thanks to @Pike (from r111262)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112904 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:53:00 +00:00
Sam Minnee
c07e870b4d BUGFIX ContentController::SiteConfig() should look to the SiteTree record so an alternate SiteConfig is considered, if this method doesn't exist on the data record then fall back to the default SiteConfig (from r111255)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112901 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:49:13 +00:00
Sam Minnee
cdb04f79de BUGFIX Fixed quoting and GROUP BY statement in ManyManyComplexTableField->getQuery() for Postgres compatibility (from r111202)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112900 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:48:57 +00:00
Sam Minnee
b9ab0e6e1c BUGFIX Force tidy to avoid wrapping long lines in CSSContentParser, it breaks our FunctionalTest string assertions (from r111176)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112899 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:48:25 +00:00
Sam Minnee
de795ba0aa MINOR Code formatting in FullTestSuite (from r111133)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112898 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:47:39 +00:00
Sam Minnee
c939b02333 BUGFIX TarballArchive::extractTo() uses an incorrectly spelled argument (from r111126)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112897 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:47:26 +00:00
Sam Minnee
b573414486 MINOR Spelling corrections to Director comments (from r111123)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112896 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:47:11 +00:00
Sam Minnee
8d0253ad57 MINOR PHPUnit annotations for PhpSyntaxTest (from r111116)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112895 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:46:47 +00:00
Sam Minnee
3808b1f393 BUGFIX Fixed PhpSyntaxTest not to rely on relative folder references (broken due to chdir() changes in cli-script.php and bootstrap.php) (from r111097)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112894 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:46:04 +00:00
Sam Minnee
47f27bef87 BUGFIX Fixed regression where coverage report request did not get passed through to runTests() in TestRunner::all() (from r111092)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112893 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:45:26 +00:00
Sam Minnee
0d7d983c14 BUGFIX Fixed regression of dev/tests/all running a coverage report instead of just unit tests (from r111091)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112892 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:44:52 +00:00
Sam Minnee
0200c75ca0 ENHANCEMENT #6023 Shorten SSViewer cached template path for readability of the filenames, and also so Windows doesn't break on long paths (from r111086)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112891 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:44:37 +00:00