Commit Graph

4413 Commits

Author SHA1 Message Date
Ingo Schommer
25a0c3e7fb ENHANCEMENT: in referencing a file in combine_files() it should fall back to standard requirement tags if combining has been disabled eg dev mode (from r107091)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112549 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:09:15 +00:00
Ingo Schommer
fbbe0b4b39 BUGFIX: prevented HTTPRequest->shift() throwing notices when shifting multiple elements. APICHANGE: SS_HTTPRequest->shift($multiple) no longer returns an array of size $multiple spaced with nulls, it returns an array up to the size of $multiple. (from r107090)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112548 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:08:39 +00:00
Ingo Schommer
7fb414818a BUGFIX: fixed notice level errors getting through (from r107089)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112547 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:08:23 +00:00
Ingo Schommer
efebfe5993 ENHANCEMENT: added setDisabled() to set DropdownField::$disabled (from r107086)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112546 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:08:09 +00:00
Ingo Schommer
a848a182a7 API CHANGE Deprecated AutocompleteTextField, use third-party solutions (from r107054)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112545 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:07:54 +00:00
Ingo Schommer
997a86b7e0 MINOR: return false rather than error out in case SS_Query:: is not a resource (from r107030)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112544 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:07:39 +00:00
Ingo Schommer
a0424ccd3e MINOR: mysql_fetch_row() expects resource, this will fatal if query was e.g. UPDATE when iterating a result because MySQLQuery::nextRecord() is used by Iterator::valid() and MySQLQuery:: is bool in this case (from r106938)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112543 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:07:22 +00:00
Ingo Schommer
f7e61e0d11 ENHANCEMENT Added TestRunner::$coverage_filter_dirs to exclude certain directories from PHPUnit test coverage reports (from r106877)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112542 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:07:08 +00:00
Ingo Schommer
68e98b4ee2 MINOR Making $Email available in Security_passwordsent.ss template (fixes #5737) (from r106876)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112541 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:06:53 +00:00
Ingo Schommer
9b177ec458 BUGFIX Making status description in Debug::friendlyError() compatible to HTTP 1.1 spec (removing any markup and newlines) (from r106867)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112540 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:06:31 +00:00
Ingo Schommer
dcb402479a MINOR Added FileTest->testValidateExtension() (related to #5693) (from r106805)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112539 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:04:54 +00:00
Ingo Schommer
122549ca60 MINOR Documentation (from r106804)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112538 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:04:27 +00:00
Ingo Schommer
35a3d79e87 BUGFIX Re-enabling theme in ErrorPage->doPublish() (it's usually disabled in the publication context through LeftAndMain->init())
MINOR Reverted r88633, it breaks <base> tag in static HTML for ErrorPage->doPublish() (from r106777)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112537 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:04:10 +00:00
Ingo Schommer
a1f9efc414 BUGFIX Stricter checking that a relation exists on ComplexTableField::saveComplexTableField() (from r106755)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112536 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:03:54 +00:00
Ingo Schommer
0acb21d219 ENHANCEMENT Calling Image->deleteFormattedImages() in Image->onBeforeWrite() (#5423) (from r106705)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112535 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:03:37 +00:00
Ingo Schommer
d51627a342 MINOR Fixed hardcoded error message in PasswordValidator (fixes #5734)
MINOR Added PasswordValidatorTest (from r106687)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112534 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:03:19 +00:00
Ingo Schommer
ceb27c4a41 BUGFIX Fixed ImageField->EditFileForm() to list subclasses of Image in tree dropdown (fixes #5708, thanks keeny) (from r106671)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112533 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:02:17 +00:00
Ingo Schommer
4d665ce268 BUGFIX Prevent DateField->performReadonlyTransformation() from segfaulting on PHP 5.2 due to broken __toString() casting (fixes #5713, thanks charden) (from r106666)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112532 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:01:58 +00:00
Ingo Schommer
48cea784f6 MINOR: Provide a default message for FIELDISREQUIRED (from r106568)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112531 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:01:42 +00:00
Ingo Schommer
333a5b487b MINOR: Correct typo in comments (from r106313)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112530 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:01:24 +00:00
Ingo Schommer
ad84f07af0 BUGFIX Checking for the same combined filename in Requirements::combine_files() to avoid irrelevant error messages (from r106225)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112529 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:01:03 +00:00
Ingo Schommer
39b056024f APICHANGE: moved Group::addToGroupByName to $member->addToGroupByCode. (from r106217)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112528 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:00:48 +00:00
Ingo Schommer
197cdb0f64 BUGFIX: updated tests for Text (from r106205)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112527 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:00:12 +00:00
Ingo Schommer
e36247c1ed ENHANCEMENT: added prefix and suffix support to ContextSummary (from r106200)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112526 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:59:46 +00:00
Ingo Schommer
5fe548f7b5 MINOR Fixed memory limit setting in SapphireTest (regression from r106128) (from r106190)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112525 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:59:10 +00:00
Ingo Schommer
f0d03207a6 MINOR: Better checking of safe_mode in MemoryLimitTest (from r106187)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112524 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:58:55 +00:00
Ingo Schommer
02c2af7249 MINOR: Don't run memory limit tests in safe mode, (from r106156)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112523 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:58:39 +00:00
Ingo Schommer
497e557632 BUGFIX: if running in cli do not output html tags when rebuilding the db (from r106154)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112522 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:58:21 +00:00
Ingo Schommer
3c18a9f1f6 MINOR: Preserve memory_limit between tests (for better PHP5.1 behaviour) (from r106128)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112521 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:58:02 +00:00
Ingo Schommer
723731a574 BUGFIX: Replaced Versioned's unique index definition with an array syntax. (from r106120)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112520 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:57:46 +00:00
Ingo Schommer
06ba0085dd MINOR: Added test for Database::hasTable(). (from r106119)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112519 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:57:14 +00:00
Ingo Schommer
2d2ca13e45 ENHANCEMENT: added setRows() and setColumns() to customize the size of the textarea field outside of the controller (from r106118)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112518 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:56:36 +00:00
Ingo Schommer
7eaca248e2 MINOR Removed db/build legacy wording in DevelopmentAdmin (fixes #5676) (from r106083)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112517 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:56:21 +00:00
Ingo Schommer
2aed7be053 BUGFIX: Fixed SiteTree::IsModifiedOnStage() for an edge-case that was identified when deleteFromStage() stopped manipulating the current record. (from r106082)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112516 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:56:05 +00:00
Ingo Schommer
c7b47d8a8b BUGFIX: Don't let deleteFromStage() kill the ID of the original record. (from r106080)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112515 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:55:45 +00:00
Ingo Schommer
03c3d59ba0 BUGFIX: Add a unique index to SiteTree_versions.RecordID+Version. Fix saving methods to support this. (from r106079)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112514 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:55:15 +00:00
Ingo Schommer
ee0d4c5197 BUGFIX: Throw an exception if you try an delete an unsaved or already-deleted record (from r106078)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112513 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:54:34 +00:00
Ingo Schommer
b839ab2b9f BUGFIX MySQLDatabaseConfigurationHelper::getVersion() will fallback to trying to get the version using a query if mysql_get_server_info() returns nothing (from r106071)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112512 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:54:18 +00:00
Ingo Schommer
db460ed57f MINOR Better error handling in Form::__construct() (fixes #5649) (from r105912)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112511 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:54:02 +00:00
Ingo Schommer
09d4d0ccb3 BUGFIX: fixed phpunit directive (from r105907)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112510 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:53:46 +00:00
Ingo Schommer
716b5cd6c5 BUGFIX: reverted revision 105890 to fix build (from r105903)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112509 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:53:31 +00:00
Ingo Schommer
3b4d0a7422 ENHANCEMENT: Added method for $this->request->latestParam() backwards compatibility with Director::urlParam() (from r105890)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112508 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:53:11 +00:00
Ingo Schommer
3aee3e2b23 BUGFIX: invalid use of @covers annotation (from r105889)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112507 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:52:20 +00:00
Ingo Schommer
ca02b91673 BUGFIX: TableListField_Item::SelectOptionClasses() can not use it parent protected variable. (from r105876)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112506 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:52:05 +00:00
Ingo Schommer
8a2576ee3e BUGFIX: rollback r105858 which introducesa bug (from r105875)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112505 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:51:48 +00:00
Ingo Schommer
91700a3dac BUGFIX: updated select options classes to work with the dataobjectset returned by selectoptions rather than the array previously (from r105872)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112504 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:51:33 +00:00
Ingo Schommer
092a3c1c26 BUGFIX: TableListField_Item::SelectOptionClasses() can use it parent protected variable. (from r105858)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112503 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:51:04 +00:00
Ingo Schommer
4c2ff4bd0a APICHANGE: refactored methods in session to use coding conventions (from r105756)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112502 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:50:43 +00:00
Ingo Schommer
74036f9642 ENHANCEMENT Added MySQLDatabaseConfigurationHelper::getDatabaseVersion() which abstracts the version number away from the version check the installer requires (from r105712)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112501 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:50:06 +00:00
Ingo Schommer
9c68b954fd BUGFIX More specific regex in Requirements->includeInHTML() to avoid duplicating information by matching HTML5-style <header> tags instead of <head> (fixes #5640) (from r105667)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112500 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:49:52 +00:00