Commit Graph

23331 Commits

Author SHA1 Message Date
Steve Boyd
f14c60ceb2
Merge pull request #10463 from creative-commoners/pulls/4/rescue-master-static-analysis
Rescue Master Branch PR: ENH Various changes via static analysis tooling
2022-08-25 09:50:13 +12:00
Steve Boyd
feb57dbf1f
Merge pull request #10461 from creative-commoners/pulls/5/rescue-master-abstract-testcase
API Rescue Master Branch PR: TestCase classes should be abstract to prevent warnings
2022-08-24 15:37:18 +12:00
Steve Boyd
9e057d8902
Merge pull request #10458 from creative-commoners/pulls/5/rescue-master-abstract-migrationtask
API Rescue Master Branch PR: Update MigrationTask class to be an abstract class
2022-08-24 15:35:46 +12:00
Steve Boyd
b37921d0b1
Merge pull request #10462 from creative-commoners/pulls/5/rescue-master-join-aliases
Rescue Master Branch PR: Fix SQLConditionalExpression::getJoins so it always adds explicit aliases
2022-08-24 15:33:41 +12:00
Damian Mooyman
f2211d690f
BUG Fix extend() failing on protected extend-prefixed methods 2022-08-24 15:31:43 +12:00
Damian Mooyman
76fc8f1596
API Only expose public extension methods
API Enable `extend*` methods to handle ->extend()
API Remove Extensible::constructExtensions()
2022-08-24 15:31:34 +12:00
Steve Boyd
f5d72e998c
Merge pull request #10460 from creative-commoners/pulls/5/rescue-master-dataobject-get-any-one
API Rescue Master Branch PR: Allow dataobject get_one without passing a class
2022-08-24 15:25:13 +12:00
Steve Boyd
4a3b6d951b
Merge pull request #10456 from creative-commoners/pulls/5/rescue-master-remove-unsafe-queryparams
API Rescue Master Branch PR: Remove isDev / isTest querystring arguments
2022-08-24 15:14:45 +12:00
Viktor Szépe
94d1ac8d99
ENH Various changes via static analysis tooling 2022-08-24 12:14:32 +12:00
Serge Latyntcev
e07671a890
Fix SQLConditionalExpression::getJoins so it always adds explicit aliases
This is a revert of https://github.com/silverstripe/silverstripe-framework/pull/8956
2022-08-24 11:27:02 +12:00
Daniel Hensby
2c102c61a9
API TestCase classes should be abstract to prevent warnings 2022-08-23 17:12:24 +12:00
Andrew Aitken-Fincham
f2de39162d
API Allow dataobject get_one without passing a class
add class validation early in get_one()
2022-08-23 16:25:23 +12:00
Dan Hensby
a666814a80
ENH CSV BOM stripping is now handled internally by league/csv 2022-08-23 15:57:13 +12:00
Michal Kleiner
e42ed95be1
API Update MigrationTask class to be an abstract class 2022-08-23 15:53:33 +12:00
Damian Mooyman
08d1cd3834
API Remove isDev / isTest querystring arguments 2022-08-23 11:40:43 +12:00
Christopher Joe
b36a01a8fd
BUG Fix table name test 2022-08-22 17:47:14 +12:00
Guy Sartorelli
a4521a7348
API Undeprecate table warning message
I think it's worth keeping this message around to encourage best
practices.
2022-08-22 17:45:00 +12:00
Christopher Joe
156f63bce3
ENH shorten auto-generated table names
Fix add check for legacy long table name and rename to short version
2022-08-22 17:44:51 +12:00
Guy Sartorelli
a75317343e
Merge pull request #10439 from creative-commoners/pulls/4/better-button-keep-state
ENH Update page number in the state on reaching the first or the last…
2022-08-22 13:47:47 +12:00
Sabina Talipova
c0b38fc411 ENH Update page number in the state on reaching the first or the last element in a list 2022-08-22 12:44:11 +12:00
Sabina Talipova
3b758a8a4c
Merge pull request #10446 from creative-commoners/pulls/5/conflict
FIX Ensure PHP 8.1 compatible version of oscarotero/html-parser is installed
2022-08-22 10:17:50 +12:00
Steve Boyd
d55683d02b FIX Ensure PHP 8.1 compatible version of oscarotero/html-parser is installed 2022-08-18 10:49:07 +12:00
Sabina Talipova
7e695dd42d
Merge pull request #10444 from creative-commoners/pulls/5/remove-phpunit-57
API Remove PHPUnit 5.7 compatability hacks
Unrelated to this PR failed test disregarded
2022-08-16 11:08:42 +12:00
Guy Sartorelli
10ef46a5ec
ENH Make DataObject::exists() an alias of DataObject::isInDB() (#10407) 2022-08-16 09:43:54 +12:00
Guy Sartorelli
3284c06703
API Remove PHPUnit 5.7 compatability hacks 2022-08-12 10:52:56 +12:00
Sabina Talipova
6afcd39d4b
Merge pull request #10448 from creative-commoners/pulls/4/deprecate-phpunit-57
API Deprecate PHPUnit 5.7 compatability hacks
2022-08-12 10:08:50 +12:00
Guy Sartorelli
4cb36d4d14
MNT Fix test 2022-08-11 16:29:39 +12:00
Guy Sartorelli
1153bacc11
API Remove unnecessary getGenerator() method.
`getIterator()` now returns a generator by default.
2022-08-11 16:29:39 +12:00
Guy Sartorelli
5bdfaea78a
FIX Don't try to call count() on an iterator 2022-08-11 16:29:39 +12:00
Daniel Hensby
595835bb15
Merge pull request #6518 from sminnee/generators
Use Generators for ORM Query, Map, ArrayList
2022-08-11 16:29:32 +12:00
Guy Sartorelli
a7461a8ffa
API Deprecate PHPUnit 5.7 compatability hacks 2022-08-10 16:21:05 +12:00
Guy Sartorelli
2ae52120c1
Merge pull request #10445 from creative-commoners/pulls/5/other-deps
DEP Update dependencies for CMS 5
2022-08-10 10:37:23 +12:00
Steve Boyd
470753194c DEP Update dependencies for CMS 5 2022-08-09 17:27:04 +12:00
Guy Sartorelli
7b0957709d
Merge pull request #10134 from gurucomkz/resolve-combined-css-refs
ENH Resolve relative paths in CSS files when combining
2022-08-09 15:28:42 +12:00
Guy Sartorelli
9f4da7607d
Merge pull request #10438 from creative-commoners/pulls/5/major-deps
DEP Update core dependencies for CMS 5
2022-08-09 09:44:18 +12:00
Steve Boyd
ae3a0d9c65
Merge pull request #10437 from creative-commoners/pulls/5/default-resource-dir
ENH Set the default resources dir to "_resources"
2022-08-08 12:16:55 +12:00
Sergey Shevchenko
4994844729 refactor: variable naming in Requirements_Backend::resolveCSSReferences() 2022-08-05 21:27:36 +12:00
Sergey Shevchenko
6975815513 config: add symfony/filesystem to base dependencies 2022-08-05 21:26:45 +12:00
Sergey Shevchenko
ebb1601d5d fix: misc suggested changes
* disable resolve_relative_css_refs by default
* variable naming
* using proper path joiner
* test comment typo
2022-08-05 15:35:26 +12:00
Sergey Shevchenko
bc9a323418 fix: more tests, improved paths detection, readability 2022-08-05 15:35:26 +12:00
Sergey Shevchenko
9854e48cfc Update Requirements_Backend.php 2022-08-05 15:35:26 +12:00
Sergey Shevchenko
a2906cd02c ENH Requirements_Backend::resolveCSSReferences(): Tests, config, doc, safety.
* Changed to ignore absolute paths altogether
* Improve tests
* Added config flag
* Changed docs
2022-08-05 15:35:26 +12:00
Sergey Shevchenko
8370ffc2a0 ENH Test for Requirements_Backend::resolveCSSReferences() 2022-08-05 15:35:26 +12:00
Sergey Shevchenko
c5e68dd2c0 ENH: resolve relative references in CSS files when combining 2022-08-05 15:35:26 +12:00
Steve Boyd
eb62db6dba DEP Update core dependencies for CMS 5 2022-08-04 17:41:32 +12:00
Guy Sartorelli
ee4144fc35 ENH Set the default resources dir to "_resources" 2022-08-04 11:36:54 +12:00
Guy Sartorelli
37dc0daacc API Remove deprecated ManifestFileFinder::RESOURCES_DIR const 2022-08-04 11:36:27 +12:00
Guy Sartorelli
9b1052f955
Merge pull request #10434 from creative-commoners/pulls/4/fix-test
MNT Fix broken unit test
2022-08-03 16:06:50 +12:00
Guy Sartorelli
a57eeb614b MNT Fix broken unit test 2022-08-03 15:47:14 +12:00
Steve Boyd
6cdefcedf0 Merge branch '4.11' into 4 2022-08-03 14:37:37 +12:00