tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 14:05:37 +02:00
Code Issues Projects Releases Wiki Activity

Merge pull request #10456 from creative-commoners/pulls/5/rescue-master-remove-unsafe-queryparams

Browse Source 
API Rescue Master Branch PR: Remove isDev / isTest querystring arguments
This commit is contained in:
Steve Boyd 2022-08-24 15:14:45 +12:00 committed by GitHub
commit 4a3b6d951b
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
3 changed files with 1 additions and 28 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
src/Core/BaseKernel.php
View File

@ -257,12 +257,6 @@ abstract class BaseKernel implements Kernel
return $this->enviroment;
}
// Check saved session
$env = $this->sessionEnvironment();
if ($env) {
return $env;
}
// Check getenv
if ($env = Environment::getEnv('SS_ENVIRONMENT_TYPE')) {
return $env;
@ -271,23 +265,6 @@ abstract class BaseKernel implements Kernel
return self::LIVE;
}
/**
* Check or update any temporary environment specified in the session.
*
* @return null|string
*
* @deprecated 5.0 Use Director::get_session_environment_type() instead
*/
protected function sessionEnvironment()
{
if (!$this->booted) {
// session is not initialyzed yet, neither is manifest
return null;
}
return Director::get_session_environment_type();
}
abstract public function boot($flush = false);
abstract public function isFlushed();

5
src/Core/Startup/ErrorControlChainMiddleware.php
View File

@ -53,10 +53,7 @@ class ErrorControlChainMiddleware implements HTTPMiddleware
{
$chain = new ConfirmationTokenChain();
$chain->pushToken(new URLConfirmationToken('dev/build', $request));
foreach (['isTest', 'isDev', 'flush'] as $parameter) {
$chain->pushToken(new ParameterConfirmationToken($parameter, $request));
}
$chain->pushToken(new ParameterConfirmationToken('flush', $request));
return $chain;
}

1
src/Core/Startup/ParameterConfirmationToken.php
View File

@ -129,7 +129,6 @@ class ParameterConfirmationToken extends AbstractConfirmationToken
public function suppress()
{
unset($_GET[$this->parameterName]);
$this->request->offsetUnset($this->parameterName);
}