Commit Graph

1645 Commits

Author SHA1 Message Date
Sam Minnee
d3f3178e8c MINOR virtual pages are now marked as broken if their pointer page is deleted (from r90996)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96737 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:04 +13:00
Sam Minnee
b82640cf62 BUGFIX: Include newly set fields in the differences shown by DataDifferencer (from r90264)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96736 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:04 +13:00
Sam Minnee
efd9b2f666 BUGFIX: Use draft site permissions over published, if available. (from r90220)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96735 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:04 +13:00
Sam Minnee
63096cfefb API CHANGE: Don't generate TestOnly DataObjects in the database immediately; instead let test developers specify them in SapphireTest::$extraDataObjects.
API CHANGE: Added SapphireTest::resetDBSchema() (from r90054)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96734 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:04 +13:00
Sam Minnee
73de615e7c BUGFIX: Call onBeforeUnpublish/onAfterUnpublish events in doDeleteFromLive, because they amount to the same thing. (from r90001)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96732 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:04 +13:00
Sam Minnee
8a0302d2ac BUGFIX: Fixed broken link correction when a page is deleted. (from r89989)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96731 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:04 +13:00
Sam Minnee
84d819f350 BUGFIX: Prevented notice-level error when publishing HTMLText fiels on tables other than SiteTree. (from r89908)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96724 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:03 +13:00
Sam Minnee
f0173f5531 BUGFIX: Fixed image link rewriting in virtual pages. (from r89904)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96721 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:03 +13:00
Sam Minnee
ad20ff2ac0 BUGFIX: Fixed SiteTree::rewriteFileURL() (from r89804)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96717 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:02 +13:00
Sam Minnee
1539aec9c7 MINOR fix syntax error (from r89472)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96716 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:02 +13:00
Sam Minnee
ac1a9da61e BUGFIX Version field weird'ed up rollback functionality (from r89464)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96715 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:02 +13:00
Sam Minnee
51a2eeed15 MERGE merged back a whole bunch of defect fixes from trunk (from r87846)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96712 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:02 +13:00
Sam Minnee
5a6131bdde MINOR changed the method to get a page's siteconfig, it is now subsite aware. (from r89870)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96710 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:01 +13:00
Andrew O'Neil
c65695b807 BUGFIX: Allow set objects as properties if the property is not a database field
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96663 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:01 +13:00
Sean Harvey
30f332cd21 ENHANCEMENT Added Date::Rfc3339() for returning an RFC 3339 valid date format (from r96010)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@96049 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:00 +13:00
Sean Harvey
465a15b536 BUGFIX Fixed undefined $this->Parent in SiteTree::getCMSFields()
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@95422 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:18:00 +13:00
Will Rossiter
354af48f6f ENHANCEMENT: Improved layout of altercation message when called via CLI. Patch via simon_w #4373
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@94515 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:58 +13:00
Sean Harvey
abab0dd631 BUGFIX #4566 Time::Nice() and Time::Nice24() return bad results if there is no value
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@94353 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:56 +13:00
Sean Harvey
52abe83a2b MINOR #4973 Automatically generate URLSegment for default records on SiteTree and ErrorPage instead of explicitly setting them
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@94352 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:56 +13:00
Sean Harvey
bcf57982cc FEATURE Added DataObjectSet::emptyItems() to remove all the items from the set - this is useful for when you are augmenting CMS and front end fields via updateCMSFields() and updateFrontEndFields() on a DataObjectDecorator
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@94297 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:56 +13:00
Tom Rix
e3c1ec7fe3 BUGFIX fixed reference to incorrect class
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@94061 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:55 +13:00
Sean Harvey
38efb79e6f MINOR Fixed tabs
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@93859 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:54 +13:00
Ingo Schommer
c66446b34d ENHANCEMENT Added parameter to DBLocale->Nice()
ENHANCEMENT Added DBLocale->getNativeName()

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@93771 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:54 +13:00
Will Rossiter
eb64eec534 API CHANGE: removed deprecated extend calls (r93632). API CHANGE: removed fieldExists(). Use hasField() (r93633). API CHANGE removed listOfFields() (r93647). API CHANGE: removed Tag() and URL() from Image. Use getTag() and getURL(). BUGFIX: updated Image.php to use getTag() (r93639, r93646). API CHANGE: removed val(). Use XML_val() (r93650). API CHANGE: removed $add_action. Use singlar_name or lang tables (r93658). API CHANGE: removed ConfirmedFormAction (r93674). API CHANGE: removed ajax_render on CTF (r93679).
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@93685 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:53 +13:00
Sean Harvey
07e40ee91f BUGFIX Removed calls to Translatable::is_enabled() since it's deprecated, replaced with Object::has_extension('SiteTree', 'Translatable') instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@93677 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:53 +13:00
Sean Harvey
9c55927a17 API CHANGE Removed ComponentSet::removeByFilter() since it's not flexible enough and fixed calls to this from HtmlEditorField::saveInto() to use custom code instead
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@93660 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:53 +13:00
Ingo Schommer
311da2d8be MINOR Fixed path for spyc thirdparty library
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@93622 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:52 +13:00
Ingo Schommer
03c5caea72 MINOR Updated paths from jsparty to sapphire/thirdparty, cms/thirdparty and sapphire/javascript
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@93611 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:52 +13:00
Ingo Schommer
fad4957687 BUGFIX Adjusted YamlFixture to new Spyc API: loadFile() instead of load() (from r92566)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@93579 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:50 +13:00
Andrew O'Neil
ad52766d6b MINOR: Increase size of URL length to be lowest common denominator of maximum length in modern browsers.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@92351 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:38 +13:00
Sean Harvey
5fc556867e MINOR Whitespace change
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@91261 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:35 +13:00
Ingo Schommer
654af798ee MINOR removed concurrent editing (merged from r91198)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@91204 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:35 +13:00
Ingo Schommer
88a8c04d9b BUGFIX Returning TRUE on Translatable->hasTranslation() if called on a record that is in the current locale (merged from r91032)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@91156 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:35 +13:00
Sam Minnee
c9a6d3a1b0 API CHANGE: Added Lower and Upper methods to Varchar, Text, and Enum
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@91048 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:34 +13:00
Sean Harvey
3ccada55ab BUGFIX: MSSQL does not support double, using float instead (from r90928)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@90934 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:31 +13:00
Ingo Schommer
3b794bb97a MINOR Changed silverstripe.com references to silverstripe.org
MINOR Fixed broken wiki links (#4672)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.4@90886 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-02-02 14:17:31 +13:00
Geoff Munn
557eb9251c MINOR: MySQL stub function created for Postgres-specific functionality
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@115447 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-01-12 00:16:48 +00:00
Sean Harvey
60d09a6c5b BUGFIX Incorrect call to weekday function in Date class (thanks webbower!) (from r115443)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@115444 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-01-11 23:11:43 +00:00
Geoff Munn
20efa5b004 MINOR: transaction functions renamed for consistency
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@115425 467b73ca-7a2a-4603-9d3b-597d59a354a9
2011-01-11 21:52:23 +00:00
Will Rossiter
bda08c6988 ENHANCEMENT: abstract generateURLSegments functionality out to Convert::raw2url() to allow non site tree objects to safely make use of the logic. BUGFIX: #5586 Group::setCode() now calls Convert::raw2url() rather than requiring a SiteTree instance
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@115205 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-20 03:18:51 +00:00
Will Rossiter
71c52f01df EHANCEMENT: #5673 allow further manipulation on Image_Cached objects. Thanks charden!. BUGFIX: generate valid png files in ImageTest to prevent getimagesize() calls returning false results
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@115202 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-20 02:19:17 +00:00
Ingo Schommer
1c34d8f1b4 API CHANGE Deprecated TreeTitle(), use getTreeTitle() (in SiteTree, File, Group)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@115119 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-16 05:16:06 +00:00
Will Rossiter
81bd4c102e MINOR: restored SiteConfig functions
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114822 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-11 05:45:04 +00:00
Will Rossiter
815e9efd94 APICHANGE: removed page comments from core. Please see the github.com account for page comments functionality
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114821 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-11 05:43:08 +00:00
Will Rossiter
2f56a8bcad ENHANCEMENT: added onBeforeVersionedPublish() hook. PATCH via muzdowski (#6016)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114813 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-11 01:28:46 +00:00
Ingo Schommer
ae2311bcd6 BUGFIX Removed switch in MySQLDatabase->query() to directly echo queries with 'showqueries' parameter when request is called via ajax
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114782 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-09 23:26:22 +00:00
Ingo Schommer
1222b4d146 ENHANCEMENT 'bypassStaticCache' cookie set in Versioned is limited to httpOnly flag (no access by JS) to improve clientside security
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-06 00:29:20 +00:00
Sam Minnee
6de3e90527 FIX: Revert last commit (from r114464)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114548 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:45:20 +00:00
Sam Minnee
aaf56e190f FIX: Revert last commit (from r114463)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114547 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:44:37 +00:00
Sam Minnee
8638221adb MINOR: Added exception handling if ClassName is null in search results (from r114454)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114546 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:44:20 +00:00
Sam Minnee
b7777cd67d BUGFIX ErrorPage::requireDefaultRecords() case where no assets directory causes an fopen() error. Ensure assets directory is created before attempting to write error page files (from r113590)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114537 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:36:05 +00:00
Sam Minnee
770281b65c BUGFIX Clear static marking caches on Hierarchy->flushCache() (from r113277)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114530 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 08:26:40 +00:00
Ingo Schommer
3e8704c882 BUGFIX Escaping $locale values in Translatable->augmentSQL() in addition to the i18n::validate_locale() input validation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114515 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-05 05:23:37 +00:00
Ingo Schommer
396f297acb API CHANGE Using i18n::validate_locale() in various Translatable methods to ensure the locale exists (as defined through i18n::$allowed_locales)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114470 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-12-03 00:28:24 +00:00
Ingo Schommer
07b6d1870a MINOR Checking for class_exists() before SapphireTest::is_running_tests() to avoid including the whole testing framework, and triggering PHPUnit to run a performance-intensive directory traversal for coverage file blacklists
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114332 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-30 05:13:09 +00:00
Ingo Schommer
196cabb2f0 MINOR: unique indexes on versioned tables now changed to 'index'
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114134 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:49 +00:00
Ingo Schommer
f1bf0d0fc4 BUGFIX Aborting marking in Hierarchy->markPartialTree() before loading nodes, if the expected node count would exceed the totals (regardless of the in-memory marking state)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114133 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-24 06:23:48 +00:00
Ingo Schommer
3725ab77a0 BUGFIX Removed double quoting of $where parameter in Translatable::get_existing_content_languages() (fixes #6203, thanks cloph)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114080 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-23 19:21:44 +00:00
Ingo Schommer
6ccd6d61bd MINOR Documentation for Aggregate caching
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@114077 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-23 05:43:59 +00:00
Saophalkun Ponlu
efda708708 MINOR: Make sure that Translatable creates a translated parent of SiteTree only when the parent is not translated
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113955 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-19 02:49:41 +00:00
Geoff Munn
7d96dcd02b MINOR: dev/build message fixed to explain changes more clearly
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113931 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-18 23:29:30 +00:00
Ingo Schommer
854cbe79c8 API CHANGE Don't partially URI encode strings in SiteTree->RelativeLink(), rely on XML casting in templates instead (fixes #6125, thanks paradigmincarnate)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113694 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-13 02:54:13 +00:00
Geoff Munn
4215b2f434 ENHANCEMENT: full text search indexes now identified more clearly in dev/build
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113657 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-11 19:06:18 +00:00
Geoff Munn
92c7419767 BUGFIX: unique versioned indexes are now converted to standard indexes
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@113299 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-11-01 02:58:43 +00:00
Sam Minnee
4665369e31 BUGFIX Renamed MySQLQuery::__destroy() renamed to __destruct() so that it is called properly after the object is destroyed (from r112288)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112950 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:08:59 +00:00
Sam Minnee
75101d329f MINOR Reverted regression in r112272 (from r112278)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112949 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:08:46 +00:00
Sam Minnee
2699eb3b5b ENHANCEMENT MySQLDatabase::renameField() no longer checks that the field exists in fieldList(). alterField() does no such check, so it should be consistent. Removing this should provide a small performance improvement as well (from r112272)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112948 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:08:32 +00:00
Sam Minnee
bb183add33 BUGFIX #3910 Setting timezone parameter to MySQLDatabase::__construct() should use $this->query() to be consistent (from r111889)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112939 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:04:40 +00:00
Sam Minnee
e2cb7001ce ENHANCEMENT MySQLDatabase::getVersion() now uses mysql_get_server_info() which has been supported since PHP 4. This gives us a better version than say "5.1", instead we now get something like "5.1.51" (from r111868)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112933 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:03:03 +00:00
Sam Minnee
429434811f MINOR Revert r111850 to MySQLDatabase::getVersion as version comparisons need to happen, and this will strip out non-numeric characters e.g. "ubuntu1" or "lenny4" which are prefixed on some Linux distros (from r111852)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112932 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:02:42 +00:00
Sam Minnee
4af7d7aa34 MINOR dev/build now shows database name and version next to "Building database ..." text (from r111851)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112931 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:02:02 +00:00
Sam Minnee
849bca4a3d ENHANCEMENT Make use of mysql_get_server_info() when calling MSSQLDatabase::getVersion(), if there's a problem getting info this way, falls back to using query for VERSION() details (from r111850)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112930 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:01:50 +00:00
Sam Minnee
5e0b978263 BUGFIX #6055 ErrorPage should always create static error page files when dev/build is called if they don't exist (from r111842)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112927 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 05:00:35 +00:00
Sam Minnee
8d5b417619 MINOR Fixed documentation in Datetime (fixes #6062, thanks nicolaas) (from r111787)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112921 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:53:11 +00:00
Sam Minnee
d328c7cc53 BUGFIX DB::connect() should not rely on $_SESSION existing, so we check isset() to supress any warnings of undefined indexes
MINOR Code formatting tidy of DB::connect() function (from r111772)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112920 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 04:52:59 +00:00
Sam Minnee
ffba082738 BUGFIX Fixed column names that were not quoted that broke PostgreSQL (from r110944)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112869 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:06:15 +00:00
Sam Minnee
4c0afd2564 BUGFIX Fixed double quotes around column names in Versioned::augmentDatabase() (from r110914)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112867 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:03:19 +00:00
Sam Minnee
0b2ed12c63 BUGFIX: delete orphaned records from versioned tables when updating. #5936 (from r110901)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112866 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 03:01:51 +00:00
Sam Minnee
995f1f4157 BUGFIX: ensure that pages can only be requested from staging and live (from r110759)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112845 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:32:39 +00:00
Sam Minnee
9d72145ee1 MINOR Warning about install.php existing for root site tree node as well (SiteConfig form) (from r110440)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112841 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:31:07 +00:00
Sam Minnee
d0c9fe908a MINOR: added missing closing tag (from r110243)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112839 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:29:55 +00:00
Sam Minnee
32783ef0e8 MINOR Make dev/build not constantly show a changed index because of whitespace between VersionID and Version in the index spec (from r110205)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112837 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:29:25 +00:00
Sam Minnee
6e8bf5617a MINOR: only call next() in iterator validation on initialisation or after reset NOT if current value is invalid (from r110190)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112834 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:27:51 +00:00
Sam Minnee
ac33763d05 BUGFIX: getItem didn't consider the PostgreSQL SQL syntax. Columns with Capital letters must be quoted. Added quotes to the where clause in getItem. I didn't added quotes to the baseTable because it causes PostgreSQL errors (tables can not be double quoted, just single quoted). (from r109591)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112827 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:25:32 +00:00
Sam Minnee
458f3b1197 MINOR: neatly quote identifiers (from r109405)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112826 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:25:19 +00:00
Sam Minnee
496e9bcef6 API CHANGE #5873 DataObjectSet::shift() now performs a proper shift instead of unshift (wrong). Please use DataObjectSet::unshift($item) if unshifting was intended!
API CHANGE Added DataObjectSet::pop()
MINOR Unit tests for DataObjectSet::shift(), DataObjectSet::unshift() and DataObjectSet::pop() (from r109156)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112817 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 01:20:56 +00:00
Sam Minnee
d6fdc57db7 BUGFIX SiteTree decorated canView() checks not being passed through to SiteTree::canView() (from r109082)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112775 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:54:02 +00:00
Sam Minnee
adfab98adb BUGFIX StringField::setNullifyEmpty() should assign the given value boolean, not evaluate whether it's true or not (from r109081)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112774 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:53:46 +00:00
Sam Minnee
58d6cbf81a MINOR: remove SQL table alias keyword AS (from r108961)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112769 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:51:53 +00:00
Sam Minnee
d295d682c5 ENHANCEMENT #3828 500 server error page is created by default on dev/build (from r108644)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112763 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:49:53 +00:00
Sam Minnee
9a036a6fad MINOR: allow $icon to be overridden on ErrorPages. PATCH via martljn (#5875). (from r108640)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112761 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:48:04 +00:00
Sam Minnee
4aa299c4f2 MINOR Making "todo" tab title translatable (from r108441)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112751 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-19 00:37:07 +00:00
Sam Minnee
684e76e36b ENHANCEMENT Added argument to SQLQuery->leftJoin()/innerJoin() (#5802, thanks stojg) (from r108418)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112732 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:58:43 +00:00
Sam Minnee
e5a07227c2 ENHANCEMENT: Full-text search with double quotes returns too many results. ticket #5733. Thanks ktauber.
Using htmlentities($keywords,ENT_NOQUOTES) instead of proposed solution (from r108417)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112731 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:58:23 +00:00
Sam Minnee
ca7edd5ca5 BUGFIX Undefined variable when calling DataObject::many_many_extraFields() and relation name couldn't be found for the component (from r108400)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112726 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:53:59 +00:00
Sam Minnee
2058ee31ee BUGFIX: DataObjects without the Versioned decorator cannot have a "Version" field. ticket #5775. Thanks ajshort (from r108399)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112725 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:53:19 +00:00
Sam Minnee
bcdf352a71 ENHANCEMENT: Show a warning inside the the CMS if you've neglected to delete install.php (from r108024)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112707 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:40:18 +00:00
Sam Minnee
ad68943003 BUGFIX dev/build always reporting index change because of a whitespace in the index column names (from r107831)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112700 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-18 22:27:12 +00:00
Ingo Schommer
b64015e2cf BUGFIX Remove dummy entry created by Versioned if record is first written to Live stage (fixes #5596, thanks muzdowski) (from r107537)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112603 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:53:14 +00:00
Ingo Schommer
cfe9b518a5 MINOR: Fixed Documentation (from r107430)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:46:54 +00:00
Ingo Schommer
556e753fee ENHANCEMENT: Added documentation and changed static names (from r107429)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112593 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:46:32 +00:00
Ingo Schommer
2f4fe2ff35 ENHANCEMENT: Added static to set regeneration of default pages (ticket #5633) (from r107426)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112591 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:44:57 +00:00
Ingo Schommer
bd6e51c87f BUGFIX: Only highlight strings more than 2 characters long. #4949 (from r107423)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112590 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:44:24 +00:00
Ingo Schommer
f63751893b BUGFIX Allowing dev/build in "live" mode when Security::database_is_ready() returns FALSE (typically happens when an existing SilverStripe project is upgraded and database columns in Member/Permission/Group have been added) (fixes #4957)
MINOR Using Object::create() in DevelopmentAdmin to make objects mockable
ENHANCEMENT Added Security::$force_database_is_ready to mock database_is_ready() state
ENHANCEMENT Added permission check exception in TaskRunner and DatabaseAdmin if SapphireTest::is_running_test() returns TRUE (necessary for DevelopmentAdminTest) (from r107415)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112588 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:43:30 +00:00
Ingo Schommer
8f8de04aaf MINOR Documentation in DataObjectSet (from r107400)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112575 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:26:27 +00:00
Ingo Schommer
2d127753ed MINOR Documentation in File and Folder class (from r107265)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112553 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:12:39 +00:00
Ingo Schommer
ad20ddf24b MINOR: updated generator tag URL (from r107214)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:10:04 +00:00
Ingo Schommer
6bf8fad460 MINOR: force exclusive connection (from r107175)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:09:49 +00:00
Ingo Schommer
997a86b7e0 MINOR: return false rather than error out in case SS_Query:: is not a resource (from r107030)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112544 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:07:39 +00:00
Ingo Schommer
a0424ccd3e MINOR: mysql_fetch_row() expects resource, this will fatal if query was e.g. UPDATE when iterating a result because MySQLQuery::nextRecord() is used by Iterator::valid() and MySQLQuery:: is bool in this case (from r106938)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112543 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:07:22 +00:00
Ingo Schommer
35a3d79e87 BUGFIX Re-enabling theme in ErrorPage->doPublish() (it's usually disabled in the publication context through LeftAndMain->init())
MINOR Reverted r88633, it breaks <base> tag in static HTML for ErrorPage->doPublish() (from r106777)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112537 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:04:10 +00:00
Ingo Schommer
0acb21d219 ENHANCEMENT Calling Image->deleteFormattedImages() in Image->onBeforeWrite() (#5423) (from r106705)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112535 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:03:37 +00:00
Ingo Schommer
333a5b487b MINOR: Correct typo in comments (from r106313)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112530 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 03:01:24 +00:00
Ingo Schommer
e36247c1ed ENHANCEMENT: added prefix and suffix support to ContextSummary (from r106200)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112526 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:59:46 +00:00
Ingo Schommer
497e557632 BUGFIX: if running in cli do not output html tags when rebuilding the db (from r106154)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112522 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:58:21 +00:00
Ingo Schommer
723731a574 BUGFIX: Replaced Versioned's unique index definition with an array syntax. (from r106120)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112520 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:57:46 +00:00
Ingo Schommer
2aed7be053 BUGFIX: Fixed SiteTree::IsModifiedOnStage() for an edge-case that was identified when deleteFromStage() stopped manipulating the current record. (from r106082)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112516 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:56:05 +00:00
Ingo Schommer
c7b47d8a8b BUGFIX: Don't let deleteFromStage() kill the ID of the original record. (from r106080)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112515 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:55:45 +00:00
Ingo Schommer
03c3d59ba0 BUGFIX: Add a unique index to SiteTree_versions.RecordID+Version. Fix saving methods to support this. (from r106079)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112514 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:55:15 +00:00
Ingo Schommer
ee0d4c5197 BUGFIX: Throw an exception if you try an delete an unsaved or already-deleted record (from r106078)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112513 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:54:34 +00:00
Ingo Schommer
2943c75156 MINOR Using ASSETS_DIR and THEMES_DIR constant in Image, ManifestBuilder, Requirements, File (fixes #5619) (from r105282)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112493 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 02:37:41 +00:00
Ingo Schommer
59883d7770 MINOR: increased height of the todo text field in the cms (from r105139)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112441 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:26:44 +00:00
Ingo Schommer
8d07a8eccc MINOT Translation in SiteTree (#5603, thanks Pike) (from r105057)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112439 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:24:43 +00:00
Ingo Schommer
0b3ff09e7e MINOR Checking for headers_sent() before setting cookies in Versioned::choose_site_stage() to avoid problems with URL parameters like showqueries=1 and ContentController calling choose_site_stage() (fixes #5557) (from r105027)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112435 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:22:25 +00:00
Ingo Schommer
a213ce7839 MINOR Allowing translation of "save" button in SiteConfig->getCMSActions() (from r104978)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112418 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:19:24 +00:00
Ingo Schommer
aa4fc0a3db ENHANCEMENT: added Month function for consistency (from r104935)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112409 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:17:45 +00:00
Ingo Schommer
e5f41ca3e0 MINOR Fixed hidden mbstring reliance in SiteTree->generateURLSegment() (broken in r104679) (from r104883)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112403 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:16:47 +00:00
Ingo Schommer
94032c6e3e MINOR Documentation (from r104795)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112381 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:12:56 +00:00
Ingo Schommer
5dc8b97217 MINOR Documentation (from r104769)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112380 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:12:41 +00:00
Ingo Schommer
0b6feffd4c MINOR Documentation (from r104767)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112379 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:12:22 +00:00
Ingo Schommer
fdb03c4d8c MINOR: fixed umlauts (from r104733)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112377 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:11:07 +00:00
Ingo Schommer
0e4573d5ab MINOR: fixed api doc (from r104682)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112372 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:04:34 +00:00
Ingo Schommer
eb0de3cd70 MINOR Fixed merge error from r112365
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112371 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 01:03:43 +00:00
Ingo Schommer
c5196c9358 BUGFIX: Make URLs lowercase (from r104679)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112367 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 00:41:14 +00:00
Ingo Schommer
c9563c48b7 BUGFIX: Fixed Translatable::canEdit() to suit new permission customisation scheme (from r104678)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112366 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 00:40:59 +00:00
Ingo Schommer
3135c96fc9 ENHANCEMENT: Macrons, umlauts, etc, are now transliterated when inserted into URLS. API CHANGE: Added Transliterator class, which uses iconv() or strtr() to convert characters with diacritical marks to their ASCII equivalents. API CHANGE: Added Extension hook updateURLSegment for SiteeTree. (from r104671)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112365 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 00:39:36 +00:00
Ingo Schommer
3ece3026d1 API CHANGE: Moved site tree permission extension to a 3-state system (true, false, null, where null means "no effect") (from r104669)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112363 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-15 00:33:48 +00:00
Ingo Schommer
32afc2923e MINOR Migrated various API-style documentation from doc.ss.org (from r104157)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112337 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-14 23:58:09 +00:00
Ingo Schommer
0fe3528768 MINOR Documentation for DB::manipulate() (moved from http://doc.silverstripe.org/manipulation-arrays) (from r104121)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112336 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-14 23:57:40 +00:00
Ingo Schommer
d50097e905 FEATURE: Add dev/build/defaults to call requireDefaultRecords (from r104093)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112334 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-14 23:57:02 +00:00
Ingo Schommer
80f609ee41 BUGFIX Fixed Database->requireTable() for Mysql 4.1 (fixes #5517, thanks gw0) (from r103957)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112326 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-14 23:52:16 +00:00
Sam Minnee
0b4e4428be MINOR: Merges from branches/2.4
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112157 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 04:04:32 +00:00
Sam Minnee
8da5de8d41 BUGFIX: Fixed ordering by aggregate columns for DataObject::get() calls with joins. (from r103620)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112155 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 04:00:52 +00:00
Sam Minnee
2c4b07ace7 BUGFIX: Fixed unlimitedRowCount() for grouped queries (from r103613)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112154 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 04:00:14 +00:00
Sam Minnee
5027bf83ab BUGFIX: Ensure that group by of many-many queries with extraFields is set correctly. (from r103612)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112153 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 03:59:44 +00:00
Sam Minnee
712680a5e8 BUGFIX #5362: Fixed duplicate removal on DataObject:get() with join argument for all databases. (from r103588)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112150 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 03:58:10 +00:00
Sam Minnee
2948bc1c64 MINOR: Misc merges from branches/2.4
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112142 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 03:53:12 +00:00
Sam Minnee
90514f2ae3 BUGFIX: Don't show error when adding default SiteConfig records after upgrading a site. (from r103341)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112134 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 03:44:14 +00:00
Sam Minnee
1379f133ea MINOR Enum DBField class should default to ExactMatchFilter to avoid wrong results with overlapping Enum values in LIKE queries (see #5434) (from r103322)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112132 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 03:40:36 +00:00
Sam Minnee
37f18971c5 ENHANCEMENT: allow onAfterPublish and onBeforePublish handlers directly on Page classes (#5112) (from r103198)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112124 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 03:35:19 +00:00
Sam Minnee
0914dd55c5 ENHANCEMENT: allow to check for any changed fields on the DataObject, this is expected behaviour when isChanged function is called without parameters (#5421, patch by walec51) (from r103047)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112072 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:48:48 +00:00
Sam Minnee
322a2da0dc BUGFIX Float should always be not null and default 0 in the database (from r102686)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112068 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:45:24 +00:00
Sam Minnee
268800dec6 BUGFIX #5316 Float and Double should never try to save NULL as the "null" value (from r102460)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112067 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:43:58 +00:00
Sam Minnee
29edff8c38 BUGFIX: delete from published site never calls canDeleteFromLive(). (via marcus #5364) (from r102386)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112065 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:41:14 +00:00
Sam Minnee
890ac94a6a MINOR: Several changes merged from branches/2.4
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112060 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:35:19 +00:00
Sam Minnee
ddf66c1fec BUGFIX Fixed SiteTree::page_type_classes() removal of base class (was broken if database driver returned classes in arbitrary order, e.g. in Postgres) (from r102026)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112058 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:28:02 +00:00
Sam Minnee
daa50b9d3b BUGFIX: Ensure that DataObject IDs are numbers and no string equivalents of numbers - 3 not '3' (from r101939)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112049 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:19:33 +00:00
Sam Minnee
bbdad4207f MINOR take advantage of an alternate path for error pages (from r101883)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112048 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:18:35 +00:00
Sam Minnee
dad17e2330 MINOR Marked DataObject::has_own_table() as static (from r101782)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112034 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:06:47 +00:00
Sam Minnee
9087f79723 BUGFIX Always including "Locale" field in Translatable->getCMSFields() regardless of "excluded" page types. Necessary to enable form state serialization for fields like TreeSelectorField on a VirtualPage (fixes #5269) (from r101747)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112031 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:05:08 +00:00
Sam Minnee
fd8e0044c4 BUGFIX Versioned->publish() with $createNewVersion=TRUE now increases version number of in-memory object (fixes #5261) (from r101739)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112030 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:04:38 +00:00
Sam Minnee
142bb640ec BUGFIX #5277 Sort of default SiteTree records is now explicitly set to avoid strange ordering set by SiteTree::onBeforeWrite for default records (from r101724)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112028 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:03:25 +00:00
Sam Minnee
1bbec96aa1 BUGFIX Don't replace "home/" URLSegment in SiteTree->RelativeLink() if Translatable is enabled and the homepage is not on the root level (nested URLs allows you to have homepages called "en/home" and "ru/home") (fixes #5244) (from r101711)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112025 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 01:01:38 +00:00
Sam Minnee
6ba32686b1 MINOR Reverted r101670 as it broke assumptions made in RedirectorPageTest (from r101671)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112018 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 00:58:39 +00:00
Sam Minnee
6490b111b6 ENHANCEMENT RedirectorPage ExternalURL field now defaults to http:// to be consistent with the "Another website" option for HtmlEditorField LinkForm (from r101670)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112017 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 00:58:20 +00:00
Sam Minnee
7d3d9a005e BUGFIX #5259 RedirectorPage and HtmlEditorField TinyMCE integration now prefixes http:// if no prefix is found (from r101668)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112016 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 00:57:45 +00:00
Sam Minnee
c08e277ba0 BUGFIX #5245 Sometimes page records will have a NULL ParentID value, it should be a number even if it's 0 (thanks wrossiter!) (from r101657)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112014 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 00:56:27 +00:00
Sam Minnee
f073c9b60c BUGFIX: test that the class exists before running subclass tests (from r101631)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112012 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 00:55:31 +00:00
Sam Minnee
ac27c7217f BUGFIX: the function makes an assumption we are working on Draft site, and breaks if we are not. Rewritten to be stage-independent, as get_version (open #5231) (from r101603)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@112006 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-13 00:50:48 +00:00
Sam Minnee
0d5a0e73fe BUGFIX Checking for existence of "ShowInMenus" property in Folder->liveChildren() and stageChildren() (#5190) (from r101264)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111978 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:58:49 +00:00
Sam Minnee
8f41e08139 BUGFIX: Don't recreate a missing draft page when calling SiteTree::doUnpublish() (from r101170)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111967 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:49:52 +00:00
Sam Minnee
dd7bba3f6f BUGFIX: Fixed versioning of pages (from r101165)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111964 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:48:48 +00:00
Sam Minnee
c6b8148052 BUGFIX: Prevent failed migrateVersion writes from breaking versioning system in future writes.
BUGFIX: MAke site tree pages go green when you save a new draft.
API CHANGE: Add option for DataObjectDecorator::onAfterSkippedWrite() (from r101155)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111963 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:48:07 +00:00
Sam Minnee
79459d72ad BUGFIX: Ensure that Versioned works on classes with underscores in the names. (from r100905) (from r101153)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111961 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:42:45 +00:00
Sam Minnee
e09cc66e94 BUGFIX: Fixed issues with broekn link tracking (from r101138)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111960 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-12 21:42:25 +00:00
Ingo Schommer
3f2cc791ac MINOR More common language in Date->TimeDiff() ("in 2 hours" instead of "2 hours away") (fixes #5402)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111840 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-10 05:06:50 +00:00
Sam Minnee
d19bf168b0 API CHANGE: Added SiteTree::VirtualPages() and SiteTree::DependentPages() accessors.
BUGFIX: Improved reliabilty of broken link tracking.
ENHANCEMENT: Added 'Dependent pages' tab to CMS, to show virtuals, redirectors, and backlinks that point to this page.
BUGFIX: Don't mark a page as changed on stage if the only thing that has changed is broken link metadata (from r101127)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111594 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:52:46 +00:00
Sam Minnee
bfc354ab7e BUGFIX: Flush cache after deleting an item.
BUGFIX: Fixed databaseFieldsOnly version of DataObject::getChangedFields() (from r101116)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111592 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:50:43 +00:00
Sam Minnee
7426ce027c BUGFIX: Fixed bugs with copying custom fields into Virtual pages, generally made virtual pages more robust and performant. (from r101112)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111591 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:49:37 +00:00
Sam Minnee
e2b6291a30 BUGFIX: Fixed link rewriting to work on other HTMLText fields (from r99517) (from r101110)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111590 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:48:47 +00:00
Sam Minnee
ca0550bb3a BUGFIX: Return true if SiteTree:doUnpublish() succeeds. (from r99515) (from r101109)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111589 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:48:07 +00:00
Sam Minnee
cc355a4f18 API CHANGE: Replaced eval based creation of extension and field objects with Object::create_from_string().
API CHANGE: Introduced new function Object::create_from_string() to instantiate an object from a string like 'Int(50)' (from r101093)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111585 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:46:41 +00:00
Sam Minnee
ce173efce3 API CHANGE: Made MySQL fulltext search optional, activated with MySQLFulltextSearchable::enable() (from r101044)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111569 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:32:48 +00:00
Sam Minnee
ec067ab08a API CHANGE: Pass the full extension string as the 2nd argument to DataObjectDecorator::extraStatics() (from r101043)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:32:30 +00:00
Sam Minnee
47df057e63 BUGFIX Image should pass through the title to Image_Cached so that Image::getTag() can produce a more useful alt attribute instead of just the filename (from r101003) (from r101005)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111565 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:30:56 +00:00
Sam Minnee
2154e0585d MINOR Removed unused variable in SiteTree::MetaTags() (from r100992)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111563 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:30:26 +00:00
Sam Minnee
32038ab3ce BUGFIX: Remove cache for Hierarchy::AllChildren() and Hierarchy::AllChildrenIncludingDeleted(), since they increase memory usage unnecessarily. (from r100980)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111555 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:28:32 +00:00
Sam Minnee
059866556a MINOR Renamed SiteTree->getEditFormFields() to getCMSFields() (including new decorator hook for 'updateCMSFields'). Renamed SiteTree->getEditFormActions() to getCMSActions() (including new decorator hook for 'updateCMSActions'). Old API was never released (from r100967)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:27:23 +00:00
Sam Minnee
94d98b18ac ENHANCEMENT Redirecting to translated page when original is requested with a 'locale' GET parameter (e.g. 'about-us/?locale=de_DE' will redirect to 'ueber-uns' with a 301 HTTP response). Implemented in ContentController->handleRequest(). (see #5001) (from r100937)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111545 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:24:01 +00:00
Sam Minnee
37bc333882 BUGFIX SiteTree::getSiteConfig() should always fall back to using a default if an alternate config wasn't found (from r100932)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111544 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:21:59 +00:00
Sam Minnee
2e49064341 BUGFIX DataObject::hasValue() is now compatible with parent ViewableData::hasValue() (this also fixes E_STRICT standards in PHP) (from r100921)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111541 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:21:06 +00:00
Sam Minnee
a9ab6321bc BUGFIX #5138: DataObjectSet::removeDuplicates() removes objects of different classes with the same ID (from r100896)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@111535 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-10-04 04:15:33 +00:00
Julian Seidenberg
6c541940e4 MINOR: updated comments on new methods that duplicate relations to be compatible with PHPDoc
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@110909 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-09-17 02:27:44 +00:00
Julian Seidenberg
c32a6e34a0 BUGFIX: fix to #110845 to allow parsing of the DataObject file in PHP 5.2 and below.
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@110863 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-09-16 05:53:16 +00:00
Julian Seidenberg
ed666b71b7 ENHANCEMENT: DataObject and SiteTree duplicate now duplicate relations (except for has_many relations, as the object at the other end of such a relation has an existing relation to the original object and that should not be modified by the duplication)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@110845 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-09-16 03:40:34 +00:00
Ingo Schommer
53b02f6d99 BUGFIX Moved SiteTree?->ParentID property to Hierarchy extension (fixes #5638) (from r105668)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105786 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-27 21:29:48 +00:00
Ingo Schommer
06f18485a9 MINOR Improved help texts around permissions (from r100784)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105651 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 05:02:08 +00:00
Ingo Schommer
9f6bf696c6 MINOR dont copy embargo or expiry to virtual page (from r100772)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105648 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:59:45 +00:00
Ingo Schommer
a0d1c7d2b1 BUGFIX: Date::now() supplies wrong string - it misses leading zeroes on hours (from r100767)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105644 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:57:43 +00:00
Ingo Schommer
0a91f30722 BUG FIX: column names quoted properly (from r100690)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105621 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:22:50 +00:00
Ingo Schommer
96ebc35cee BUG FIX: column names quoted properly (from r100687)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105620 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:22:35 +00:00
Ingo Schommer
f661501019 BUG FIX: the default value for decimals are now cast as (doubles) (from r100686)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105619 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:22:21 +00:00
Ingo Schommer
6f936bf10d API CHANGE: dbDataType function created (from r100651)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105616 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:21:21 +00:00
Ingo Schommer
25c2b79718 BUGFIX DB::getConnect() should be properly declared as a static function (from r100627)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105615 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:21:07 +00:00
Ingo Schommer
593448929a MINOR can always create top level if admin (from r100511)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105588 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:12:51 +00:00
Ingo Schommer
a1d9d8b890 API CHANGE Removed deprecated Image::loadUploaded() (deprecated from the parent::loadUploaded for which it called), please use Upload directly instead! (from r100498)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105587 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 04:12:31 +00:00
Ingo Schommer
046dd623be API CHANGE Removed deprecated function SiteTree::get_by_url(), please use SiteTree::get_by_link() instead! (from r100492)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105578 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:57:46 +00:00
Ingo Schommer
93d405c4a3 MINOR Fixed tabbing in DataObjectSet (from r100491)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105577 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:56:02 +00:00
Ingo Schommer
a06e2af9ef API CHANGE Removed deprecated methods DataObjectSet::filter_map() and DataObjectSet::map_multiple() - please use map() instead! (from r100490)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105576 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:55:47 +00:00
Ingo Schommer
7e8a2c10c9 MINOR Changed places of Object::extInstance() to Object::getExtensionInstance() and added a notice if extInstance is used in future (from r100487)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105575 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:55:30 +00:00
Ingo Schommer
d5e48d55dc ENHANCEMENT #4599 DataObjectSet now uses more array functions instead of performing equivalent tasks - thanks simon_w! (from r100453)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105570 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:53:43 +00:00
Ingo Schommer
5db5bbf9df BUGFIX: PHP 5.1 requires an array rather than a string for call_user_func() (from r100367)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105553 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:44:54 +00:00
Ingo Schommer
e5eff98e15 BUGFIX: Show Language dropdown in English (#5098) (from r100359)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:44:31 +00:00
Ingo Schommer
179641d972 MINOR correct order of OBW (from r100323)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105551 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:43:28 +00:00
Ingo Schommer
d8478a8f59 BUGFIX SQL Error is a member is not part of any groups (from r100053)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105548 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:40:56 +00:00
Ingo Schommer
3bd114256b MINOR added Rfc2822 method to SS_Datetime. Fixed bug where dates in DataObject would not set times. (from r100032)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105546 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:40:37 +00:00
Ingo Schommer
052f71f4b3 MINOR LastEdited/Created dates are now mockable via SS_Datetime (from r100008)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105545 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:40:11 +00:00
Ingo Schommer
b632c8ff88 BUGFIX: Fix #5097, Translatable uses augmentValidURLSegment to check that URLSegment is valid (from r99850)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105539 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:18:25 +00:00
Ingo Schommer
0ab57094a0 API CHANGE: SiteTree::validURLSegment extendable (#5907)
Uses $this->extend('augmentValidURLSegment')
so that (for instance) Translatable can hook this. (from r99849)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105538 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:16:54 +00:00
Ingo Schommer
097eb6b649 Revert "FEATURE: Use tidied HTML in DataDifferencer"
This reverts commit a0d2f7b3e289d12dedcdbd02ae52eec3e6718340. (from r99848)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105537 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:15:54 +00:00
Ingo Schommer
b3409a2ea3 MINOR Reverted r99522 as this will cause problems if File records are deleted when the resampled images are linked to in the content fields (from r99823)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@105533 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-05-25 03:06:35 +00:00
Ingo Schommer
271584e43b MINOR Fixed phpdoc documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@103390 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-23 01:04:16 +00:00
Ingo Schommer
6460d09570 MINOR Fixed phpdoc documentation
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@103385 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-23 00:11:41 +00:00
Ingo Schommer
af88731959 MINOR Merge error
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102887 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 06:25:00 +00:00
Ingo Schommer
1f5654ed19 BUFGFIX: Prevent selection of self as parent (see #5106) (from r99732)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102876 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 05:36:33 +00:00
Ingo Schommer
5ce40aab7f BUGFIX: Show 'Inherit' option for edit and view all the time (since we now have SiteConfig) (from r99587)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102870 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:42:07 +00:00
Ingo Schommer
efc69855ac BUGFIX Image::onBeforeDelete() now calls deleteFormattedImages() so resampled images in the filesystem are cleaned up (from r99522)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102868 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:41:43 +00:00
Ingo Schommer
a20e559256 BUGFIX: tablename and columns quoted properly (from r99490)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102865 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:40:45 +00:00
Ingo Schommer
720bcfa61d BUGFIX: batch_permission_check returns null rather than empty array when user has no permissions (from r99443)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102863 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:40:16 +00:00
Ingo Schommer
6227478f82 FEATURE New DatetimeField class (form field wrapper composed of DateField andTimeField)
FEATURE New DateField and TimeField form classes with more consistent API and easier localization
API CHANGE Date/time parsing in DateField, TimeField and DatetimeField defaults to i18n::get_locale() ('en_US') instead of using en_NZ/en_GB specific parsing. Use i18n::set_locale('en_NZ') in mysite/_config.php to revert to old behaviour.
API CHANGE  constructor parameter in TimeField needs to be in ISO date notation (not PHP's date())
API CHANGE TimeField, DateField and related subclasses use Zend_Date for date parsing, meaning they're stricer than the previously used strtotime()
API CHANGE Removed DMYCalendarDateField and CalendarDateField, use DateField with setConfig('showcalendar')
API CHANGE Removed CompositeDateField, DMYDateField, use DateField with setConfig('dmyfields')
API CHANGE Removed DropdownTimeField, use TimeField with setConfig('showdropdown')
API CHANGE Removed PopupDateTimeField, use DatetimeField
API CHANGE Changed 'date', 'month' and 'year' HTML field names to lowercase in DMYDateField
API CHANGE Removed support for ambiguous date formats in DateField, e.g. '06/03/03'. Use DateField->setConfig('dateformat', '<format>') to revert to this behaviour.
API CHANGE Removed  flag from DateField, CalendarDateField etc., use DateField->setConfig('min') and DateField->setConfig('max')
ENHANCEMENT Using Zend_Date for DateField and TimeField, with more robust date handling, starting localization support. Set globally via i18n::set_locale(), or for a field instance through setLocale(). Note: Javascript validation is not localized yet. (from r99360)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102859 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:38:40 +00:00
Ingo Schommer
bf8f089caf BUGFIX: Disable some permission caching for now, as it was breaking unit tests (from r98504) (from r99303)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102854 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:11:38 +00:00
Ingo Schommer
da2a530274 BUGFIX: SiteTree::batch_permission_check() doesn't recurse with ID=0 calls
ENHANCEMENT: SiteTree::batch_permission_check() populates its own cache (from r97900) (from r99302)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102853 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:11:18 +00:00
Ingo Schommer
65473615d9 MINOR Partially reverted r99079 - SiteTree->getNavigatorItems() was refactored to SilverStripeNavigator::get_for_record() (from r99081)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102840 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:04:44 +00:00
Ingo Schommer
fc6ffa5e94 FEATURE: Add Link to silverstripe navigator (from r97407) (from r99080)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102839 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:03:40 +00:00
Ingo Schommer
54330495a2 APICHANGE: Use the same navigator items in the CMS that are used on the frontend (from r97395) (from r99079)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102837 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 04:00:43 +00:00
Ingo Schommer
7c057cbecb MINOR adjustments to ensure that the cached permissions were actually hit (from r98835) (from r99068)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102835 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:59:54 +00:00
Ingo Schommer
ffd0774839 BUGFIX: Fixed SiteTree_versions version numbers for published virtual pages. (from r98675) (from r99065)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102833 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:58:16 +00:00
Ingo Schommer
000d892256 MINOR refactored setting/getting strict hierarchy setting. (from r98654) (from r99064)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102832 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:57:45 +00:00
Ingo Schommer
809072d1bf API CHANGE: Let sitetree extensions prepopulate permisson cache for their own permissions. (from r98650) (from r99063)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102831 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:57:21 +00:00
Ingo Schommer
a5c2a3e564 MINOR more unit tests around loose hierarchy (from r98509) (from r99062)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102830 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:56:51 +00:00
Ingo Schommer
658e24ea45 MINOR added enforce_strict_hierarchy option, and tests around not cascading deletions (from r98498) (from r99059)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102829 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:56:22 +00:00
Ingo Schommer
9c5303285a BUGFIX: Generate SiteTree_version records for VirtualPages more reliably. (from r98309) (from r99052)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102828 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:54:36 +00:00
Ingo Schommer
728a401631 MINOR fix typo (from r98980)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102819 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:50:41 +00:00
Ingo Schommer
45c5163c18 BUGFIX fix for #5076 (from r98957)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102818 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:50:21 +00:00
Ingo Schommer
feabab3808 BUGFIX: modified float to have the same database table schema as int. Now defaults to zero and 'not null' (from r98847)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102805 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:45:20 +00:00
Ingo Schommer
746b2f2f0a BUGFIX #5053 Aggregate::query() should not set an orderby clause, otherwise databases will complain (from r98776)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102795 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:31:06 +00:00
Ingo Schommer
16f79a6dd8 BUGFIX: columns quoted properly (from r98694)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102794 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 03:30:49 +00:00
Ingo Schommer
944d013086 MINOR Fixed SiteTree->canViewStage(), merge error from r94253
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102781 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:28:51 +00:00
Ingo Schommer
9f2f88fb28 BUGFIX: Fix virtual pages not returning correct content (from r98520)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102762 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:17:29 +00:00
Ingo Schommer
74643c8e51 MINOR Partially reverted accidental commit r102759
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102760 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:16:58 +00:00
Ingo Schommer
bfb10b849f BUGFIX Fixed missing third argument to ComplexTableField_Item when the parent class instantiates it (from r98448)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102759 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-14 02:16:07 +00:00
Ingo Schommer
6a1cb91c9f MINOR Partially reverted r98382 which added unnecessarily defensive checking to Hierarchy->allChildren() (from r98404)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102652 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:23:18 +00:00
Ingo Schommer
dc21cb9ae0 BUGFIX Fixed Hierarchy->loadDescendantIdList() to call setOwner() on the extension instance. This was necessary due to underlying Object/Extension changes in 2.4.
MINOR Fixed HierarchyTest assertions around including grand children counts (from r98403)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102651 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:23:06 +00:00
Ingo Schommer
28fd09115a BUGFIX #5044 Hierarchy::loadDescendantIDListInto() now uses Object::getExtensionInstance('Hierarchy') instead of going through __call(), as PHP 5.3 has issues converting references to values (from r98382)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102649 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:22:12 +00:00
Ingo Schommer
d7f2925dc8 APICHANGE: Refactor Versioned so a single state is kept for stage, archived date, or any module specific reading modes (from r98161) (from r98224)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102633 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 03:16:57 +00:00
Ingo Schommer
5ff636c6b4 MINOR make showing virtual pages tab conditional
MINOR made virtual page tracking sitetree tablelistfield subsite agnostic (from r98005) (from r98223)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102630 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:29:51 +00:00
Ingo Schommer
a2883d0354 MINOR removed redundant method call (from r97817) (from r98222)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102629 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:29:35 +00:00
Ingo Schommer
031835a361 ENHANCEMENT roll batch permissions in to a generic function (from r97748) (from r98219)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102627 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:29:03 +00:00
Ingo Schommer
9fdc7cb2ff BUGFIX Don't allow translations of VirtualPage (until we can reliably copy data between locales) (see #5000) (from r98217)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102626 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:28:34 +00:00
Ingo Schommer
a3b49b1566 MINOR: fixed typos in the comments (from r98201)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102625 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:28:13 +00:00
Ingo Schommer
c63256fb0f MINOR: added quotes (from r98199)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102624 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:28:00 +00:00
Ingo Schommer
9f4413421d MINOR: use DB doubles only in MySQL, fall back to float (from r98178)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102623 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:27:46 +00:00
Ingo Schommer
447ec71471 MINOR better error reporting for broken redirector & virtual pages (from r97185) (from r98155)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102622 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:27:30 +00:00
Ingo Schommer
99be47c479 MINOR if the $fieldname to DOS->sort has a direction in it, split it out, and pass it. (from r96482) (from r98140)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102612 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:17:25 +00:00
Ingo Schommer
864a15db8e MINOR redirector link tracking is more intelligent (from r96461) (from r98139)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102611 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:17:11 +00:00
Ingo Schommer
9b650a4e6c MINOR remove sort direction when running canSortBy. Also added test coverage for this. (from r96428) (from r98138)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102610 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:16:50 +00:00
Ingo Schommer
5044de817e BUGFIX: removing search&replace victim, using unpopulated cache. Reverted to AllChildren, which calls the cache itself. (from r98111)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102598 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:13:27 +00:00
Ingo Schommer
21299ba686 ENHANCEMENT Allow user theme selection through SiteConfig, falling back to SSViewer::set_theme() as a default if there are none selected
MINOR Unit tests for SSViewer::current_theme() and SiteConfig::getAvailableThemes() (from r98110)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102597 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:13:12 +00:00
Ingo Schommer
1e20e55c68 MINOR don't HTML-format queries from showqueries if this is an AJAX request. (from r95855) (from r98097)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102589 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:06:24 +00:00
Ingo Schommer
453faed88a API CHANGE: Refactored test for whether a SQLQuery can be sorted by a particular column into SQLQuery::canSortBy($fieldName) (from r95850) (from r98096)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102588 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:06:12 +00:00
Ingo Schommer
da778dd2a9 BUGFIX: Make TableListField rely on SQLQuery for its count-generation.
BUGFIX: Make SQLQuery return an appropriate count if a HAVING clause is used. (from r95814) (from r98094)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102586 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:45 +00:00
Ingo Schommer
2ae6f896e3 Add some nice date formats (from r95772) (from r98093)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102585 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:05:26 +00:00
Ingo Schommer
0ee0244a01 MINOR added direct links to items in the backlinks report (from r88277) (from r98085)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102578 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 02:00:41 +00:00
Ingo Schommer
7bd479156b MINOR Changed MySQLDatabase::now() block comment to be more useful (from r98059)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102572 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:53:25 +00:00
Ingo Schommer
a5dde231b6 API CHANGE Decimal now allows setting a default value properly
MINOR Unit tests for Decimal field type default value through new test class DecimalTest (from r98056)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102571 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:53:13 +00:00
Ingo Schommer
529ed1dd1d MINOR: niced the way MultiEnums call requireField to give alternative adapter access (from r98043)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102570 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:50:15 +00:00
Ingo Schommer
a2055d1d67 MINOR: use ENUM hack for dealing with SET legacy values (from r98042)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102569 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:49:58 +00:00
Ingo Schommer
92a25a3e68 FEATURE: added support for MySQL data type SET used in MultiEnum FEATURE: added datetime helper functions (from r98041)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102568 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:49:40 +00:00
Ingo Schommer
25ad651966 APICHANGE: rename the class "Cache" to "SS_Cache" (ref ticket: #4997) (from r97996)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102564 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:48:06 +00:00
Ingo Schommer
98de6165ea MINOR: groupby works for SQLite too (from r97985)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102563 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:46:51 +00:00
Ingo Schommer
1997485ba3 BUGFIX #5009: Removed inappropriate field-detection change on multienums with no default (from r97980)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102561 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:46:27 +00:00
Ingo Schommer
9e9dcb1b96 MINOR: Better error message on bad Enum default (from r97979)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102560 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:45:53 +00:00
Ingo Schommer
6c0efa68de BUGFIX Allowing translations of VirtualPage by not copying over original Locale property (see #5000) (from r97912)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102554 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:44:23 +00:00
Ingo Schommer
48bd1ffa24 BUGFIX If a Group doesn't have any specific TRANSLATE_<locale> edit rights, but has general CMS access (CMS_ACCESS_CMSMain, CMS_ACCESS_LeftAndMain, ADMIN), then assign TRANSLATE_ALL permissions as a default. Necessary to avoid locking out CMS editors from their default language (see #4940 and 4941) (from r97911)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102553 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:44:03 +00:00
Ingo Schommer
6fb2a2a2e0 MINOR Removed debug code (from r97910)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102552 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:43:44 +00:00
Ingo Schommer
22fde45409 ENHANCEMENT: 2.4 tickets (#4670) new permission code to view draft w/o CMS access (from r97896)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102549 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:34:28 +00:00
Ingo Schommer
54d166c4ce ENHANCEMENT: 2.4 tickets (#4670), new permission code to view draft stage w/o CMS access (from r97895)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102548 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-13 01:33:49 +00:00
Ingo Schommer
279031cc3a MINOR fix call to undefined method when a virtual page picks up the wrong object. (from r97875)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102540 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:44:25 +00:00
Ingo Schommer
731269988e MINOR PHP notice error (from r97838)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102539 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:43:52 +00:00
Ingo Schommer
68fb898c6d API CHANGE: Added cancelSchemaUpdate() and doesSchemaNeedUpdating() to the Database class (from r97827)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102538 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:43:10 +00:00
Ingo Schommer
efa09e60a5 MINOR: replaced proprietary update query with one that is ANSI compliant in doPublish() (from r97705)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102526 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 23:11:58 +00:00
Ingo Schommer
891de73b31 MINOR Fixed undefined variable in SiteTree::can_edit_multiple() (broken in r83442)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102516 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 22:46:40 +00:00
Ingo Schommer
fa8c4b128c BUGFIX: Fixed potential data corruption issue when you are changing the class of a SiteTree subclass between two subclasses that share a fieldname. (from r97594)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102514 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 22:30:07 +00:00
Ingo Schommer
1417722d9e API CHANGE #4929: Add $class argument to DataObjectDecorator::extraStatics() (from r97582)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102508 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:58:35 +00:00
Ingo Schommer
b70c2df842 MINOR Using SiteTree::get_by_link() in SiteTree->requireDefaultRecords() (see #4590) (from r97484)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102499 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:19:54 +00:00
Ingo Schommer
f331e2e1a6 BUGFIX: Was using custom_database_fields in Aggregate, not database_fields, and so aggregates for the common fields (LastEdited, Created, ClassName) would fail (from r97414)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102489 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 21:10:21 +00:00
Ingo Schommer
4e850f6011 FEATURE: Add aggregate calculation to DataObject, allowing (cached) calculation of Max, Min, Count, Avg, etc (from r97390)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102448 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 05:04:34 +00:00
Ingo Schommer
1039cfade4 FEATURE Allowing translation of SiteConfig (including toplevel permission groups)
BUGFIX Fixed SiteConfig->canView()/canEdit() to respect empty CanViewType/CanEditType assignments. (from r97370)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102445 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 05:02:31 +00:00
Ingo Schommer
6eb4d67c86 BUGFIX: Let users without a specific TRANSLATE_ permission edit the default locale, so that things don't break when you install the Translatabe module. (from r97267)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102435 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:41:34 +00:00
Ingo Schommer
36dbefedcf BUGFIX Fixed URLSegment access for translated homepages in SiteTree->RelativeLink (#4781, thanks martijn) (from r97211)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102434 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:39:50 +00:00
Ingo Schommer
e717044628 API CHANGE Deprecated ContentController->LangAttributes(). Use ContentLocale() instead and write attribute names suitable to XHTML/HTML templates directly in the template.
ENHANCEMENT Added ContentController->ContentLocale() to allow XHTML/HTML specific lang= attribute settings in custom template code (see #4858). Removed <meta http-equiv="Content-Language"...> tag in SiteTree->MetaTags().
ENHANCEMENT Updated blackcandy theme to use new $ContentLocale attribute to set the locale of the current page (in Page.ss) (from r97207)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102433 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:39:35 +00:00
Ingo Schommer
3fe5af85a4 MINOR Reverted 'single instance only' feature from r79868, delayed until later release (see #4277) (from r97182)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102431 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:38:58 +00:00
Ingo Schommer
2f0bc863e7 ENHANCEMENT: include menu title in default search. PATCH via lubzee #4508 (from r97028)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102423 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:33:29 +00:00
Ingo Schommer
8a8501c854 FEATURE: Use tidied HTML in DataDifferencer (from r97018)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102420 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:31:35 +00:00
Ingo Schommer
474a6a9931 API CHANGE #3600 Inconsistency in File::getURL() which returns an absolute URL, when it should be relative - please use getAbsoluteURL() instead for old behaviour
API CHANGE #3600 Image no longer has an explicit getURL() method, instead it inherits getURL() from File which returns a relative URL (from r96988)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102415 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:29:56 +00:00
Ingo Schommer
24105c9adb BUGFIX: Fixed bug in VirtualPage::isPublishable() when CopyContentFromID not set (from r96941)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102413 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:28:56 +00:00
Ingo Schommer
2f849222f8 BUGFIX: fixed onBeforeDuplicate calling before page existed (from r96879)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102411 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:28:22 +00:00
Ingo Schommer
7b3e45539b MINOR: added hooks for extending duplicate page functionality (from r96877)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102410 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:28:07 +00:00
Ingo Schommer
9fc3256025 BUGFIX: Don't let Versioned archive tables clutter the global state when testing.
BUGFIX: Don't let mocked datetimes clutter the global state when testing. (from r96640) (from r96648) (from r96774)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102403 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:21:30 +00:00
Ingo Schommer
31bf50d69d MINOR when a parent page is unpublished, unpublish all related virtual pages, includes test coverage (from r94777) (from r96771)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102399 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:19:11 +00:00
Ingo Schommer
c0dfaa0b51 BUGFIX: Don't set the nodelete class on the CMS tree on load, since this is now handled by the batch-action system with an Ajax call. (from r94762) (from r96770)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102397 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:18:05 +00:00
Ingo Schommer
112fe3c1d4 MINOR track virtual pages that link to the current page (from r94700) (from r96768)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102396 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:17:44 +00:00
Ingo Schommer
07ad87a09a BUGFIX: Don't let users edit the location in the Behaviour tab if they don't have sitetree reorganise permission (from r94609) (from r96767)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102395 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:17:25 +00:00
Ingo Schommer
d9bd1af9ec BUGFIX: Don't publish virtual pages on regular page publish unless the page has already been published. (from r93529) (from r96760)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102391 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:14:36 +00:00
Ingo Schommer
679d48c2ff BUGFIX: Virtual pages can be deleted from the live site even when the're not publishable. (from r93319) (from r96758)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102389 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:13:26 +00:00
Ingo Schommer
bed078c16d API CHANGE: Added canDeleteFromLive permission to SiteTree, separate from canPublish (from r93315) (from r96756)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102388 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:12:45 +00:00
Ingo Schommer
6167cad850 BUGFIX: Fixed notice-level errors when checking permissions of pages that don't exist anywhere (from r93166) (from r96755)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102387 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 03:12:14 +00:00
Ingo Schommer
b124fafb0b MINOR: Removed debugging information: (from r93151) (from r96753)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102382 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:45:16 +00:00
Ingo Schommer
46db9796a5 BUGFIX: Add a default list of allowed extensions so that the CMS works reasonably out of the box.
BUGFIX: Allow files that don't have an extension (most notably folders)
BUGFIX: Ensure that file URL rewriting works if you rename a page twice without publishing.
BUGFIX: Ensure that the page doesn't go green after URLs are rewritten
ENHANCEMENT: Recognise HTTP_X_FORWARDED_HOST header and use that in place of HTTP_HOST (from r93148) (from r96752)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102381 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:42:51 +00:00
Ingo Schommer
c83e6718b7 API CHANGE: Define VirtualPage::isPublishable() so that people know not to even request publication if it's not allowed. (from r93098) (from r96751)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102380 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:41:23 +00:00
Ingo Schommer
e362790abd BUGFIX: Fixed bug in r93095 (from r93097) (from r96750)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102379 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:41:02 +00:00
Ingo Schommer
08075929ba API CHANGE: Added DataObjectDecorator::cacheKeyComponent() to ensure that the cached behind DataObject::get_one() is appropriately specific (from r93095) (from r96749)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102378 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:40:50 +00:00
Ingo Schommer
b8246bb433 BUGFIX: Update virtual pages semantics to grab content from the published version of the source page when you publish the virtual page, and to not allow publication before their source page is published. (from r92209) (from r96748)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102377 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:40:09 +00:00
Ingo Schommer
1ad6130b64 MINOR: Fixed SiteTree::canEdit() for records not yet saved to DB (from r92193) (from r96745)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102372 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:35:43 +00:00
Ingo Schommer
a7d39ef9c1 MINOR: can_edit_multiple() should return false, not 0, for permission failure. (from r92192) (from r96744)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102370 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:35:28 +00:00
Ingo Schommer
c672061024 BUGFIX: Use live permissions if the stage page has been deleted. (from r91761) (from r96741)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102367 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:34:21 +00:00
Ingo Schommer
967e218758 BUGFIX: Make virtual page broken link detection work across subsites. (from r91311) (from r96740)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102366 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:34:04 +00:00
Ingo Schommer
848b7805e2 API CHANGE: Added Hierarchy::numHistoricalChildren() and Versioned::get_including_deleted_query()
API CHANGE: Added numChildrenMethod arg to getChildrenAsUL, markPartialTree, markChildren, markingFinished
BUGFIX: Clear the bypassStaticCache cookie when you return to the live site. (from r91165) (from r96739)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102365 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:33:46 +00:00
Ingo Schommer
6f8f7ba90a MINOR if looking at a specific stage, set a cooking to bypass static cacheing (from r91006) (from r96738)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102364 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:33:08 +00:00
Ingo Schommer
4a3986a28c MINOR virtual pages are now marked as broken if their pointer page is deleted (from r90996) (from r96737)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102363 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:32:51 +00:00
Ingo Schommer
43fb34a748 BUGFIX: Include newly set fields in the differences shown by DataDifferencer (from r90264) (from r96736)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102361 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:32:34 +00:00
Ingo Schommer
db859b793a BUGFIX: Use draft site permissions over published, if available. (from r90220) (from r96735)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102357 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:04:15 +00:00
Ingo Schommer
e921b376bc API CHANGE: Don't generate TestOnly DataObjects in the database immediately; instead let test developers specify them in SapphireTest::$extraDataObjects.
API CHANGE: Added SapphireTest::resetDBSchema() (from r90054) (from r96734)

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102356 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 02:03:16 +00:00
Ingo Schommer
219c57b7bd BUGFIX: Call onBeforeUnpublish/onAfterUnpublish events in doDeleteFromLive, because they amount to the same thing. (from r90001) (from r96732)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102354 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:57:56 +00:00
Ingo Schommer
6b85948404 BUGFIX: Fixed broken link correction when a page is deleted. (from r89989) (from r96731)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102353 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:57:01 +00:00
Ingo Schommer
d89552485e BUGFIX: Prevented notice-level error when publishing HTMLText fiels on tables other than SiteTree. (from r89908) (from r96724)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102346 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:49:50 +00:00
Ingo Schommer
1c0b6163f3 BUGFIX: Fixed image link rewriting in virtual pages. (from r89904) (from r96721)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102344 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:49:23 +00:00
Ingo Schommer
19911cd241 BUGFIX: Fixed SiteTree::rewriteFileURL() (from r89804) (from r96717)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102340 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:47:19 +00:00
Ingo Schommer
cec98c6b63 MINOR fix syntax error (from r89472) (from r96716)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102339 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:47:04 +00:00
Ingo Schommer
c726569bcf BUGFIX Version field weird'ed up rollback functionality (from r89464) (from r96715)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102338 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:46:47 +00:00
Ingo Schommer
603657b943 MERGE merged back a whole bunch of defect fixes from trunk (from r87846) (from r96712)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102336 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:45:52 +00:00
Ingo Schommer
670bd4bce4 MINOR changed the method to get a page's siteconfig, it is now subsite aware. (from r89870) (from r96710)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102335 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:44:06 +00:00
Ingo Schommer
22e789e916 BUGFIX: Allow set objects as properties if the property is not a database field (from r96663)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102329 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:36:30 +00:00
Ingo Schommer
eba3409c20 ENHANCEMENT Added Date::Rfc3339() for returning an RFC 3339 valid date format (from r96010) (from r96049)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@102324 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-04-12 01:34:42 +00:00
Ingo Schommer
ca27086c84 BUGFIX Fixed SiteTree->MetaTags() to either use <meta name=> or <meta http-equiv=>, and only using the "http-equiv" attribute for valid HTTP headers (see http://www.w3.org/TR/html4/struct/global.html#edef-META)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@100631 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-03-08 20:26:34 +00:00
Ingo Schommer
a4e14d3c56 ENHANCEMENT Allow DataObjectSet to remove duplicates based on any field (#5094, thanks mobiusnz)
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@99736 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-23 22:15:23 +00:00
Ingo Schommer
2fc2d72501 BUGFIX Fixed DataObject->fieldLabels() to respect flag
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@98748 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-11 02:18:54 +00:00
Geoff Munn
fda7836aca BUG FIX: Default sort columns now quoted properly
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@98232 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-02-04 19:45:14 +00:00
Andrew Short
82df67ac81 MINOR: Moved the YamlFixture class into the dev directory.
From: Andrew Short <andrewjshort@gmail.com>

git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@97399 467b73ca-7a2a-4603-9d3b-597d59a354a9
2010-01-21 22:59:17 +00:00
Sean Harvey
f2d264ce3a ENHANCEMENT #3049 Array notation on DataObjectSet is now possible
MINOR Added unit tests for array notation to DataObjectSetTest
MINOR Removed commented out tests from DataObjectSet



git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/trunk@95876 467b73ca-7a2a-4603-9d3b-597d59a354a9
2009-12-18 03:35:26 +00:00