Lee Bradley
78b661dcf6
Prevent infinite loop when getting table name for ComponentID
...
If the field isn't in the first 2 classes then would just continue to loop
Fix means it will continue going to parent classes
Can be seen in the UsedOnTable in `admin` module if you have injected a new `Image` class that extends the built in one
2022-11-10 14:00:29 +00:00
Guy Sartorelli
ed63beeeee
Merge branch '4.11' into 4
2022-11-09 10:53:09 +13:00
Loz Calver
7f8f5afc91
Ensure forms/fields overridden by onBeforeRender() can override templates
2022-11-02 11:57:57 +00:00
Loz Calver
e2cb683f14
FIX: Stop FormField onBeforeRenderHolder extension result being overridden
2022-11-02 10:06:23 +00:00
Loz Calver
c925fae180
NEW: Add onBeforeRender extension hook to Form
2022-11-02 10:05:02 +00:00
Steve Boyd
9091d64652
API Deprecate Member::create_new_password()
2022-11-02 10:08:27 +13:00
Steve Boyd
b1dc861aac
NEW Record deprecated config
2022-10-31 19:00:59 +13:00
Steve Boyd
a3c1cb0ddf
ENH Set PasswordEncryption on default admin
2022-10-27 13:57:27 +13:00
Guy Sartorelli
168ca00555
[CVE-2022-38724] Restrict embed shortcode attributes
2022-10-26 09:31:12 +13:00
Steve Boyd
59b980edd7
Merge branch '4.11' into 4
2022-10-21 11:46:39 +13:00
Steve Boyd
897f9906f9
FIX Handle calling Deprecation::notice() before manifests are available
2022-10-21 10:08:31 +13:00
Steve Boyd
bd2eb15c72
FIX Ensure Deprecation works with 1.x branches
2022-10-20 13:14:58 +13:00
Steve Boyd
e3a6cad8a8
FIX Allow passing objects to InjectionCreator::create()
...
Co-authored-by: Nate Devereux <nate@daveclark.co.nz>
2022-10-19 18:04:48 +13:00
Phillip King
c4b3d5304d
Update tinymce links in comments
2022-10-14 16:11:58 +13:00
Steve Boyd
9c453abf89
API Update deprecations
2022-10-13 14:49:15 +13:00
Steve Boyd
33b6a00f49
ENH Update deprecation messages
2022-10-13 14:48:40 +13:00
Steve Boyd
e6aa183eb4
API Update deprecations for SapphireTest and FunctionalTest
2022-10-13 14:05:49 +13:00
Steve Boyd
2991901660
ENH Update deprecation messages
2022-10-13 14:05:49 +13:00
Steve Boyd
7b87926428
ENH Update deprecation messages
2022-10-13 14:05:49 +13:00
Steve Boyd
9f541b9a04
MNT Remove deprecation from private method
2022-10-13 14:05:49 +13:00
Steve Boyd
cc49036616
ENH Standardise deprecation messages
2022-10-13 14:05:49 +13:00
Steve Boyd
0852f504fb
API Update deprecations for SapphireTest and FunctionalTest
2022-10-13 14:05:49 +13:00
Steve Boyd
1ee0aff1d1
FIX Prevent infinite loops in Deprecation::notice()
2022-10-13 13:37:29 +13:00
Steve Boyd
906cd0e76d
API Deprecate render() ( #10527 )
2022-10-07 14:44:02 +13:00
Guy Sartorelli
8419984b36
Merge pull request #10517 from creative-commoners/pulls/4/deprecate-swiftmailer
...
API Deprecate swiftmailer
2022-10-07 09:37:11 +13:00
Steve Boyd
96a931d24f
API Deprecate swiftmailer
2022-10-06 09:52:06 +13:00
Christian Bünte
e24fb3f86c
Fix i18nTextCollector produces corrupt output / namespaces when running under PHP8.0 ( #10228 )
...
* FIX i18nTextCollector produces corrupt output / namespaces when running under PHP8.0
2022-09-29 13:40:40 +13:00
Guy Sartorelli
421864d111
Merge branch '4.11' into 4
2022-09-29 09:41:06 +13:00
Thomas Portelange
54892fa267
request may not have a session
...
see https://github.com/silverstripe/silverstripe-framework/pull/10512
2022-09-28 10:44:13 +02:00
Guy Sartorelli
4a598ded51
FIX Allow removing named extensions in yaml config
2022-09-27 13:15:28 +13:00
Bram de Leeuw
f78c3ee5bb
Member updateName extension hook
...
Allow updating the Member name from an extension
2022-09-26 16:57:39 +02:00
Steve Boyd
5111b56ac9
ENH Add PHP 8.1 safe null-coalescing operators to peg file
2022-09-15 12:59:05 +12:00
Guy Sartorelli
c4eadcd074
Merge branch '4.11' into 4
2022-09-09 16:47:49 +12:00
Guy Sartorelli
d3c28579b7
[CVE-2022-38462] Don't allow CRLF in header values
2022-09-07 11:22:07 +12:00
Guy Sartorelli
6d885ab894
FIX Normalise casing before casting fields
2022-08-25 17:36:06 +12:00
Viktor Szépe
94d1ac8d99
ENH Various changes via static analysis tooling
2022-08-24 12:14:32 +12:00
Steve Boyd
2b5420ee7d
[CVE-2022-37430] Sanitise mixed case javascript
2022-08-23 15:36:48 +12:00
Guy Sartorelli
a75317343e
Merge pull request #10439 from creative-commoners/pulls/4/better-button-keep-state
...
ENH Update page number in the state on reaching the first or the last…
2022-08-22 13:47:47 +12:00
Sabina Talipova
c0b38fc411
ENH Update page number in the state on reaching the first or the last element in a list
2022-08-22 12:44:11 +12:00
Guy Sartorelli
10ef46a5ec
ENH Make DataObject::exists() an alias of DataObject::isInDB() ( #10407 )
2022-08-16 09:43:54 +12:00
Guy Sartorelli
a7461a8ffa
API Deprecate PHPUnit 5.7 compatability hacks
2022-08-10 16:21:05 +12:00
Sergey Shevchenko
4994844729
refactor: variable naming in Requirements_Backend::resolveCSSReferences()
2022-08-05 21:27:36 +12:00
Sergey Shevchenko
ebb1601d5d
fix: misc suggested changes
...
* disable resolve_relative_css_refs by default
* variable naming
* using proper path joiner
* test comment typo
2022-08-05 15:35:26 +12:00
Sergey Shevchenko
bc9a323418
fix: more tests, improved paths detection, readability
2022-08-05 15:35:26 +12:00
Sergey Shevchenko
9854e48cfc
Update Requirements_Backend.php
2022-08-05 15:35:26 +12:00
Sergey Shevchenko
a2906cd02c
ENH Requirements_Backend::resolveCSSReferences(): Tests, config, doc, safety.
...
* Changed to ignore absolute paths altogether
* Improve tests
* Added config flag
* Changed docs
2022-08-05 15:35:26 +12:00
Sergey Shevchenko
c5e68dd2c0
ENH: resolve relative references in CSS files when combining
2022-08-05 15:35:26 +12:00
Steve Boyd
311afc25ef
Merge branch '4.11' into 4
2022-08-02 18:26:54 +12:00
Steve Boyd
c466ca5ca5
Merge pull request #9341 from unclecheese/pulls/4/come-on-baby-make-it-search-so-good
...
NEW: Allow search field customisation
2022-08-02 11:59:55 +12:00
Loz Calver
6b15bd6dd4
FIX: Invalid argument warning in backtrace
2022-08-01 09:08:52 +01:00
Guy Sartorelli
11595952f4
NEW Search across multiple searchable fields by default ( #10382 )
...
* NEW Search across multiple searchable fields by default
* ENH Split search query and search each term separately.
2022-08-01 12:19:02 +12:00
Guy Sartorelli
c7504aa337
Merge pull request #10331 from creative-commoners/pulls/4/gridfield-keep-state
...
ENH Restore gridfield state from get vars (POC)
2022-07-29 11:33:19 +12:00
Sabina Talipova
7a9bc7f577
ENH Keep Request in URL
2022-07-28 10:14:43 +12:00
Guy Sartorelli
af3c50c9da
NEW Set many_many_extraFields data via the ORM
2022-07-28 09:29:36 +12:00
Guy Sartorelli
1253ab82af
Merge pull request #10415 from kinglozzer/10413-php81-enums
...
NEW: Add support for autoloading PHP 8.1 enums
2022-07-27 11:38:51 +12:00
Aaron Carlino
07a6c1191a
NEW: Allow search field customisation in GridFieldFilterHeader
2022-07-25 17:33:09 +12:00
Guy Sartorelli
afa1fa14b7
Merge pull request #10410 from ntd/pr8
...
DOCS Fix DataObject examples
2022-07-25 11:49:15 +12:00
Loz Calver
d3f104382d
NEW: Add support for autoloading PHP 8.1 enums
2022-07-22 15:59:55 +01:00
Steve Boyd
d4d1ff3450
Merge branch '4.11' into 4
2022-07-22 11:21:15 +12:00
Steve Boyd
dd210e0f84
FIX Check if blank method passed ( #10417 )
2022-07-21 15:49:48 +12:00
Nicola Fontana
d65ba0d718
DOCS Fix DataObject examples
2022-07-15 06:48:59 +02:00
Sabina Talipova
2262d84a73
Merge pull request #9952 from creative-commoners/pulls/4.7/allow-class-to-inject-over-parent
...
All works perfect.
2022-07-12 15:29:17 +12:00
Steve Boyd
b62c4a9f53
Merge branch '4.11' into 4
2022-07-08 17:13:31 +12:00
Guy Sartorelli
3cad03357a
Merge pull request #10384 from creative-commoners/pulls/4.11/remove-wrong-message
...
FIX Unexpected message issue
2022-07-08 13:20:11 +12:00
Guy Sartorelli
3e85c4dc5c
Merge pull request #9905 from christopherdarling/patch-20
...
BUG fieldNameError() references invalid $this->form
2022-07-07 20:29:38 +12:00
Guy Sartorelli
29fae72211
API TableBuilder class reduces inconsistency between temp & prod db
2022-07-07 09:49:19 +12:00
Maxime Rainville
33600c3b73
BUG Manually create singleton when building table
2022-07-06 11:29:19 +12:00
Guy Sartorelli
0cd6665130
Merge branch '4.11' into 4
2022-07-06 11:28:41 +12:00
Loz Calver
9b45342a06
FIX: Add missing casting for Form::getAttributesHTML ( fixes #10386 )
2022-07-04 12:24:58 +01:00
Sabina Talipova
babc811381
FIX Remove unexpected message
2022-07-04 16:05:57 +12:00
Steve Boyd
5a940b0f14
FIX PDO in PHP 8
2022-07-04 15:08:52 +12:00
Steve Boyd
b101b8bdb8
Merge branch '4.11' into 4
2022-07-04 13:20:12 +12:00
Brandon Iffert
ad83b78a10
FIX Handle null values passed to PDO::quote() ( #10383 )
2022-07-04 13:17:51 +12:00
Loz Calver
b37178e831
FIX: 'passwordsent' title was not being displayed ( fixes #10366 ) ( #10367 )
2022-07-01 13:58:57 +12:00
Guy Sartorelli
cfb347dc9b
Merge branch '4.11' into 4
2022-06-30 16:33:12 +12:00
Guy Sartorelli
6c01661512
FIX Support search filters with match_any searchable_fields
2022-06-30 15:55:53 +12:00
Guy Sartorelli
4e53c35b53
MNT Deprecate unusable property
...
This property must always have the value 'AND' or an exception will be
thrown - it should be deprecated. Also, no need to process the query
before throwing.
2022-06-30 15:53:17 +12:00
Steve Boyd
3a0fff25de
FIX PDO in PHP 8
2022-06-30 12:34:05 +12:00
Steve Boyd
a77ca74a7e
FIX Ensure not passing null to mysql methods for PHP 8.1 compatibility
2022-06-29 09:34:30 +12:00
Steve Boyd
4d662d2dea
Merge branch '4.11' into 4
2022-06-28 17:42:07 +12:00
Steve Boyd
98b985fb91
Merge branch '4.10' into 4.11
2022-06-28 17:41:49 +12:00
Guy Sartorelli
794640247b
Merge pull request #10374 from creative-commoners/pulls/4.10/cve-2022-28803
...
[CVE-2022-28803] Block XSS in links and iframes.
2022-06-28 17:27:37 +12:00
Guy Sartorelli
a78d3458ea
Merge pull request #10375 from creative-commoners/pulls/4.10/cve-2022-25238
...
[CVE-2022-25238] Sanitise htmlfields serverside by default
2022-06-28 17:27:21 +12:00
Steve Boyd
b5abc38455
CVE-2021-41559 Disable xml entities
2022-06-28 17:04:34 +12:00
Steve Boyd
991aedf017
[CVE-2022-25238] Sanitise htmlfields serverside by default
2022-06-28 17:03:05 +12:00
Guy Sartorelli
d2c58f3bbc
[CVE-2022-28803] Block XSS in links and iframes.
2022-06-28 17:01:53 +12:00
Steve Boyd
c80e10f892
FIX PDO transaction in PHP 8, add GitHub Actions CI ( #10360 )
2022-06-27 15:30:03 +12:00
Guy Sartorelli
d448622ff4
ENH Allow subclasses to be defined for backtrace filtered functions.
2022-06-23 15:17:33 +12:00
Guy Sartorelli
2b0df58176
ENH Minor performance enhancement for backtrace.
...
Don't keep processing when we've found a match.
2022-06-23 15:16:46 +12:00
Guy Sartorelli
268a66418b
ENH Move backtrace ignored functions into yml config.
...
Each module that adds its own methods will do it via yml. This keeps
framework consistent with the others.
2022-06-23 14:24:23 +12:00
Guy Sartorelli
7f7feb8604
ENH Refactor Backtrace to be a bit more readable.
2022-06-23 13:57:08 +12:00
Fred Condo
f670eb4980
Correct declaration of variadic $args to mixed
...
Declaring as array confuses static analyzers, specifically phan, which
throws PhanTypeMismatchArgument for every invocation of
Injectable::create(). Correcting this declaration in the doc block
prevents all those false positives.
2022-06-09 14:27:42 -07:00
Paweł Suwiński
1c85d151a6
NEW Add factory_method configuration to Injector
...
use callable as well as creator
2022-06-09 13:57:47 +12:00
Guy Sartorelli
fa3556746f
Merge pull request #10335 from creative-commoners/pulls/4/samesite-cookies
...
ENH Add samesite attribute to cookies.
2022-06-02 12:49:34 +12:00
Guy Sartorelli
31c974c528
ENH Add samesite attribute to cookies.
...
Co-authored-by: pine3ree <pine3ree@gmail.com>
2022-06-02 12:01:03 +12:00
Christian Bünte
d37ddedd90
Fix i18nTextCollector produces corrupt output / namespaces when running under PHP8.0 ( #10228 )
...
* FIX i18nTextCollector produces corrupt output / namespaces when running under PHP8.0
2022-05-30 15:04:51 +12:00
Guy Sartorelli
8ae7f30c41
Merge branch '4.11' into 4
2022-05-27 15:19:51 +12:00
Guy Sartorelli
dec85819bd
Merge branch '4.10' into 4.11
2022-05-27 15:19:39 +12:00
Guy Sartorelli
0bc3ed4d2c
Merge branch '4.9' into 4.10
2022-05-27 15:19:17 +12:00
Guy Sartorelli
2cf1725ba6
Merge pull request #10317 from silverstripe-terraformers/feature/mock-sleep
...
NEW: Mock sleep unit test utility.
2022-05-27 13:52:01 +12:00
Guy Sartorelli
9d73b7b4bd
Merge branch '4.11' into 4
2022-05-27 12:55:53 +12:00
Guy Sartorelli
972a77f4d3
Merge branch '4.10' into 4.11
2022-05-27 12:55:35 +12:00
Guy Sartorelli
e0c4f01c11
FIX Resolve deduping problem with group codes.
...
Also remove dead validation code.
2022-05-27 11:19:32 +12:00
Guy Sartorelli
07aae0e56a
Merge pull request #10330 from creative-commoners/pulls/4.9/permissions-repeated-records
...
ENH Replace record in Permission Table if GroupID already exist
2022-05-23 18:30:21 +12:00
Sabina Talipova
70f1dc8841
ENH Override record if a provided GroupId with provided Code already exist in Permission table.
2022-05-23 14:52:33 +12:00
Guy Sartorelli
a8652f7cbb
ENH Restore gridfield state from get vars
2022-05-23 10:57:13 +12:00
Steve Boyd
db5fbcd035
Merge branch '4.11' into 4
2022-05-19 17:25:42 +12:00
Steve Boyd
d3252b1645
Merge branch '4.10' into 4.11
2022-05-19 17:25:15 +12:00
Mojmir Fendek
a9a6b0f114
PR fixes.
2022-05-19 14:09:04 +12:00
Steve Boyd
6c5448b70f
Merge branch '4.11' into 4
2022-05-18 13:43:06 +12:00
Steve Boyd
dfa0571d6d
Merge branch '4' into patch-1
2022-05-18 11:29:18 +12:00
Loz Calver
903dd860b7
ENH: Add extension hooks to core emails
2022-05-16 10:02:49 +01:00
Sabina Talipova
cb37869bac
Merge pull request #10297 from creative-commoners/pulls/4/gridfield-set-polymorphic-class
...
Issue was fixed
2022-05-13 14:01:17 +12:00
Guy Sartorelli
c0ff638cd8
Merge pull request #10307 from silverstripe-terraformers/feature/removal-all-enhancement
...
ENH: RemoveAll() memory performance enhancement.
2022-05-13 14:00:29 +12:00
Steve Piner
e91b7be056
FIX Use DataColumns content when available in CSV export
...
Fix #9248 broke #9173 by accidentally checking for a string key in a
numerically indexed array. Change the check to search the array instead
(fixes #10308 )
2022-05-13 13:53:04 +12:00
Mojmir Fendek
78d20f6fe5
NEW: Mock sleep unit test utility.
2022-05-13 13:15:24 +12:00
Mojmir Fendek
26d59944e0
ENH: RemoveAll() memory performance enhancement.
2022-05-13 11:19:04 +12:00
Steve Boyd
13e79ef8fc
Merge branch '4.11' into 4
2022-05-13 09:51:29 +12:00
Steve Boyd
89582dd476
Merge pull request #10313 from creative-commoners/pulls/4.11/email-when-password-changes
...
ENH Ensure users are sent emails when passwords are changed by default
2022-05-13 09:39:14 +12:00
Steve Boyd
6a779d07d0
ENH Allow multiple backtick variables in a single value
2022-05-12 17:12:14 +12:00
Guy Sartorelli
63f3637dc2
ENH Ensure users are sent emails when passwords are changed by default.
2022-05-12 11:42:27 +12:00
Guy Sartorelli
5436df57e4
FIX Add polymorphic class on new records for use in forms.
2022-05-11 14:04:52 +12:00
Guy Sartorelli
b64ad664bb
Merge branch '4.11' into 4
2022-05-11 12:07:46 +12:00
Guy Sartorelli
35d5f16286
Merge pull request #10274 from tiller1010/check-for-dot-syntax-component
...
Check for component before saving, fallback to full form field name
2022-05-09 15:15:50 +12:00
Guy Sartorelli
19bb72e7c7
FIX Correctly remove relations with ManyManyThroughList::removeall
...
Instead of just setting one side of the relation to null in the through
list, remove the rows entirely.
Remove only the relations which match the filters that have already been
set on the list.
This is consistent with the way ManyManyList works.
Also some small tidy-up (removing an unnecessary line break and an
unused "use" statement)
2022-05-05 11:21:51 +12:00
Ed Wilde
0b6b2d1524
Fix error when posix_getpwuid
returns false
...
The posix_getpwuid function can return false if it fails (see [docs](https://www.php.net/manual/en/function.posix-getpwuid.php#:~:text=The%20function%20returns%20false%20on%20failure .)).
2022-05-04 09:05:19 +12:00
Guy Sartorelli
2836478c72
API Add method to get foreign class key on polymorphic has_many
2022-05-02 18:29:01 +12:00
Steve Boyd
337c6e583c
ENH Various fixes for PHP 8.1 compatibility
2022-04-27 09:29:40 +12:00
Guy Sartorelli
2411a83d5d
Merge pull request #10291 from creative-commoners/pulls/4/revert
...
FIX Revert adding extension hook
2022-04-26 12:00:26 +12:00
Steve Boyd
345173343c
FIX Revert adding extension hook
2022-04-26 09:58:45 +12:00
Steve Boyd
511b3bb060
ENH PHP 8.1 compatibility
2022-04-14 13:12:59 +12:00
Steve Boyd
f1678781a2
ENH Various fixes for PHP 8.1 compatibility
2022-04-11 17:22:22 +12:00
Maxime Rainville
3e5a74c6b2
Merge pull request #10273 from creative-commoners/pulls/4/remove-ini-setting
...
ENH Fix deprecation issues for PHP 8.1 compatibility
2022-04-07 13:25:24 +12:00
Steve Boyd
814c5b2fd0
ENH Fix deprecation issues for PHP 8.1 compatibility
2022-04-06 11:34:34 +12:00
Steve Boyd
3202ef7c52
Merge branch '4.10' into 4
2022-04-06 10:42:58 +12:00
Tyler
13b81c5e38
Check for component before saving, fallback to full form field name
2022-04-05 14:39:23 -04:00
Maxime Rainville
cb05e52b0f
Merge pull request #10244 from creative-commoners/pulls/4/embed
...
NEW Use embed/embed v4
2022-03-25 15:38:17 +13:00
Steve Boyd
9add508718
NEW Use embed/embed v4
2022-03-24 10:27:15 +13:00
Maxime Rainville
77e87875b3
Merge pull request #10211 from creative-commoners/pulls/4.10/seach-filter-tests
...
FIX Default GridField search fields with an index of 0 to use StartWithFilter
2022-03-23 11:37:15 +13:00
Steve Boyd
78c9aea61f
ENH Faster method for creating injected instances ( #10265 )
2022-03-23 10:39:58 +13:00
Steve Boyd
740d087e97
FIX Default GridField search fields with an index of 0 to use StartWithFilter
2022-03-22 16:17:37 +13:00
Tobias Bossert
be65db7207
removed impossible method name contraint
2022-03-20 18:42:39 +01:00
Nicolaas / Sunn Side Up
334bd48d27
PATCH: add MemberAuthenticator::checkPassword()
to backtrace::$ignore_function_args
2022-03-17 22:48:08 +00:00
Steve Boyd
081ec34461
Merge branch '4.10' into 4
2022-03-10 11:30:03 +13:00
Steve Boyd
82aba312fe
Merge branch '4.9' into 4.10
2022-03-10 11:27:48 +13:00
Steve Boyd
204b39bfdf
FIX Handle admin_email array config
2022-03-10 10:37:47 +13:00
Maxime Rainville
78dcfd217a
Merge pull request #10235 from creative-commoners/pulls/4/meta-generator
...
NEW Get the version for an individual module
2022-03-09 13:41:12 +13:00
Steve Boyd
b73a3cdd7a
API Extension hook for email default from
2022-03-08 14:31:51 +13:00
Steve Boyd
f488f38f7d
NEW Get the version for an individual module
2022-03-08 13:48:43 +13:00
Steve Boyd
09fdfc4611
Merge branch '4.10' into 4
2022-03-08 12:21:52 +13:00