76ae5bc38a
FIX Type checking in objectForKey() to fix postgres bug
2021-01-08 15:25:38 +13:00
c932d7e7fb
Fix the phpdoc blocks
2020-12-21 22:23:23 +01:00
a8d121d23f
Merge pull request #9800 from creative-commoners/pulls/4.7/arraylist-value-set
...
FIX Bug when specifying 0 in ArrayList::offsetSet
2020-12-16 15:40:20 +13:00
5be045f9a2
FIX Bug when specifying 0 in ArrayList::offsetSet
2020-12-15 14:50:10 +13:00
460715197d
Merge pull request #9190 from open-sausages/pulls/4/test-state
...
Don't include default value in url grid state
2020-11-18 12:31:50 +13:00
6e77d5eada
NEW DataObject related objects service
2020-10-29 09:29:26 +13:00
e89ae93ac9
FIX Harden hasMethod() against invalid values
...
This method should typehint the incoming value once union types are
available, but for now this ensures that method_exists() is not called
on scalar values, which is unsupported in PHP 8.
2020-10-28 09:34:33 +13:00
941df19e88
ENH Improve YamlReader exception message ( #9731 )
...
Fixes #9690
2020-10-12 22:38:13 +13:00
c5d676fa4e
FIX Avoid test failure on use of narrow-NBSP ( #9725 )
...
For whatever reason (different locale version) my local dev env uses
narrow-NBSPs (Unicode 8239) rather than regular NBSP in its localised
strings. This patch makes the tests robust against this difference.
Note that this occurred running the tests in Lando.
Co-authored-by: Robbie Averill <robbie@averill.co.nz>
2020-10-09 10:33:51 +13:00
198b25c900
FIX Hardcode PasswordValidator config in VersionedMemberAuthenticatorTest
2020-10-06 16:07:24 +13:00
544b137328
Merge branch '4.6' into 4
2020-10-05 14:03:05 +13:00
478d487f0e
Merge pull request #9707 from robbieaverill/pulls/4.7/exceptions
2020-10-01 17:16:43 -07:00
fe45655a2b
Merge pull request #9698 from sminnee/pulls/symfony4
...
Symfony 4 support
2020-09-30 23:22:51 +01:00
8ad4c4e024
FIX Fix namespace parsing under PHP 8, tweak readability of parser
...
$hadNamespace was ambiguously named, so the original PHP 8 support
update marked it true when it was strictly meant to indicate that a
namespace separator token had been encountered, resulting in bungled
parsing of complex class specs like Class(["arg" => true]).
2020-09-30 16:16:30 +13:00
ae1e17edec
Update exception assertions in tests and remove deprecated annotations
2020-09-25 10:06:49 -07:00
9247bc8b79
NEW: Add Symfony 4 support alongside Symfony 3
...
- Remove duplicate key in YML file
- Remove deprecated yaml dump indentation set (the constructor arg works in both ^3 and ^4)
Fixes #9274
2020-09-21 19:09:08 +12:00
ae0ece2b02
Merge pull request #9665 from creative-commoners/pulls/4/php8-fqcn-token
2020-09-18 20:44:22 +01:00
0d7c5a9ece
NEW Add/remove callbacks on RelationList
...
This provides a mechanism for adjusting the behaviour of these
relations when building more complex data models.
For example the following example has a status field incorporates a
Status field into the relationship:
```php
function MyRelation() {
$rel = $this->getManyManyComponents(‘MyRelation’);
$rel = $rel->filter(‘Status’, ‘Active’);
$rel->addCallbacks()->add(function ($relation, $item, $extra) {
$item->Status = ‘Active’;
$item->write();
});
}
```
Introduces a new library dependency: http://github.com/sminnee/callbacklist
2020-09-18 13:33:42 +12:00
ff18dec2e5
API Add new behat method for interacting with toasts ( #9695 )
2020-09-17 17:12:35 +12:00
bca0f28b62
FIX: Make template parser error on mismatched brackets ( fixes #8845 )
2020-09-15 16:54:24 +01:00
bfc3b4b468
FIX: Stop empty comments breaking the template parser ( fixes #8742 )
2020-09-15 16:54:22 +01:00
099ee2deb7
FIX Remove extraneous @depends annotations
2020-09-15 17:40:42 +12:00
f1c94e6d54
FIX Allow quotes in expected ReflectionExceptions within tests
2020-09-15 17:40:42 +12:00
57bdef3b2e
FIX: Fix test mistakenly labelling content as name arguments in data provider
2020-09-15 17:40:42 +12:00
b3dd27953b
NEW: Allow league/csv ^9
...
Hopefully this has better PHP 8 support.
2020-09-15 17:40:42 +12:00
015ea8cfc8
Merge branch '4.6' into 4
2020-09-11 11:54:23 +12:00
ac6f34846e
BUG Resolve issue where TreeMultiSelectField would error loading its value ( #9604 )
...
* BUG Resolve issue with TreeMultiSelectField not retaining value in some situations
E.g. in an elemental form
2020-09-11 11:52:36 +12:00
de61681dec
Merge pull request #9634 from open-sausages/pulls/4/ellipsis
...
BUG Use proper ellipsis character in the various summary method.
2020-09-10 14:48:33 -07:00
acdebcdba7
Fix unit test
2020-09-10 17:08:13 +12:00
4c3a5441b2
Merge branch '4.6' into 4
2020-09-09 13:58:35 +12:00
27c1c72912
FIX ModuleManifest::getModuleByPath fix to ensure right module is returned ( #9569 )
...
* FIX: ModuleManifest::getModuleByPath returns the wrong module #9561
Co-authored-by: Nicolaas Thiemen <nt@sunnysideup.co.nz>
2020-09-09 13:47:36 +12:00
adaf793ddb
BUG Always validate Member credentials against DRAFT stage ( #9671 )
2020-09-08 11:47:04 +12:00
3575070b9d
FIX Removing selected column detail only if having is empty (MySQL "feature")
2020-09-01 16:21:43 +12:00
6b78428fbb
Merge pull request #9651 from open-sausages/pulls/4/test-mysql-connection-collation
...
ENH Test coverage for MySQL connection collation
2020-08-30 22:44:28 +12:00
f57d5cc807
ENH Test coverage for MySQL connection collation
2020-08-30 13:21:38 +12:00
9aa2642d03
Merge pull request #9639 from creative-commoners/pulls/4/embed-performance
...
NEW Cache embed shortcodes
2020-08-27 12:15:24 +12:00
c143941e44
Merge pull request #9628 from creative-commoners/pulls/4/version-provider
...
NEW Additional logic for VersionProvider
2020-08-21 14:25:23 +12:00
b810b7d5c9
API: Allow for user-created objects to have values passed in the constructor ( #8591 )
2020-08-20 12:28:31 +12:00
00a60432f6
Backport fix to GroupedDropdownFieldTest
2020-08-19 11:21:46 +12:00
5226d961e8
Fix unit test
2020-08-18 10:29:57 +12:00
a43414dedb
Make sure GridState always outputs a JSON Object string
2020-08-17 23:23:42 +12:00
70ffb3297a
API Only include gridfield state value that differ from the expected default
2020-08-17 12:11:56 +12:00
7304acb171
NEW Cache embed shortcodes
2020-08-12 12:14:05 +12:00
e19ef240f7
NEW VersionProvider now supports recipes as well as modules
2020-08-11 13:04:48 +12:00
8195bb480d
Merge pull request #9630 from silverstripe-terraformers/feature/with-time
...
NEW: WithMockTime callback.
2020-08-07 10:16:30 +12:00
26b8b7964e
Rename DefaultEllipsis to defaultEllipsis
2020-08-07 09:48:42 +12:00
e31565cb71
BUG Fix GroupedDropdownFieldTest::testReadonlyValue
2020-08-06 22:50:40 +12:00
896c0e4388
BUG Use proper ellipsis character in the various summary method.
2020-08-06 19:37:03 +12:00
c2ed6a4cd6
NEW: WithMockTime callback.
2020-08-06 11:18:39 +12:00
9d03a6856c
FIX Retain custom sort on custom lists in GridFieldAddExistingAutoCompleter
...
Forcing sort by the first search field isn't always appropriate.
When a custom search list is used, we can set the expectation that custom sorting is intended as well.
As an example, this can be used to autocomplete based on FULLTEXT indexes,
and sort based on relevancy.
2020-08-04 22:02:20 +12:00
8287fad24d
Merge branch '4.6' into 4
2020-07-29 11:38:49 +12:00
52d38a8b4a
Merge pull request #9615 from creative-commoners/pulls/4.6/embed-iframe-dimensions
...
FIX Set iframe dimension attributes specified in shortcode
2020-07-28 11:04:24 +12:00
f0936d4c1e
FIX Set iframe dimension attributes specified in shortcode
2020-07-27 18:04:03 +12:00
404f450ac3
BUG Readonly version of GroupedDropdownField
...
GroupedDropdownField was showing empty values in Readonly mode due to not correctly handling the hierarchical source array.
Uses flattened source now in GroupedDropdownField->performReadonlyTransformation()
2020-07-21 09:23:30 +02:00
84b4057a9a
Merge pull request #9406 from chrispenny/feature/standardise-get-cms-validator
...
v4 improvement: Standardise getCMSValidator for DataObjects/Forms
2020-07-16 15:58:33 -07:00
d408a4e714
Merge branch '4.6' into 4
2020-07-13 12:28:14 +12:00
fbe0f5a981
Merge branch '4.5' into 4.6
2020-07-13 12:27:02 +12:00
8518987cbd
[CVE-2019-19326] Stop honouring X-HTTP-Method-Override header, X-Original-Url header and _method POST variable. Add SS_HTTPRequest::setHttpMethod()
2020-07-10 17:56:15 +12:00
71db45b18b
[CVE-2019-19326] Stop honouring X-HTTP-Method-Override header, X-Original-Url header and _method POST variable. Add SS_HTTPRequest::setHttpMethod()
2020-07-10 14:57:26 +12:00
b780c4f504
BUG Tweak DBHTMLText::Plain to avoid treating some chinese characters as line breaks.
2020-07-09 13:33:43 +12:00
01d3b4fd96
FIX: Set many-many-through joinRecord on newly added records.
...
When many-many-through relations are queried, a joinRecord is set on
each DataObject in the list to provide the extra fields defined on
the connector object. This didn’t previously happen when the record
was first add()ed to a list. This fixes that bug.
2020-07-02 15:18:12 +12:00
f72491f7f4
Linting fix
2020-06-08 09:35:00 +12:00
d4165db690
Update getter name to getCMSCompositeValidator
2020-05-28 12:23:35 +12:00
2765b65f42
Use ReflectionClass for CompositeValidator tests
2020-05-28 11:18:46 +12:00
bca4be77ed
Update name to CompositeValidator. Add docblocks
2020-05-28 11:18:46 +12:00
b45a3561df
Implemented PR feedback. Added some initial test cov
2020-05-28 11:18:46 +12:00
acccdd8a1c
Merge branch '4.5' into 4
2020-05-26 14:31:06 +12:00
42bb28965c
Merge branch '4.4' into 4.5
2020-05-26 14:30:27 +12:00
395893b559
Merge branch '4.3' into 4.4
2020-05-26 14:30:02 +12:00
86fcb9e29c
Merge branch '4.2' into 4.3
2020-05-26 14:29:16 +12:00
080ce157ce
Fix various typos in comments
2020-05-16 10:34:53 +01:00
21129b1624
Use short array syntax across the framework's codebase
2020-05-16 10:34:45 +01:00
b1b61f866e
FIX Set nonce style on unit tests
2020-05-13 16:07:31 +12:00
1d19051c10
Add sha1 and md5 hashing options in resource URL
2020-05-12 18:14:03 +12:00
7dc6b36c16
Unique key for DataObject ( #9400 )
...
NEW Unique key for DataObject
2020-05-04 09:10:51 +12:00
33b0b6985a
Update file paths for autoloading compatibility
2020-04-25 10:28:28 +01:00
237b2d5f74
Convert array delcarations to short array syntax
2020-04-20 18:58:09 +01:00
f94078d963
Merge pull request #9408 from chrometoasters/pulls/classes-with-extension
...
Add ClassInfo method to get all classes with a given extension applied
2020-04-20 20:11:01 +12:00
cb36aab80c
Merge branch '4.5' into 4
2020-04-15 14:49:19 +12:00
e968f5cb86
DOCS: Remove outdated TODO
2020-04-14 15:00:08 +05:45
2c5deceeb4
FIX Filter out all FULLTEXT BOOLEAN chars
...
The query might still work depending on where these chars are placed,
but it seems weird to only remove *some* of the valid chars here.
See https://dev.mysql.com/doc/refman/5.6/en/fulltext-boolean.html
Note that the query runs both the actual boolean query with chars,
and then a separate relevance search without them.
2020-04-09 10:32:45 +12:00
c6b698cb02
NEW Allow InnoDB for FULLTEXT indexes
...
MyISAM used to be the only one to support it, now InnoDB has caught up.
Unless an engine is set specifically in create_table_options,
this will auto-convert existing MyISAM tables to InnoDb.
Fixes #9242
2020-04-09 10:32:45 +12:00
5bf2ac83ee
Merge branch '4.5' into 4
2020-04-01 19:23:47 +01:00
1fb574a5bd
NEW: Variadic URL parameter matches for url_handlers ( #9438 )
...
* Add wildcard URL parameter matches for url_handlers
* Extra tests for wildcard parameters
* Add a PHP warning if more params appear after wildcard param
2020-03-25 09:16:13 +13:00
30c3b127c1
NEW Add ClassInfo method to get all classes with a given extension applied
2020-03-24 10:48:35 +13:00
37e8720fe5
Linting
2020-03-17 16:21:46 +13:00
7ad5f1bb14
BUGFIX: Ensure diff arrays are one-dimensional
2020-03-17 15:57:28 +13:00
667495eaf9
Merge branch '4.5' into 4
2020-03-06 10:53:28 +13:00
687435a2f1
Merge branch '4.4' into 4.5
2020-03-06 10:52:22 +13:00
bba0f2f72f
BUGFIX: Fixed issue where TimeField_Readonly would only show "(not set)" instead of the value
2020-02-24 09:59:00 -04:00
affd43052a
Merge branch '4.5' into 4
2020-02-17 18:11:23 +13:00
acd7d94167
Merge branch '4.4' into 4.5
2020-02-17 13:07:26 +13:00
49fda52b12
Merge pull request #94 from silverstripe-security/fix/cve-2019-19325
...
CVE-2019-1935
2020-02-17 12:54:40 +13:00
ad1b00ec7d
[CVE-2019-19325] XSS through non-scalar FormField attributes
...
Silverstripe Forms allow malicious HTML or JavaScript to be inserted
through non-scalar FormField attributes, which allows performing XSS (Cross-Site Scripting)
on some forms built with user input (Request data). This can lead to phishing attempts
to obtain a user's credentials or other sensitive user input.
There is no known attack vector for extracting user-session information or credentials automatically,
it required a user to fall for the phishing attempt.
XSS can also be used to modify the presentation of content in malicious ways.
2020-02-17 09:58:29 +13:00
c31de772ab
Merge pull request #8838 from creative-commoners/pulls/4/slash-means-root
...
Use '/' as an alternative designation for root in routing
2020-02-14 11:29:32 -08:00
9d1d59d8d1
NEW Accept / as designation for root URL controller
2020-02-14 14:41:10 +13:00
9d5c3ef20e
Merge branch '4.4' into 4.5
2020-02-11 16:45:15 +13:00
99786dda22
ORM Column now supports related table lookup
2020-01-28 15:46:30 +13:00
6650d81324
BUG Fix extra blank Group being created when creating a new Group ( #9325 )
...
* Fix extra blank Group being created when creating a new Group
* Update tests to reflect expected behavior
* Improved tests
2019-11-27 09:32:33 +13:00
91e4aa90f1
Merge branch '4.4' into 4.5
2019-11-20 11:09:23 +13:00
8219491705
Merge branch '4.3' into 4.4
2019-11-20 11:08:35 +13:00
ea2a2b4786
FIX Adjust HTMLEditorField tests to support alt attr changes in assets
...
The default behaviour of the alt attribute has changed from using the
filename to applying an empty value.
2019-11-14 12:04:37 +13:00
e2bea6b41f
API Add `withConfig` method ( #9011 )
...
* With config functionality added.
* Update docs/en/02_Developer_Guides/04_Configuration/00_Configuration.md
2019-10-31 16:12:04 +13:00
e76601e5c8
BUG FormAction title property cannot be set if useButtonTag is false
2019-10-29 17:21:45 +13:00
17f4cc6e30
Merge pull request #9281 from creative-commoners/pulls/4/textfield-tip-ui
...
NEW: Add support for Tip UI in TextField
2019-10-23 16:50:43 +13:00
bed3f2b3c6
NEW Add type declarations to Tip API, add TippableFieldInterface
2019-10-23 10:46:22 +13:00
195417b061
NEW Extract Tip from TextField, add test coverage
2019-10-22 17:04:58 +13:00
e59625fe5a
NEW Add ability to define image size preset for the TinyMCE editor. ( #9276 )
...
* NEW Add ability to define image size preset for the TinyMCE editor.
* DOC Explain how to define image size pre-sets
2019-10-22 11:50:28 +13:00
33a28394d6
Merge branch '4.4' into 4
2019-10-18 15:59:28 +13:00
0cf5d4cbe2
Merge branch '4.3' into 4.4
2019-10-18 15:58:13 +13:00
46b9530d88
PSR2 linting fixes
2019-10-18 15:31:39 +13:00
7873efde9c
Merge branch '4.4' into 4
2019-10-18 10:58:19 +13:00
dcbe6d0310
Merge branch '4.3' into 4.4
2019-10-18 10:57:35 +13:00
d7752b7945
Run PSR2 Lint cleaner
2019-10-04 13:26:31 +13:00
7db524bd90
FIX DebugViewFrendlyErrorFormatter handle of admin_email
2019-10-04 10:26:54 +13:00
047ac060c4
Merge pull request #9265 from emteknetnz/feature/noopener
...
Add noopener attribute to links with a target
2019-10-03 14:42:50 +13:00
887f198b07
Add rel attribute to link elements with a target attribute
2019-10-03 14:03:12 +13:00
af6644f762
Merge pull request #9240 from chrometoasters/pulls/db-readonly-transactions-support
...
NEW Introduce supported database transaction mode check
2019-09-25 10:02:53 +12:00
b002ef1171
Merge branch '4.4' into 4
2019-09-24 17:26:50 +12:00
0d27f32cc9
FIX Add 'legal empty attributes' to allow empty alt values on imgs
...
In some situations, a caption is used in place of a value in the alt
attribute, and in others an image may be cosmetic and not in need of an
alt attribute value (though the alt attribute must still be rendered in
this case).
2019-09-24 11:44:12 +12:00
3cfc21c405
Merge pull request #9241 from open-sausages/pulls/4.4.3/fix-file-permission
...
Fix administrators not being able to see files that are restricted to groups
2019-09-23 11:13:26 -07:00
6a1c6ecec6
Fix administrators not being able to see files that are restricted to groups
...
Resolves https://github.com/silverstripe/silverstripe-asset-admin/issues/777
2019-09-23 16:44:28 +12:00
bcbf90a837
NEW Introduce supported database transaction mode check
2019-09-16 14:44:15 +12:00
aa6b244db9
Merge branch '4.4' into 4
2019-09-13 18:11:46 -07:00
592ab6abc1
Merge branch '4.3' into 4.4
2019-09-13 18:11:34 -07:00
9a76d4adb4
Merge pull request #9181 from kinglozzer/8762-shortcode-templates
...
NEW: Use templates to render embed shortcodes (closes #8762 )
2019-09-13 17:58:32 -07:00
233e0e7aa0
ENH PasswordExpirationMiddleware implementation ( #9207 )
2019-09-12 14:34:06 +12:00
da6582f593
NEW: Remove web installer, move to separate package ( #9231 )
...
* Remove installer
* Remove exposed install files
* Replace Dev/Install classes still in use
* Update changelog
* FIX make the grid field actions consistent to what they look like on pages
Resolves https://github.com/silverstripe/silverstripe-admin/issues/904
* Docs changes
2019-09-11 13:10:25 +12:00
591b88a9bc
BUG Allow infinite loop when calling DataObject::writeComponent() recursively
2019-09-10 14:15:28 +12:00
e8c2f963fd
FIX Member::getLastName() now correctly returns the Member surname
2019-09-06 12:12:27 -07:00
dd40d53e6b
Merge branch '4.4' into 4
2019-09-04 09:46:33 +12:00
24015c7767
Merge branch '4.3' into 4.4
2019-09-04 09:42:09 +12:00
77ba8391c4
FIX Byte Order Marks (BOM) are now stripped when importing CSV files
2019-08-29 14:54:57 +12:00
759601741d
NEW: Use templates to render embed shortcodes ( closes #8762 )
2019-08-21 09:32:16 +01:00
a5d6b998fc
Merge branch '4.4' into 4
2019-08-16 16:40:39 +12:00
11a7d6ccb4
Rename test to be clearer about its intent
...
Co-Authored-By: Guy Marriott <guy@scopey.co.nz>
2019-08-16 09:49:36 +12:00
bae7e32680
FIX Member::changePassword() no longer applies password validation rules to the hashed value
2019-08-16 09:06:07 +12:00
f354e2018d
FIX Set minimum test scores and password length for Members while running fixtured DataObject tests
2019-08-15 15:23:11 +12:00
45f86658ca
Merge branch '4.4' into 4
2019-08-14 09:31:05 +12:00
4b44272367
Merge branch '4.3' into 4.4
2019-08-14 09:30:53 +12:00
d63e4b520c
Merge branch '4.2' into 4.3
2019-08-14 09:30:41 +12:00
f3132c89d7
Merge pull request #9170 from open-sausages/pulls/4/add-option-to-disable-user-agent-session-check
...
API Add option to disable user-agent header session validation
2019-08-08 11:47:07 +12:00
b3093b7a1a
BUGFIX: Allow state to be shared across nested GridFields
2019-08-07 23:09:51 +12:00
4380d7d155
API Add option to disable user-agent header session validation
2019-08-06 22:00:01 +12:00
0672f8b76b
NEW HTTPRequest now has hasSession() to determine whether a session exists for it
2019-08-02 11:29:23 +12:00
c1ffc4edfb
Added unit tests for multiple relationship sorting
2019-07-29 10:45:10 -03:00
cb91f5fa06
NEW Added SRI support for Requirements::css, Requirements::javascript ( #9139 )
2019-07-21 09:51:22 +02:00
22b514c421
#9114 - DBText::ContextSummary() cuts line breaks
...
ContextSummary() was cutting the HTML which was added by nl2br because
it expected plain text elements as it's stripping and replacing text.
Instead this fix changes the behaviour to apply the nl2br after the text
changes have been made. That way we can't cut anything in the middle of
a HTML tag, but new lines, or paragraphs are replaced by BRs after,
should they exist.
- Added tests to ensure text is not cut in the middle of a sentence.
- Added test to ensure that <br>'s are added in the correct place should
the summary span between new lines.
2019-07-19 12:43:20 +12:00
29a663c65d
Merge branch '4.4' into 4
2019-07-15 09:24:49 +12:00
d667d64f13
Merge branch '4.3' into 4.4
2019-07-15 09:18:17 +12:00
fcd7a1e63e
FIX core memory limit test
2019-07-12 16:30:25 +12:00
7ef13e7ef6
FIX Confirmation components to respect SS_BASE_URL ( #9074 )
2019-07-05 16:05:41 +12:00
844d2ef134
NEW DBDate and DBDatetime now support modify() with a strtotime() style adjustment string ( #9105 )
2019-07-05 15:57:23 +12:00
e3aa0ff63a
Added unit tests for config condition if PHP extension is loaded
2019-07-03 10:32:41 -03:00
96e7914f23
FIX: Fix MySQLQuery::seek() and Query::rewind() to fix repeated iteration
...
API: Query::seek() and Query::rewind() no longer return a value.
Although breaking an API inside a patch release may seem odd, this in
fact is correcting a long-standing bug in our implementation of
Iterator::rewind(), so I think it’s appropriate.
https://github.com/silverstripe/silverstripe-framework/issues/9097
2019-07-03 09:20:05 +12:00
6a8c6703d1
Remove `use_gzip` from HTMLEditorField since it's been removed by TinyMCE codebase ( #7261 )
...
* Remove `use_gzip` from HTMLEditorField
* DOCS Mention remove use_gzip in changelog
2019-06-21 09:27:48 +12:00
d04e54c1be
Merge branch '4.4' into 4
2019-06-10 17:33:30 +12:00
c747b1f8d3
Merge branch '4.3' into 4.4
2019-06-10 17:32:07 +12:00
f766555d61
Merge branch '4.2' into 4.3
2019-06-10 17:27:05 +12:00
ca56e8d78e
[CVE-2019-12246] Denial of Service on flush and development URL tools
2019-06-10 17:23:56 +12:00
654156d46d
FIX: Fix bug when confirmed password is changed but not the password. ( #9012 )
...
In this case the confirmed password field is not reflected. It’s
unclear how often this situation would arise outside of test scenarios,
but may come up if $form->loadDataFrom() is called more than once.
Fixes #2496 (it’s a minor issue but I think this is why Dan flagged it
as a regression). Originally introduced as part of Dan’s initial fix
at 2a6f1f1949
2019-06-10 15:48:29 +12:00
9184056b5e
URLSegmentFilter: Remove : characters from url segments when multibyte characters are allowed.
2019-06-02 11:43:51 +03:00
00fd74a0a1
Merge branch '4.4' into 4
...
# Conflicts:
# src/Dev/Tasks/MigrateFileTask.php
2019-05-30 09:36:42 +12:00
14673ffd0a
Merge branch '4.3' into 4.4
2019-05-30 09:35:26 +12:00
188698dcee
Merge branch '4.2' into 4.3
2019-05-30 09:35:17 +12:00
3e2fc6aa0b
Automated phpcbf linting
2019-05-30 09:34:34 +12:00
f97ca26e76
Merge pull request #9014 from sminnee/fix-4142
...
FIX: List default items in the readonly view of ListboxField
2019-05-27 20:13:20 +12:00
7407096e99
FIX: List default items in the readonly view of ListboxField
...
Adds tests for non-readonly default items too.
Fixes #4142
2019-05-27 17:47:09 +12:00
2c71daacfe
MINOR: Add tests for GroupedDropdownField empty strings
...
These bugs were never present in SS4 as the relevant code had a
substantial rewrite at the same time they were introduced in SS3.
In SS3, test C still fails.
Fixes #4705
Fixes #4987
Fixes #4793
2019-05-27 17:46:03 +12:00
350888bf50
NEW Adding a shuffle method to ArrayList ( #8984 )
...
* NEW Adding a shuffle method to ArrayList
* API Add shuffle to DataList for ArrayList parity
2019-05-16 09:26:11 +12:00
3f1479edbb
BUGFIX: DataQuery overwriting _SortColumn selects ( #8974 )
...
* BUGFIX: DataQuery overwriting _SortColumn selects
* FIX DataQuery _SortColumn handling
2019-05-15 11:42:10 +12:00
8ee50d2ba7
API Remove DataObjectSchema::getFieldMap() ( #8960 )
...
Introduced as a less public API in https://github.com/silverstripe/silverstripe-assets/pull/227
2019-05-06 12:33:23 +12:00
82c8225502
Merge branch '4.3' into 4.4
2019-05-03 09:45:25 +12:00
3d777cfb8a
Backward compatible behaviour for SQLConditionalExpression::getJoins
2019-05-02 15:39:36 +12:00
0c6c57f1ef
Add `getFieldMap` method to retrieve a list of all fields for any giv… ( #8892 )
...
* Add `getFieldMap` method to retrieve a list of all fields for any given class
* Add `TagsToShortcodeTask` to upgrading guide
Adding after the file migration part as this is where it makes the most sense to run it.
* `getFieldMap` accepts an array
* Move to `DataObjectSchema`
* Add `HTMLVarchar` to documentation
Minor refactoring
* Add test for checking that `subclassesfor` works without the base class
Add test `DataObjectSchema::getFieldMap` returns the correct array
* Remove cms dependency
2019-04-30 10:43:14 +12:00
c63eecc3e1
Merge branch '4.3' into 4
2019-04-18 11:57:36 +12:00
155a9bb1f9
Merge pull request #8934 from creative-commoners/pulls/4.4/pdostgresql-boolean-consistency
...
FIX Postgres booleans should return as int for consistency
2019-04-17 15:43:35 +12:00
da1af3d8b0
FIX Postgres booleans should return as int for consistency
2019-04-17 15:15:17 +12:00
cc1fdf603b
Resolve incorrect empty string assertion in tests
2019-04-17 13:29:54 +12:00
9d6b5048a6
FIX Table aliases are retained on base tables in queries built using SQLConditionalExpression ( #8918 )
...
* Adding failing test for base table aliases using SQLSelect
* FIX Retain table aliases applied to the base table on queries
* FIX Move the trimmed alias outside of the condition so we can use it within the condition
2019-04-16 15:40:09 +12:00
66c372ce28
Include baseURL with relative setGetVar() links ( #8834 )
...
* Return baseURL with setGetVar
* Adjust testSetGetVar tests for base url
2019-04-15 14:50:46 +12:00
8a06682e31
Merge branch '4.3' into 4
...
# Conflicts:
# src/ORM/Connect/DBSchemaManager.php
2019-04-11 11:24:17 +12:00
d295888838
MINOR: Improve type testing
2019-04-05 15:11:21 +13:00
2625cea5e3
MINOR: Add a test that 0 is falser on int, decimal, currency
...
Validates that https://github.com/silverstripe/silverstripe-framework/issues/3473 has been fixed
The bug was fixed in #8448
2019-04-05 15:11:21 +13:00
4f4153c834
MINOR: Test test to validate that multiple GreaterThan filters in a filterAny work.
...
Confirms https://github.com/silverstripe/silverstripe-framework/issues/3995 isn’t a bug.
2019-04-05 15:05:42 +13:00
123d483213
MemberTest and SecurityTest now set the default authenticator to use
2019-04-05 11:26:29 +13:00
a9d57f5bfb
Merge pull request #8241 from creative-commoners/pulls/4.3/separate-logging
...
Separate core error logging from standard LoggerInterface
2019-04-05 08:49:09 +13:00
fc6213c293
Merge branch '4.3' into 4
2019-03-27 13:25:57 +13:00
e1190e33d2
Fix PDOConnector GeneratedID return type
2019-03-21 09:26:14 +01:00
388baa01b4
Fix linting
2019-03-20 13:19:10 +13:00
aa491d9294
Fix tests
2019-03-20 12:33:00 +13:00
6b450395ce
API Allow empty arraylists to be typed ( #8866 )
...
* API Allow empty arraylists to be typed
* PHPCBF fixes
2019-03-20 11:46:35 +13:00
765d1568ab
Merge branch '4.3' into 4
2019-03-06 11:04:50 +00:00
a8605b04e0
Merge branch '4.2' into 4.3
2019-03-06 11:04:14 +00:00
d1396b7dfe
BUG Fix writeBaseRecord with unique indexes
...
Fixes #6819
2019-02-27 16:40:12 +13:00
11b9429c34
Merge branch '4.3' into 4
2019-02-27 12:14:51 +13:00
651d537196
Merge branch '4.2' into 4.3
2019-02-27 12:13:24 +13:00
ed013fcfbb
Merge branch '4.1' into 4.2
2019-02-27 12:12:39 +13:00
ac53f77115
Merge branch '4.0' into 4.1
2019-02-27 12:11:47 +13:00
6ff319a0e1
BUG Implement peer review feedback,
2019-02-27 11:14:47 +13:00
9a59f2f57d
BUG Renable the ability to do dynamic assignment with DBField
2019-02-22 11:08:43 +13:00
3e90fdf42f
Merge branch '4.3' into 4
2019-02-19 08:41:05 +07:00
ed74549c4f
Merge branch '4.2' into 4.3
2019-02-19 08:39:59 +07:00
79e44b42fa
Merge branch '4.1' into 4.2
2019-02-19 08:37:07 +07:00
cb7f15a681
Merge branch '4.0' into 4.1
2019-02-19 08:36:41 +07:00
09c539e1c3
Merge branch '4.3' into 4
2019-02-19 12:21:24 +13:00
25bba49923
[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation
2019-02-19 12:20:24 +13:00
95505db7d6
[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation
2019-02-12 21:08:09 +13:00
fd90cf6ceb
[SS-2018-021] Fix potential SQL vulnerability in non-scalar value hyrdation
2019-02-12 20:44:17 +13:00
7c5b73881b
FIX: Prevent null->null being flagged as a value change ( fixes #8774 )
2019-02-06 13:24:18 +13:00
d116b9a8d2
Add test for shortcode parsing with querystring and anchor
2019-01-29 13:15:17 +02:00
a589bcb092
Merge pull request #8729 from emteknetnz/bugfix/htmlvalue-getcontent
...
Ensure document is not falsey before attempting to clone it
2019-01-29 09:11:04 +13:00
d00c59c383
Fix tests not loading fixtures and loading themes in CWP recipe kitchen sink
2019-01-28 13:34:52 +02:00
d28552915d
Add unit test for an invalid HTMLValue
2019-01-25 15:55:03 +13:00
d8cd085190
Merge branch '4.3' into 4
2019-01-24 17:14:09 +02:00
e087e564e1
Fix tests not loading fixtures and loading themes in CWP recipe kitchen sink
2019-01-24 16:45:38 +02:00
13486ca80e
MINOR Add unit test for Requirements::add_i18n_javascript()
2019-01-16 10:36:53 +13:00
34ac228029
BUG Fix issue with assertListEquals() ignoring field getters
2019-01-11 11:35:11 +13:00
1e01deea39
NEW Make resources dir configurable ( #8519 )
...
* NEW Make resources dir configurable.
* Removing reference to old `resources` and updating doc #8519
* Rrtarget to 4.4 release.
* DOC Reference SS_RESOURCES_DIR in Environment doc.
* API Add a Resources method to SilverStripe\Core\Manifest\Module to read the resources-dir from composer.json
* Clean up reference to SS_RESOURCES_DIR env var
* Set default resources-dir
* Update test to use RESOURCES_DIR const in expected resource url method
* Correcting typos
Co-Authored-By: maxime-rainville <maxime@rainville.me>
* MINOR Correctubg minor typos
* DOCS Document the intricacies of exposing static assets.
2019-01-09 15:35:45 +13:00
7c96feef37
Merge branch '4.3' into 4
2019-01-08 12:27:48 +01:00
394dd4765c
NEW Scaffolded field labels now only have an uppercased first word
2019-01-07 17:52:28 +01:00
7d1aa44786
Merge pull request #8654 from creative-commoners/pulls/4.3/password-complexity-test-fixes
...
Update tests to pass in CWP kitchen sink context
2018-12-13 16:50:25 +13:00
470093de2f
Merge pull request #8650 from sminnee/nested-vendor
...
FIX: Manifest should ignore vendor folders within packages contained in vendor
2018-12-12 19:52:03 +00:00
fcc37350a1
Merge branch '4.3' into 4
2018-12-12 12:17:37 +00:00
f7846fc34c
FIX behat CmsUiContext waits for cms-loading-container after step
2018-12-10 16:49:57 +13:00
5d7c5ffb07
Merge branch '4.3' into 4
2018-12-06 09:40:40 +00:00
08866f89d9
Merge branch '4.2' into 4.3
2018-12-06 09:40:05 +00:00
96bd17d469
Merge branch '4.1' into 4.2
2018-12-06 09:38:45 +00:00
3f532466d1
Merge branch '4.0' into 4.1
2018-12-06 09:37:52 +00:00
6edcbe9086
Merge pull request #8592 from open-sausages/pulls/4.0/tree-multiselect-null
...
FIX TreeMultiselectField passes value 'unchanged' as null to ORM
2018-12-06 14:23:48 +13:00
1ac36611a6
Update tests to pass in CWP kitchen sink context
2018-12-02 23:04:34 +00:00
0c17ffc944
FIX: Manifest should ignore vendor folders within packages contained in vendor
...
Without this change vendor/silverstripe/framework/vendor/silverstripe/config
will be pick up by the manifest, which is inappropriate.
Although this doesn’t happen often, it can occur if you have run
“composer install” within vendor/silverstripe/framework, which can be
done either accidentally or (in my case) as part of running the
framework tests isolated from the rest of your project (which is closer
to the execution model on Travis)
Note that the presence of the ‘nestedvendor.txt’ file tests that this
works without any explicit changes to the PHP of the tests, since it’s
merely confirming that such a file is *not* picked up.
2018-11-30 13:52:25 +13:00
4ee63eb4e7
TreeMultiselectFieldTest / make scrutinizer happy
2018-11-29 12:13:56 +13:00
38f8217f01
TreeMultiselectFieldTest / setUp is protected in PHPUnit5
2018-11-29 09:55:28 +13:00
3f8551df41
Merge pull request #8462 from sminnee/nondestructive-enum
...
FIX: Make all enums non-destructive, not just ClassName
2018-11-28 16:42:12 +01:00
1f1c344272
Merge branch '4.3' into 4
...
# Conflicts:
# tests/php/Forms/ConfirmedPasswordFieldTest.php
2018-11-26 12:15:17 +01:00
41dc9229bf
FIX Reverting ExtensionTestState and Extensible extra methods modifications to prevent PHP 5.6 segfault ( #8581 )
...
* API Revert addition of Extensible::flush_extra_methods_cache() and change to ExtensionTestState
This reverts the changes from #8465 and #8505 that relate to ExtensionTestState and the
tracking of extra methods between unit tests. The existing test from #8465 testing
overloaded Extensions after extra_methods are populated has been updated to show that you
must re-add the extension to flush the extra_methods cache if you need this behaviour.
* Revert change to InjectorTest::testExtendedExtensions
* Revert "Add failing test to show that overloaded extensions are broken in Extensible"
This reverts commit 55e79ffdfd
2018-11-26 12:00:02 +13:00
f526c794fc
Minor / Refactor php tests for TreeMultiselectField
2018-11-23 16:03:44 +13:00
9ce6d91b76
FIX / TreeMultiselectField::objectForKey handles list of IDs correctly
2018-11-22 12:11:18 +13:00
d74af1c17e
FIX Explicity mark nodes when searching nodes in TreeDropdownField #8621
2018-11-21 11:43:21 +13:00
80885fc231
ADD php test TreeMultiselectField::testEmptyChoiceReadonly
2018-11-20 16:45:23 +13:00
3b1e91eb59
Merge branch '4.2' into 4.3
2018-11-15 13:41:23 +02:00
ef0f9dff8a
Merge branch '4.1' into 4.2
2018-11-15 13:41:00 +02:00
c6e3a398c7
Merge branch '4.0' into 4.1
2018-11-15 13:40:08 +02:00
b5bae137bd
FIX: Redirect loop with multiple confirmation tokens present ( fixes #8607 )
2018-11-15 10:59:42 +00:00
7d1d6d0f7b
FIX Ensure that tests setting passwords have stubbed configuration
2018-11-14 11:54:17 +02:00
0bb94b018b
FIX Remove default password validation rules before running unit tests
2018-11-13 14:09:08 +02:00
8854f053c8
Fix rebase conflicts
2018-11-13 11:09:33 +02:00
a8853504b4
API API MonologErrorHandler::setLogger is deprecated, use MonologErrorHandler::pushLogger instead
2018-11-13 11:08:27 +02:00
b2dd22fb50
Merge pull request #8506 from creative-commoners/pulls/4.3/all-the-unit-tests
...
NEW Adding a stack more unit tests for logging and some form fields
2018-11-11 10:31:24 +13:00
bab84f31dc
Remove underscores from variable test class names
2018-11-10 14:55:11 +02:00
eba92d77df
Rename CheckboxFieldReadonlyTest for future PSR-2 compatibility
2018-11-10 10:04:17 +02:00
a8d3b95175
FIX: Make test work with utf8mb4
2018-11-10 12:10:25 +13:00
bd5a815909
FIX: Make all enums non-destructive, not just ClassName
...
This change also renders a portion of DBSchemaManager irrelevant, that
destructively “fixes” old values. This is in keeping with the
non-destructive principle of dev/build, and some suggestions to move
away from enum fields altogether.
Fixes https://github.com/silverstripe/silverstripe-framework/issues/1387
2018-11-10 12:10:25 +13:00
a12a5b7168
Merge pull request #8377 from creative-commoners/pulls/4.3/bootstrap-alerts
...
NEW Use Bootstrap alerts throughout the CMS
2018-11-09 14:27:38 +02:00
0f2eebe5d4
NEW Change to variadic calls in ListDecorator and add unit tests
2018-11-09 13:59:14 +02:00
bbb208e1dd
Merge pull request #8499 from sminnee/fix-1489
...
FIX: CheckboxSetField can now save into DBMultiEnum
2018-11-09 10:40:55 +01:00
24d6527845
Merge branch '4.3' into 4
2018-11-09 11:39:27 +02:00
10f502f0c7
Merge branch '4.2' into 4.3
2018-11-09 11:39:05 +02:00
5b7723df7f
Merge branch '4.1' into 4.2
...
# Conflicts:
# lang/fi.yml
# lang/nl.yml
2018-11-09 11:38:04 +02:00
df4d2bd838
Merge branch '4.0' into 4.1
...
# Conflicts:
# lang/da.yml
# lang/eo.yml
# lang/fi.yml
# lang/it.yml
# lang/nl.yml
# lang/sv.yml
2018-11-09 11:36:34 +02:00
5531baa87f
FIX: Introduce readonly transaction test to all database.
...
This should work on MySQL and PDO; let’s test this.
2018-11-09 10:57:26 +13:00
2615399535
FIX: Use PDO’s built-in transaction support in MySQLDatabase.
2018-11-09 10:31:19 +13:00
0111b98b18
FIX: Ensure that types are preserved fetching from database
...
This ensures that numeric fields appear in PHP as int/float values
rather than strings, which allows the development of more type-safe PHP
code.
This doesn’t work on the legacy mysql driver and this will now throw
a notice-level error. It requires mysqlnd.
2018-11-09 10:31:19 +13:00
bc0f17fb09
Cleanup Convert
...
* remove unneeded parenthesis and double quotes
* simplify flow / remove unneeded else
2018-11-07 17:45:01 +01:00
3f321f935a
Convert::memstring2bytes should return integer value
...
bytes are by nature an integer
fixes #8572
2018-11-07 17:01:36 +01:00
76936d863d
Merge branch '4.3' into 4
2018-11-07 23:20:44 +13:00
11fe5b3adf
Implement ConfirmationTokenChain to handle multiple tokens at once
2018-11-07 11:33:24 +13:00
8d7c2dafab
[SS-2018-019] Add confirmation token to dev/build
2018-11-07 11:33:24 +13:00
02ad0f44aa
Implement ConfirmationTokenChain to handle multiple tokens at once
2018-11-07 11:32:55 +13:00
af000bea9b
[SS-2018-019] Add confirmation token to dev/build
2018-11-07 11:32:55 +13:00
5563537cc8
Implement ConfirmationTokenChain to handle multiple tokens at once
2018-11-07 11:31:33 +13:00
0610f76da0
[SS-2018-019] Add confirmation token to dev/build
2018-11-07 11:31:33 +13:00
0877442c64
Implement ConfirmationTokenChain to handle multiple tokens at once
2018-11-07 11:24:51 +13:00
3dbb10625c
[SS-2018-019] Add confirmation token to dev/build
2018-11-07 11:24:51 +13:00
64c2938c96
Merge branch '4.3' into 4
2018-11-06 11:05:22 +01:00
3c58ae009e
Merge branch '4.2' into 4.3
2018-11-06 11:05:08 +01:00
22c7fa2bc9
Merge branch '4.1' into 4.2
2018-11-06 11:04:43 +01:00
6d2665d687
Merge branch '4.0' into 4.1
2018-11-06 11:04:28 +01:00
adafd73943
Convert::memstring2bytes should preserve -1
...
fixes #8570
2018-11-06 10:22:13 +01:00
0ba275cb40
Merge branch '4.2' into 4.3
2018-11-06 15:09:01 +13:00
e60cea8561
Merge branch '4.1' into 4.2
2018-11-06 15:08:42 +13:00
67fe41d00b
FIX: Ensure that repeated setting/unsetting doesn’t corrode forceChange()
2018-11-05 23:09:24 +13:00
5bb2d9484a
FIX: Update “original” DataObject data to be the content of the last write
...
FIX: Compare to original when determining fields changes
This fixes a number of edge-case issues relating to change detection.
Fixes #8443
Fixes #3821
Fixes #4561
2018-11-05 23:09:24 +13:00
76255c9fb5
FIX: CheckboxSetField can now save into DBMultiEnum
...
Fixes https://github.com/silverstripe/silverstripe-framework/issues/1489
2018-11-05 17:40:28 +13:00
78ceca6934
MINOR: Add test for defaults on subclasses
...
This was raised in https://github.com/silverstripe/silverstripe-framework/issues/8567
and wasn’t covered by a test.
2018-11-05 16:09:49 +13:00
8866e7674a
BUG: Fix duplicate plugins on HTML editor fields ( #8559 )
...
* BUG: Fix duplicate plugins on HTML editor fields
* Add new test
2018-11-02 12:26:53 +13:00
55f95b7bc8
BUGFIX many many through not sorting by join table ( #8534 )
...
* BUGFIX many many through not sorting by join table
* #8534 added docs to support many many sorting fix
* #8534 added test cases for many_many default sorting
2018-11-01 14:17:15 +13:00
7086f2ea3a
BUGFIX many many through not sorting by join table ( #8534 )
...
* BUGFIX many many through not sorting by join table
* #8534 added docs to support many many sorting fix
* #8534 added test cases for many_many default sorting
2018-11-01 13:42:27 +13:00
b02a6fa02d
FIX Replace usage of Convert JSON methods with json_encode
2018-10-28 21:15:29 +00:00
e72fc9e3d0
FIX DataObject singleton creation ( #8516 )
...
Ensure DataObject instances are aware they are singletons so functions like populateDefaults() can be skipped. (fixes #4878 )
Correctly applies https://github.com/silverstripe/silverstripe-framework/pull/7850 to the 4.x line
This has already been fixed in 3.x
2018-10-25 11:42:45 +13:00
bea4101e21
Add tests for DisabledTransformation, PrintableTransformation and PrintableTransformation_TabSet
2018-10-20 20:06:02 +02:00
449b2cf291
Add tests for DefaultFormFactory
2018-10-20 19:47:11 +02:00
fd50ce6295
Add more edge case tests for disabled DateFields and DatetimeField
2018-10-20 18:29:07 +02:00
97209bc919
Add edge case unit tests for DateField
2018-10-20 18:15:42 +02:00
0e2847e289
Add tests for DatalessField
2018-10-20 17:59:55 +02:00
c06cf4820e
BUG Readonly and disabled CurrencyFields no longer always returns dollar currency sign, now respect config
2018-10-20 17:47:16 +02:00
d56bad7568
Add tests for edge cases in CurrencyField
2018-10-20 17:33:59 +02:00
8929b8204f
More validation tests for ConfirmedPasswordField
2018-10-20 17:21:25 +02:00
c418ee2915
NEW Add getters and setters for public properties in ConfirmPasswordField, add tests
...
Some of the validation parts of ConfirmPasswordField are previously untested, this adds tests
2018-10-20 16:43:49 +02:00
Steve Boyd
William Desportes
Sam Minnée
Andre Kiste
Garion Herman
wernerkrauss
Aaron Carlino
Guy Marriott
Daniel Hensby
Robbie Averill
Dan Hensby
Maxime Rainville
Loz Calver
Damian Mooyman
Robbie Averill
Nicolaas
Serge Latyntcev
Mojmir Fendek
Ingo Schommer
Martin Heise
cpenny
Michal Kleiner
Brett Tasker
mattclegg
UndefinedOffset
Maxime Rainville
Dylan Wagstaff
bergice
Robbie Averill
Chee Wai
Simon Gow
Saophalkun Ponlu
Jarkko Linnanvirta
Ralph Slooten
Johannes Hammersen
Damian Mooyman
Loz Calver
Luke Edwards
Michael Strong