00ee8d8abf
BUGFIX: Re-declare $items to be an ArrayList if it's null
...
getBackLink() modified to tolerate empty ArrayList
2020-06-29 16:07:24 +03:00
824b5e0b67
BUGFIX: Ensure $items isn't null in GridFieldDetailForm_ItemRequest->Breadcrumbs() prior to performing operations on it.
2020-06-29 14:13:49 +03:00
1a6e2da995
Merge pull request #9543 from jakxnz/pulls/4.6/undeclared-private-statics
2020-06-15 23:16:57 -07:00
dadac00c19
Added array declaration to `GridFieldDetailForm_ItemRequest::$formActions`
...
Co-authored-by: Robbie Averill <robbie@averill.co.nz>
2020-06-15 11:45:33 +12:00
7d87ba72d5
Merge branch '4.6' into 4
2020-06-12 11:20:53 +12:00
4daccfab67
Merge branch '4.5' into 4.6
2020-06-12 11:20:13 +12:00
84235c6518
Adjusted missing definitions to only include definitions referenced by framework
2020-06-11 14:28:47 +12:00
4303917ac5
DOCS Form::loadDataFrom constants in docblock
...
... missing MERGE_ prefix as defined in this class
2020-05-28 16:40:12 +01:00
d320026375
Remove recursive write until its fixed
2020-05-28 14:34:55 +12:00
d4165db690
Update getter name to getCMSCompositeValidator
2020-05-28 12:23:35 +12:00
8ba65313e9
Add internal note for protected method
2020-05-28 11:18:46 +12:00
bca4be77ed
Update name to CompositeValidator. Add docblocks
2020-05-28 11:18:46 +12:00
a2b57f0801
Update DefaultFormFactory extension point. Use array for validators
2020-05-28 11:18:46 +12:00
b45a3561df
Implemented PR feedback. Added some initial test cov
2020-05-28 11:18:46 +12:00
d7dd93f7a7
Standardise getCMSValidator for DataObjects/Forms
2020-05-28 11:18:46 +12:00
080ce157ce
Fix various typos in comments
2020-05-16 10:34:53 +01:00
21129b1624
Use short array syntax across the framework's codebase
2020-05-16 10:34:45 +01:00
153e2383e6
DOCS: Minor typo
2020-05-10 08:01:10 +05:45
3a424747df
Merge pull request #9332 from shoosah/feature/add-error-message-into-field
...
Allow to add error message into a specific field
2020-05-01 15:46:29 +12:00
ec51f98adb
Merge pull request #8870 from jinjie/4
...
Fix: Allow editing of relation if item is created.
2020-05-01 15:37:52 +12:00
42cee6f5fb
Merge pull request #9489 from mattclegg/1587548067
...
DOCS: Fix typos
2020-04-22 12:28:02 +01:00
d521a52a33
DOCS: Fix typos
2020-04-22 15:20:11 +05:45
237b2d5f74
Convert array delcarations to short array syntax
2020-04-20 18:58:09 +01:00
cb36aab80c
Merge branch '4.5' into 4
2020-04-15 14:49:19 +12:00
5585f6633f
DOCS: Update typos
2020-04-14 15:00:08 +05:45
f77f725355
Merge pull request #9447 from mattclegg/docs__GridFieldDetailForm_ItemRequest-httpError
...
[DOCS] Better debug text for errors generated by GridFieldDetailForm_ItemRequest
2020-04-02 13:05:49 -07:00
d3b19069b3
Apply suggestions from code review
...
Add double quotes around object title
2020-04-02 12:51:13 -07:00
d1075f29b8
Remove empty parameter as per feedback
2020-04-02 12:11:35 +01:00
9e0ed0a50a
Fix spaces around concatenation operator
2020-04-02 12:09:22 +01:00
24bc80ed35
[DOCS] Better debug text for errors generated by GridFieldDetailForm_ItemRequest
2020-03-31 12:09:16 +05:45
9c7eac481e
Add "option" to list elements that belong to "listbox"
...
The accessibility attribute `role="listbox"` requires its immediate children to be set as `role="option"`, currently they don't have this option and accessibility tests are failing.
2020-03-10 11:10:04 -06:00
667495eaf9
Merge branch '4.5' into 4
2020-03-06 10:53:28 +13:00
687435a2f1
Merge branch '4.4' into 4.5
2020-03-06 10:52:22 +13:00
bba0f2f72f
BUGFIX: Fixed issue where TimeField_Readonly would only show "(not set)" instead of the value
2020-02-24 09:59:00 -04:00
affd43052a
Merge branch '4.5' into 4
2020-02-17 18:11:23 +13:00
acd7d94167
Merge branch '4.4' into 4.5
2020-02-17 13:07:26 +13:00
ad1b00ec7d
[CVE-2019-19325] XSS through non-scalar FormField attributes
...
Silverstripe Forms allow malicious HTML or JavaScript to be inserted
through non-scalar FormField attributes, which allows performing XSS (Cross-Site Scripting)
on some forms built with user input (Request data). This can lead to phishing attempts
to obtain a user's credentials or other sensitive user input.
There is no known attack vector for extracting user-session information or credentials automatically,
it required a user to fall for the phishing attempt.
XSS can also be used to modify the presentation of content in malicious ways.
2020-02-17 09:58:29 +13:00
9c38c5f625
CMS action related extension points ( #9340 )
...
* CMS action related extension points
* Refactor to use fewer extension points
* Remove explicit return type
Co-authored-by: Aaron Carlino <unclecheese@leftandmain.com>
2020-01-27 15:09:15 +13:00
6ff0f3f466
BUG The "Link existing" should be disabled rather than readonly.
2020-01-24 14:47:12 +13:00
acbbf80d14
CMS action related extension points ( #9340 )
...
* CMS action related extension points
* Refactor to use fewer extension points
* Remove explicit return type
Co-authored-by: Aaron Carlino <unclecheese@leftandmain.com>
2020-01-15 14:24:49 +13:00
2724d93111
Allow to add error message into a specific field
2019-11-22 11:03:27 +13:00
91e4aa90f1
Merge branch '4.4' into 4.5
2019-11-20 11:09:23 +13:00
8219491705
Merge branch '4.3' into 4.4
2019-11-20 11:08:35 +13:00
e76601e5c8
BUG FormAction title property cannot be set if useButtonTag is false
2019-10-29 17:21:45 +13:00
17f4cc6e30
Merge pull request #9281 from creative-commoners/pulls/4/textfield-tip-ui
...
NEW: Add support for Tip UI in TextField
2019-10-23 16:50:43 +13:00
bed3f2b3c6
NEW Add type declarations to Tip API, add TippableFieldInterface
2019-10-23 10:46:22 +13:00
195417b061
NEW Extract Tip from TextField, add test coverage
2019-10-22 17:04:58 +13:00
e59625fe5a
NEW Add ability to define image size preset for the TinyMCE editor. ( #9276 )
...
* NEW Add ability to define image size preset for the TinyMCE editor.
* DOC Explain how to define image size pre-sets
2019-10-22 11:50:28 +13:00
7873efde9c
Merge branch '4.4' into 4
2019-10-18 10:58:19 +13:00
efc7ba9520
NEW Tweak TextField Tip API to match changes to component
2019-10-11 15:04:56 +13:00
a44bc5bcf3
NEW Add support for Tip UI in TextField
...
See TextField documentation in silverstripe/admin Pattern Library
2019-10-09 16:26:06 +13:00
d7752b7945
Run PSR2 Lint cleaner
2019-10-04 13:26:31 +13:00
f1594fd991
BUG Ensure that canCreate() context matches that respected by GridFieldAddNewButton
2019-10-04 11:24:34 +13:00
047ac060c4
Merge pull request #9265 from emteknetnz/feature/noopener
...
Add noopener attribute to links with a target
2019-10-03 14:42:50 +13:00
887f198b07
Add rel attribute to link elements with a target attribute
2019-10-03 14:03:12 +13:00
58c080db5a
FEATURE Option placeholder for upload folder id ( #9262 )
...
* FEATURE Option placeholder for upload folder id
* ENHANCEMENT Add setFolderName() to TinyMCEConfig
* Typehint return type
* Add type to param
2019-09-30 10:50:55 +13:00
349589b23b
Clarify that $title in FormField can accept ViewableData
...
When constructing a FormField, an IDE would previously tell you the `$title` needs to be string (or null). Let's make it more clear that a ViewableData instance (such as `HTMLValue::create($title)`) is also accepted. This should help people more quickly find a solution to put html in labels.
2019-09-26 02:39:39 +02:00
88fde6e7c3
Merge branch '4.4' into 4
2019-09-24 17:29:06 +12:00
50a1aa4c4d
Merge branch '4.3' into 4.4
2019-09-24 17:28:31 +12:00
d85ff3bc44
FIX: Don't force-add view button to readonly GridField ( fixes #9249 )
2019-09-23 16:52:47 +01:00
6ff97821ed
Merge branch '4.4' into 4
2019-09-18 15:52:36 -07:00
7877ffcc85
Merge branch '4.3' into 4.4
2019-09-18 15:52:18 -07:00
daf9d55ecb
Allow non summary fields to be used as export fields
...
Fixes regression in 3d989a6eae
2019-09-19 10:00:54 +12:00
42dd02ef78
Merge pull request #9122 from aNickzz/4
...
Add onBeforeRenderHolder extension point for FormField
2019-09-06 11:53:10 -07:00
dd40d53e6b
Merge branch '4.4' into 4
2019-09-04 09:46:33 +12:00
ef49dcf726
Merge pull request #9164 from sminnee/fix-9162
...
FIX: Write relations when saving in grid-field item edit form
2019-09-01 20:44:13 -07:00
a2a202c016
Merge pull request #9200 from open-sausages/pulls/4.4.3/consistent-actions
...
FIX make the grid field actions consistent to what they look like on pages
2019-09-02 14:07:22 +12:00
2f8d847a10
FIX make the grid field actions consistent to what they look like on pages
...
Resolves https://github.com/silverstripe/silverstripe-admin/issues/904
2019-09-02 12:22:32 +12:00
d2a07b1047
FIX Remove error when exporting a column that is not displayed in a GridField
2019-08-27 11:54:31 +12:00
45f86658ca
Merge branch '4.4' into 4
2019-08-14 09:31:05 +12:00
4b44272367
Merge branch '4.3' into 4.4
2019-08-14 09:30:53 +12:00
4a32b3418a
Add onBeforeRenderHolder extension point for FormField
2019-08-09 14:43:14 +09:30
3d989a6eae
FIX Use content generated by DataColumns component for print and csv export
2019-08-09 15:04:38 +12:00
b3093b7a1a
BUGFIX: Allow state to be shared across nested GridFields
2019-08-07 23:09:51 +12:00
6ec02da577
FIX: Allow multi-line content in grid field cells
...
It’s amazing that this but has been present for 7 years, but there you
go!
2019-08-02 17:46:56 +12:00
d088354f46
FIX: Write relations when saving in grid-field item edit form
...
Fixes https://github.com/silverstripe/silverstripe-framework/issues/9162
2019-08-02 16:17:42 +12:00
6a8c6703d1
Remove `use_gzip` from HTMLEditorField since it's been removed by TinyMCE codebase ( #7261 )
...
* Remove `use_gzip` from HTMLEditorField
* DOCS Mention remove use_gzip in changelog
2019-06-21 09:27:48 +12:00
e2da7b0dc4
Merge branch '4.4' into 4
2019-06-10 16:37:16 +12:00
654156d46d
FIX: Fix bug when confirmed password is changed but not the password. ( #9012 )
...
In this case the confirmed password field is not reflected. It’s
unclear how often this situation would arise outside of test scenarios,
but may come up if $form->loadDataFrom() is called more than once.
Fixes #2496 (it’s a minor issue but I think this is why Dan flagged it
as a regression). Originally introduced as part of Dan’s initial fix
at 2a6f1f1949
2019-06-10 15:48:29 +12:00
179a982f45
Merge pull request #9019 from rafaeldsousa/pull/include-cancreate-check-gridfield-rightgroupfield
...
Including canCreate in if statement so that button gets removed if us…
2019-06-10 09:59:45 +12:00
00fd74a0a1
Merge branch '4.4' into 4
...
# Conflicts:
# src/Dev/Tasks/MigrateFileTask.php
2019-05-30 09:36:42 +12:00
14673ffd0a
Merge branch '4.3' into 4.4
2019-05-30 09:35:26 +12:00
188698dcee
Merge branch '4.2' into 4.3
2019-05-30 09:35:17 +12:00
7f69cc8f94
Merge branch '4.1' into 4.2
2019-05-30 09:35:06 +12:00
02864aba3f
Merge branch '4.0' into 4.1
2019-05-30 09:34:55 +12:00
a1f0d7a3bf
Merge pull request #9016 from sminnee/partial-fix-4622
...
FIX: Better message when form action handler not found.
2019-05-30 09:22:54 +12:00
f7c1be7ac1
Including canCreate in if statement so that button gets removed if user isn't to be able to create new records
2019-05-28 12:28:00 +12:00
7407096e99
FIX: List default items in the readonly view of ListboxField
...
Adds tests for non-readonly default items too.
Fixes #4142
2019-05-27 17:47:09 +12:00
983d36b7ee
FIX: Better message when form action handler not found.
...
Fixes #4622 to some extent, although this fix will be most useful when
https://github.com/silverstripe/silverstripe-errorpage/issues/30 is
addressed also.
2019-05-27 15:00:10 +12:00
25aa3af032
FIX HeaderField requires the optional Title field
...
FormField marks the Title constructor argument as optional, and DatalessField does not override the __construct method. HeaderField on the other hand goes against the grain of FormFields as a whole and requires the Title field, seemingly for no good reason (at least, not that the commit message for a68ba38478
2019-05-24 13:44:01 +12:00
4da8be3bf5
Add extend function in getSchemaValidation function
...
This allows to create extensions which add validation list
2019-05-14 09:47:14 +12:00
28be2b2263
Swap argument order for implode
...
I noticed this squiggly red line while perusing the code.
The PHP doc says
`implode ( string $glue , array $pieces ) : string`
> implode() can, for historical reasons, accept its parameters in either order. For consistency with explode(), however, it may be less confusing to use the documented order of arguments.
2019-05-11 00:32:23 +09:30
856e841955
FIX Ensuring pagination buttons have a consistent state to work off of ( #8957 )
2019-05-06 14:42:25 +12:00
5337e6d048
API Replace FormActions with anchors to enable panel-based loading in GridField navigation buttons ( #8953 )
...
* FIX Add accessibility labels and titles to previous, next, and add new buttons in GridFields
* API Replace FormActions with anchors to enable panel-based loading in GridField navigation buttons
* FIX Previous and Next links are now correctly disabled when end of lists are reached
* Add English translations
2019-05-03 15:03:59 +12:00
ecfe039e72
FIX Don't add "better buttons" previous and next without a paginator
2019-05-01 15:48:03 +12:00
6a2762662b
MINOR: Change “Choose Page” to “Search or choose Page” ( #8766 )
...
* MINOR: Change “Choose Page” to “Search or choose Page”
Based on discussions with James Ford, it wasn’t clear that you could
search.
* Use new translation key
2019-04-16 16:06:37 +12:00
b1339f0d72
NEW Update FieldList::replaceField API to match removeByName ( #8876 )
...
* API Update FieldList::replaceField API to match removeByName
This specifically adds the parameter that `removeByName` has but `replaceField` does not. This parameter is set to `true` by default rather than inheriting the same default as `removeByField`. This is because the existing funtionality of `replaceField` was the same as if this parameter was set to `true`. This should be updated in SS5 to match the `removeByField` API.
* Add dataFieldOnly to CompositeField
2019-04-15 16:22:54 +12:00
f4a6115ee6
Merge branch '4.0' into 4.1
2019-04-11 11:36:40 +12:00
8a06682e31
Merge branch '4.3' into 4
...
# Conflicts:
# src/ORM/Connect/DBSchemaManager.php
2019-04-11 11:24:17 +12:00
55cbacca86
Merge branch '4.2' into 4.3
...
# Conflicts:
# src/Forms/GridField/GridFieldLevelup.php
# src/includes/constants.php
2019-04-11 11:21:42 +12:00
f12fa62ad6
FIX: Better error message when GridFieldLevelup passed bad record details
...
Fixes https://github.com/silverstripe/silverstripe-framework/issues/3519
2019-04-08 18:09:51 +12:00
8b4b54f264
PHPCS linting error on indentation
2019-04-05 16:29:24 +13:00
fc6213c293
Merge branch '4.3' into 4
2019-03-27 13:25:57 +13:00
6dc41e50a0
MINOR Linting fixes
2019-03-26 17:35:58 +13:00
1d406c64b9
Fix: Allow editing of relation if item is created.
2019-03-20 12:51:49 +08:00
f6a7bddd8d
Linting
2019-03-20 15:50:54 +13:00
3e90fdf42f
Merge branch '4.3' into 4
2019-02-19 08:41:05 +07:00
ed74549c4f
Merge branch '4.2' into 4.3
2019-02-19 08:39:59 +07:00
79e44b42fa
Merge branch '4.1' into 4.2
2019-02-19 08:37:07 +07:00
cb7f15a681
Merge branch '4.0' into 4.1
2019-02-19 08:36:41 +07:00
dc9d1b9cc0
FIX GridFieldPrintButton no longer assumes that children of GridField would implement their own print template
2019-01-28 11:45:55 +02:00
db466fb013
MINOR Always cast formfield display value as a string to avoid 0 being blank
2019-01-25 13:34:36 +13:00
394dd4765c
NEW Scaffolded field labels now only have an uppercased first word
2019-01-07 17:52:28 +01:00
1667af8f5e
Add $disabledItems to check for disabled items instead of checking against $defaultItems
...
Fixes #8688
2018-12-31 17:25:11 +08:00
0397c54b5a
FIX: Fixes #8459
...
- Missing conditionals for optional constructor args
- Missing calls to FieldList::setForm()
- Missing guards around naive calls to Form::Fields()->foo()
2018-12-19 13:28:19 +13:00
5d7c5ffb07
Merge branch '4.3' into 4
2018-12-06 09:40:40 +00:00
08866f89d9
Merge branch '4.2' into 4.3
2018-12-06 09:40:05 +00:00
96bd17d469
Merge branch '4.1' into 4.2
2018-12-06 09:38:45 +00:00
3f532466d1
Merge branch '4.0' into 4.1
2018-12-06 09:37:52 +00:00
c7b5b1efd2
FIX Switching to use Controller::curr as it was using previously
2018-11-30 15:40:45 +13:00
32d096d9e5
DOCS Moving interface subscription to the abstract and adding a changelog entry
2018-11-30 15:40:45 +13:00
ddaa22986f
Updating StateStore interface not to define a constructor & fixing GridFieldFilterHeader to add required attributes
2018-11-30 15:40:45 +13:00
b4c8f699eb
FIX Provide alternatives to session for storing GridField_FormAction state
2018-11-30 15:40:45 +13:00
441d079647
Merge pull request #8637 from creative-commoners/pulls/4.4/falsy-detail-component
...
FIX getComponentByType can return null - prevent null pointer errors
2018-11-26 18:28:26 +01:00
f22a4b980b
FIX getComponentByType can return null - prevent null pointer errors
2018-11-26 16:01:46 +01:00
efa427fc45
FIX Remove redundant "rightGroup" logic and increase getRightGroupField to protected
2018-11-26 12:42:47 +01:00
1f1c344272
Merge branch '4.3' into 4
...
# Conflicts:
# tests/php/Forms/ConfirmedPasswordFieldTest.php
2018-11-26 12:15:17 +01:00
1d9e40ba26
Use new plus icon ( #8619 )
...
* Use new plus icon and refactor
* MINOR: Add ability to customise the visibility of the `Previous`, `Next` and `Add` buttons at a `GridField` level
* - Merge `showPrevious` and `showNext` to `showPagination` for grid fields
- Update documentation
- Improve performance for next/previous buttons by not fetching all list records
- Refactoring
* Refactor to fail gracefully on GridFieldPaginator
* Fix merge
2018-11-23 12:40:18 +13:00
9ce6d91b76
FIX / TreeMultiselectField::objectForKey handles list of IDs correctly
2018-11-22 12:11:18 +13:00
d74af1c17e
FIX Explicity mark nodes when searching nodes in TreeDropdownField #8621
2018-11-21 11:43:21 +13:00
cc712892a9
NEW Port betterbuttons to framework ( #8569 )
...
* MINOR: Add `Previous`, `Next` and `Create New` actions in edit form
If the form is opened via a grid field, the filters will be retained so the previous/next record opened will be correct
* MINOR: Add ability to customise the visibility of the `Previous`, `Next` and `Add` buttons at a `GridField` level
* Fix invalid action when pressing the `New` button in an edit form unless `betterbuttons` module was installed
* - Merge `showPrevious` and `showNext` to `showPagination` for grid fields
- Update documentation
- Improve performance for next/previous buttons by not fetching all list records
- Refactoring
* Refactor to fail gracefully on GridFieldPaginator
2018-11-19 11:06:47 +13:00
15aaf9db9f
Fix a code style typo
2018-11-13 10:20:49 +13:00
b2dd22fb50
Merge pull request #8506 from creative-commoners/pulls/4.3/all-the-unit-tests
...
NEW Adding a stack more unit tests for logging and some form fields
2018-11-11 10:31:24 +13:00
bbb208e1dd
Merge pull request #8499 from sminnee/fix-1489
...
FIX: CheckboxSetField can now save into DBMultiEnum
2018-11-09 10:40:55 +01:00
24d6527845
Merge branch '4.3' into 4
2018-11-09 11:39:27 +02:00
4b4fbabed5
FIX TreeMultiselectField passes value 'unchanged' as null to ORM for 'ID' column key
2018-11-08 15:41:46 +13:00
358cef0cdf
Merge pull request #8514 from wilr/pulls/lookup-injector
...
FIX use Injector for FormField::castedCopy
2018-11-07 19:20:36 +02:00
64c2938c96
Merge branch '4.3' into 4
2018-11-06 11:05:22 +01:00
0ba275cb40
Merge branch '4.2' into 4.3
2018-11-06 15:09:01 +13:00
76255c9fb5
FIX: CheckboxSetField can now save into DBMultiEnum
...
Fixes https://github.com/silverstripe/silverstripe-framework/issues/1489
2018-11-05 17:40:28 +13:00
97180c2612
Fix readonly grid state always being truthy ( #8562 )
2018-11-02 14:28:47 +13:00
8866e7674a
BUG: Fix duplicate plugins on HTML editor fields ( #8559 )
...
* BUG: Fix duplicate plugins on HTML editor fields
* Add new test
2018-11-02 12:26:53 +13:00
c7b8b80e8b
Persist GridField readonly state, add view button ( #8535 )
...
* Persist GridField readonly state, add view button
* Minor clarity fixes
2018-11-01 11:12:52 +13:00
511c368e8c
Merge pull request #8521 from open-sausages/pulls/4.3/searching-for-legacy
...
Add config to force legacy filter header globally
2018-10-29 14:57:21 +13:00
b02a6fa02d
FIX Replace usage of Convert JSON methods with json_encode
2018-10-28 21:15:29 +00:00
3284bf48d6
Fix search filtering relations and clear filters ( #8477 )
2018-10-26 14:43:56 +13:00
d879148bff
Add config to force legacy filter header globally
2018-10-26 14:28:15 +13:00
66a404ad1a
FIX use Injector for FormField::castedCopy
...
Allows LookupField to be replaced with user specificed classes.
2018-10-24 12:13:14 +13:00
af46381dca
MINOR Correct implementation of single lookup field when valueToLabel returns null
2018-10-23 11:54:26 +13:00
bea4101e21
Add tests for DisabledTransformation, PrintableTransformation and PrintableTransformation_TabSet
2018-10-20 20:06:02 +02:00
449b2cf291
Add tests for DefaultFormFactory
2018-10-20 19:47:11 +02:00
97209bc919
Add edge case unit tests for DateField
2018-10-20 18:15:42 +02:00
c06cf4820e
BUG Readonly and disabled CurrencyFields no longer always returns dollar currency sign, now respect config
2018-10-20 17:47:16 +02:00
d56bad7568
Add tests for edge cases in CurrencyField
2018-10-20 17:33:59 +02:00
8929b8204f
More validation tests for ConfirmedPasswordField
2018-10-20 17:21:25 +02:00
c418ee2915
NEW Add getters and setters for public properties in ConfirmPasswordField, add tests
...
Some of the validation parts of ConfirmPasswordField are previously untested, this adds tests
2018-10-20 16:43:49 +02:00
60b375d995
Add more tests for CheckboxField_Readonly and CompositeField, improve PHPDocs
2018-10-20 15:44:23 +02:00
a6a1743997
BUG: Fix `ENTER` not triggering form save button as `GridField`s used `submit` type buttons
2018-10-18 12:37:24 +13:00
57756f38cb
Revert bd6c4fd
2018-10-17 14:54:03 +13:00
7215637673
Merge pull request #8460 from open-sausages/pulls/4/lazy-loadable-gidfield
...
API Add a new GridFieldLazyLoader component
2018-10-11 13:43:10 +02:00
dca2d47127
Merge pull request #8357 from creative-commoners/pulls/4.3/fix-i18n
...
FIX Text collector translations now compile without errors
2018-10-11 13:16:23 +02:00
250d925810
MINOR Update CompositeField::__construct to call setChildren #8460
2018-10-11 15:25:34 +13:00
98afbfe9b4
Implement Peer review feedback #8460
2018-10-11 14:56:06 +13:00
ef439f9306
MINOR Correct GridField_DataManipulator PHPDOC to not assume DataList
...
Tweak GridField_DataManipulator to not assume only DataList will be
provided. Use the SS_List Interface instead. (#8460 )
2018-10-11 12:06:21 +13:00
2e2ca5a4a7
Make sure LazyLoader still woks after a readonly transofrmation ( #8460 )
2018-10-11 11:56:39 +13:00
bd6c4fdda0
Merge pull request #8440 from creative-commoners/pulls/4.3/its-indestruc-tab-le
...
NEW TabSet react component is no longer structural
2018-10-09 22:05:53 +02:00
d1281a571a
FIX Escape HTML in PHPDoc to fix API docs from rendering incorrectly
2018-10-09 10:46:45 +02:00
fdb53311ba
Fix linting issue.
2018-10-09 17:32:42 +13:00
bfb6518176
Tweak the logic to empty lazy list.
2018-10-09 17:32:42 +13:00
d2a51471e9
Don't lazy load tab that are not in a TabSet.
2018-10-09 17:32:42 +13:00
5276b6cbb1
API Add FieldList::getContainerField
2018-10-09 17:32:42 +13:00
bdb53979aa
API Create a new GridFieldLazyLoader GridField component
2018-10-09 17:32:42 +13:00
e5d3b28a4d
FIX: Don’t break validation on selects without a source.
...
Fixes cases where there are no valid values or an empty-string
value is manually added rather than using setEmptyString()
Fixes #4849
Fixes #7159
2018-10-06 11:53:17 +13:00
ee24413c30
Merge branch '4.2' into 4
2018-10-03 15:28:05 +02:00
d74fed554a
Merge pull request #8427 from sminnee/fix-1397
...
FIX: Append any fields that don’t match name in insertBefore/insertAfter
2018-10-03 13:22:23 +02:00
6a5fb4999c
Merge pull request #8416 from lekoala/patch-14
...
raw2att accepts array, but sprintf doesn't
2018-10-03 13:21:43 +02:00
90afb2037a
NEW TabSet react component is no longer structural
2018-10-03 16:36:17 +13:00
cb2b9498fb
API Deprecate updateSearchContextCallback and updateSearchFormCallback
2018-10-03 13:47:40 +13:00
bf60a699a5
Add extension points for ModelAdmin search API
2018-10-03 13:47:40 +13:00
c8e7672ede
Merge pull request #8414 from creative-commoners/pulls/4/searching-for-a-name-conflict
...
FIX Avoid having search fields with the same names as form elements
2018-10-02 13:43:59 +02:00
71dad5f685
FIX: Append any fields that don’t match name in insertBefore/insertAfter
...
Previous behaviour was to return false, which has been described as
a confusing bug on https://github.com/silverstripe/silverstripe-framework/issues/1397
where the issue was identified.
2018-10-02 10:39:48 +13:00
755907d117
Merge pull request #8409 from open-sausages/pulls/4/treedropdown-caching
...
MINOR Add caching to the TreeDropdownField tree action
2018-10-01 13:56:21 +13:00
c503dbd634
Prefixing search filters for the React search form context
2018-10-01 13:38:32 +13:00
13c89d0ed0
Add a comment and only apply caching if using the standard NumChildrenMethod
2018-10-01 11:29:51 +13:00
f842ee2eec
Update deprecation PHPDocs to be PSR-5 compliant
...
See: https://github.com/php-fig/fig-standards/blob/master/proposed/phpdoc-tags.md#55-deprecated
2018-09-28 10:49:14 +02:00
fdd5acff5d
raw2att accepts array, but sprintf doesn't
...
it's not very likely to happen (it did in my case :-) ) but if the value is an array, sprintf will fail (because raw2att accepts array, but sprintf doesn't). i suggest to json encode any array data to ensure it's safely included in the html. Or we should throw proper exceptions to make sure invalid values do not result in a php error.
2018-09-27 12:12:59 +02:00
c54e7317d2
FIX Avoid having search fields with the same names as form elements
2018-09-27 17:39:50 +12:00
f103648f8c
value can be something else than a string
...
if the value is not a string (an array for instance), sprintf will fail
2018-09-26 11:35:40 +02:00
77339b7e75
MINOR Add caching to the TreeDropdownField tree action
2018-09-26 17:24:06 +12:00
0276f6c089
FIX Revert semver break in adding GridField type hint to method signature
2018-09-24 13:39:33 +02:00
e8fd49b394
Merge pull request #8381 from open-sausages/pulls/4.2/sort-out-your-field
...
BUG Changes being detected on TreeMulti as values not sorted
2018-09-21 16:38:56 +12:00
4ac4cdc91b
Merge pull request #8348 from caffeineinc/bugfix/3357
...
BUG Add GridField Readonly Transformation (#3357 )
2018-09-21 14:54:37 +12:00
3fc49dd4ce
Lint fixes and allow a few other components by default
2018-09-20 13:32:52 +12:00
db63f55fbb
BUG Changes being detected on TreeMulti as values not sorted
2018-09-18 13:24:55 +12:00
588bf83e12
NEW Add hideNav flag to schema defaults
2018-09-18 10:45:36 +12:00
a33866ff4c
Merge pull request #8353 from open-sausages/pulls/4.2/2227-show-link-tracking
...
API: Add Link Tracking section to Relations developer guide
2018-09-13 14:23:34 +12:00
01db5c9e98
API: Add Link Tracking section to Relations developer guide and describe `show_sitetree_link_tracking`, `show_file_link_tracking`.
...
Refactor form scaffolder.
2018-09-13 11:02:09 +12:00
b555bb83b8
Merge pull request #8359 from creative-commoners/pulls/4/HTMLEditorSchema
...
Add schema information for HTMLEditorField
2018-09-10 09:53:12 +02:00
373a8afeb5
Merge branch '4.2' into 4
2018-09-06 13:26:46 +02:00
f13ee4486d
Add schema information for HTMLEditorField
...
This allows React form builders (or other such view layer builders in a
headless environment) to obtain the details that would otherwise only be
rendered in a PHP side template. Some of the details are critical for
rendering correctly, and are necessary to be passed through -
particularly when moving toward replacing the Entwine initiator for
TinyMCE with a React component in `silverstripe/admin`.
I new interface method has been added to the abstract class for HTML
editor configs in order to facilitate this. It is not itself abstract as
this would break backwards compatiblity with any existing custom config
(aside from the TinyMCE one which we're editing here), which is most
certainly not what we want.
2018-09-06 14:35:11 +12:00
Tom Yrjas
Guy Marriott
Jackson Darlow
Steve Boyd
Christopher Darling
Adrian Humphreys
cpenny
Daniel Hensby
Michal Kleiner
Matt Clegg
Andre Kiste
Daniel Hensby
Serge Latyntcev
Robbie Averill
Ramon Lapenta
UndefinedOffset
Maxime Rainville
Mojmir Fendek
shoosah
Damian Mooyman
Garion Herman
Dylan Wagstaff
Damian Mooyman
JorisDebonnet
Loz Calver
Hayden Shaw
bergice
Will Rossiter
Robbie Averill
Nicholas Sorokin
Aaron Carlino
Sam Minnee
Saophalkun Ponlu
Rafael Marins de Sousa
Dylan Wagstaff
aNickzz
Kong Jin Jie
Russell Michell
Loz Calver
Luke Edwards
Raissa North
Maxime Rainville
Thomas Portelange