288aaf083c
BUG Fix issue with DebugView failing on class name of existing class
...
Fixes #7827
2018-02-05 10:45:49 +13:00
a3c52f901a
Merge remote-tracking branch 'origin/4.0' into 4
...
# Conflicts:
# src/Core/TempFolder.php
# src/ORM/DataObject.php
# src/View/ThemeResourceLoader.php
# src/includes/constants.php
# tests/php/Control/SimpleResourceURLGeneratorTest.php
# tests/php/Forms/HTMLEditor/HTMLEditorFieldTest.php
# tests/php/View/RequirementsTest.php
2018-01-22 14:57:05 +13:00
db610aaf3b
Fixing string concat CS issues
2018-01-16 18:39:30 +00:00
20348b5f42
BUG Fix `upgrade-code doctor` with public path
2018-01-16 15:38:12 +13:00
8d077203d4
API Implement support for public/ webroot folder ( #7741 )
...
* API Implement support for public/ webroot folder
* Bugfixes and refactor based on feedback
2018-01-12 16:25:02 +13:00
529e341dbc
Merge pull request #7699 from open-sausages/pulls/4/html-in-security-msg
...
ENHANCEMENT Allow html in security failure message
2017-12-14 14:30:09 +13:00
1c8576cee7
Linting cleanup
2017-12-14 14:18:41 +13:00
8b1b9f022b
Fix linting issues
2017-12-14 13:50:52 +13:00
6b384f4b35
Merge branch '4.0' into 4
2017-12-07 13:52:00 +13:00
b46b858847
Merge pull request #48 from silverstripe-security/pulls/4.0/fix-install-redacting
...
[SS-2017-010] Prevent install.php from disclosing system passwords
2017-12-06 18:22:36 +13:00
99e772b361
Merge pull request #51 from silverstripe-security/pulls/4.0/ss-2017-007
...
[ss-2017-007] Ensure xls formulae are safely sanitised on output (4.0)
2017-12-06 18:22:11 +13:00
eb55c27124
Merge branch '4.0' into 4
2017-12-05 12:14:22 +00:00
3a4c6705c1
Fix db autodiscover comment on loading behavior.
2017-12-02 10:52:49 +10:30
cfe1d4f481
[ss-2017-007] Ensure xls formulae are safely sanitised on output
...
CSVParser now strips leading tabs on cells
2017-12-01 10:24:49 +13:00
9666222637
BUG Fix _configure_database.php being ignored
...
Fixes #7590
2017-11-29 12:01:24 +13:00
7a79cd039a
[SS-2017-010] Prevent install.php from disclosing system passwords
2017-11-27 18:15:53 +13:00
0b879d690a
Reintroduce checking against original php.ini values.
...
Seems to have been accidentally removed in 806ffb934ehttps://github.com/silverstripe/silverstripe-installer/issues/211
2017-11-26 01:36:40 +01:00
0ceb4cfa18
Merge branch '3' into 4
2017-11-25 17:34:24 +00:00
07a0f75426
Merge branch '3.6' into 4.0
2017-11-25 16:56:50 +00:00
8b063026f0
ENHANCEMENT Ensure that non-writable assets files are notified during install
...
Fixes #7580
2017-11-15 13:30:19 +13:00
bf20d59cb8
FIX: Fixes SapphireTest masking userland coding errors.
2017-11-09 15:39:20 +13:00
8497b9e1e6
BUG Disable directory index with missing slash
2017-11-08 12:12:10 +13:00
1929ec46bb
BUG Prevent logOut() from clearing site stage during bootstrapping due to flushed session
2017-11-03 16:22:11 +13:00
af9caa4e51
Warn if theme.yml isn't writeable
2017-11-02 11:34:36 +01:00
f6b7cf8889
Feature disable current user from removing their admin permission
2017-10-30 12:34:06 +13:00
97f9eddf90
Warn if env isn't writable
2017-10-25 15:07:35 +13:00
2f82d08460
BUG Fix env loading in installer
2017-10-25 14:06:57 +13:00
b9cb1e69e6
BUG Replace phpdotenv with thread-safe replacement
2017-10-20 18:43:11 +13:00
11b2c74533
ENHANCEMENT Improve upgrade experience for beta3 -> beta4 upgrade
2017-10-10 15:27:41 +13:00
1e913bb938
Remove rewrite-less routing through index.php
...
It's currently broken (doesn't rewrite subsequent links),
and is of questionable use. It was introduced during a time
when PHP didn't have a built-in webserver (I think).
Virtually ever webserver will have rewriting capabilities these days (even IIS!),
and if you struggle with the setup as a new user, you can just fall back to PHP's built-in webserver.
This doesn't affect installation capabilities, since these are triggered via install.php.
2017-10-09 17:21:43 +13:00
4a94dfe55b
Remove "url" query param reliance, use index.php
...
See https://github.com/silverstripe/silverstripe-framework/issues/7430
2017-10-09 17:21:43 +13:00
311811a261
Merge pull request #7451 from open-sausages/pulls/4.0/whats-temporary-could-turn-path
...
rename TEMP_FOLDER to TEMP_PATH
2017-10-09 14:16:06 +13:00
3560a0418d
rename TEMP_FOLDER to TEMP_PATH
2017-10-09 12:41:34 +13:00
f686b50824
API Rename assert dos to assert list
2017-10-09 11:53:11 +13:00
566d7baa48
Merge pull request #7437 from open-sausages/pulls/4.0/stateless-extensions
...
API Extensions are now stateless
2017-10-09 11:45:33 +13:00
b996e2c22c
API Extensions are now stateless
...
ENHANCEMENT Injector now lazy-loads services more intelligently
2017-10-06 14:53:44 +13:00
96a314f076
Merge pull request #7401 from creative-commoners/pulls/4.0/i18n-collector-fix
...
FIX Class name in _t() call in installer and run text collector
2017-10-05 10:56:12 +01:00
f64c95b33c
Add new ModuleResourceLoader helper
2017-10-03 12:20:49 +13:00
8e49b563a9
Fix installer paths for vendorised module
2017-10-03 09:03:37 +13:00
85a951584e
Update main.php path to support framework in vendor
2017-10-03 09:03:37 +13:00
36397c787c
Enhancement add notice for MigrateFileTask if FileMigrationHelper doesn't exist
...
Enhancement add call to image thumbnail helper to generate thumbnails
2017-10-02 14:54:31 +13:00
28552155c3
NEW Add actWithPermission to SapphireTest for shortcut to perform actions with specific permissions
2017-09-26 13:39:31 +01:00
33ae463e5b
FIX Class name in _t() call in installer and run text collector
2017-09-26 14:57:16 +13:00
261302a121
ENHANCEMENT Don't force all class names to lowercase
...
Speeds up autoloading because composer psr-4 works properly now
2017-09-20 15:14:55 +12:00
22e991ef90
Merge pull request #7344 from creative-commoners/pulls/4.0/email-assertion-return
...
DOCS Update doc block for TestMailer::findEmail to reflect the new key names
2017-09-08 13:08:03 +12:00
a4aa59bfdc
DOCS Update doc block for TestMailer::findEmail to reflect the new key names
2017-09-06 16:10:55 +12:00
806ffb934e
BUG Ensure installer.php works nicely with .env files
...
Unenjoyable cleanup of internal logic
2017-09-06 13:52:51 +12:00
8ebc13ae4e
Replace use of Configurable stat() with config()->get(), will be deprecated in future
2017-08-23 09:42:10 +12:00
9b4d689bb2
Lazy-load custom methods and extensions on CustomMethods and Extensible traits
...
No longer need constructExtensions()
2017-08-22 15:47:24 +12:00
c0211927aa
Merge branch '3' into 4
2017-08-14 21:18:03 +01:00
f7bebdd8f8
BUG Fix install issue with IIS
...
Fixes #7218
2017-08-07 10:15:40 +12:00
24ab3abbea
Update installer path to match recipe
2017-08-03 10:02:55 +12:00
da4e46e4de
FIX Use merge and set instead of update for config calls
2017-07-17 17:59:40 +12:00
2b266276c2
API Implement new module sorting pattern
2017-07-13 10:27:27 +12:00
85359ad59e
BUG Ensure that installer can create an initial admin account
...
Fixes #7124
2017-07-06 13:30:04 +12:00
2f551c91d7
Merge pull request #6922 from kinglozzer/debugview-styles
...
Update DebugView styles
2017-07-05 11:35:04 +01:00
713b01ebc7
Update DebugView styles
2017-07-05 09:14:26 +01:00
ed26b251c8
ENHANCEMENT: Better output type detection for debugging
2017-07-04 17:33:49 +12:00
f65e3627dc
BUG Implement or exclude all pending upgrader deltas
2017-07-03 12:21:47 +12:00
3633947699
BUG Fix broken installer assets and session crash
2017-06-30 14:50:58 +12:00
b2f3b218a3
BUG Fix incorrect $database autoinit
...
BUG Fix missing $request in Installer bootstrapping
2017-06-28 17:59:16 +12:00
67887febc5
fix - session now uses request
2017-06-27 13:32:39 +12:00
3873e4ba00
API Refactor bootstrap, request handling
...
See https://github.com/silverstripe/silverstripe-framework/pull/7037
and https://github.com/silverstripe/silverstripe-framework/issues/6681
Squashed commit of the following:
commit 8f65e5653276f95944fa9379834cb4188ce35d827ed4660e7a738f50c4976279d28e5e5c90d53a84f9b2ba47555b59a912b6e2c4a18f635d235e64f3d88d4ed4e4f7946aec3312bd31f936bba97911462a10c2397bd75a8d1d9306364af3c32a278e2953b65c21241bd1d4375c95b220534f06603704165c2f6336a15bfc7188da7da0ae723514ca03395251c66d433977f26ae75c6e001d559662de079c041d
2017-06-22 22:50:45 +12:00
62d095305b
API Update DefaultAdmin services
...
API Improve validation of authentication process
2017-06-15 15:53:57 +12:00
d89bd15330
Move authentication hooks to SapphireTest
2017-06-09 16:25:40 +12:00
082db89550
Feedback from Damian.
...
- Move the success and message to a validationresult
- Fix tests for validationresult return
- We need to clear the session in Test logOut method
- Rename to MemberAuthenticator and CMSMemberAuthenticator for consistency.
- Unify all to getCurrentUser on Security
- ChangePasswordHandler removed from Security
- Update SapphireTest for CMS login/logout
- Get the Member ID correctly, if it's an object.
- Only enable "remember me" when it's allowed.
- Add flag to disable password logging
- Remove Subsites coupling, give it an extension hook to disable itself
- Change cascadeLogInTo to cascadeInTo for the logout method logic naming
- Docblocks
- Basicauth config
2017-06-08 17:50:20 +12:00
2b26cafcff
Separate out the log-out handling.
...
Repairing tests and regressions
Consistently use `Security::getCurrentUser()` and `Security::setCurrentUser()`
Fix for the logout handler to properly logout, some minor wording updates
Remove the login hashes for the member when logging out.
BasicAuth to use `HTTPRequest`
2017-06-07 21:11:58 +12:00
f9ea752bae
NEW: Add AuthenticationHandler interface
...
NEW: Add IdentityStore for registering log-in / log-out data
NEW: Add AuthenticationRequestFilter for managing login
NEW: Add Security:setCurrentUser() / Security::getCurrentUser()
NEW: Add FunctionalTest::logOut()
2017-06-07 21:11:55 +12:00
7af7e6719e
API: Security.authenticators is now a map, not an array
...
Authenticators is now a map of keys -> service names. The key is used
in things such as URL segments. The “default_authenticator” value has
been replaced with the key “default” in this map, although in time a
default authenticator may not be needed.
IX: Refactor login() to avoid code duplication on single/multiple handlers
IX: Refactor LoginHandler to be more amenable to extension
IX: Fixed permissionFailure hack
his LoginHandler is expected to be the starting point for other
custom authenticators so it should be easier to repurpose components
`of it.
IX: Fix database-is-ready checks in tests.
IX: Fixed MemberAuthenticatorTest to match the new API
IX: Update security URLs in MemberTest
2017-06-07 21:11:53 +12:00
db59e51c4a
Fixes a bug with split file names during CSV import
2017-05-29 16:08:23 +10:00
d15b9ee0b0
Response to feedback
2017-05-23 13:50:35 +12:00
fba8e2c245
API Remove Object class
...
API DataObjectSchema::manyManyComponent() return array is now associative array
2017-05-23 13:50:35 +12:00
2aa3b5d5fa
Merge pull request #6934 from robbieaverill/pulls/4.0/consistent-instance-method
...
API Consistent use of inst() naming across framework
2017-05-22 11:57:20 +12:00
f2cbe86f03
Remove CustomMethods::createMethod and create_function implementations, replace with closures
2017-05-19 15:56:44 +12:00
ad43a82923
API Consistent use of inst() naming across framework
2017-05-19 14:38:06 +12:00
3495c0826e
Cleanup SapphireTest and time related tests ( #6898 )
...
* Test databases now include timestamp for easier debugging
* Use classname::class instead of string literal classnames
* Remove DataObject::get_one() from SapphireTest
* More fixes to ICU DB inconsitency for time formatting
* Correctly restore PHPUnits error handler
2017-05-18 22:01:55 +12:00
259f957ce8
API Rename services to match FQN of interface / classes
2017-05-16 14:15:49 +12:00
8f43bc128b
Merge pull request #6348 from open-sausages/pulls/4.0/test-cleanup-db
...
ENHANCEMENT Prevent test DBs persisting after testing
2017-05-08 23:14:53 +12:00
d2c6c539d2
Merge pull request #6872 from sminnee/fixture-by-table
...
NEW: Allow SapphireTest::objFromFixture() to accept either table or class
2017-05-05 15:14:01 +12:00
942c0257b7
API Upgrade to behat 3
2017-05-05 14:32:07 +12:00
1691e90fbd
NEW: Allow SapphireTest::objFromFixture() to accept either table or class
...
Right now SapphireTest::objFromFixture() requires a class as the first
argument. This is fine when your fixture file uses classes as the keys,
but if populating a fixture via tables, objFromFixture() won’t work.
This patch lets you specify either the table name or the class name as
the key.
The benefit here is that you can build fixtures as raw inserts, which is
substantially quicker, and is likely to be a useful tool in building
more efficient test suites.
2017-05-05 10:53:49 +12:00
3f9528a073
Merge pull request #6849 from robbieaverill/bugfix/extension-arguments-in-sapphiretest
...
FIX Regression from 3.x: allow $required_extensions to have arguments
2017-04-28 20:29:11 +12:00
494cbd1875
Ran upgrader for lang files
2017-04-28 14:59:42 +12:00
c95c6c466f
FIX Regression from 3.x: allow $required_extensions to have arguments
2017-04-27 17:59:52 +12:00
5a7c6d4f60
Allow —no-dev install via a PHPUnit shim
...
Partially reinstates the 3.x style PhpUnitWrapper which was removed in d1af214ef5
2017-04-24 15:24:02 +12:00
c21f71405f
Merge pull request #6823 from open-sausages/pulls/4.0/remove-TeamCityListener
...
Removed TeamCityListener
2017-04-21 15:56:20 +12:00
0a55ff9f8c
API Remove SapphireTestReporter and CliTestReporter
...
Was missed from the removal of PHPUnitWrapper:
a16588aac32fdc96a0de (diff-82b3f89e8e5ae090c93e9c3a2ba8aa36L3)
2017-04-21 15:11:59 +12:00
60e4c011de
Removed TeamCityListener
2017-04-21 12:13:13 +12:00
227ba8dcc4
FIX illegal_extensions in unit tests not being removed
2017-03-30 13:54:53 +13:00
9cdcb339e9
FIX: Fix test breakage in most recent change.
2017-03-30 11:55:43 +13:00
ac075eaf0b
Remove TestListener and rely on PHPUnits APIs
2017-03-30 11:46:58 +13:00
ede549a6ed
FIX illegalExtensions are optional, requiredExtensions are mandatory with useful error messages.
2017-03-29 11:08:07 +13:00
ac3a9c9e6e
API Split out SilverStripe\ORM\Versioned into new module
2017-03-27 11:03:39 +13:00
0410b4c35e
Respect PHPUnit method visibility
2017-03-24 16:23:03 +13:00
cfa6a36697
Merge pull request #6706 from open-sausages/pulls/4.0/manifest-cache
...
API Build new ManifestCache based on PSR-16 SimpleCache
2017-03-21 10:29:03 +13:00
54ba08a306
API Replace ManifestCache with ManifestCacheFactory
...
API Remove lots of deprecated module code from ClassManifest
2017-03-21 09:43:48 +13:00
6dd236e9b1
remove spaces in elseif statements
2017-03-20 15:39:53 +13:00
3e17dd3201
Move to template PHP syntax for installer
2017-03-16 16:09:46 +13:00
53b98284fe
FIX Remove undefined var from installer
2017-03-16 16:09:33 +13:00
6b43d79f3e
Removed confusing src/ dir
2017-03-15 11:59:13 +13:00
f6a4a059fa
Moved frontend code from dist/ to src/
...
We no longer compile it, so it’s technically the “source” now
2017-03-15 11:07:17 +13:00
02bbc05816
Remove unnecessary frontend build tooling
...
We’re loading 60MB of node_modules to compile 600 LOC of SCSS files down to CSS.
These can be maintained as plain CSS for now, at least until we redesign installer (at which point we’ll likely split it out into a separate module)
2017-03-15 11:03:04 +13:00
466c50b302
API Switch from npm4 and shrinkwrap to npm6 and yarn
2017-03-10 11:38:26 +13:00
9c9443602d
FIX Installer no longer causes recursion in yml config
2017-03-07 11:39:11 +00:00
c452d5f6cd
API Rename CoreConfigCreator to CoreConfigFactory
...
Fix rebase regressions
2017-02-27 16:54:01 +13:00
3362e15a29
API Upgrade code to use updated config
2017-02-27 16:54:01 +13:00
b3fc11e594
API Move ssmedia plugin to asset-admin
2017-02-27 10:58:41 +13:00
f63b741e46
FIX: Improve DebugView’s display of non-header information.
...
DebugView had not ability just to output a regular paragraph that
didn’t have a blue background.
This refactors the CSS classes a bit to amend this.
2017-02-26 15:07:32 +13:00
029a8b9586
API Substitute Zend_Currency with NumberFormatter based solution
...
API Substitute Zend_Locale with Locale / NumberFormatter
API Substitute Zend_Date with IntlDateFormatter
API Added DBTIme::Nice12, FormatFromSettings
API Added Short() method to DBDate / DBTime / DBDatetime
API Add Date::getTimestamp()
API Added setSubmittedValue api for FormField
API Add second arg to base FormField::setValue()
API Major refactor of i18n into component data parts
API Implement Resettable interface to reset objects between tests
ENHANCEMENT Changed DBField::create_field return type to `static` to support better type hinting
ENHANCEMENT i18nTextCollector supports __CLASS__
2017-02-09 15:28:59 +13:00
8c8231c03e
NEW Director::host() to determine host name of site
2017-01-31 21:36:04 +00:00
873fd8c5bc
NEW replace _ss_environment.php with .env and environment vars
2017-01-31 20:40:17 +00:00
a5da085cc7
Merge branch '3'
2017-01-31 17:03:53 +00:00
7b26b4a1f3
BUG Ensure that tests run with flush=1 clean Flushables
...
BUG Restore opt-in flushing (regression from #4404 )
2017-01-31 18:59:19 +13:00
8a07c56bdf
API Replace i18n message localisation with symfony/translation
...
API Implement enhanced pluralisation
Remove Zend_Translate and all Zend dependencies from i18n
Deprecated $context from i18n::_t()
Warn on missing default string for i18n::_t()
2017-01-25 17:08:12 +13:00
87ac3e3971
ENHANCEMENT Display warning on always_populate_raw_post_data not being -1 in php 5 ( #6507 )
2017-01-16 17:31:48 +13:00
3ea5015f8b
NEW Move to SwiftMailer powered Emails ( #6466 )
...
* API Replace existing Email and Mailer classes with SwiftMailer powered email system
* DOCS New Email docs
* Initial feedback from Damian
* Making Mailer an interface
* Templates relocated
* Round of feedback
* More robust approach to plain parts
* Revert changes to TestMailer
2017-01-13 14:48:46 +13:00
6fc50cae5c
FIX: Refactor TestMailer to better be base class
...
This small refactoring makes TestMailer better suited as a base class
for the behat-extension’s implementation, which means that we don’t
need to coordinate cross-module commits in dhensby’ SwiftMailer work.
See https://github.com/silverstripe/silverstripe-framework/pull/6466
2017-01-12 10:22:57 +13:00
ba39e552a2
Merge branch '3'
2016-12-15 12:20:29 +00:00
6e589aac75
API Updates to Form, ValidationResponse, ValidationException
...
API Implement form schema "errors" handling
2016-12-09 14:24:11 +13:00
6650561dac
Don't use session and FormSchema to manage server-side React validation responses
2016-12-09 10:27:23 +13:00
0e92ecea0c
ENHANCEMENT Prevent test DBs persisting after testing
2016-11-30 10:59:37 +13:00
4b7d31377b
PSR2: Automatic fixes
2016-11-29 12:33:28 +13:00
1b1e921e3d
PSR2: Whitespace-only changes
2016-11-29 12:31:16 +13:00
1be2e70a2a
Merge branch '3'
2016-11-24 14:18:09 +00:00
cac326eebb
API Add getExtraDataObjects() and getExtraControllers() methods to SapphireTest
2016-11-23 19:25:12 +13:00
6e8304ff2f
API Namespace framework tests
2016-11-23 19:25:12 +13:00
506213899b
Setting default db adapter in installation as PDO MySQL with MySQLi as fail safe.
...
Added back missed assignment of $_REQUEST['db']['type']
2016-11-02 19:51:13 +13:00
019e99dd4d
BUG Fix regressions from src folder creation ( #6272 )
2016-11-02 13:18:56 +13:00
5650254b53
NEW: Fixes to allow code files in src/ folder.
...
Separated from the file renames for clarity.
2016-11-01 16:35:32 +13:00
7a10c194bd
NEW: Move code files into src/ folder.
...
This updates framework to be more in keeping with PHP conventions.
2016-11-01 13:37:24 +13:00
Damian Mooyman
Daniel Hensby
Russell Maclean
Sil3ntStorm
Russell Michell
Jay Devlin
Christopher Joe
Ingo Schommer
Werner M. Krauß
Chris Joe
Daniel Hensby
Daniel Hensby
Robbie Averill
Aaron Carlino
Loz Calver
Sam Minnee
Simon Erkelens
Colin Tucker
Ingo Schommer
Mike Cochrane
Christopher Joe
David Alexander