tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-09-28 20:29:15 +02:00
Code Issues Projects Releases Wiki Activity

Incorrect Contant-Type header for RSS feeds

Browse Source 
It should be application/rss+xml but not text/xml.
This commit is contained in:
uniun 2013-02-05 18:11:28 +02:00
parent accbd7f1e2
commit e249799e9a
1 changed files with 4 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
api/RSSFeed.php
View File

@ -189,9 +189,11 @@ class RSSFeed extends ViewableData {
$prevState = SSViewer::get_source_file_comments(); $prevState = SSViewer::get_source_file_comments();
SSViewer::set_source_file_comments(false); SSViewer::set_source_file_comments(false);
$response = Controller::curr()->getResponse();
if(is_int($this->lastModified)) { if(is_int($this->lastModified)) {
HTTP::register_modification_timestamp($this->lastModified); HTTP::register_modification_timestamp($this->lastModified);
header('Last-Modified: ' . gmdate("D, d M Y H:i:s", $this->lastModified) . ' GMT'); $response->addHeader("Last-Modified", gmdate("D, d M Y H:i:s", $this->lastModified) . ' GMT');
} }
if(!empty($this->etag)) { if(!empty($this->etag)) {
HTTP::register_etag($this->etag); HTTP::register_etag($this->etag);
@ -199,7 +201,7 @@ class RSSFeed extends ViewableData {
if(!headers_sent()) { if(!headers_sent()) {
HTTP::add_cache_headers(); HTTP::add_cache_headers();
header("Content-type: text/xml"); $response->addHeader("Content-Type", "application/rss+xml");
} }
SSViewer::set_source_file_comments($prevState); SSViewer::set_source_file_comments($prevState);