tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-09-29 12:49:06 +02:00
Code Issues Projects Releases Wiki Activity

Revert "FIX: Strict error warnings on DataExtension"

Browse Source 
This reverts commit 1960df8bc3.

Revert "FIX: validate doesn't take var by reference"
This reverts commit 866bb0713b.

@ajshort has changed the method signatures in 1f6f7f08. While it wasn't explicitly noted in the commit message, I think its a good change - objects like a FieldList are always passed by reference in PHP, no need to declare that behaviour.
This commit is contained in:
Ingo Schommer 2013-02-04 17:22:30 +01:00
parent 857d8bb8df
commit accbd7f1e2
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
model/DataExtension.php
View File

@ -58,7 +58,7 @@ abstract class DataExtension extends Extension {
* @param $validationResult Local validation result
* @throws ValidationException
*/
public function validate(ValidationResult $validationResult) {
public function validate(ValidationResult &$validationResult) {
}
/**
@ -145,7 +145,7 @@ abstract class DataExtension extends Extension {
*
* @param FieldList $fields FieldList with a contained TabSet
*/
public function updateCMSFields(FieldList &$fields) {
public function updateCMSFields(FieldList $fields) {
}
/**
@ -156,7 +156,7 @@ abstract class DataExtension extends Extension {
*
* @param FieldList $fields FieldList without TabSet nesting
*/
public function updateFrontEndFields(FieldList &$fields) {
public function updateFrontEndFields(FieldList $fields) {
}
/**
@ -165,7 +165,7 @@ abstract class DataExtension extends Extension {
*
* @param FieldList $actions FieldList
*/
public function updateCMSActions(FieldList &$actions) {
public function updateCMSActions(FieldList $actions) {
}
/**