Apply suggestions from code review

Add double quotes around object title
This commit is contained in:
Robbie Averill 2020-04-02 12:51:13 -07:00 committed by GitHub
parent d1075f29b8
commit d3b19069b3
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
2 changed files with 5 additions and 5 deletions

View File

@ -111,8 +111,8 @@ en:
NEW: 'Add new record' NEW: 'Add new record'
NEXT: 'Go to next record' NEXT: 'Go to next record'
PREVIOUS: 'Go to previous record' PREVIOUS: 'Go to previous record'
EditPermissionsFailure: 'It seems you don''t have the necessary permissions to edit {ObjectTitle}' EditPermissionsFailure: 'It seems you don''t have the necessary permissions to edit "{ObjectTitle}"'
ViewPermissionsFailure: 'It seems you don''t have the necessary permissions to view {ObjectTitle}' ViewPermissionsFailure: 'It seems you don''t have the necessary permissions to view "{ObjectTitle}"'
SilverStripe\Forms\GridField\GridFieldEditButton: SilverStripe\Forms\GridField\GridFieldEditButton:
EDIT: Edit EDIT: Edit
SilverStripe\Forms\GridField\GridFieldFilterHeader: SilverStripe\Forms\GridField\GridFieldFilterHeader:

View File

@ -113,7 +113,7 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler
if (!$this->record->canView()) { if (!$this->record->canView()) {
$this->httpError(403, _t( $this->httpError(403, _t(
__CLASS__ . '.ViewPermissionsFailure', __CLASS__ . '.ViewPermissionsFailure',
'It seems you don\'t have the necessary permissions to view {ObjectTitle}', 'It seems you don\'t have the necessary permissions to view "{ObjectTitle}"',
['ObjectTitle' => $this->record->singular_name()] ['ObjectTitle' => $this->record->singular_name()]
)); ));
} }
@ -195,7 +195,7 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler
$controller = $this->getToplevelController(); $controller = $this->getToplevelController();
return $controller->httpError(403, _t( return $controller->httpError(403, _t(
__CLASS__ . '.ViewPermissionsFailure', __CLASS__ . '.ViewPermissionsFailure',
'It seems you don\'t have the necessary permissions to view {ObjectTitle}', 'It seems you don\'t have the necessary permissions to view "{ObjectTitle}"',
['ObjectTitle' => $this->record->singular_name()] ['ObjectTitle' => $this->record->singular_name()]
)); ));
} }
@ -499,7 +499,7 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler
if (!$this->record->canEdit()) { if (!$this->record->canEdit()) {
$this->httpError(403, _t( $this->httpError(403, _t(
__CLASS__ . '.EditPermissionsFailure', __CLASS__ . '.EditPermissionsFailure',
'It seems you don\'t have the necessary permissions to edit {ObjectTitle}', 'It seems you don\'t have the necessary permissions to edit "{ObjectTitle}"',
['ObjectTitle' => $this->record->singular_name()] ['ObjectTitle' => $this->record->singular_name()]
)); ));
return null; return null;