From d3b19069b33b1b252a9a4066afaaf0e45f61d00c Mon Sep 17 00:00:00 2001 From: Robbie Averill Date: Thu, 2 Apr 2020 12:51:13 -0700 Subject: [PATCH] Apply suggestions from code review Add double quotes around object title --- lang/en.yml | 4 ++-- src/Forms/GridField/GridFieldDetailForm_ItemRequest.php | 6 +++--- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/lang/en.yml b/lang/en.yml index 2c386ebdb..773d7c7d1 100644 --- a/lang/en.yml +++ b/lang/en.yml @@ -111,8 +111,8 @@ en: NEW: 'Add new record' NEXT: 'Go to next record' PREVIOUS: 'Go to previous record' - EditPermissionsFailure: 'It seems you don''t have the necessary permissions to edit {ObjectTitle}' - ViewPermissionsFailure: 'It seems you don''t have the necessary permissions to view {ObjectTitle}' + EditPermissionsFailure: 'It seems you don''t have the necessary permissions to edit "{ObjectTitle}"' + ViewPermissionsFailure: 'It seems you don''t have the necessary permissions to view "{ObjectTitle}"' SilverStripe\Forms\GridField\GridFieldEditButton: EDIT: Edit SilverStripe\Forms\GridField\GridFieldFilterHeader: diff --git a/src/Forms/GridField/GridFieldDetailForm_ItemRequest.php b/src/Forms/GridField/GridFieldDetailForm_ItemRequest.php index 7950aaa27..322cde4b7 100644 --- a/src/Forms/GridField/GridFieldDetailForm_ItemRequest.php +++ b/src/Forms/GridField/GridFieldDetailForm_ItemRequest.php @@ -113,7 +113,7 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler if (!$this->record->canView()) { $this->httpError(403, _t( __CLASS__ . '.ViewPermissionsFailure', - 'It seems you don\'t have the necessary permissions to view {ObjectTitle}', + 'It seems you don\'t have the necessary permissions to view "{ObjectTitle}"', ['ObjectTitle' => $this->record->singular_name()] )); } @@ -195,7 +195,7 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler $controller = $this->getToplevelController(); return $controller->httpError(403, _t( __CLASS__ . '.ViewPermissionsFailure', - 'It seems you don\'t have the necessary permissions to view {ObjectTitle}', + 'It seems you don\'t have the necessary permissions to view "{ObjectTitle}"', ['ObjectTitle' => $this->record->singular_name()] )); } @@ -499,7 +499,7 @@ class GridFieldDetailForm_ItemRequest extends RequestHandler if (!$this->record->canEdit()) { $this->httpError(403, _t( __CLASS__ . '.EditPermissionsFailure', - 'It seems you don\'t have the necessary permissions to edit {ObjectTitle}', + 'It seems you don\'t have the necessary permissions to edit "{ObjectTitle}"', ['ObjectTitle' => $this->record->singular_name()] )); return null;