tonyair/silverstripe-framework
1
0
Fork 0
mirror of https://github.com/silverstripe/silverstripe-framework synced 2024-10-22 12:05:37 +00:00
Code Issues Projects Releases Wiki Activity

BUGFIX Added check before foreach() to fix potential HMCTF bugs

Browse Source 
git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69377 467b73ca-7a2a-4603-9d3b-597d59a354a9
This commit is contained in:
Sean Harvey 2008-12-17 07:29:28 +00:00 committed by Sam Minnee
parent ae2cb53fb1
commit 1213a073a0
1 changed files with 5 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
forms/HasManyComplexTableField.php
View File

@ -124,9 +124,11 @@ class HasManyComplexTableField extends ComplexTableField {
function ExtraData() { function ExtraData() {
$items = array(); $items = array();
foreach($this->unpagedSourceItems as $item) { if($this->unpagedSourceItems) {
if($item->{$this->joinField} == $this->controller->ID) foreach($this->unpagedSourceItems as $item) {
$items[] = $item->ID; if($item->{$this->joinField} == $this->controller->ID)
$items[] = $item->ID;
}
} }
$list = implode(',', $items); $list = implode(',', $items);
$inputId = $this->id() . '_' . $this->htmlListEndName; $inputId = $this->id() . '_' . $this->htmlListEndName;