From 1213a073a0aacf46f71282a76ebc8914c78a6732 Mon Sep 17 00:00:00 2001 From: Sean Harvey Date: Wed, 17 Dec 2008 07:29:28 +0000 Subject: [PATCH] BUGFIX Added check before foreach() to fix potential HMCTF bugs git-svn-id: svn://svn.silverstripe.com/silverstripe/open/modules/sapphire/branches/2.3@69377 467b73ca-7a2a-4603-9d3b-597d59a354a9 --- forms/HasManyComplexTableField.php | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/forms/HasManyComplexTableField.php b/forms/HasManyComplexTableField.php index 90d3a8f91..2807b294c 100644 --- a/forms/HasManyComplexTableField.php +++ b/forms/HasManyComplexTableField.php @@ -124,9 +124,11 @@ class HasManyComplexTableField extends ComplexTableField { function ExtraData() { $items = array(); - foreach($this->unpagedSourceItems as $item) { - if($item->{$this->joinField} == $this->controller->ID) - $items[] = $item->ID; + if($this->unpagedSourceItems) { + foreach($this->unpagedSourceItems as $item) { + if($item->{$this->joinField} == $this->controller->ID) + $items[] = $item->ID; + } } $list = implode(',', $items); $inputId = $this->id() . '_' . $this->htmlListEndName;