Commit Graph

10 Commits

Author SHA1 Message Date
Dylan Wagstaff a88e8be403 FIX Linting errors for code cleanliness 2017-11-23 13:19:00 +13:00
Dylan Wagstaff 1ed9a23a71 Run the upgrader & linting tools
An initial (untested) run at a proper upgrade. Progress commit.
2017-11-23 12:56:44 +13:00
Robbie Averill 99d4a6ee1a FIX Ensure that translatable cannot break tests. Separate page stub class. Remove injector nesting. 2017-05-12 11:38:49 +12:00
Ingo Schommer 38659bac98 Include Hamcrest without clashing with PHPUnit globals
PHPUnit had a Functions.php with global methods like any() for a while (3.7 at least),
which clashes with similar globals from Hamcrest (used in Phockito).

Both PHPUnit and Phockito use 'classmap' composer autoloading,
but that's not directly requiring/evaluating the files.
The problem is caused by SilverStripe's ClassLoader
which does require ALL subclasses of SapphireTest.
This in turn causes PHP outside of the class context to execute,
which includes Hamcrest.

Changing the include_hamcrest() is not strictly necessary here,
but makes the code a bit more resilient against any preceding
test including Functions.php from PHPUnit.

See https://github.com/hafriedlander/phockito/issues/32 for context.
2015-04-29 14:28:08 +12:00
Damian Mooyman 7328344408 API Add description for response code to report 2014-08-13 10:20:39 +12:00
Damian Mooyman a4ede246ab Tests, refactor, cleanup, fix issues 2014-08-07 15:24:20 +12:00
Kirk Mayo 6bda4dcc82 BUG: Correcting test code and fixing bug with create report button 2014-08-04 17:38:28 +12:00
Kirk Mayo da7e45ddd4 BUG: Fixing report page link and set to check stage not live 2014-08-04 15:26:22 +12:00
Kirk Mayo e9fe1a4707 NEW: Use DB row for job status and refactor the sql statements 2014-08-01 12:48:30 +12:00
Kirk Mayo d25adca175 NEW: Adding tests and code tidyup 2014-07-29 09:31:22 +12:00