FIX Linting errors for code cleanliness

.upgrade.yml

@@ -1,5 +1,5 @@
 mappings:
-  CMSExternalLinks_Controller: SilverStripe\ExternalLinks\Controllers\CMSExternalLinks_Controller
+  CMSExternalLinks_Controller: SilverStripe\ExternalLinks\Controllers\CMSExternalLinksController
   CheckExternalLinksJob: SilverStripe\ExternalLinks\Jobs\CheckExternalLinksJob
   BrokenExternalLink: SilverStripe\ExternalLinks\Model\BrokenExternalLink
   BrokenExternalPageTrack: SilverStripe\ExternalLinks\Model\BrokenExternalPageTrack

_config/routes.yml

@@ -4,4 +4,4 @@ After: framework/routes
 ---
 Director:
   rules:
-    'admin/externallinks//$Action': 'CMSExternalLinks_Controller'
+    'admin/externallinks//$Action': 'CMSExternalLinksController'

src/Controllers/CMSExternalLinks.php

@@ -8,7 +8,7 @@ use SilverStripe\ExternalLinks\Jobs\CheckExternalLinksJob;
 use SilverStripe\ExternalLinks\Tasks\CheckExternalLinksTask;
 use SilverStripe\Control\Controller;
 
-class CMSExternalLinks_Controller extends Controller
+class CMSExternalLinksController extends Controller
 {
 
     private static $allowed_actions = array('getJobStatus', 'start');

src/Jobs/CheckExternalLinksJob.php

@@ -2,46 +2,44 @@
 
 namespace SilverStripe\ExternalLinks\Jobs;
 
-use AbstractQueuedJob;
-use QueuedJob;
-
-use SilverStripe\ExternalLinks\Tasks\CheckExternalLinksTask;
-
-if (!class_exists('AbstractQueuedJob')) {
-    return;
-}
-
-/**
- * A Job for running a external link check for published pages
- *
- */
-class CheckExternalLinksJob extends AbstractQueuedJob implements QueuedJob
-{
-
-    public function getTitle()
-    {
-        return _t('CheckExternalLiksJob.TITLE', 'Checking for external broken links');
-    }
-
-    public function getJobType()
-    {
-        return QueuedJob::QUEUED;
-    }
-
-    public function getSignature()
-    {
-        return md5(get_class($this));
-    }
+if (class_exists('Symbiote\QueuedJobs\Services\AbstractQueuedJob')) {
+    use Symbiote\QueuedJobs\Services\AbstractQueuedJob;
+    use Symbiote\QueuedJobs\Services\QueuedJob;
+    use SilverStripe\ExternalLinks\Tasks\CheckExternalLinksTask;
 
     /**
-     * Check an individual page
+     * A Job for running a external link check for published pages
+     *
      */
-    public function process()
+    class CheckExternalLinksJob extends AbstractQueuedJob implements QueuedJob
     {
-        $task = CheckExternalLinksTask::create();
-        $track = $task->runLinksCheck(1);
-        $this->currentStep = $track->CompletedPages;
-        $this->totalSteps = $track->TotalPages;
-        $this->isComplete = $track->Status === 'Completed';
+
+        public function getTitle()
+        {
+            return _t('CheckExternalLiksJob.TITLE', 'Checking for external broken links');
+        }
+
+        public function getJobType()
+        {
+            return QueuedJob::QUEUED;
+        }
+
+        public function getSignature()
+        {
+            return md5(get_class($this));
+        }
+
+        /**
+         * Check an individual page
+         */
+        public function process()
+        {
+            $task = CheckExternalLinksTask::create();
+            $track = $task->runLinksCheck(1);
+            $this->currentStep = $track->CompletedPages;
+            $this->totalSteps = $track->TotalPages;
+            $this->isComplete = $track->Status === 'Completed';
+        }
     }
+
 }

tests/ExternalLinksTest.php

@@ -1,5 +1,7 @@
 <?php
 
+namespace SilverStripe\ExternalLinks\Tests;
+
 use SilverStripe\ExternalLinks\Tasks\LinkChecker;
 use SilverStripe\Core\Injector\Injector;
 use SilverStripe\ExternalLinks\Tasks\CheckExternalLinksTask;

tests/ExternalLinksTestPage.php

@@ -1,5 +1,7 @@
 <?php
 
+namespace SilverStripe\ExternalLinks\Tests;
+
 use SilverStripe\Dev\TestOnly;
 
 class ExternalLinksTestPage extends Page implements TestOnly