tonyair
/
silverstripe-externallinks
mirror of https://github.com/silverstripe/silverstripe-externallinks.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

FIX Implement TestOnly in PretendLinkChecker, move Page stub and sort class imports

This commit is contained in:
Robbie Averill 2017-11-28 09:35:31 +13:00
parent 789ce91e1c
commit 78fbc68797
4 changed files with 13 additions and 12 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
tests/ExternalLinksTest.php
View File

@ -2,16 +2,16 @@
namespace SilverStripe\ExternalLinks\Tests;
use SilverStripe\ExternalLinks\Reports\BrokenExternalLinksReport;
use SilverStripe\ExternalLinks\Model\BrokenExternalPageTrackStatus;
use SilverStripe\ExternalLinks\Tasks\CheckExternalLinksTask;
use SilverStripe\ExternalLinks\Tests\ExternalLinksTestPage;
use SilverStripe\i18n\i18n;
use SilverStripe\Core\Injector\Injector;
use SilverStripe\ExternalLinks\Tasks\LinkChecker;
use SilverStripe\ExternalLinks\Tests\Stubs\PretendLinkChecker;
use SilverStripe\Reports\Report;
use SilverStripe\Dev\SapphireTest;
use SilverStripe\ExternalLinks\Model\BrokenExternalPageTrackStatus;
use SilverStripe\ExternalLinks\Reports\BrokenExternalLinksReport;
use SilverStripe\ExternalLinks\Tasks\CheckExternalLinksTask;
use SilverStripe\ExternalLinks\Tasks\LinkChecker;
use SilverStripe\ExternalLinks\Tests\Stubs\ExternalLinksTestPage;
use SilverStripe\ExternalLinks\Tests\Stubs\PretendLinkChecker;
use SilverStripe\i18n\i18n;
use SilverStripe\Reports\Report;
class ExternalLinksTest extends SapphireTest
{

2
tests/ExternalLinksTest.yml
View File

@ -1,4 +1,4 @@
SilverStripe\ExternalLinks\Tests\ExternalLinksTestPage:
SilverStripe\ExternalLinks\Tests\Stubs\ExternalLinksTestPage:
# Tests mix of broken and working external links
page1:
Title: 'Page 1'

4
tests/ExternalLinksTestPage.php → tests/Stubs/ExternalLinksTestPage.php
View File

@ -1,9 +1,9 @@
<?php
namespace SilverStripe\ExternalLinks\Tests;
namespace SilverStripe\ExternalLinks\Tests\Stubs;
use SilverStripe\Dev\TestOnly;
use Page;
use SilverStripe\Dev\TestOnly;
class ExternalLinksTestPage extends Page implements TestOnly
{

3
tests/Stubs/PretendLinkChecker.php
View File

@ -1,9 +1,10 @@
<?php
namespace SilverStripe\ExternalLinks\Tests\Stubs;
use SilverStripe\Dev\TestOnly;
use SilverStripe\ExternalLinks\Tasks\LinkChecker;
class PretendLinkChecker implements LinkChecker
class PretendLinkChecker implements LinkChecker, TestOnly
{
public function checkLink($href)
{