From 78fbc687976d3791832b5e4fcef1ce3dc041f3eb Mon Sep 17 00:00:00 2001
From: Robbie Averill <robbie@silverstripe.com>
Date: Tue, 28 Nov 2017 09:35:31 +1300
Subject: [PATCH] FIX Implement TestOnly in PretendLinkChecker, move Page stub
 and sort class imports

---
 tests/ExternalLinksTest.php                 | 16 ++++++++--------
 tests/ExternalLinksTest.yml                 |  2 +-
 tests/{ => Stubs}/ExternalLinksTestPage.php |  4 ++--
 tests/Stubs/PretendLinkChecker.php          |  3 ++-
 4 files changed, 13 insertions(+), 12 deletions(-)
 rename tests/{ => Stubs}/ExternalLinksTestPage.php (83%)

diff --git a/tests/ExternalLinksTest.php b/tests/ExternalLinksTest.php
index e1c4bbd..4806774 100644
--- a/tests/ExternalLinksTest.php
+++ b/tests/ExternalLinksTest.php
@@ -2,16 +2,16 @@
 
 namespace SilverStripe\ExternalLinks\Tests;
 
-use SilverStripe\ExternalLinks\Reports\BrokenExternalLinksReport;
-use SilverStripe\ExternalLinks\Model\BrokenExternalPageTrackStatus;
-use SilverStripe\ExternalLinks\Tasks\CheckExternalLinksTask;
-use SilverStripe\ExternalLinks\Tests\ExternalLinksTestPage;
-use SilverStripe\i18n\i18n;
 use SilverStripe\Core\Injector\Injector;
-use SilverStripe\ExternalLinks\Tasks\LinkChecker;
-use SilverStripe\ExternalLinks\Tests\Stubs\PretendLinkChecker;
-use SilverStripe\Reports\Report;
 use SilverStripe\Dev\SapphireTest;
+use SilverStripe\ExternalLinks\Model\BrokenExternalPageTrackStatus;
+use SilverStripe\ExternalLinks\Reports\BrokenExternalLinksReport;
+use SilverStripe\ExternalLinks\Tasks\CheckExternalLinksTask;
+use SilverStripe\ExternalLinks\Tasks\LinkChecker;
+use SilverStripe\ExternalLinks\Tests\Stubs\ExternalLinksTestPage;
+use SilverStripe\ExternalLinks\Tests\Stubs\PretendLinkChecker;
+use SilverStripe\i18n\i18n;
+use SilverStripe\Reports\Report;
 
 class ExternalLinksTest extends SapphireTest
 {
diff --git a/tests/ExternalLinksTest.yml b/tests/ExternalLinksTest.yml
index 59992d0..66da000 100644
--- a/tests/ExternalLinksTest.yml
+++ b/tests/ExternalLinksTest.yml
@@ -1,4 +1,4 @@
-SilverStripe\ExternalLinks\Tests\ExternalLinksTestPage:
+SilverStripe\ExternalLinks\Tests\Stubs\ExternalLinksTestPage:
   # Tests mix of broken and working external links
   page1:
     Title: 'Page 1'
diff --git a/tests/ExternalLinksTestPage.php b/tests/Stubs/ExternalLinksTestPage.php
similarity index 83%
rename from tests/ExternalLinksTestPage.php
rename to tests/Stubs/ExternalLinksTestPage.php
index a4ce0e5..7486986 100644
--- a/tests/ExternalLinksTestPage.php
+++ b/tests/Stubs/ExternalLinksTestPage.php
@@ -1,9 +1,9 @@
 <?php
 
-namespace SilverStripe\ExternalLinks\Tests;
+namespace SilverStripe\ExternalLinks\Tests\Stubs;
 
-use SilverStripe\Dev\TestOnly;
 use Page;
+use SilverStripe\Dev\TestOnly;
 
 class ExternalLinksTestPage extends Page implements TestOnly
 {
diff --git a/tests/Stubs/PretendLinkChecker.php b/tests/Stubs/PretendLinkChecker.php
index 8701422..b5afdc6 100644
--- a/tests/Stubs/PretendLinkChecker.php
+++ b/tests/Stubs/PretendLinkChecker.php
@@ -1,9 +1,10 @@
 <?php
 namespace SilverStripe\ExternalLinks\Tests\Stubs;
 
+use SilverStripe\Dev\TestOnly;
 use SilverStripe\ExternalLinks\Tasks\LinkChecker;
 
-class PretendLinkChecker implements LinkChecker
+class PretendLinkChecker implements LinkChecker, TestOnly
 {
     public function checkLink($href)
     {