Removing superflous i18n test and updating label test to only test labels specifically added

This commit is contained in:
Guy Marriott 2019-01-11 12:22:31 +13:00
parent 4ee9720081
commit a57c83c121
No known key found for this signature in database
GPG Key ID: A80F9ACCB86D3DA7

View File

@ -605,52 +605,19 @@ class CommentsTest extends FunctionalTest
*/ */
public function testFieldLabels() public function testFieldLabels()
{ {
$locale = i18n::get_locale();
i18n::set_locale('fr');
/** @var Comment $comment */ /** @var Comment $comment */
$comment = $this->objFromFixture(Comment::class, 'firstComA'); $comment = $this->objFromFixture(Comment::class, 'firstComA');
$labels = $comment->FieldLabels();
$expected = array(
'Name' => 'Nom de l\'Auteur',
'Comment' => 'Commentaire',
'Email' => 'Email',
'URL' => 'URL',
'Moderated' => 'Modéré?',
'IsSpam' => 'Spam?',
'AllowHtml' => 'Allow Html',
'SecretToken' => 'Secret Token',
'Depth' => 'Depth',
'Author' => 'Author Member',
'ParentComment' => 'Parent Comment',
'ChildComments' => 'Child Comments',
'ParentTitle' => 'Parent',
'Created' => 'Date de publication',
'Parent' => 'Parent'
);
i18n::set_locale($locale);
foreach ($expected as $key => $value) {
$this->assertEquals($value, $labels[$key]);
}
$labels = $comment->FieldLabels(); $labels = $comment->FieldLabels();
$expected = array( $expected = array(
'Name' => 'Author Name', 'Name' => 'Author Name',
'Comment' => 'Comment', 'Comment' => 'Comment',
'Email' => 'Email', 'Email' => 'Email',
'URL' => 'URL', 'URL' => 'URL',
'Moderated' => 'Moderated?',
'IsSpam' => 'Spam?', 'IsSpam' => 'Spam?',
'AllowHtml' => 'Allow Html', 'Moderated' => 'Moderated?',
'SecretToken' => 'Secret Token',
'Depth' => 'Depth',
'Author' => 'Author Member',
'ParentComment' => 'Parent Comment',
'ChildComments' => 'Child Comments',
'ParentTitle' => 'Parent', 'ParentTitle' => 'Parent',
'Created' => 'Date posted', 'Created' => 'Date posted',
'Parent' => 'Parent'
); );
foreach ($expected as $key => $value) { foreach ($expected as $key => $value) {
$this->assertEquals($value, $labels[$key]); $this->assertEquals($value, $labels[$key]);